- 26 Jan, 2018 12 commits
-
-
Michael Achenbach authored
TBR=sergiyb@chromium.org Bug: v8:6917 Change-Id: I5bc8f49dc01d98949e3efab01192c663de8027bf Reviewed-on: https://chromium-review.googlesource.com/888578 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#50887}
-
Sigurd Schneider authored
This fixes %StringIteratorPrototype%.next to not mixup UTF16 and UTF32, and consistently use UTF32 for now. Bug: chromium:805855 Change-Id: If58e2fe0d9bebd894e12abf8af82881c74388294 Reviewed-on: https://chromium-review.googlesource.com/888741 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#50886}
-
Georg Neis authored
This is a reland of 181ac2b0 that fixes the issue with load elimination. Original change's description: > [ic] Improve performance of KeyedStoreIC on literal-based arrays. > > In mode STORE_AND_GROW_NO_TRANSITION, the handler for elements stores > used to bail out when seeing a COW array, even if the store that > installed the handler had been operating on the very same array. > > This CL adds support for COW arrays to the mode (and renames it to > STORE_AND_GROW_NO_TRANSITION_HANDLE_COW). > > Bug: v8:7334 > Change-Id: I6a15e8c1ff8d4ad4d5b8fc447745dce5d146c67c > Reviewed-on: https://chromium-review.googlesource.com/876014 > Commit-Queue: Georg Neis <neis@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50840} TBR=bmeurer@chromium.org Bug: v8:7334, chromium:805768 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I3d9c1b08583e08d68a1d30242a25e4a2190c8c55 Reviewed-on: https://chromium-review.googlesource.com/886261 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Jakob Gruber authored
This reverts commit 7ac6edf9. Reason for revert: Fails on gcc (https://build.chromium.org/p/client.v8/builders/V8%20Linux%20gcc%204.8/builds/17623) Original change's description: > [builtins] Add .incbin cctest > > Just to ensure this is portable across all platforms. > > Credits go to https://github.com/graphitemaster/incbin, bits of the > .incbin code were taken from there. Thanks! > > Bug: v8:6666 > Change-Id: Id068f70fb4ac925b574a14dec40cf80627a22073 > Reviewed-on: https://chromium-review.googlesource.com/881181 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50883} TBR=yangguo@chromium.org,jgruber@chromium.org Change-Id: Ibf4527e068afffb5380839a0936992087903135e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6666 Reviewed-on: https://chromium-review.googlesource.com/888620Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#50884}
-
jgruber authored
Just to ensure this is portable across all platforms. Credits go to https://github.com/graphitemaster/incbin, bits of the .incbin code were taken from there. Thanks! Bug: v8:6666 Change-Id: Id068f70fb4ac925b574a14dec40cf80627a22073 Reviewed-on: https://chromium-review.googlesource.com/881181 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#50883}
-
Michael Achenbach authored
TBR=sergiyb@chromium.org NOTREECHECKS=true NOTRY=true Bug: chromium:786303 Change-Id: I81ebe285f93ee777fb0d20cbaa2fee40d4b77ec0 Reviewed-on: https://chromium-review.googlesource.com/888740Reviewed-by:
-
Clemens Hammacher authored
This adds support for the rest of the i32 comparisons. R=titzer@chromium.org Bug: v8:6600 Change-Id: Ic613c59d17140b1e5c72fb58c4a8487ae13b6ae6 Reviewed-on: https://chromium-review.googlesource.com/887022Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#50881}
-
Choongwoo Han authored
Replace conversions of relative indices in builtin-string-gen.cc with ConvertToRelativeIndex which is defined in code-stub-assembler.cc. Change-Id: I790d58d296ccb482d3f96a62ec64227b1c2ce2c0 Reviewed-on: https://chromium-review.googlesource.com/883701Reviewed-by:
-
Michael Achenbach authored
A timeout result of randomly combined tests is not a useful indicator. Therefore we ignore those now. This also prevents timeouts from being re-run. TBR=sergiyb@chromium.org NOTRY=true Bug: v8:6917 Change-Id: I8e5eb93e2f13067ca5270fb152c3dc1eda1bb3c2 Reviewed-on: https://chromium-review.googlesource.com/888559Reviewed-by:
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/3e3eeac..4ab66b7 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/e99797e..8d63750 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/179d836..1243a6d TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ib530d55dc6aba878088ec6433fd815aeb2c52f90 Reviewed-on: https://chromium-review.googlesource.com/887981Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#50878}
-
Jakob Kummerow authored
which was dropped from the proposal: https://github.com/tc39/proposal-bigint/pull/101 Bug: v8:6791 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I5a3e0024900b34a322a23bcbc4bfdbdffbf8b9d4 Reviewed-on: https://chromium-review.googlesource.com/885510 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#50877}
-
jing.bao authored
Change-Id: I7dd81c104da3296cb78688c066b24e12b8ffc6c2 Reviewed-on: https://chromium-review.googlesource.com/882952 Commit-Queue: Jing Bao <jing.bao@intel.com> Reviewed-by:
Aseem Garg <aseemgarg@chromium.org> Cr-Commit-Position: refs/heads/master@{#50876}
-
- 25 Jan, 2018 19 commits
-
-
Deepti Gandluri authored
- Shift opcode numbers for asmjs-compat opcodes - Add --experimental-wasm-se flag to gate sign extension opccodes - Fix codegen for ia32 movsx instructions Bug: v8:6532 Change-Id: If7c9eff5ac76d24496effb2314ae2601bb8bba85 Reviewed-on: https://chromium-review.googlesource.com/838403 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
-
Michal Majewski authored
Bug: v8:6917 Change-Id: I7e04255649f62a28f0ed07ccb4fbaf4825498bf6 Reviewed-on: https://chromium-review.googlesource.com/886841 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by:
-
Sigurd Schneider authored
For M65 I added a fast-path for String.p.charCodeAt, which behaves incorrectly for wide characters. This patch disables the incorrect fast-path. This is likely no performance regression against M64, as M64 did not have a fast path for String.p.charCodeAt. Bug: v8:7371 Change-Id: I8ea9c5da5a583138d87ccb8ffe6d61eba16630b9 Reviewed-on: https://chromium-review.googlesource.com/886782 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#50873}
-
Michal Majewski authored
Bug: v8:6917 Change-Id: I36b7ef75d34f9dfee20cba09d55063d816334293 Reviewed-on: https://chromium-review.googlesource.com/887021Reviewed-by:
-
Michal Majewski authored
Bug: v8:6917 Change-Id: I3ba4ca3df8bac400c248fa16c58fcba3497da806 Reviewed-on: https://chromium-review.googlesource.com/881167 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by:
-
Michal Majewski authored
This is a reland of 4de2be99. Original change's description: > [test] Move timeout control to timeout processor > > Bug: v8:6917 > Change-Id: I03be38be952f0d59eb20fa98102ef09ca795de40 > Reviewed-on: https://chromium-review.googlesource.com/883446 > Commit-Queue: Michał Majewski <majeski@google.com> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50848} Bug: v8:6917 Change-Id: I52798af84991d4815910e9da5f4837329cdb3c96 Reviewed-on: https://chromium-review.googlesource.com/885765Reviewed-by:
-
Yang Guo authored
This is somewhat of a revival of what used to be UnseededNumberDictionary. The difference to NumberDictionary is that each entry only has two fields (no field for property details) and there is no header field for a bitfield. The reason for this change is memory regression introduced when we removed UnseededNumberDictionary (6e1c57ea). We now use SimpleNumberDictionary for - slow template instantiation cache - code stubs table - value serializer map - stack frame cache - type profile source positions R=ishell@chromium.org, ulan@chromium.org Bug: chromium:783695 Change-Id: I3cd32e485060bb379fb2279eeefbbbded7455f0e Reviewed-on: https://chromium-review.googlesource.com/885811Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#50869}
-
Clemens Hammacher authored
Also refactor the implementation of i32.eqz such that the same platform-specific code can be reused. As a next step, it should be straight-forward to add other i32 comparison operations. R=titzer@chromium.org Bug: v8:6600 Change-Id: I4e8768d4ceb7294ba35777b7777ddd69d1a58cf1 Reviewed-on: https://chromium-review.googlesource.com/877889 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
peterwmwong authored
- Introduce new helper IsFastJSArrayWithNoCustomIteration. - Consolidates all entry array checks... - Is a fast array (defers to BranchIfFastJSArray) - No possibility that the Array's iteration protocol has been tampered with - Introduce new BoolT constant helpers Int32TrueConstant and Int32FalseConstant. Bug: chromium:804176, chromium:804188 Change-Id: I6b08396484682dc680b431ea564a7a28eeab8108 Reviewed-on: https://chromium-review.googlesource.com/883065 Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Reviewed-by: -
Michael Achenbach authored
TBR=sergiyb@chromium.org Bug: v8:7343 Change-Id: I24ec4d9a58596cca22ca34a48b5a7297ed24b132 Reviewed-on: https://chromium-review.googlesource.com/886341Reviewed-by:
-
Michael Lippautz authored
No-try: true Bug: v8:7266 Change-Id: I89f54feafbd4e2a6021c3bd8e339b00ed39fc3b9 Reviewed-on: https://chromium-review.googlesource.com/883883Reviewed-by:
-
Sigurd Schneider authored
Array.p.reduce[Right] did not correctly treat holey arrays when dealing with mixed holey/non-holey receiver maps. Bug: chromium:804956 Change-Id: Ic22f64a1beeb93005809948299cde1f1d21a0f19 Reviewed-on: https://chromium-review.googlesource.com/883241Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#50864}
-
Andreas Haas authored
In addition I added some comments in the update script which describes steps which have to be takes the first time you run the script on a new machine. R=titzer@chromium.org Change-Id: Ib360e6fcdcb63eaf225f398eff60041b48f86b62 Reviewed-on: https://chromium-review.googlesource.com/883344Reviewed-by:
-
Clemens Hammacher authored
We cannot handle i64 values yet, so bail out if an indirect call returns i64. The same bailout already exists for direct calls. R=ahaas@chromium.org Bug: v8:6600 Change-Id: I3ddf44a913ee79b5610862e3a93059c6d37a280c Reviewed-on: https://chromium-review.googlesource.com/885813Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#50862}
-
Georg Neis authored
Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I0ecc0af1668f5036bb591e8236d9a28fba61cea5 Reviewed-on: https://chromium-review.googlesource.com/881782 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#50861}
-
Georg Neis authored
This reverts commit 181ac2b0. Reason for revert: TF changes break load elimination. Original change's description: > [ic] Improve performance of KeyedStoreIC on literal-based arrays. > > In mode STORE_AND_GROW_NO_TRANSITION, the handler for elements stores > used to bail out when seeing a COW array, even if the store that > installed the handler had been operating on the very same array. > > This CL adds support for COW arrays to the mode (and renames it to > STORE_AND_GROW_NO_TRANSITION_HANDLE_COW). > > Bug: v8:7334 > Change-Id: I6a15e8c1ff8d4ad4d5b8fc447745dce5d146c67c > Reviewed-on: https://chromium-review.googlesource.com/876014 > Commit-Queue: Georg Neis <neis@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50840} TBR=neis@chromium.org,ishell@chromium.org,bmeurer@chromium.org Change-Id: Id841d91b12d199045e0a9c4ddae2c2ead20b5e21 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7334 Reviewed-on: https://chromium-review.googlesource.com/885814Reviewed-by:
-
Yang Guo authored
R=machenbach@chromium.org Bug: v8:7341 Change-Id: I8ab5cadbff2428f43ee1f240c58c53f14c2a8df3 Reviewed-on: https://chromium-review.googlesource.com/883201 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/6f1e572..3e3eeac Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/296e7c3..e99797e TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: If632b39f9f0a9b7ce511b367f04f6b281cfe73df Reviewed-on: https://chromium-review.googlesource.com/885721Reviewed-by:
-
Deepti Gandluri authored
Bug: v8:6020 Change-Id: I056eb376bddfefad9f509808a6c71f5ce1769402 Reviewed-on: https://chromium-review.googlesource.com/877327 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
-
- 24 Jan, 2018 9 commits
-
-
Benedikt Meurer authored
Refactor the PromiseHandle builtin and move the separate debug checks into the PromiseHookBefore and PromiseHookAfter runtime calls, so they are performed only when we've already hit the slow-path. Bug: v8:7253 Change-Id: I01ab8592a474b6897280734b995cab0b90a5e010 Reviewed-on: https://chromium-review.googlesource.com/884583Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#50856}
-
Ali Ijaz Sheikh authored
Do not start a new step when an existing step is in progress. We may have partially updated information as part of the current step, and the next step will assume consistency. A new step will be started once the current in-progress step completes. BUG=v8:7313 Change-Id: I4c0c47c4f4b5f8b9139be24408440189679b38dc Reviewed-on: https://chromium-review.googlesource.com/882507Reviewed-by:
Ali Ijaz Sheikh <ofrobots@google.com> Commit-Queue: Ali Ijaz Sheikh <ofrobots@google.com> Cr-Commit-Position: refs/heads/master@{#50855}
-
Michal Majewski authored
This is a reland of 4de2be99. Original change's description: > [test] Move timeout control to timeout processor > > Bug: v8:6917 > Change-Id: I03be38be952f0d59eb20fa98102ef09ca795de40 > Reviewed-on: https://chromium-review.googlesource.com/883446 > Commit-Queue: Michał Majewski <majeski@google.com> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50848} Bug: v8:6917 Change-Id: I7c83bf1cb8965a149b06c1dbc138b5d097f5275d Reviewed-on: https://chromium-review.googlesource.com/883284Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Michał Majewski <majeski@google.com> Cr-Commit-Position: refs/heads/master@{#50854}
-
Clemens Hammacher authored
When moving arguments for calls into the right registers and stack slots, we were sometimes overwriting stack slots which would still be used later to load arguments from. This is because we popped the (wasm) value stack before executing the register moves, hence the stack transfer would think the values are not being used any more and reuse the stack slots. With this CL, we only pop the arguments from the stack after executing the stack transfer. R=ahaas@chromium.org Bug: v8:7366, v8:6600 Change-Id: I3aa5126c82634fd281959075e91e73465c39abaa Reviewed-on: https://chromium-review.googlesource.com/883802 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Sergiy Byelozyorov authored
R=machenbach@chromium.org Bug: chromium:616879 Change-Id: Ice9927dd4bbaf72141c6693e4afaf57a362f515b Reviewed-on: https://chromium-review.googlesource.com/884281Reviewed-by:
-
Michael Achenbach authored
This reverts commit 4de2be99. Reason for revert: Testing stops too early now, e.g. here after 2 min: https://build.chromium.org/p/client.v8.clusterfuzz/builders/V8%20NumFuzz/builds/32 Original change's description: > [test] Move timeout control to timeout processor > > Bug: v8:6917 > Change-Id: I03be38be952f0d59eb20fa98102ef09ca795de40 > Reviewed-on: https://chromium-review.googlesource.com/883446 > Commit-Queue: Michał Majewski <majeski@google.com> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50848} TBR=machenbach@chromium.org,sergiyb@chromium.org,majeski@google.com Change-Id: I6a925866476c69b3b50aa08e99facca0eaaa396b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6917 Reviewed-on: https://chromium-review.googlesource.com/884082Reviewed-by:
-
Michael Achenbach authored
This is a reland of fffa4555. The win asan bots use win10 now which should fix the problems. Original change's description: > [build] Prepare switching win asan to 64 bits > > This switches the current win32 bots to win32 under the hood in MB. We'll > remove them and replace them with win64 bots in a follow up on the infra > side. > > This also infers the clang option from asan, because on windows we need > to set clang explicitly. > > TBR=sergiyb@chromium.org > > Bug: chromium:786303 > Change-Id: I9dddd5050a21a364c302a761ff15ddd21e97c7dc > Reviewed-on: https://chromium-review.googlesource.com/883103 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50828} TBR=sergiyb@chromium.org Bug: chromium:786303 Change-Id: Ie344a7b6b16f575a061d13b5c3792fc9bd862734 Reviewed-on: https://chromium-review.googlesource.com/883522Reviewed-by:
-
Benedikt Meurer authored
This adds a new operator JSCreatePromise, which currently allocates a native JSPromise instance and initializes it to pending state. In addition to that we introduce a new PromiseHookProtector, which get's invalidated the first time someone enables the debugger or installs a PromiseHook (via async_hooks for example). As long as the protector is intact we lower AsyncFunctionPromiseCreate to JSCreatePromise and AsyncFunctionPromiseRelease to a no-op in optimized code. This yields a speedup of roughly 33% on the benchmark mentioned in the bug. Bug: v8:7271, v8:7253 Change-Id: Ib5d219f2b6e052a7cc5e6ed5aa66dd3c8885a859 Reviewed-on: https://chromium-review.googlesource.com/883124 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Michal Majewski authored
Bug: v8:6917 Change-Id: I03be38be952f0d59eb20fa98102ef09ca795de40 Reviewed-on: https://chromium-review.googlesource.com/883446 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by:
-
