- 31 Jul, 2017 3 commits
-
-
Jakob Gruber authored
This reverts commit 2f79e035. Reason for revert: Conflicts with successor CL. Original change's description: > [builtins] Remove Builtins::Name() accessors > > Instead of auto-generating the Name() convenience accessor, use a macro to > avoid wasting code space. > > BUILTIN_CODE(isolate, Name) > > expands to > > isolate->builtins()->builtin_handle(Builtins::kName); > > This reduces the size of libv8.so by 134,752 bytes on a x64 release build. > > Bug: v8:6624 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng > Change-Id: Idff7ee5c45e344e73412c0f47e92553c7c7ff75f > Reviewed-on: https://chromium-review.googlesource.com/593607 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#47010} TBR=yangguo@chromium.org,ahaas@chromium.org,jgruber@chromium.org,bmeurer@chromium.org Change-Id: Ia9ef5c755b26c3f4e143d87a7c51033614ea435e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6624 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/594048Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#47012}
-
jgruber authored
Instead of auto-generating the Name() convenience accessor, use a macro to avoid wasting code space. BUILTIN_CODE(isolate, Name) expands to isolate->builtins()->builtin_handle(Builtins::kName); This reduces the size of libv8.so by 134,752 bytes on a x64 release build. Bug: v8:6624 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Idff7ee5c45e344e73412c0f47e92553c7c7ff75f Reviewed-on: https://chromium-review.googlesource.com/593607Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#47010}
-
Clemens Hammacher authored
This reverts commit 072d0e3e. Reason for revert: Performance regressions (https://crbug.com/749041). Original change's description: > [wasm] Allow for arbitrarily long error messages > > We currently have a fixed limit of 256 characters for error messages > generated in the decoder. However, we sometimes embed names in it, > which makes it easy to generate a crash by using long names (e.g. for > exports) in invalid wasm modules. > This CL fixes this by switching to a stream based interface, allowing > to pass arbitrary objects to be printed. With this interface, we can > easily limit the length of output later. > > R=titzer@chromium.org > > Bug: chromium:740023 > Change-Id: I2848c31c63a015157e2a3a9458b54e523060cd69 > Reviewed-on: https://chromium-review.googlesource.com/565282 > Reviewed-by: Ben Titzer <titzer@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#46860} TBR=titzer@chromium.org,clemensh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:740023, chromium:749041 Change-Id: I005a60d55dcf01d350230f8d98f715bab9c43886 Reviewed-on: https://chromium-review.googlesource.com/593807 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#47008}
-
- 27 Jul, 2017 6 commits
-
-
Alexey Kozyatinskiy authored
This CL moves us much closer to the point where we can remove debugger-script.js and usage of debugger context from inspector. There are three main parts left: - managing breakpoints, - inspecting stack and scopes (this CL), - LiveEdit. In this CL I moved all stack/scope inspection to native. As side effect running debugger and inspector tests are 10-20% faster (it's significant since not all of tests requesting break). R=yangguo@chromium.org,jgruber@chromium.org Bug: chromium:652939 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I409396a687e18e9c0554c0c9c35b6e1064627be8 Reviewed-on: https://chromium-review.googlesource.com/580645Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#46947}
-
Mircea Trofin authored
We've been passing a context to the compiler, which turns out to be solely used to determine if we're executing in a specific cctest configuration. This change adds a configuration to the graph builder that we can use to explicitly opt out of stack checks and traps. CcTests default to opting out, except for the few that don't. Bug: Change-Id: I4724e31c2a62e9b3ab4feadb788287c374b39f53 Reviewed-on: https://chromium-review.googlesource.com/585779Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Mircea Trofin <mtrofin@chromium.org> Cr-Commit-Position: refs/heads/master@{#46943}
-
Mircea Trofin authored
This reverts commit 862d605c. Reason for revert: fixed compile issue Original change's description: > Revert "[wasm] Consolidate function table representation." > > This reverts commit 4a45f35f. > > Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20debug%20builder/builds/25471 > > Original change's description: > > [wasm] Consolidate function table representation. > > > > This CL avoids the need to reference the function tables (and signatures) > > as either fixed arrays or vectors, preferring vectors. > > > > The only place we need fixed arrays is on the compiled module, to support > > serialization. When we move off the GC heap, we'll also move away > > from fixed arrays in that last case. > > > > The CL aids with getting wasm of the GC heap, by reducing the places > > and representations we'll need to change when changing the way we > > reference fixed tables. > > > > Bug: > > Change-Id: Id4e43905a3df39062bf2839fa72dd5d9a0fe87da > > Reviewed-on: https://chromium-review.googlesource.com/588334 > > Commit-Queue: Mircea Trofin <mtrofin@chromium.org> > > Reviewed-by: Brad Nelson <bradnelson@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#46917} > > TBR=bradnelson@chromium.org,titzer@chromium.org,mtrofin@chromium.org,ahaas@chromium.org > > Change-Id: Ie7d04f7ec74d6d0b3783df1c78c91c100ab784f4 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/588627 > Reviewed-by: Mircea Trofin <mtrofin@chromium.org> > Commit-Queue: Mircea Trofin <mtrofin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#46918} TBR=bradnelson@chromium.org,titzer@chromium.org,mtrofin@chromium.org,ahaas@chromium.org Change-Id: Ic0ba8097c13f2b1afd263b6243360e8ab95ae474 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/588667 Commit-Queue: Mircea Trofin <mtrofin@chromium.org> Reviewed-by:
Mircea Trofin <mtrofin@chromium.org> Cr-Commit-Position: refs/heads/master@{#46919}
-
Mircea Trofin authored
This reverts commit 4a45f35f. Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20debug%20builder/builds/25471 Original change's description: > [wasm] Consolidate function table representation. > > This CL avoids the need to reference the function tables (and signatures) > as either fixed arrays or vectors, preferring vectors. > > The only place we need fixed arrays is on the compiled module, to support > serialization. When we move off the GC heap, we'll also move away > from fixed arrays in that last case. > > The CL aids with getting wasm of the GC heap, by reducing the places > and representations we'll need to change when changing the way we > reference fixed tables. > > Bug: > Change-Id: Id4e43905a3df39062bf2839fa72dd5d9a0fe87da > Reviewed-on: https://chromium-review.googlesource.com/588334 > Commit-Queue: Mircea Trofin <mtrofin@chromium.org> > Reviewed-by: Brad Nelson <bradnelson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#46917} TBR=bradnelson@chromium.org,titzer@chromium.org,mtrofin@chromium.org,ahaas@chromium.org Change-Id: Ie7d04f7ec74d6d0b3783df1c78c91c100ab784f4 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/588627Reviewed-by:
Mircea Trofin <mtrofin@chromium.org> Commit-Queue: Mircea Trofin <mtrofin@chromium.org> Cr-Commit-Position: refs/heads/master@{#46918}
-
Mircea Trofin authored
This CL avoids the need to reference the function tables (and signatures) as either fixed arrays or vectors, preferring vectors. The only place we need fixed arrays is on the compiled module, to support serialization. When we move off the GC heap, we'll also move away from fixed arrays in that last case. The CL aids with getting wasm of the GC heap, by reducing the places and representations we'll need to change when changing the way we reference fixed tables. Bug: Change-Id: Id4e43905a3df39062bf2839fa72dd5d9a0fe87da Reviewed-on: https://chromium-review.googlesource.com/588334 Commit-Queue: Mircea Trofin <mtrofin@chromium.org> Reviewed-by:
Brad Nelson <bradnelson@chromium.org> Cr-Commit-Position: refs/heads/master@{#46917}
-
Karl Schimpf authored
Check for these UMA stats were in functions only used for testing. Moved the checks to code inside module decoding. Note that the module decoder is used both to validate and generate the intermediate (turbofan) graph of function bodies. This CL assumes that the validation phase (of function bodies) is the correct place to track decoding time. Bug: v8:6361 Change-Id: I791281daae96473d53cb8ae332fff8bb2673bf6c Reviewed-on: https://chromium-review.googlesource.com/586974 Commit-Queue: Karl Schimpf <kschimpf@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#46915}
-
- 26 Jul, 2017 1 commit
-
-
Ben L. Titzer authored
R=clemensh@chromium.org Bug: Change-Id: I5e4cd8dcb9c22cd261b48598c021f84ad712ba58 Reviewed-on: https://chromium-review.googlesource.com/586249Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#46895}
-
- 25 Jul, 2017 3 commits
-
-
Aseem Garg authored
With this patch, rather than embedding the JSReceiver address directly in the WasmToJS wrappers, we put that in a fixed array with global handle scope and instead embed the location of the handle and the index in the wrapper. This ensures that the wrapper doesn't need to be patched if the GC kicks in. This is needed to get the WASM code off the GCed heap. R=mtrofin@chromium.org Bug: Change-Id: Ie5a77a78cdecec51b04f702c63b8e4285e6a2d8d Reviewed-on: https://chromium-review.googlesource.com/581682 Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Reviewed-by:
Mircea Trofin <mtrofin@chromium.org> Cr-Commit-Position: refs/heads/master@{#46884}
-
Clemens Hammacher authored
We currently have a fixed limit of 256 characters for error messages generated in the decoder. However, we sometimes embed names in it, which makes it easy to generate a crash by using long names (e.g. for exports) in invalid wasm modules. This CL fixes this by switching to a stream based interface, allowing to pass arbitrary objects to be printed. With this interface, we can easily limit the length of output later. R=titzer@chromium.org Bug: chromium:740023 Change-Id: I2848c31c63a015157e2a3a9458b54e523060cd69 Reviewed-on: https://chromium-review.googlesource.com/565282Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#46860}
-
Clemens Hammacher authored
Extend the errors.js mjsunit test to also check for the message in the generated errors. This will help catch bugs later, e.g. when refactoring the way we output errors: https://chromium-review.googlesource.com/c/565282 Drive-by 1: Fix a superfluous period in one error message. Drive-by 2: Fix a weird exception catching construct in the test. R=titzer@chromium.org Change-Id: I1c2e92fb2c34a481cbf8802153f8502452d45348 Reviewed-on: https://chromium-review.googlesource.com/582960Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#46858}
-
- 24 Jul, 2017 1 commit
-
-
titzer authored
BUG=chromium:747995 Review-Url: https://codereview.chromium.org/2981883002 Cr-Commit-Position: refs/heads/master@{#46848}
-
- 19 Jul, 2017 2 commits
-
-
Clemens Hammacher authored
Before the existence of "= delete", we were enforcing that the DISALLOW_* macros were used in the private: section of classes only. This is not needed any more, hence remove the comment on the macros. Also, introduce macros for making types move-only, and use them instead of our special macro in wasm. R=bmeurer@chromium.org CC=titzer@chromium.org Change-Id: Iceba456fb0a32ae67defe16e35b865db8c8da500 Reviewed-on: https://chromium-review.googlesource.com/577687Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#46773}
-
titzer authored
R=ishell@chromium.org,clemensh@chromium.org BUG=chromium:742659 Review-Url: https://codereview.chromium.org/2977113002 Cr-Commit-Position: refs/heads/master@{#46772}
-
- 18 Jul, 2017 5 commits
-
-
Clemens Hammacher authored
This makes all data structures containing non-trivially-copyable fields move-only, to prevent security and performance bugs. Drive-by: Fix smaller performance bugs found by this refactoring. R=titzer@chromium.org Change-Id: I6802ac3591534c2ab5cacb2ca42b737f3b7fa801 Reviewed-on: https://chromium-review.googlesource.com/576170Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#46747}
-
Clemens Hammacher authored
This allows to reuse the class e.g. in the baseline compiler. R=titzer@chromium.org Change-Id: I7251af16e8c74f267834a9cefb676edf3c9f3a07 Reviewed-on: https://chromium-review.googlesource.com/570020Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#46735}
-
Clemens Hammacher authored
This CL replaces some Handles which can be empty by MaybeHandle. This documents that they can be empty, and forces a check before using them. R=ahaas@chromium.org Change-Id: Iefb9ae76617c45d2304b0a620dc082ab9c7b0585 Reviewed-on: https://chromium-review.googlesource.com/574593Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#46733}
-
Clemens Hammacher authored
This refactoring makes some parameters const, and does not rely on the fact that inputs are passed via NodeVector. Both changes are needed for an upcoming refactoring of the wasm decoder. R=bbudge@chromium.org Change-Id: Ifbd6185ae9ea5a0ef526c2fd695e13e3f14475f4 Reviewed-on: https://chromium-review.googlesource.com/571004Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#46729}
-
Clemens Hammacher authored
Signature maps should only be updated, but never copied. We had a bug because we accidentally updated a copy of the map. This refactoring prevents any such bugs in the future, and fixes more occurences where we accidentally copied structs containing a signature map (the move-only constraint also extends to all structs containing a signature map). Drive-by: Make InstanceBuilder::NeedsWrappers const. R=titzer@chromium.org Bug: chromium:741750 Change-Id: Id919203d8c4078e608a1163e5c790c97d06a9753 Reviewed-on: https://chromium-review.googlesource.com/571791Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#46728}
-
- 14 Jul, 2017 2 commits
-
-
Clemens Hammacher authored
This is a reland of 5648aad5. Previous compile error should be fixed by disabling strict aliasing assumptions on gyp: https://chromium-review.googlesource.com/c/571806 Original change's description: > [wasm] Don't store global handles in the interpreter > > Storing global handles in the interpreter is dangerous, because the > global handles are strong roots into the heap. The interpreter itself is > referenced from the heap via a Managed. Hence the interpreter keeps the > instance alive, while the instance keeps the Managed alive. So the GC > will never collect them. > > This CL refactors this to only store the handle to the instance object > while executing in the interpreter, and clearing it when returning. > It also removes the cache of import wrappers, as it should not be > performance critical, but keeps lots of objects alive. If it turns out > to be performance critical, we will have to reintroduce such a cache > stored in the WasmDebugInfo object. > > R=titzer@chromium.org > CC=ahaas@chromium.org > > Bug: chromium:610330 > Change-Id: I54b489dadc16685887c0c1a98da6fd0df5ad7cbb > Reviewed-on: https://chromium-review.googlesource.com/567058 > Reviewed-by: Ben Titzer <titzer@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#46629} TBR=titzer@chromium.org Bug: chromium:610330 Change-Id: Ic7836b1b1a044a89f2138f0c76f92acd3a1b2f2b Reviewed-on: https://chromium-review.googlesource.com/570578 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#46679}
-
Clemens Hammacher authored
The code was already there, but there was a bug in it: Because of the missing reference, we were only updating a *copy* of the signature map, hence the update had no effect. This intentially is a minimal CL, in order to allow for easy backmerging. More mitigations and tests are coming in a separate CL. R=titzer@chromium.org Change-Id: Ifb462093f4b8f4d5380b6774636537c67c2b676c Reviewed-on: https://chromium-review.googlesource.com/570278Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#46664}
-
- 13 Jul, 2017 7 commits
-
-
sreten.kovacevic authored
Found issue with BuildChangeEndianness. There is difference between load and store case. Load depends primarily on MachineRepresentation, while store depends on ValueType. TEST=wasm-spec-tests/tests/endianness TEST=wasm-spec-tests/tests/memory TEST=wasm-spec-tests/tests/memory_trap Bug: Change-Id: I437f611107daad2f425a67fcc068e874822e0f58 Reviewed-on: https://chromium-review.googlesource.com/558882Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@imgtec.com> Cr-Commit-Position: refs/heads/master@{#46645}
-
Igor Sheludko authored
... that have computed name and/or require home object. This should give us the opportunity to implement initialization of name and home object values in a stub. Bug: v8:6459 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I47a1a2c185e120e86c793733cce737811f895291 Reviewed-on: https://chromium-review.googlesource.com/512802Reviewed-by:
Ben Titzer <titzer@chromium.org> Reviewed-by:
Andreas Rossberg <rossberg@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#46638}
-
Clemens Hammacher authored
This reverts commit 5648aad5. Reason for revert: Compile error on mips: https://build.chromium.org/p/client.v8.ports/builders/V8%20Mips%20-%20builder/builds/10732 Original change's description: > [wasm] Don't store global handles in the interpreter > > Storing global handles in the interpreter is dangerous, because the > global handles are strong roots into the heap. The interpreter itself is > referenced from the heap via a Managed. Hence the interpreter keeps the > instance alive, while the instance keeps the Managed alive. So the GC > will never collect them. > > This CL refactors this to only store the handle to the instance object > while executing in the interpreter, and clearing it when returning. > It also removes the cache of import wrappers, as it should not be > performance critical, but keeps lots of objects alive. If it turns out > to be performance critical, we will have to reintroduce such a cache > stored in the WasmDebugInfo object. > > R=titzer@chromium.org > CC=ahaas@chromium.org > > Bug: chromium:610330 > Change-Id: I54b489dadc16685887c0c1a98da6fd0df5ad7cbb > Reviewed-on: https://chromium-review.googlesource.com/567058 > Reviewed-by: Ben Titzer <titzer@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#46629} TBR=titzer@chromium.org,clemensh@chromium.org Change-Id: Ifadfb885f937f37bb3eab4732a97f20ff40c2583 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:610330 Reviewed-on: https://chromium-review.googlesource.com/569962Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#46630}
-
Clemens Hammacher authored
Storing global handles in the interpreter is dangerous, because the global handles are strong roots into the heap. The interpreter itself is referenced from the heap via a Managed. Hence the interpreter keeps the instance alive, while the instance keeps the Managed alive. So the GC will never collect them. This CL refactors this to only store the handle to the instance object while executing in the interpreter, and clearing it when returning. It also removes the cache of import wrappers, as it should not be performance critical, but keeps lots of objects alive. If it turns out to be performance critical, we will have to reintroduce such a cache stored in the WasmDebugInfo object. R=titzer@chromium.org CC=ahaas@chromium.org Bug: chromium:610330 Change-Id: I54b489dadc16685887c0c1a98da6fd0df5ad7cbb Reviewed-on: https://chromium-review.googlesource.com/567058Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#46629}
-
Clemens Hammacher authored
It's ok that the instance of the called code object is different from the caller instance. This happens if one instance calls an exported function of another instance. R=ahaas@chromium.org Bug: chromium:739768 Change-Id: I6afa8332a9b33fe32e9332cdca573053f058421d Reviewed-on: https://chromium-review.googlesource.com/568494Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#46624}
-
Clemens Hammacher authored
It used to be module-relative, but since we switched to decoding sections individually, the offsets would be section-relative. This CL fixes this by adding the buffer offset to the reported locations. R=ahaas@chromium.org Change-Id: I27240832e5cbd625d6b952678503252017dd83f3 Reviewed-on: https://chromium-review.googlesource.com/568488 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#46623}
-
Clemens Hammacher authored
The DCHECK is supposed to check that the read in the next line does not read out of bounds. Hence we have to use {pc} and not {pc_}. I accidentally triggered this while writing an unrelated test case, but now fail to reproduce. R=ahaas@chromium.org Change-Id: Ia3fa9a9874866dc14180b22b9af526459fbda495 Reviewed-on: https://chromium-review.googlesource.com/568487Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#46621}
-
- 12 Jul, 2017 2 commits
-
-
Karl Schimpf authored
This turns on collection of function size bytes, and decode time for functions in all cases (both background and foreground). Bug: v8:6361 Change-Id: I5d982ec4452596210b3ea9858126820ad0c3eacf Reviewed-on: https://chromium-review.googlesource.com/568781 Commit-Queue: Karl Schimpf <kschimpf@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#46605}
-
Adam Klein authored
JSFunction::SetName can fail if it tries to create a string with length > String::kMaxLength (either by prepending "set "/"get " or by surrounding a Symbol descriptor with "["/"]"). This patch propagates that exception to the surrounding code rather than CHECK-failing. Bug: chromium:740398 Change-Id: I394943af481f3147387dd82ec5862d7071d57827 Reviewed-on: https://chromium-review.googlesource.com/566092Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Mircea Trofin <mtrofin@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#46601}
-
- 10 Jul, 2017 8 commits
-
-
Deepti Gandluri authored
- Implement js-api changes for WebAssembly.Memory to accept a shared parameter - Update allocation to use SharedArrayBuffers BUG=v8:6532 R=binji@chromium.org, bradnelson@chromium.org Change-Id: I021491217568751b06fbd7b4b08b1dd88910e21d Reviewed-on: https://chromium-review.googlesource.com/564058 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Brad Nelson <bradnelson@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#46543}
-
Karl Schimpf authored
This Cl fixes a fundamental misunderstanding when Wasm memory histograms were added. They were added using HISTOGRAM_MEMORY_LIST(). This macro implements aggregating memory histograms that handle cases memory cases that are not module specific. The fixed memory histograms are all module specific, and are simple histograms. In addition, it removes field is_sync from ModuleCompiler and WasmCompilationUnit, since the field is no longer needed to make the fixed memory histograms synchronous. Bug: v8:6361 Change-Id: I696109b4fd1a4aadc87a6bdbbc4b7daefd58ea51 Reviewed-on: https://chromium-review.googlesource.com/565349Reviewed-by:
Brad Nelson <bradnelson@chromium.org> Commit-Queue: Karl Schimpf <kschimpf@chromium.org> Cr-Commit-Position: refs/heads/master@{#46541}
-
Karl Schimpf authored
Adds missing opcodes for exception handling for the function body decoder. Also adds error messages if the exception handling construct is not yet functional. Note that the previous prototype for catch and throw have been marked as not yet functional. This was done because it doesn't model exceptions the way the proposal suggests. Rather, they implement a hard-coded (c++ model) of exceptions. Bug: v8:6577 Change-Id: Ife170b9f0cb2be91b11082e43c4795ce81a427dc Reviewed-on: https://chromium-review.googlesource.com/564138Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Karl Schimpf <kschimpf@chromium.org> Cr-Commit-Position: refs/heads/master@{#46540}
-
Karl Schimpf authored
Modifies V8 to be able to parse the exception section (defining exception types), when the experimental_wasm_eh flag is true. Bug: v8:6577 Change-Id: I5d8b3fddaf5b0dec6b14ddd0992f9fb883e8dc90 Reviewed-on: https://chromium-review.googlesource.com/561757 Commit-Queue: Karl Schimpf <kschimpf@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#46539}
-
Karl Schimpf authored
That is, change to use TimedHistogram (which functions properly on background threads). Bug: v8:6361 Change-Id: I821fb0afea97be422786778d576683f67667c31b Reviewed-on: https://chromium-review.googlesource.com/559769 Commit-Queue: Karl Schimpf <kschimpf@chromium.org> Reviewed-by:
Brad Nelson <bradnelson@chromium.org> Cr-Commit-Position: refs/heads/master@{#46529}
-
jgruber authored
This adds a convenience method for the common Smi to int conversion pattern. Bug: Change-Id: I7d7b171c36cfec5f6d10c60f1d9c3e06e3aed0fa Reviewed-on: https://chromium-review.googlesource.com/563205 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Andreas Rossberg <rossberg@chromium.org> Cr-Commit-Position: refs/heads/master@{#46516}
-
titzer authored
R=clemensh@chromium.org BUG=chromium:740199 Review-Url: https://codereview.chromium.org/2977543002 Cr-Commit-Position: refs/heads/master@{#46508}
-
Loo Rong Jie authored
Change-Id: I7fd794342a13718059b47ea25c26d850ed2da509 Reviewed-on: https://chromium-review.googlesource.com/564189Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#46506}
-