1. 20 Nov, 2020 1 commit
    • Clemens Backes's avatar
      [wasm][profiler] Fix late enabling of the profiler · 31005b5c
      Clemens Backes authored
      We had a test which first enabled the profiler, and then compiled wasm
      code. In this case, all code objects were registered correctly and the
      profile looked as expected.
      This CL extends the test for also test another order: First compile the
      wasm code, then enable the profiler. In that case, we were reporting a
      wrong debug name of the exported wasm function. The name of that
      function is spec'ed to be the string representation of the function
      index. But for debugging, we want to see a more meaningful name,
      identical to the name we show when reporting the code during
      compilation.
      
      This fix requires handlifying the {SharedFunctionInfo::DebugName}
      method, because for exported wasm functions, it needs to allocate a new
      name on the JS heap.
      In order to avoid this allocation where possible, a second variant is
      added which returns a unique_ptr directly. This can be used in all
      places where the name is just being printed, which turned out to be the
      majority of cases ({DebugName().ToCString()}).
      
      R=petermarshall@chromium.org
      
      Bug: chromium:1141787
      Change-Id: I0343c2f06f0b852007535ff07459b712801ead01
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2543931
      Commit-Queue: Clemens Backes <clemensb@chromium.org>
      Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
      Reviewed-by: 's avatarPeter Marshall <petermarshall@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#71308}
      31005b5c
  2. 11 Aug, 2020 1 commit
  3. 13 Sep, 2019 1 commit
  4. 24 May, 2019 1 commit
  5. 23 May, 2019 2 commits
  6. 20 May, 2019 1 commit
  7. 17 May, 2019 2 commits
  8. 07 Mar, 2019 1 commit
  9. 26 Dec, 2018 1 commit
  10. 17 Dec, 2018 1 commit
  11. 08 Dec, 2018 1 commit
  12. 28 Nov, 2018 1 commit
  13. 27 Nov, 2018 1 commit
  14. 14 Sep, 2018 1 commit
  15. 30 May, 2017 1 commit
  16. 07 Dec, 2016 1 commit
    • lpy's avatar
      [Tracing] Implement IC statistics in tracing. · 0a3c8fc3
      lpy authored
      This patch introduces:
      
      1. ICStats class to store ic statistics items produced by V8,
      2. A disabled by default tracing category v8.ic_stats,
      3. An trace event V8.ICStats that contains ic statistics items in args,
      
      We store ic statistics items in an array until the array is full to reduce
      the number of trace events.
      
      TBR=jkummerow@chromium.org,ishell@chromium.org
      
      Review-Url: https://codereview.chromium.org/2503183002
      Cr-Commit-Position: refs/heads/master@{#41559}
      0a3c8fc3