- 06 Apr, 2022 1 commit
-
-
Shu-yu Guo authored
For the normative change, see https://github.com/tc39/ecma262/pull/2723 Bug: v8:12750, v8:11111 Change-Id: I8e8a2e9b443622b20bb5a4c2d453f782dfbd2ed6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3570865 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#79789}
-
- 05 Apr, 2022 21 commits
-
-
Shu-yu Guo authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/4c7c24646a..d7c0a2076c Bug: v8:7834, v8:10776, v8:11544, v8:12744, v8:12750 Change-Id: I782a347833af3418ff5c15562ae24f213375b539 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3573067 Commit-Queue: Shu-yu Guo <syg@chromium.org> Auto-Submit: Shu-yu Guo <syg@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/main@{#79788}
-
Shu-yu Guo authored
The FastArray path for Array#groupBy and Array#groupByToMap does not recheck the input array's length each iteration. This is incorrect since the grouping callback can truncate the length, and we should deopt to the generic path when this happens. Bug: chromium:1312838, v8:12499 Change-Id: Id3a4973e9960500a2f29ed63281ea721777d4dd3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3570342Reviewed-by:
-
Camillo Bruni authored
- Double click on the current timeline selection to focus and zoom in - Make timeline-tracks focusable by setting a tabindex - Add back arrow-key navigation for the map panel (only when focused) - Prepare code for adding keyboard-based horizontal scrolling - Use --code-font CSS variable Bug: v8:10644 Change-Id: Ic473695c9fcdc795d173cd064b4660e100ae8b24 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3568475Reviewed-by:
Patrick Thier <pthier@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#79786}
-
Anton Bikineev authored
The DCHECKs check that the metrics from previous cycles are extracted for both young and full GCs. Bug: chromium:1029379 Change-Id: I8390d474abc8bd698e7f02896383b6fe013d792e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3570430Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/main@{#79785}
-
Michael Lippautz authored
Incremental finalization previously used to rescan roots to avoid any new work showing up in the atomic pause. With concurrent marking we should be way faster in finalizing, so that we can save ourselves this work. In particular, if we finalize in the same JS execution we would be doubling work as the atomic pause anyways needs to rescan all roots. Bug: v8:12775 Change-Id: I58a5a931da72c8d5c8aee4cd5dad4512954668b4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3570427Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#79784}
-
Clemens Backes authored
Use C++17's std::void_t instead. R=leszeks@chromium.org Bug: v8:12425 Change-Id: I1367af170505ed97a725e22f6b60cce056f72cb1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3568476Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#79783}
-
Thibaud Michaud authored
Pass the context as an argument of the runtime function, instead of using the stack frame iterator to find it. R=jkummerow@chromium.org Bug: v8:12191 Change-Id: I43c0cf74b1b83b9c1c63df99c3816bd3f3e94ebf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3562984Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#79782}
-
Leszek Swirski authored
This reverts commit 54e360d1. Reason for revert: Waterfall failures https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20debug/38922/overview Original change's description: > [wasm] --liftoff-only should disable --wasm-dynamic-tiering > > A Liftoff only configuration should never tier up to TurboFan, hence add > a proper implication to disable dynamic tiering if --liftoff-only is > set. > Also, add a DCHECK to ensure we never accidentally compile with TurboFan > if --liftoff-only is set. > > R=jkummerow@chromium.org > > Bug: v8:12281 > Change-Id: Ia9b81add503cc939f59fde3f4d3bb67252facf2c > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3569741 > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/main@{#79779} Bug: v8:12281 Change-Id: Ie1551a9c7b4491cf02995acd0b72a276c2f68eab No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3572042 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#79781}
-
Anton Bikineev authored
When the heap is gracefully terminated, all the destructors are called. CrossThreadPersistents must clear the back references (references from CrossThreadPersistentRegion) so that further GCs on other threads will not access freed CTPs. To force destruction with young-gen enabled, the CL unmarks the heap on termination. Bug: chromium:1029379 Change-Id: I7f4a34a914ca20b50fe6d2ad493d56e0ba525ecc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3568473Reviewed-by:
-
Clemens Backes authored
A Liftoff only configuration should never tier up to TurboFan, hence add a proper implication to disable dynamic tiering if --liftoff-only is set. Also, add a DCHECK to ensure we never accidentally compile with TurboFan if --liftoff-only is set. R=jkummerow@chromium.org Bug: v8:12281 Change-Id: Ia9b81add503cc939f59fde3f4d3bb67252facf2c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3569741Reviewed-by:
-
Leszek Swirski authored
This reverts commit 1f0d7d20. Reason for revert: Speculative revert for roll failures in https://chromium-review.googlesource.com/c/chromium/src/+/3569445 Original change's description: > cppgc-js: Concurrently process v8::TracedReference > > Adds concurrent marking for reaching through v8::TracedReference. > Before this CL, a v8::TracedReference would always be processed on the > main thread by pushing a callback for each encountered reference. > > This CL now wires up concurrent handling for such references. In particular: > - Global handles are already marked as well and not repurposed during > the same GC cycle. > - Since global handles are not repurposed, it is enough to > double-deref to the V8 object, checking for possible null pointers. > - The bitmap for global handle flags is mostly non-atomic, with the > markbit being the exception. > - Finally, all state is wired up in CppHeap. Concurrent markers keep > their own local worklist while the mutator marker directly pushes to > the worklist owned by V8. > > Bug: v8:12600 > Change-Id: Ia67dbd18a57dbcccf4dfb9ccfdb9ee438d27fe71 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3516255 > Reviewed-by: Omer Katz <omerkatz@chromium.org> > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#79736} Bug: v8:12600 Change-Id: I8a91dcd6880580207bf8d315b264edbe42a794e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3568474 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Owners-Override: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
R=jkummerow@chromium.org CC=fgm@chromium.org Change-Id: I57c1860ef35919cdc7752e1dcc1beccfb4282b90 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3555770Reviewed-by:
-
Dominik Inführ authored
HeapAllocator didn't fall back to old space allocation when the heap had no map space. Bug: v8:12578, chromium:1313119 Change-Id: Ic02334f42f9fb80a8a9dcf99a94a7ac16da24053 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3570423Reviewed-by:
-
Victor Gomes authored
If we have a smi operation in the feedback vector, we emit SmiTag Int32AddWithOverflow and SmiUntag nodes, instead of a generic operation binary node. Change-Id: Idb9ce2b60289fbe492bf269793660b32de23e2b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3560641Reviewed-by:
-
jameslahm authored
... when enable V8_COMPRESS_POINTERS_IN_ISOLATE_CAGE. When enable V8_COMPRESS_POINTERS_IN_ISOLATE_CAGE and V8_EXTERNAL_CODE_SPACE, because of the external code space, we could not get the isolate using RoundDown directly, which may cause wrong isolate address. We should use memory chunk like in V8_COMPRESS_POINTERS_IN_SHARED_CAGE instead. Bug: v8:12664, v8:12715 Change-Id: Ib78770fdb66fa509d6d8acc836803ec9d6804ef1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3532599Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: 王澳 <wangao.james@bytedance.com> Cr-Commit-Position: refs/heads/main@{#79774}
-
Clemens Backes authored
This includes two fixes: 1. For dynamic tiering, the budget must always be reduced when jumping backwards, otherwise we might never trigger tier up, which makes the loop non-interruptible (because the tier-up check replaces the stack check). 2. The d8 worker implementation also needs to terminate the isolate via an interrupt, in addition to scheduling a task, because the worker might never return to the event queue. This CL also fixes one of the failure modes of the inspector fuzzer (see https://crbug.com/1180018). R=jkummerow@chromium.org, marja@chromium.org Bug: v8:12767, chromium:1180018 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng Change-Id: Ia01d1725fc14931d2ea54c4769c4ee93f866ed63 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3568470Reviewed-by:
-
Leszek Swirski authored
Remove cctest's ability to run multiple tests (which has long been deprecated and mostly broken). We can then make platform & V8 initialisation be part of running the test's Run method. In particular, this allows us to inject custom logic into the platform initialisation, like setting up a platform wrapper. Add a TEST_WITH_PLATFORM which exercises this by registering a platform factory on the test, and wrapping the default platform using this factory. This allows these tests to guarantee that the lifetime of the platform is longer than the lifetime of the isolate. As a result of this, we can also remove the complexity around draining platform state in the TestPlatform (since it will now have a longer lifetime than the Isolate using it), and as a drive-by clean up the TestPlaform to use a CcTest-global "default platform" instead of trying to scope over the "current" platform. As another drive-by, change the linked-list of CcTests and the linear search through it into an std::map of tests. Change-Id: I610f6312fe042f29f45cc4dfba311e4184bc7759 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3569223Reviewed-by:
-
Camillo Bruni authored
Bug: v8:11263 Change-Id: I6f9f43125e5a1b27d8f8595bbbebdff2665968da Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3471635Reviewed-by:
-
Shu-yu Guo authored
Bug: v8:12007, v8:12584 Change-Id: Ic78eb0e7145c7d6127d23e46a6ddccfbd31fffd4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3419796 Auto-Submit: Shu-yu Guo <syg@chromium.org> Reviewed-by:
-
Alexander Schulze authored
Bug: v8:12581 Change-Id: Iea05e0171ad6edbda569c443c0db97e5c0bfc9ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3569222Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Alexander Schulze <alexschulze@chromium.org> Cr-Commit-Position: refs/heads/main@{#79769}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/d162691..1356876 Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/e9c9bdf..1850510 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/a9d86a4..c4e6210 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/a9c548e..c4b1b77 Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/d1aa7af..3b1df9d Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/c8e9f23..fbe0742 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Ia2bed4e4a7ea13cd708471339269c7e4262abb9b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571201 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#79768}
-
- 04 Apr, 2022 18 commits
-
-
Junliang Yan authored
Change-Id: Iadf5d379e105232c0992e3588ecd9a1c5f3500d2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3570422Reviewed-by:
Milad Farazmand <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#79767}
-
Anton Bikineev authored
The CL makes sure to extract and copy Oilpan young GC metrics to v8::metrics::GarbageCollectionYoungCycle. In addition, it makes sure that metrics are not reported twice by bailing out from GCTracer::NotifyCppGCCompleted() for young GC cycles (the metrics are reported later in Heap::CollectGarbage() by calling GCTracer::StopCycle()). Bug: chromium:1029379 Change-Id: I07bf51e85a76a7cdbeeb8d87c9072edf2634158b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3545168Reviewed-by:
-
Junliang Yan authored
Change-Id: I0b69c8042f1b88efc14d2923c595b14f45b9557e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3568471Reviewed-by:
-
Junliang Yan authored
Change-Id: I698fbf3d49ed7e88a6004ead38427e4ca3a02663 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3569681Reviewed-by:
-
Bryant Chandler authored
cr_fuchsia_package is deprecated in favor of using the Fuchsia SDK provided rules directly. Bug: chromium:1092804 Change-Id: I86a59b6a717cb0aa8c3473e8410bdd98f0ffd042 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3537883Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Bryant Chandler <bryantchandler@chromium.org> Cr-Commit-Position: refs/heads/main@{#79763}
-
Jakob Gruber authored
.. to simplify logic within compiler.cc. GetOrCompileOptimized now only returns Code object if the requested optimized Code object is available. This change also required updating CompileLazy to install the appropriate Code object before potentially calling CompileOptimized_* runtime functions in order to satisfy the is_compiled precondition. Bug: v8:12161 Change-Id: I991dbcc0ba8f3d635aa1e1f06e4cffd89e08a47b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3562978Reviewed-by:
-
Jakob Gruber authored
If we've already cached OSR'd code for the current function but with a different osr offset, fall back to synchronous compilation. This avoids degenerate cases where we repeatedly spawn OSR jobs but then fail to install them. Drive-by: More consistent --trace-osr output. Drive-by: Rename kCompileForOnStackReplacement to kCompileOptimizeOSR for name consistency. Drive-by: Add JSFunction::DebugNameCStr() for more convenient PrintF's. Bug: v8:12161 Change-Id: I2b4a65bc9e082d85d7048a3e92ef86b07d396687 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3560431Reviewed-by:
-
Bryant Chandler authored
cr_fuchsia_package is deprecated in favor of using the Fuchsia SDK provided rules directly. This CL adds a cmx file specifically for v8_unittests. CMX files define fuchsia components, see https://chromium-review.googlesource.com/c/chromium/src/+/3529652 for more info. Bug: chromium:1092804 Change-Id: Ibf1d866ec6b94a0e1a7a7c7c443a6ee80e3b1042 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3537885Reviewed-by:
-
Jakob Gruber authored
Tweak a few names, remove a few GetIsolate calls, other minor usability refactors. It may be worth taking a closer look at the impl in the future, currently the design choices don't seem ideal (see the added TODO on top of the class). The reland is unchanged from the original CL. Bug: v8:12161 Change-Id: I9971f7f2fb08b7a1ec2d57b2a0e4accdc11191ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3568444Reviewed-by:
-
Clemens Backes authored
If the immediate is a 32-bit value, we can just write the lower half of the target register, the upper half will automatically be zero-extended. R=tebbi@chromium.org Bug: v8:10005 Change-Id: Ib3c54c9f6ac2434c7345c507529298233d6b7d6f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3563565Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#79758}
-
Leszek Swirski authored
Port the eager deopt handling in the use marker and register allocator to do the same thing with lazy deopts. This requires moving the lazy deopt info to be a pseudo-input before the node, same as eager deopt info, so that the regalloc can read it without needing the Node's opcode. For now, this means that a node cannot both eager- and lazy-deopt; if we need this in the future we can rethink it. Bug: v8:7700 Change-Id: I96292af9c483f285b1e45bfb374c8dc600fa6347 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3568452Reviewed-by:
-
Joyee Cheung authored
Since the code is generated unconditionally, using a DCHECK to check that shared RO heap is enabled breaks builds with v8_enable_shared_ro_heap set to false, this patch turns that into a CSA_DCHECK so it only crashes when V8 actually attempts to store into a shared struct while the RO heap isn't shared at run time. Refs: https://github.com/nodejs/node/pull/42115 Bug: v8:12547 Change-Id: I30d9a02b98a0b647097125c0a9d141e40d6348cc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3561598Reviewed-by:
Shu-yu Guo <syg@chromium.org> Reviewed-by:
-
Dominik Inführ authored
Fail immediately when page allocation fails during deserialization. We would crash immediately in the GC following the allocation failure but with a less descriptive error message. Bug: v8:12514 Change-Id: I688d9bac5978ca7af3b24830999c992e1df32dce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3568458Reviewed-by:
-
Camillo Bruni authored
- Add references from CodeLogEntry to DeoptLogEntry - Add simple basic blocks in the disassembly code view Bug: v8:10644 Change-Id: I15f3b56751d515b902185b08f9454be3951ffa48 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3540142Reviewed-by:
-
Junliang Yan authored
Change-Id: Id3c0c09ca0c0e3b95ec51a8563d092c8410d3bc5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3568925Reviewed-by:
-
Jakob Gruber authored
- Unhandlify OSROptimizedCodeCache::GetOptimizedCode. - Unstatic-fy FeedbackVector::SetOptimizedCode. - Remove frame-walking logic during the OSR tierup decision. The reland is unchanged from the original CL. Bug: v8:12161 Change-Id: Ibf03a9dd9a6fcd38c0664e5d5014a26d0240e035 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3568463Reviewed-by:
-
Michael Achenbach authored
No-Try: true Bug: chromium:1245634 Change-Id: I1fca09f9e4917e9bb43ccc86a13220d1c13a3434 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3569024 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Liviu Rau <liviurau@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/main@{#79751}
-
Camillo Bruni authored
- Process the minidump in a separate function to avoid keeping references to the mmapped file during disposal - Clear all MinidumpReader variables before disposing the mmapped file Change-Id: I0ce468597329d6f7d703a08309e4be378d9c27cf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3568469Reviewed-by:
-
