- 18 Oct, 2018 1 commit
-
-
Michael Achenbach authored
This reverts commit fad1c1c9. Reason for revert: Debug printing not needed anymore. Original change's description: > [test] Be more chatty when killing hanging tests > > Bug: v8:8292 > Change-Id: I74fd304692e90adfb694b73ecf5e7858e3b66607 > Reviewed-on: https://chromium-review.googlesource.com/c/1275814 > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> > Reviewed-by: Maya Lekova <mslekova@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56562} TBR=machenbach@chromium.org,sergiyb@chromium.org,mslekova@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:8292 Change-Id: Ieaba51f866b93d49fe168b6370bd126752993afb Reviewed-on: https://chromium-review.googlesource.com/c/1288632Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#56774}
-
- 11 Oct, 2018 1 commit
-
-
Michael Achenbach authored
Bug: v8:8292 Change-Id: I74fd304692e90adfb694b73ecf5e7858e3b66607 Reviewed-on: https://chromium-review.googlesource.com/c/1275814Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#56562}
-
- 07 Sep, 2018 1 commit
-
-
Michael Achenbach authored
The cctest and unittests suites call the test executable to list the tests, which requires pushing the executables to the device on Android. NOTRY=true TBR=sergiyb@chromium.org Bug: chromium:866862 Change-Id: I318dff7af2b2de3b8642ec4b6ba30b602da808bb Reviewed-on: https://chromium-review.googlesource.com/1213202Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#55723}
-
- 10 Aug, 2018 6 commits
-
-
Michael Achenbach authored
This is a reland of 18c90f48 Original change's description: > [test] Pass suite environment to Android test runner > > TBR=sergiyb@chromium.org > > Bug: v8:8046 > Change-Id: I201f7a7ee119628e14c864602a2d3cbadfc4052b > Reviewed-on: https://chromium-review.googlesource.com/1170779 > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55051} NOTRY=true Bug: v8:8046 Change-Id: I73923a2ae532bb7d773c87fd77844b4e655b568c Reviewed-on: https://chromium-review.googlesource.com/1171382 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#55064}
-
Michael Achenbach authored
This is a reland of 4c094342 Original change's description: > [test] Add logic to run tests on Android > > This adds a new command abstraction for running commands on Android > using dockered devices on swarming. > > The new abstraction handles pushing all required files to the device. > The logic used for pushing and running is reused from the perf runner. > > This adds only the mjsunit test suite. Others will be handled in > follow up CLs. The suite logic is enhanced with auto-detection of files > to be pushed to devices, for e.g. load or import statements. > > Some test cases need an extra resource section for specifying required > files. > > Remaining failing tests are marked in the status files for later > triage. > > Bug: chromium:866862 > Change-Id: I2b957559f07fdcd8c1bd2f7034f5ba7754a31fb7 > Reviewed-on: https://chromium-review.googlesource.com/1150153 > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55041} Bug: chromium:866862 Change-Id: Icf7e04c75d4abeab7254d10ba21240e46b0022ae Reviewed-on: https://chromium-review.googlesource.com/1170643Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#55059}
-
Sergiy Byelozyorov authored
This reverts commit 4c094342. Reason for revert: Unfortunately this broke all perf builders. Original change's description: > [test] Add logic to run tests on Android > > This adds a new command abstraction for running commands on Android > using dockered devices on swarming. > > The new abstraction handles pushing all required files to the device. > The logic used for pushing and running is reused from the perf runner. > > This adds only the mjsunit test suite. Others will be handled in > follow up CLs. The suite logic is enhanced with auto-detection of files > to be pushed to devices, for e.g. load or import statements. > > Some test cases need an extra resource section for specifying required > files. > > Remaining failing tests are marked in the status files for later > triage. > > Bug: chromium:866862 > Change-Id: I2b957559f07fdcd8c1bd2f7034f5ba7754a31fb7 > Reviewed-on: https://chromium-review.googlesource.com/1150153 > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55041} TBR=machenbach@chromium.org,yangguo@chromium.org,sergiyb@chromium.org Change-Id: If80129810586b709dab762c9b5724888e15daec2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:866862 Reviewed-on: https://chromium-review.googlesource.com/1170962Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#55058}
-
Sergiy Byelozyorov authored
This reverts commit 18c90f48. Reason for revert: needs to be reverted prior to https://crrev.com/c/1170962 Original change's description: > [test] Pass suite environment to Android test runner > > TBR=sergiyb@chromium.org > > Bug: v8:8046 > Change-Id: I201f7a7ee119628e14c864602a2d3cbadfc4052b > Reviewed-on: https://chromium-review.googlesource.com/1170779 > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55051} TBR=machenbach@chromium.org,sergiyb@chromium.org Change-Id: I2c874305251b8b73f3bc0aaaf31a81ef30d6c15d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8046 Reviewed-on: https://chromium-review.googlesource.com/1171002Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#55056}
-
Michael Achenbach authored
TBR=sergiyb@chromium.org Bug: v8:8046 Change-Id: I201f7a7ee119628e14c864602a2d3cbadfc4052b Reviewed-on: https://chromium-review.googlesource.com/1170779Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#55051}
-
Michael Achenbach authored
This adds a new command abstraction for running commands on Android using dockered devices on swarming. The new abstraction handles pushing all required files to the device. The logic used for pushing and running is reused from the perf runner. This adds only the mjsunit test suite. Others will be handled in follow up CLs. The suite logic is enhanced with auto-detection of files to be pushed to devices, for e.g. load or import statements. Some test cases need an extra resource section for specifying required files. Remaining failing tests are marked in the status files for later triage. Bug: chromium:866862 Change-Id: I2b957559f07fdcd8c1bd2f7034f5ba7754a31fb7 Reviewed-on: https://chromium-review.googlesource.com/1150153Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#55041}
-
- 20 Feb, 2018 1 commit
-
-
Michael Achenbach authored
This is a partial revert of: https://crrev.com/c/890938 and https://crrev.com/c/893982 Before this CL, the test runner blocked on ongoing tests in order to process their results after an internal timeout. However, the logic required for this feature was overly complicated and prevented an acceptable implementation for fast aborts. Furthermore, also the fuzzers suffered from timeouts on swarming due to hanging tests. Instead, we now abort immediately on internal timeout (used on fuzzers), SIGINT (Ctrl-C) and SIGTERM. Ongoing tests are immediately terminated and their results are disregarded. On SIGTERM and SIGINT, we return with non-zero exit codes, and zero on internal timeout. This will also properly return json output, when the external hard timeout is reached on swarming (causes SIGTERM). TBR=sergiyb@chromium.org Bug: v8:7423, chromium:813065 Change-Id: Ib20f835f58a0970693bdd3b21dc5d766d8e115d8 Reviewed-on: https://chromium-review.googlesource.com/924852Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#51399}
-
- 03 Jan, 2018 1 commit
-
-
Michael Achenbach authored
This seperates OS-specific code of the Command class into a Posix and a WindowsCommand to simplify scattered OS checks. This also removes some temporary mac debug output that's obsolete after https://crbug.com/v8/6927 got resolved. TBR=sergiyb@chromium.org Bug: v8:6917 Change-Id: Iaab3b527ce556dfba797a164ae58e8dd358eb56f Reviewed-on: https://chromium-review.googlesource.com/847000Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#50346}
-
- 15 Dec, 2017 1 commit
-
-
Michal Majewski authored
Bug: v8:6917 Change-Id: Ifc3dac7a82fa67dda1f8b166fbd3f76a123ffba2 Reviewed-on: https://chromium-review.googlesource.com/824365 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#50122}
-
- 04 Dec, 2017 1 commit
-
-
Michal Majewski authored
This is a reland of 3b065110 Original change's description: > Reland "[test] Creating command before execution phase." > > This is a reland of 98cc9e86 > Original change's description: > > [test] Creating command before execution phase. > > > > Immutable command class with shell, flags and > > environment. > > > > Command creation moved from worker to the main > > process. Because of that there is no need to send > > test cases beyond process boundaries and load test > > suites in worker processes. > > > > Bug: v8:6917 > > Change-Id: Ib6a44278095b4f7141eb9b96802fe3e8117678a6 > > Reviewed-on: https://chromium-review.googlesource.com/791710 > > Commit-Queue: Michał Majewski <majeski@google.com> > > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#49746} > > Bug: v8:6917 > Change-Id: I49c29a8db813c47909f2cc45070ac7721a447c7a > Reviewed-on: https://chromium-review.googlesource.com/800370 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Michał Majewski <majeski@google.com> > Cr-Commit-Position: refs/heads/master@{#49756} Bug: v8:6917 Change-Id: Ia39010a0a0f63537ad12490dfab17897d70d4930 Reviewed-on: https://chromium-review.googlesource.com/806034Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michał Majewski <majeski@google.com> Cr-Commit-Position: refs/heads/master@{#49830}
-
- 01 Dec, 2017 1 commit
-
-
Michael Achenbach authored
This reverts commit 3b065110. Reason for revert: Broke fuzzers: https://build.chromium.org/p/client.v8.clusterfuzz/builders/V8%20Deopt%20Fuzzer/builds/384 Original change's description: > Reland "[test] Creating command before execution phase." > > This is a reland of 98cc9e86 > Original change's description: > > [test] Creating command before execution phase. > > > > Immutable command class with shell, flags and > > environment. > > > > Command creation moved from worker to the main > > process. Because of that there is no need to send > > test cases beyond process boundaries and load test > > suites in worker processes. > > > > Bug: v8:6917 > > Change-Id: Ib6a44278095b4f7141eb9b96802fe3e8117678a6 > > Reviewed-on: https://chromium-review.googlesource.com/791710 > > Commit-Queue: Michał Majewski <majeski@google.com> > > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#49746} > > Bug: v8:6917 > Change-Id: I49c29a8db813c47909f2cc45070ac7721a447c7a > Reviewed-on: https://chromium-review.googlesource.com/800370 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Michał Majewski <majeski@google.com> > Cr-Commit-Position: refs/heads/master@{#49756} TBR=machenbach@chromium.org,sergiyb@chromium.org,majeski@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:6917 Change-Id: I4938642c4396366be1e13daf6998c4b8538b688b Reviewed-on: https://chromium-review.googlesource.com/804254Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#49805}
-
- 30 Nov, 2017 3 commits
-
-
Michal Majewski authored
This is a reland of 98cc9e86 Original change's description: > [test] Creating command before execution phase. > > Immutable command class with shell, flags and > environment. > > Command creation moved from worker to the main > process. Because of that there is no need to send > test cases beyond process boundaries and load test > suites in worker processes. > > Bug: v8:6917 > Change-Id: Ib6a44278095b4f7141eb9b96802fe3e8117678a6 > Reviewed-on: https://chromium-review.googlesource.com/791710 > Commit-Queue: Michał Majewski <majeski@google.com> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49746} Bug: v8:6917 Change-Id: I49c29a8db813c47909f2cc45070ac7721a447c7a Reviewed-on: https://chromium-review.googlesource.com/800370Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michał Majewski <majeski@google.com> Cr-Commit-Position: refs/heads/master@{#49756}
-
Michael Achenbach authored
This reverts commit 98cc9e86. Reason for revert: Breaks test isolation: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20builder/builds/29746 Original change's description: > [test] Creating command before execution phase. > > Immutable command class with shell, flags and > environment. > > Command creation moved from worker to the main > process. Because of that there is no need to send > test cases beyond process boundaries and load test > suites in worker processes. > > Bug: v8:6917 > Change-Id: Ib6a44278095b4f7141eb9b96802fe3e8117678a6 > Reviewed-on: https://chromium-review.googlesource.com/791710 > Commit-Queue: Michał Majewski <majeski@google.com> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49746} TBR=machenbach@chromium.org,sergiyb@chromium.org,majeski@google.com Change-Id: I44b99468d18fd093833f4185dad067a9eeaf2bc1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6917 Reviewed-on: https://chromium-review.googlesource.com/800292Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#49747}
-
Michal Majewski authored
Immutable command class with shell, flags and environment. Command creation moved from worker to the main process. Because of that there is no need to send test cases beyond process boundaries and load test suites in worker processes. Bug: v8:6917 Change-Id: Ib6a44278095b4f7141eb9b96802fe3e8117678a6 Reviewed-on: https://chromium-review.googlesource.com/791710 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#49746}
-