- 11 Feb, 2020 2 commits
-
-
Jakob Gruber authored
This reverts commit c0fbfcd8. Reason for revert: Fix found. Original change's description: > Revert [gasm] Implement ReduceArrayPrototypeReduce using the graph assembler > > Reverting due to a nondeterministic correctness issue bisected to this > change. The intent is to reland once we fully understand and have > fixed the problem. > > The original CL landed in https://crrev.com/c/1934329. > The revert on master is https://crrev.com/c/2049763. > The revert on 8.0 is https://crrev.com/c/2049764. > > Bug: v8:9972,chromium:1049982 > Change-Id: I171624bdeb18831e70869ae806c73529c240be4a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2049763 > Reviewed-by: Georg Neis <neis@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#66215} TBR=neis@chromium.org,jgruber@chromium.org Change-Id: Id12a01dc72558639b26af58ff56cd0b11916eec2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9972, chromium:1049982 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2050395Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#66222}
-
Jakob Gruber authored
Reverting due to a nondeterministic correctness issue bisected to this change. The intent is to reland once we fully understand and have fixed the problem. The original CL landed in https://crrev.com/c/1934329. The revert on master is https://crrev.com/c/2049763. The revert on 8.0 is https://crrev.com/c/2049764. Bug: v8:9972,chromium:1049982 Change-Id: I171624bdeb18831e70869ae806c73529c240be4a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2049763Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#66215}
-
- 22 Jan, 2020 1 commit
-
-
Georg Neis authored
... and consult it there from the various reducers. The flag makes no sense without the broker and the reducers already have access to the broker, so we can avoid an additional flag per reducer. Bug: v8:7790 Change-Id: I448050a55951b94d5313c1a79a502be906b98b25 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2013108 Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#65918}
-
- 21 Jan, 2020 1 commit
-
-
Jakob Gruber authored
The most interesting part of this change is that try-catch patterns are now supported by graph assembler through TryCatchBuilder0. Bug: v8:9972 Change-Id: I6ef0d51d4a1973eb8a30a5072c630261860f0a05 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1986000 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#65874}
-
- 09 Jan, 2020 1 commit
-
-
Maya Lekova authored
Bug: v8:7790 Change-Id: Idf066adcd5c3dca3004e2eaa0d8fa389755720af Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991490Reviewed-by: Michael Stanton <mvstanton@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#65671}
-
- 30 Dec, 2019 1 commit
-
-
Jakob Gruber authored
Bug: v8:9972 Change-Id: Ieed4ba6648a20a9b372888d75e8eb7617acdf562 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1981490 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#65566}
-
- 25 Dec, 2019 1 commit
-
-
Jakob Gruber authored
Bug: v8:9972 Change-Id: I94a6a1a520de9da76a5de7bdcc19bd1b71b303cd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1973736 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#65555}
-
- 18 Dec, 2019 1 commit
-
-
Jakob Gruber authored
Bug: v8:9972 Change-Id: Ic1d18586c92536575c9bf4e7b3d2758b44acab30 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1954389 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#65489}
-
- 28 Nov, 2019 1 commit
-
-
Jakob Gruber authored
Very similar to the recent ArrayPrototypeForEach port, this moves the Reduce reduction, which previously operated directly on the graph, to graph assembler. Nothing too interesting here, but it's becoming clearer that we will need more flexible Branch (multiple merge values) and If (a `break` mechanism) handling in the future. Bug: v8:9972 Change-Id: Ic48c85305ba721a9a43c67f7ad13c60da310487e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1934329 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#65233}
-
- 27 Nov, 2019 1 commit
-
-
Jakob Gruber authored
After landing a few relatively simple ports in preceding work, this CL ports the more involved Array.prototype.forEach reduction, containing checkpoints, JS and runtime calls, loops, and exceptions. With the mechanisms introduced in this change, I'd expect a large chunk of js-call reductions to be trivially portable. Newly introduced: - IfBuilder0 for if-then-else statements (with optional else). - ForBuilder for for-loop statements. - MayThrow() for exceptional control flow. Exceptional edges are automatically merged and wired into the outer graph if necessary. Bug: v8:9972 Change-Id: I835bf90c5871fbd94a1d12721d44b500fbef75e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1921798Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#65193}
-
- 21 Nov, 2019 1 commit
-
-
Jakob Gruber authored
An initial investigation of using GraphAssembler in JSCallReducer. This CL ports two simple reductions (ReduceMathUnary, ReduceMathBinary) as well as a slightly more involved reduction with branching control flow (ReduceStringPrototypeSubstring). The graph assembler abstracts away the details of maintaining effect and control edges. Resulting code ends up looking very similar to CSA. Newly introduced: - Typing through TNode. - IfBuilder1 for nicer if-then-else sequences that return exactly 1 value. Future CLs will add more convenience builders that follow this pattern. - Many small readability improvements through helper functions. Bug: v8:9972 Change-Id: Iaa186b76c006e07c8d69a74f340a4912577a32a5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1914204 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#65095}
-
- 04 Nov, 2019 1 commit
-
-
Nico Hartmann authored
Changing the target of JSCall nodes (e.g. while lowering higher order calls) now preserves feedback and speculation mode to allow further (speculative) optimizations. A flag is introduced to mark feedback unrelated to the call target after such a transformation. This flag is used to prevent access to the feedback without the need to invalidate it. Bug: v8:9702 Change-Id: I311d3a4b1b22d6f65e5837a23b0b7585c8d75eed Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1844788 Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#64733}
-
- 26 Aug, 2019 1 commit
-
-
Maya Lekova authored
This is a reland of 8ff8ddba Original change's description: > [turbofan] Further brokerize BytecodeGraphBuilder > > Replace all usages of VectorSlotPair with FeedbackSource. > > Bug: v8:7790 > Change-Id: I0ac6e9cd8f5730154cc1842e267ca1ebfdebc874 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1763536 > Commit-Queue: Maya Lekova <mslekova@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63378} Bug: v8:7790 Change-Id: I54fbf4433a65681780fda4ded09ec2d145d36ec1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1768361Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#63391}
-
- 23 Aug, 2019 2 commits
-
-
Bill Budge authored
This reverts commit 8ff8ddba. Reason for revert: Causes failures on GC Stress and TSan: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20gc%20stress/24138 https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN/27969 Original change's description: > [turbofan] Further brokerize BytecodeGraphBuilder > > Replace all usages of VectorSlotPair with FeedbackSource. > > Bug: v8:7790 > Change-Id: I0ac6e9cd8f5730154cc1842e267ca1ebfdebc874 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1763536 > Commit-Queue: Maya Lekova <mslekova@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63378} TBR=neis@chromium.org,mslekova@chromium.org Change-Id: Ieb6fb24dd0626fd9eb2183844614ac5b3c8084e8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7790 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1769287Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#63387}
-
Maya Lekova authored
Replace all usages of VectorSlotPair with FeedbackSource. Bug: v8:7790 Change-Id: I0ac6e9cd8f5730154cc1842e267ca1ebfdebc874 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1763536 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#63378}
-
- 05 Aug, 2019 1 commit
-
-
Joshua Litt authored
When a fast path was added for Math.hypot, the algorithm was also simplified. This simplification turns out to be incorrect in some rare edge cases. This cl reverts back to the original algorithm and converts it to torque. Original cl: https://chromium-review.googlesource.com/c/v8/v8/+/1684178 Bug: v8:9546 Change-Id: If4e21504732f46081a8de823f50f499917f1a20c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1725200 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#63070}
-
- 05 Jul, 2019 1 commit
-
-
Maya Lekova authored
Got rid of the following circular header dependency chains: compilation-dependencies <-> js-heap-broker <-> access-info types <-> js-heap-broker <-> access-info Extracted former CompilationDependencies::Dependency class into its own header. Extracted *Ref classes into their own header. This should enable building on older GCC versions, e.g. 5.4.0. Bug: v8:9440 Change-Id: Ia345bc227d8f7806d0b8622b706346a7ce6d01ea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1687415 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#62541}
-
- 02 Jul, 2019 2 commits
-
-
Nico Hartmann authored
Operations on BigInts, for which TurboFan statically knows that they are no larger than 2^64, can be lowered to efficient machine code in TurboFan. This is the first step in doing so by generating efficient code for asUintN and the required checks and conversions. Bug: v8:9407 Change-Id: I51f6505f6c4567434fa369fcf870a09871487f51 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1680548 Commit-Queue: Nico Hartmann <nicohartmann@google.com> Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#62488}
-
Benedikt Meurer authored
This adds a fast-path to inline `Math.hypot(v1,...,vn)` into optimized code assuming that v1,...,vn are already numbers. The inlining follows the general C++ implementation (which was also simplified a bit), and thus uses Kahan summation to avoid rounding errors. This improves the benchmark in [1] from around testHypot: 656 ms. testSqrt: 105 ms. testExp: 103 ms. to testHypot: 147 ms. testSqrt: 103 ms. testExp: 102 ms. so its roughly a **4.5x improvement**. [1] https://github.com/bmeurer/js-micro-benchmarks/blob/60a34c0dd29b77e6950555c2dd9687b1a0a7671e/bench-math-hypot.js Bug: chromium:979893 Change-Id: Id834d5613bc22aa7ce27b9d6eca1f1f1979aa3e7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1684178 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#62483}
-
- 19 Jun, 2019 1 commit
-
-
Mike Stanton authored
CL https://chromium-review.googlesource.com/c/v8/v8/+/1660623 ("[Turbofan] Brokerize more promise reductions in JSCallReducer") introduced a bug where we bail out of a call reduction but failed to remove graph constructs added by the MapInference class. R=jarin@chromium.org Bug: chromium:976256, chromium:976524 Change-Id: I97f142fe6c1caba5e679f7df742893536c83b2d8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1666990Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#62267}
-
- 18 Jun, 2019 1 commit
-
-
Mike Stanton authored
This CL is an improvement on https://chromium-review.googlesource.com/c/v8/v8/+/1664052 which introduced unnecessary boilerplate (now reverted). The code objects for resolve/reject handlers are builtins, and therefore already serialized. R=jarin@chromium.org Bug: v8:7790 Change-Id: I6a49110aa794d4bd380cabd40e67fba7783e642a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1664055 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#62236}
-
- 17 Jun, 2019 1 commit
-
-
Mike Stanton authored
The functions * JSCallReducer::ReducePromisePrototypeThen * JSCallReducer::ReducePromisePrototypeFinally * JSCallReducer::ReducePromisePrototypeCatch need the prototype for all receiver maps to be serialized in order to take effect. We can do this by processing our receiver hints when processing a builtin call in the serializer. Bug: v8:7790 Change-Id: I3d9144924cf6926cfcd93b60ac703cfba2d3d93a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660623 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#62208}
-
- 31 May, 2019 1 commit
-
-
Mythri A authored
Array push / pop / shift were inlined if the elements kind of the receiver maps is the same. This cl extends it by inlining these builtins even when the receiver maps have different elements kinds. It still limits it to only fast elements kinds. This is required to prevent regressions in deltablue when lazy feedback allocation is enabled. With lazy feedback allocation we may see polymorphic feedback more often, since we don't have allocation site feedback till the feedback vectors are allocated. Bug: v8:9078 Change-Id: Id4a7b84be6305b125913b6ce0fb4f3eb3e3b15ec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1632239 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#61949}
-
- 20 May, 2019 4 commits
-
-
Yang Guo authored
This reverts commit a7695520. Reason for revert: Was not the culprit. Original change's description: > Revert "Move deoptimizer files" > > This reverts commit 61523c45. > > Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Win32%20-%20debug/20396 > > Original change's description: > > Move deoptimizer files > > > > Bug: v8:9247 > > Change-Id: I6287907edb8a36225bfa9fe864305ea59c20dd8b > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617667 > > Commit-Queue: Yang Guo <yangguo@chromium.org> > > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#61648} > > TBR=yangguo@chromium.org,mstarzinger@chromium.org,jarin@chromium.org,bmeurer@chromium.org > > Change-Id: Icf258f7bc409ef0c360cfa82029bfc45a41dc75f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: v8:9247 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1619749 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61650} TBR=yangguo@chromium.org,mstarzinger@chromium.org,jarin@chromium.org,bmeurer@chromium.org Change-Id: Ic2aa07ccd08b6070222ec7a65b92b7afb9db484c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9247 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1619753Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#61652}
-
Yang Guo authored
This reverts commit 61523c45. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Win32%20-%20debug/20396 Original change's description: > Move deoptimizer files > > Bug: v8:9247 > Change-Id: I6287907edb8a36225bfa9fe864305ea59c20dd8b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617667 > Commit-Queue: Yang Guo <yangguo@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61648} TBR=yangguo@chromium.org,mstarzinger@chromium.org,jarin@chromium.org,bmeurer@chromium.org Change-Id: Icf258f7bc409ef0c360cfa82029bfc45a41dc75f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9247 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1619749Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#61650}
-
Yang Guo authored
Bug: v8:9247 Change-Id: I6287907edb8a36225bfa9fe864305ea59c20dd8b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617667 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#61648}
-
Ujjwal Sharma authored
This is a reland of e7e512da Original change's description: > [turbofan] Add fast path for single-character String#startsWith() > > This CL adds a fast path to String#startsWith(s) if s is a > single character string. > > Bug: v8:8400 > Change-Id: Ibd6a9d1e46d98f41c198d2b579208e25003eedb0 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1525362 > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61504} Bug: v8:8400 Change-Id: Ic2d60ccb8fdeb51373fcd025a7e970fda0c14d79 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1618342Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#61637}
-
- 16 May, 2019 1 commit
-
-
Ujjwal Sharma authored
This reverts commit e7e512da. Reason for revert: chromium:963687, chromium:963731 Original change's description: > [turbofan] Add fast path for single-character String#startsWith() > > This CL adds a fast path to String#startsWith(s) if s is a > single character string. > > Bug: v8:8400 > Change-Id: Ibd6a9d1e46d98f41c198d2b579208e25003eedb0 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1525362 > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61504} TBR=sigurds@chromium.org,bmeurer@chromium.org,usharma1998@gmail.com Change-Id: Ie09a96557102063ab15c3900563cf16ec57a47e3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8400 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1614605Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#61562}
-
- 15 May, 2019 1 commit
-
-
Ujjwal Sharma authored
This CL adds a fast path to String#startsWith(s) if s is a single character string. Bug: v8:8400 Change-Id: Ibd6a9d1e46d98f41c198d2b579208e25003eedb0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1525362Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#61504}
-
- 01 May, 2019 1 commit
-
-
Georg Neis authored
This is a reland of 9284ad57, after adding a missing speculation mode check in ReduceCallApiFunction. Original change's description: > [turbofan] Avoid raw InferReceiverMaps in JSCallReducer > > Instead provide an abstraction that makes it hard to forget > dealing with unreliable maps. > > This also fixes a deopt loop in Function.prototype.bind and > one in Array.prototype.reduce. > > Bug: v8:9137 > Change-Id: If6a51182c8693a62e9fb6d302cec19b4d48e25cb > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578501 > Commit-Queue: Georg Neis <neis@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61106} Tbr: jarin@chromium.org Bug: v8:9137, v8:9197 Change-Id: I0db68d267055969553c0c1b85fad7b909075c062 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1589976 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#61140}
-
- 30 Apr, 2019 2 commits
-
-
Sigurd Schneider authored
This reverts commit 9284ad57. Reason for revert: breaks blink tests: https://ci.chromium.org/p/v8/builders/ci/V8-Blink%20Win/16839 Original change's description: > [turbofan] Avoid raw InferReceiverMaps in JSCallReducer > > Instead provide an abstraction that makes it hard to forget > dealing with unreliable maps. > > This also fixes a deopt loop in Function.prototype.bind and > one in Array.prototype.reduce. > > Bug: v8:9137 > Change-Id: If6a51182c8693a62e9fb6d302cec19b4d48e25cb > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578501 > Commit-Queue: Georg Neis <neis@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61106} TBR=jarin@chromium.org,neis@chromium.org Change-Id: I97e0f47fb82eda76656905a3f7cc494babd92be6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9137 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588433Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#61118}
-
Georg Neis authored
Instead provide an abstraction that makes it hard to forget dealing with unreliable maps. This also fixes a deopt loop in Function.prototype.bind and one in Array.prototype.reduce. Bug: v8:9137 Change-Id: If6a51182c8693a62e9fb6d302cec19b4d48e25cb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578501 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#61106}
-
- 29 Mar, 2019 1 commit
-
-
Clemens Hammacher authored
Even though both are allowed in the style guide, it recommends to use 'using', as its syntax is more consistent with the rest of C++. This CL turns all typedefs in compiler code to 'using' declarations. R=mstarzinger@chromium.org Bug: v8:8834 Change-Id: I3baf3ecbfe2c853cb17bb479ebbf140382193b5c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545896 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#60527}
-
- 26 Mar, 2019 1 commit
-
-
Georg Neis authored
... in the case of unreliable receiver maps in JSCallReducer. Change-Id: I68aea1f74fe98f3ac9bc7251f1af789f2cf9bc56 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1532332Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#60458}
-
- 18 Mar, 2019 1 commit
-
-
Sigurd Schneider authored
This reverts commit acadb202. Reason for revert: chromium:941952 Original change's description: > [turbofan] add fast path for String.p.startsWith > > Add a fast path for String.p.startsWith(str) when length of str is 1. > > Bug: v8:8400 > Change-Id: I65e657549902dc3ad064a213d815dd098ce6455f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1491872 > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60091} TBR=sigurds@chromium.org,bmeurer@chromium.org,usharma1998@gmail.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:8400 Change-Id: Iabd66b8db0d6958686ea15a042d8567955700c9e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524205 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#60279}
-
- 07 Mar, 2019 1 commit
-
-
Ujjwal Sharma authored
Add a fast path for String.p.startsWith(str) when length of str is 1. Bug: v8:8400 Change-Id: I65e657549902dc3ad064a213d815dd098ce6455f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1491872 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#60091}
-
- 02 Nov, 2018 1 commit
-
-
Georg Neis authored
Bug: v8:7790 Change-Id: Ifbcfaa3ae0cc8bef119da52e66a2b9371d6ecf03 Reviewed-on: https://chromium-review.googlesource.com/c/1314548 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#57212}
-
- 23 Oct, 2018 1 commit
-
-
Benedikt Meurer authored
This builtin was initially used to create the promise for an async function, but that is now done by the AsyncFunctionEnter intrinsic. Bug: v8:7253 Change-Id: I90d0bb31c1548bbfdb53833a5c06161db368f4f0 Reviewed-on: https://chromium-review.googlesource.com/c/1296129Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#56878}
-
- 22 Oct, 2018 1 commit
-
-
Georg Neis authored
Bug: v8:7790 Change-Id: I1e168132f5d3c90e1a3ee5c13ebc6dbc11e9daa1 Reviewed-on: https://chromium-review.googlesource.com/c/1288250 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#56859}
-
- 17 Oct, 2018 1 commit
-
-
Jaroslav Sevcik authored
Bug: chromium:895799 Change-Id: Icbc06f1fc2362a04e76961f50a8ba4b29080837c Reviewed-on: https://chromium-review.googlesource.com/c/1286336Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#56720}
-