- 14 Jan, 2019 1 commit
-
-
Sigurd Schneider authored
Notry: true Bug: v8:7327 Change-Id: I2592d921905ad361f09ff6d99c0b0d64617543c4 Reviewed-on: https://chromium-review.googlesource.com/c/1407051 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58780}
-
- 07 Jan, 2019 3 commits
-
-
Sigurd Schneider authored
This improves readability and encapsulation of the code. Change-Id: Ifbca8441941a1776797937c973a064153818c859 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1396423 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58578}
-
Sigurd Schneider authored
This CL enables noImplicitReturns and noImplicitThis warnings in TypeScript, another step on the road to stricter types. Drive-by: Fix bug in search function. Change-Id: Iafb528b5f0e7ccc8774bc218fd0dcdb206a0de31 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1396422 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58576}
-
Sigurd Schneider authored
Refactor NodeLabel from GNode, which saves memory and is a step towards decoupling the node layout from the graph structure. Change-Id: I095a2f7a7ab28067161deffbc37952ae15410e0a Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1396418 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58571}
-
- 04 Jan, 2019 4 commits
-
-
Sigurd Schneider authored
This CL adds more TypeScript types and inserts some instanceof checks to ensure typing. The CL also selects es2018 as target and loads es6/es2018 libs for TypeScript types. This ensures that RegExp groups matching results are properly typed. Notry: true Bug: v8:7327 Change-Id: I1a59a1047188a49579c975149b336cc232c05eef Reviewed-on: https://chromium-review.googlesource.com/c/1396095Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58553}
-
Sigurd Schneider authored
...and fix all related issues. Change-Id: I3bd37ae038b9ea7c4305600958c1ae20e67e0f1f Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1396092Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58552}
-
Sigurd Schneider authored
This CL updates TypeScript, rollup and d3 to newer versions. Drive-bys: - Remove unused source file lang-disassembly. - Fix typing problem with FileReader callback The rollup version update also ensures that watch mode works again: npm run-script watch Change-Id: If852bc4287760017c185fbcb6dd9d2e36db36a04 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1396091 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58551}
-
Sigurd Schneider authored
This CL splits out a Graph class from the GraphView, which improves maintainability and is a first step towards preserving node positions during phase view changes. This CL also removes duplication of node storage on the graph and provides a generator function instead. The only storage for nodes in the graph is now the {nodeMap}. Bug: v8:7327 Notry: true Change-Id: I1659ecfe46f62a12d2fb3c40ccd6f4936f081b53 Reviewed-on: https://chromium-review.googlesource.com/c/1396087 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58549}
-
- 11 Jul, 2018 1 commit
-
-
Sigurd Schneider authored
Bug: v8:7327 Change-Id: If2670e2b8e64a34f5de7855615e2288b6f2f3133 Reviewed-on: https://chromium-review.googlesource.com/1131193 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#54371}
-
- 08 Jun, 2018 1 commit
-
-
Sigurd Schneider authored
This CL updates the d3.js library to version 5.4. The most notable change is that the library can now distinguish between click and drag events if an element supports both selection via click and displacement via drag. Curiously, npm created a 'package-lock.json', which is ~500 lines, and which is supposed to be checked into the repository according to documentation. Change-Id: Ifabd236296d951f390e0a1516d89e73138ce1713 Reviewed-on: https://chromium-review.googlesource.com/1076234Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#53604}
-
- 29 May, 2018 1 commit
-
-
Sigurd Schneider authored
Change-Id: I2be450c6498ce863d5e36acf02db643788e6c8bf Reviewed-on: https://chromium-review.googlesource.com/1068045 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#53400}
-