- 19 May, 2016 20 commits
-
-
rmcilroy authored
We cannot tier up from interpreted to baseline code when there is an activation of the function on the stack. This significantly regresses the performance of recursive functions since they are unlikely to get tiered up. This CL adds the ability for a function to be marked for baseline compilation when it returns. To do this we patch the InterpreterEntryTrampoline return address to point to InterpreterMarkBaselineOnReturn, which leaves the interpreted frame and recompile the function for baseline. This improves the score of EarlyBoyer by ~8x for Ignition. BUG=v8:4280 LOG=N Review-Url: https://codereview.chromium.org/1965343002 Cr-Commit-Position: refs/heads/master@{#36360}
-
jgruber authored
Script position calculation logic (i.e. line & column numbers for a given code position) is now based on a single method Script::GetPositionInfo(). Refactored related code in isolate.cc and js/messages.js to use the new method and removed the line_ends JS accessor. R=yangguo@chromium.org BUG= Review-Url: https://codereview.chromium.org/1986173002 Cr-Commit-Position: refs/heads/master@{#36359}
-
hpayer authored
BUG=chromium:613125 LOG=n Review-Url: https://codereview.chromium.org/1992193002 Cr-Commit-Position: refs/heads/master@{#36358}
-
ulan authored
This patch extracts typed slot processing logic from the PointerUpdatingVisitor to a set of functions. Each of these functions takes an untyped slot processing function and applies it to a typed slot. BUG=chromium:612847 LOG=NO Review-Url: https://codereview.chromium.org/1991843003 Cr-Commit-Position: refs/heads/master@{#36357}
-
machenbach authored
BUG=chromium:474921 LOG=n NOTRY=true Review-Url: https://codereview.chromium.org/1988163002 Cr-Commit-Position: refs/heads/master@{#36356}
-
danno authored
Review-Url: https://codereview.chromium.org/1995543003 Cr-Commit-Position: refs/heads/master@{#36355}
-
clemensh authored
R=titzer@chromium.org, yangguo@chromium.org Review-Url: https://codereview.chromium.org/1961453002 Cr-Commit-Position: refs/heads/master@{#36354}
-
machenbach authored
Revert of Adding ia32 simd assembler changes. (patchset #2 id:20001 of https://codereview.chromium.org/1991713002/ ) Reason for revert: Crashes on win32 debug: https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds/2305/steps/Check/logs/stdio Also, would be nice if the test output could be a bit shorter and only print what's necessary to trace a failure. Or split things into more smaller tests. Like that, these logs must be processed, json-encoded/decoded and sent around through the infrastructure. Some chars in the output make the json encoder unhappy, therefore the infrastructure can't nicely display the failures. Original issue's description: > Adding ia32 simd assembler support. > > Based on assembler changes from this patch: > https://codereview.chromium.org/90643003/ > > BUG=https://bugs.chromium.org/p/v8/issues/detail?id=4124 > R=titzer@chromium.org > LOG=N > > Committed: https://crrev.com/fbf58a5af1d07a7fbb3763aa15f8ba26e2ce7d11 > Cr-Commit-Position: refs/heads/master@{#36349} TBR=bbudge@chromium.org,titzer@chromium.org,gdeepti@chromium.org,aseemgarg@chromium.org,bradnelson@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=https://bugs.chromium.org/p/v8/issues/detail?id=4124 Review-Url: https://codereview.chromium.org/1992163002 Cr-Commit-Position: refs/heads/master@{#36353}
-
verwaest authored
1) avoid the builder 2) by precomputing the result we're guaranteed to have a flat string avoiding extra cost later of using the string BUG= Review-Url: https://codereview.chromium.org/1988023004 Cr-Commit-Position: refs/heads/master@{#36352}
-
danno authored
Review-Url: https://codereview.chromium.org/729913004 Cr-Commit-Position: refs/heads/master@{#36351}
-
yangguo authored
Code in V8 embeds memory addresses. Upon deserialization, those addresses will be updated anyways, so it's not important whether the serializer records those addresses. In order to have a deterministic build, we create a copy of the code and null out memory addresses and serialize this copy. For the code cache, we do not care about determinism. By avoiding the copy we can save some time spent on serialization. For the mandreel script in Octane, this reduces the serialization time from ~85ms to ~75ms. R=vogelheim@chromium.org Review-Url: https://codereview.chromium.org/1991033003 Cr-Commit-Position: refs/heads/master@{#36350}
-
bradnelson authored
Based on assembler changes from this patch: https://codereview.chromium.org/90643003/ BUG=https://bugs.chromium.org/p/v8/issues/detail?id=4124 R=titzer@chromium.org LOG=N Review-Url: https://codereview.chromium.org/1991713002 Cr-Commit-Position: refs/heads/master@{#36349}
-
clemensh authored
Empty function names are allowed and are output as such, unnamed functions or functions with no valid UTF-8 name are output as "<WASM UNNAMED>", while the CallSite object returns null as the function name. R=titzer@chromium.org, yangguo@chromium.org Review-Url: https://codereview.chromium.org/1970503004 Cr-Commit-Position: refs/heads/master@{#36348}
-
machenbach authored
Revert of Reland changes to v8_snapshot GN build arg. (patchset #2 id:20001 of https://codereview.chromium.org/1979883002/ ) Reason for revert: Blocks the roll again: https://codereview.chromium.org/1993163002/ https://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/140169 Lets add chromeos_amd64-generic_chromium_compile_only_ng on a reland as well. Original issue's description: > Reland changes to v8_snapshot GN build arg. > > This patch re-lands #36193 with a couple of minor tweaks > including updating the BUILD.gn file to use the new > variable name and incorporating thakis' request to support > cross-compiling the win snapshot from a mac. > > R=thakis@chromium.org, jochen@chromium.org, machenbach@chromium.org > BUG=608596, 595653 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:chromeos_daisy_chromium_compile_only_ng > > Committed: https://crrev.com/b6168e1223d266dba1a357a921bc84ae97a1d803 > Cr-Commit-Position: refs/heads/master@{#36342} TBR=jochen@chromium.org,thakis@chromium.org,stevenjb@chromium.org,adamk@chromium.org,dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=608596, 595653 Review-Url: https://codereview.chromium.org/1996533002 Cr-Commit-Position: refs/heads/master@{#36347}
-
littledan authored
The default value of the flag was true, so --intl_extra was not previously unshipped. This patch sets it to false. BUG=v8:3785 CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_noi18n_rel_ng Review-Url: https://codereview.chromium.org/1990763003 Cr-Commit-Position: refs/heads/master@{#36346}
-
zhengxing.li authored
port 5c22cf5a (r36341) original commit message: BUG= Review-Url: https://codereview.chromium.org/1990133002 Cr-Commit-Position: refs/heads/master@{#36345}
-
zhengxing.li authored
X87: [Interpreter] Remove InterpreterExitTrampoline and replace with returning to the entry trampoline. port 39738bc9 (r36310) original commit message: In order to support compiling to baseline on return we need to be able to return to the actual return address. With this change this is what the Return bytecode now does, removing the need for the InterpreterExitTrampoline. This change also removes the InterpreterNotifyDeoptXXX builtins and unifies FCG and Igntion to both use NotifyDeoptXXX. As part of this change, FullCodegenerator::State is moved to Deoptimize::BailoutState. BUG= Review-Url: https://codereview.chromium.org/1987053006 Cr-Commit-Position: refs/heads/master@{#36344}
-
v8-autoroll authored
Rolling v8/build to b2d15686436cdc17f67c3621c314f8d96b5b6fd9 Rolling v8/tools/clang to 996bab489f816e51dde704bd215fb3403919f07e TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/1992113002 Cr-Commit-Position: refs/heads/master@{#36343}
-
dpranke authored
This patch re-lands #36193 with a couple of minor tweaks including updating the BUILD.gn file to use the new variable name and incorporating thakis' request to support cross-compiling the win snapshot from a mac. R=thakis@chromium.org, jochen@chromium.org, machenbach@chromium.org BUG=608596, 595653 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:chromeos_daisy_chromium_compile_only_ng Review-Url: https://codereview.chromium.org/1979883002 Cr-Commit-Position: refs/heads/master@{#36342}
-
binji authored
Review-Url: https://codereview.chromium.org/1986113004 Cr-Commit-Position: refs/heads/master@{#36341}
-
- 18 May, 2016 20 commits
-
-
gsathya authored
Instead of directly looking up Uint8Array.__proto__, to get a hold of the TypedArray prototype, use object_get_prototype_of. This is a functionally equivalent, but cleaner approach. Review-Url: https://codereview.chromium.org/1990983002 Cr-Commit-Position: refs/heads/master@{#36340}
-
caitpotter88 authored
Prevent crash/UB during stack frame iteration through functions, which occurs when debugging, when building stacktraces, etc. Also prevents these functions from appearing in stacktraces, by unsetting the "native" flag. BUG=v8:4483, v8:5025 R=yangguo@chromium.org, littledan@chromium.org, adamk@chromium.org Review-Url: https://codereview.chromium.org/1990803005 Cr-Commit-Position: refs/heads/master@{#36339}
-
bryleun authored
R=joransiu@ca.ibm.com,michael_dawson@ca.ibm.com,mbrandy@us.ibm.com,jyan@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/1992703004 Cr-Commit-Position: refs/heads/master@{#36338}
-
ulan authored
BUG=chromium:612847 LOG=N Review-Url: https://codereview.chromium.org/1989973002 Cr-Commit-Position: refs/heads/master@{#36337}
-
jyan authored
PPC/S390: [Interpreter] Remove InterpreterExitTrampoline and replace with returning to the entry trampoline. port 39738bc9 Original Commit Message: In order to support compiling to baseline on return we need to be able to return to the actual return address. With this change this is what the Return bytecode now does, removing the need for the InterpreterExitTrampoline. This change also removes the InterpreterNotifyDeoptXXX builtins and unifies FCG and Igntion to both use NotifyDeoptXXX. As part of this change, FullCodegenerator::State is moved to Deoptimize::BailoutState. R=rmcilroy@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:4280 LOG=N Review-Url: https://codereview.chromium.org/1989983002 Cr-Commit-Position: refs/heads/master@{#36336}
-
machenbach authored
Revert of [heap] Do not invoke GC to make heap iterable. (patchset #5 id:80001 of https://codereview.chromium.org/1961373003/ ) Reason for revert: Breaks https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/3551 Original issue's description: > [heap] Do not invoke GC to make heap iterable. > > Remove kMakeHeapIterableMask since the heap is always iterable. > > BUG=chromium:580959 > LOG=n > > Committed: https://crrev.com/7c1cac4888a248fda3fa6de3624f32a6babb37e9 > Cr-Commit-Position: refs/heads/master@{#36333} TBR=ulan@chromium.org,yangguo@chromium.org,hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:580959 Review-Url: https://codereview.chromium.org/1987363002 Cr-Commit-Position: refs/heads/master@{#36335}
-
mlippautz authored
Properly records entries individually instead of using the hammer that requires visiting the whole code object during pointer updating. BUG=chromium:612847 LOG=N Review-Url: https://codereview.chromium.org/1994653002 Cr-Commit-Position: refs/heads/master@{#36334}
-
hpayer authored
Remove kMakeHeapIterableMask since the heap is always iterable. BUG=chromium:580959 LOG=n Review-Url: https://codereview.chromium.org/1961373003 Cr-Commit-Position: refs/heads/master@{#36333}
-
titzer authored
R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/1990923002 Cr-Commit-Position: refs/heads/master@{#36332}
-
nikolaos authored
BUG=v8:5023 R=mythria@chromium.org,machenbach@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/1993663002 Cr-Commit-Position: refs/heads/master@{#36331}
-
littledan authored
This patch ensures that Intl bound method getters can't be retargeted to other Intl types. If that were to happen, then a RUNTIME_ASSERT would trigger later. This patch throws a TypeError instead, as the specification requires. BUG=v8:4870 Review-Url: https://codereview.chromium.org/1986763003 Cr-Commit-Position: refs/heads/master@{#36330}
-
machenbach authored
BUG=chromium:474921 LOG=n NOTRY=true Review-Url: https://codereview.chromium.org/1988023003 Cr-Commit-Position: refs/heads/master@{#36329}
-
ivica.bogosavljevic authored
NOTRY=true Review-Url: https://codereview.chromium.org/1995473002 Cr-Commit-Position: refs/heads/master@{#36328}
-
yangguo authored
R=vogelheim@chromium.org Review-Url: https://codereview.chromium.org/1991793002 Cr-Commit-Position: refs/heads/master@{#36327}
-
mythria authored
Updates blink_tests/TestExpecations by removing failure expectation for gc related tests. These tests are modified to work with ignition by the following cls: https://codereview.chromium.org/1972943002/ https://codereview.chromium.org/1950613005/ BUG=v8:4280,chromium:595672 LOG=N Review-Url: https://codereview.chromium.org/1985673002 Cr-Commit-Position: refs/heads/master@{#36326}
-
mstarzinger authored
This is a pure refactoring that removes unnecessary wrapper methods from the EscapeAnalysis class. This completely removes the notion of "Alias" from the interface. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/1989243002 Cr-Commit-Position: refs/heads/master@{#36325}
-
mstarzinger authored
This promotes the escape analysis from an experimental feature to be a fully supported feature. The main goal is to unleach ClusterFuzz on the implementation so that we can stabilize it. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/1989833002 Cr-Commit-Position: refs/heads/master@{#36324}
-
jyan authored
port 8e303dd0 R=bmeurer@chromium.org, yangguo@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:5010 Review-Url: https://codereview.chromium.org/1986343002 Cr-Commit-Position: refs/heads/master@{#36323}
-
mstarzinger authored
This is pure refactoring that moves many internal details of the escape analysis from the header into the compilation unit. The goal of this is to simplify the interface for readability. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/1991723003 Cr-Commit-Position: refs/heads/master@{#36322}
-
cbruni authored
Move most of JSReceiver::GetKeys to the KeyAccumulator BUG= Review-Url: https://codereview.chromium.org/1989263002 Cr-Commit-Position: refs/heads/master@{#36321}
-