- 13 Oct, 2016 2 commits
-
-
mythria authored
With --trace-ic flag, the function names and the source positions are not shown for interpreted functions. Interpreted functions have an extra frame built by bytecode handlers which has to be skipped to get the interpreted function's frame. Also the code offsets are computed differently for interpreted functions. BUG=v8:4280 Review-Url: https://codereview.chromium.org/2405173007 Cr-Commit-Position: refs/heads/master@{#40274}
-
ishell authored
BUG= Review-Url: https://codereview.chromium.org/2412043003 Cr-Commit-Position: refs/heads/master@{#40255}
-
- 12 Oct, 2016 1 commit
-
-
bmeurer authored
This is the next step to unify the Call/Construct feedback collection and prepare it to be able to collect SharedFunctionInfo feedback. This also reduces the CallICStub overhead quite a bit since we only need one stub per mode (and tail call mode), not also one per call arity. R=mvstanton@chromium.org BUG=v8:2206 NOTRY=true Review-Url: https://codereview.chromium.org/2412453005 Cr-Commit-Position: refs/heads/master@{#40206}
-
- 07 Oct, 2016 3 commits
-
-
jgruber authored
BUG= Committed: https://crrev.com/7db0ecdec3cf330766575cb7973b983f3f1e3020 Review-Url: https://codereview.chromium.org/2381843002 Cr-Original-Commit-Position: refs/heads/master@{#40080} Cr-Commit-Position: refs/heads/master@{#40087}
-
jgruber authored
This reverts commit 7db0ecde. Manual revert since automatic revert is too large for the web interface. BUG= TBR=bmeurer@chromium.org,mstarzinger@chromium.org,yangguo@chromium.org,ahaas@chromium.org NOPRESUBMIT=true NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2396353002 Cr-Commit-Position: refs/heads/master@{#40082}
-
jgruber authored
BUG= Review-Url: https://codereview.chromium.org/2381843002 Cr-Commit-Position: refs/heads/master@{#40080}
-
- 06 Oct, 2016 1 commit
-
-
adamk authored
Introduce AccessCompilerData which hangs off the Isolate, and initialize it when the first PropertyAccessCompiler is instantiated. This avoids TSAN failures when trying to access load/store calling convention arrays. BUG=v8:5427 Review-Url: https://codereview.chromium.org/2389313002 Cr-Commit-Position: refs/heads/master@{#40055}
-
- 05 Oct, 2016 1 commit
-
-
ishell authored
... by passing a field offset as a runtime parameter. This CL also introduces a StoreMapStub - a special case of a store transition that used to be handled by old StoreTransitionStub. BUG=chromium:648545 Review-Url: https://codereview.chromium.org/2397573004 Cr-Commit-Position: refs/heads/master@{#39997}
-
- 04 Oct, 2016 3 commits
-
-
franzih authored
BUG= Review-Url: https://codereview.chromium.org/2389193002 Cr-Commit-Position: refs/heads/master@{#39959}
-
franzih authored
BUG= Review-Url: https://codereview.chromium.org/2390923003 Cr-Commit-Position: refs/heads/master@{#39957}
-
franzih authored
BUG= Review-Url: https://codereview.chromium.org/2387173003 Cr-Commit-Position: refs/heads/master@{#39956}
-
- 28 Sep, 2016 2 commits
-
-
ishell authored
BUG=chromium:650973 Review-Url: https://codereview.chromium.org/2374003002 Cr-Commit-Position: refs/heads/master@{#39823}
-
jkummerow authored
When the inline lookup on a fast-property receiver doesn't find anything, try a stub cache lookup before going into the runtime. This is much faster for properties loaded from the receiver's prototype chain. BUG=chromium:650236 Review-Url: https://codereview.chromium.org/2373683002 Cr-Commit-Position: refs/heads/master@{#39813}
-
- 23 Sep, 2016 3 commits
-
-
jkummerow authored
Megamorphic keyed loads often load fast properties from the receiver (as opposed to its prototype chain). They should avoid polluting the stub cache for this. Drive-by fix: --trace-ic printed two identical log lines for KeyedLoadIC misses taking the LoadIC::Load path. Review-Url: https://codereview.chromium.org/2358373002 Cr-Commit-Position: refs/heads/master@{#39684}
-
ishell authored
Namely: Runtime_LoadIC_MissFromStubFailure Runtime_StoreIC_MissFromStubFailure Runtime_KeyedStoreIC_MissFromStubFailure BUG=chromium:608675 Review-Url: https://codereview.chromium.org/2346743003 Cr-Commit-Position: refs/heads/master@{#39675}
-
ishell authored
According to new store IC calling convention the value, slot and vector are passed on the stack and there's no need in trying to preserve values or respective registers in store handlers. Nice bonus: we also don't need virtual registers anymore. BUG=v8:5407 Review-Url: https://codereview.chromium.org/2357323003 Cr-Commit-Position: refs/heads/master@{#39672}
-
- 22 Sep, 2016 1 commit
-
-
ishell authored
The handlers cleanup will be done in a follow-up CL. BUG=v8:5407 Review-Url: https://codereview.chromium.org/2357163003 Cr-Commit-Position: refs/heads/master@{#39617}
-
- 20 Sep, 2016 1 commit
-
-
ishell authored
This will allow to simplify the miss part of store IC handlers when we decide to pass value/slot/vector on the stack. BUG=v8:5407 Review-Url: https://codereview.chromium.org/2351643005 Cr-Commit-Position: refs/heads/master@{#39549}
-
- 16 Sep, 2016 1 commit
-
-
ishell authored
This CL also cleans up related interface descriptors: 1) unused StoreTransitionDescriptor is removed and VectorStoreTransitionDescriptor is renamed to StoreTransitionDescriptor. 2) on ia32/x87 architectures slot and vector are passed on the stack (dispatcher/handlers cleanup will be addressed in a separate CL). These two stub ports have to be combined in one CL because: 1) without changing the StoreTransitionDescriptor TF was not able to compile them on ia32/x87 (because of lack of registers), 2) it was not possible to change the descriptor first because Crankshaft was not able to deal with the stack allocated parameters in case of a stub failure. TBR=jkummerow@chromium.org BUG=v8:5269 Review-Url: https://codereview.chromium.org/2313093002 Cr-Commit-Position: refs/heads/master@{#39476}
-
- 15 Sep, 2016 1 commit
-
-
ishell authored
Review-Url: https://codereview.chromium.org/2343813002 Cr-Commit-Position: refs/heads/master@{#39445}
-
- 06 Sep, 2016 1 commit
-
-
marja authored
Rebuilding (after touching certain files) is crazy slow because includes are out of control. The (last remaining) offending include path is: ast.h <- liveedit.h <- debug.h <- src/x64/assembler-whatever-port-inl.h <- src/macro-assembler.h <- everything possible With this CL, the rebuild steps needed when touching ast-value-factory.h drops from 365 to 181. BUG=v8:5294 TBR=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2316443002 Cr-Commit-Position: refs/heads/master@{#39195}
-
- 05 Sep, 2016 1 commit
-
-
jkummerow authored
And also handle dictionary elements loads in the dispatcher. This is a reland with fix for negative indices into DICTIONARY_ELEMENTS. Original review: https://codereview.chromium.org/2245683002/ Review-Url: https://codereview.chromium.org/2313683002 Cr-Commit-Position: refs/heads/master@{#39172}
-
- 02 Sep, 2016 1 commit
-
-
mvstanton authored
Our Type class has a semantic and representational dimension. Much code in src/ast, Crankshaft and Turbofan is based on it. Going forward in Turbofan we'd like to remove representational information entirely. To that end, new type AstType has been created to preserve existing behavior for the benefit of Crankshaft and the AST. BUG= Review-Url: https://codereview.chromium.org/2302283002 Cr-Commit-Position: refs/heads/master@{#39135}
-
- 01 Sep, 2016 2 commits
-
-
jkummerow authored
Revert of [stubs] Port KeyedLoadIC_Generic stub to TurboFan (patchset #4 id:60001 of https://codereview.chromium.org/2245683002/ ) Reason for revert: Suspected to cause webgl_conformance_tests failures: WebglConformance_conformance_textures_misc_tex_image_with_format_and_type (gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest) ... [21956:1299:0901/082859:INFO:CONSOLE(11)] "Uncaught TypeError: Cannot read property 'charCodeAt' of undefined", source: (11) [21956:1299:0901/082859:INFO:CONSOLE(174)] "Uncaught TypeError: Cannot read property 'charCodeAt' of undefined", source: http://127.0.0.1:56892/js/pnglib.js (174) Original issue's description: > [stubs] Port KeyedLoadIC_Generic stub to TurboFan > > And also handle dictionary elements loads in the dispatcher. > > Committed: https://crrev.com/fd5fe3b2a40cc7a9b044416798c3c2aa734469ff > Cr-Commit-Position: refs/heads/master@{#39070} TBR=verwaest@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2303793002 Cr-Commit-Position: refs/heads/master@{#39096}
-
jkummerow authored
And also handle dictionary elements loads in the dispatcher. Review-Url: https://codereview.chromium.org/2245683002 Cr-Commit-Position: refs/heads/master@{#39070}
-
- 31 Aug, 2016 1 commit
-
-
marja authored
This way, many files which only need CompilationInfo but not compiler.h and its dependencies can include just compilation-info.h. BUG= Review-Url: https://codereview.chromium.org/2284313003 Cr-Commit-Position: refs/heads/master@{#39038}
-
- 19 Aug, 2016 1 commit
-
-
marja authored
Rebuilding (after touching certain files) is crazy slow because includes are out of control. Fixing it: - Don't include stuff in headers unless necessary. - Include the stuff you need, not some other stuff that happens to include the stuff you need. BUG=v8:5294 Review-Url: https://codereview.chromium.org/2260483002 Cr-Commit-Position: refs/heads/master@{#38740}
-
- 18 Aug, 2016 5 commits
-
-
verwaest authored
Use bool is_strict_ to encode language_mode in scopes using a single bit. BUG= Review-Url: https://codereview.chromium.org/2261463002 Cr-Commit-Position: refs/heads/master@{#38724}
-
hablich authored
Revert of There are only 2 language modes, not 3 (patchset #4 id:60001 of https://codereview.chromium.org/2250703003/ ) Reason for revert: Breaks ARM and MIPS builds e.g. https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm%20-%20debug%20builder/builds/2479/steps/compile/logs/stdio Original issue's description: > There are only 2 language modes, not 3 > > BUG= > > Committed: https://crrev.com/39764ba293412adde99a77a66d0750695312e006 > Cr-Commit-Position: refs/heads/master@{#38704} TBR=neis@chromium.org,marja@chromium.org,verwaest@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2257133002 Cr-Commit-Position: refs/heads/master@{#38714}
-
hablich authored
Revert of Replace LANGUAGE_END with LAST_LANGUAGE_MODE (patchset #1 id:1 of https://codereview.chromium.org/2257703003/ ) Reason for revert: Needed to land revert https://codereview.chromium.org/2257133002/ Original issue's description: > Replace LANGUAGE_END with LAST_LANGUAGE_MODE > > BUG= > > Committed: https://crrev.com/9324efca85710ebb14f21ef8476447e21cbe3f35 > Cr-Commit-Position: refs/heads/master@{#38707} TBR=neis@chromium.org,marja@chromium.org,verwaest@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2259853002 Cr-Commit-Position: refs/heads/master@{#38713}
-
verwaest authored
BUG= Review-Url: https://codereview.chromium.org/2257703003 Cr-Commit-Position: refs/heads/master@{#38707}
-
verwaest authored
BUG= Review-Url: https://codereview.chromium.org/2250703003 Cr-Commit-Position: refs/heads/master@{#38704}
-
- 10 Aug, 2016 2 commits
-
-
ishell authored
... and let the stub ask the IC whether it should throw or not when the property was not found. This CL undoes ast-numbering changes made here: https://codereview.chromium.org/2219303002/ BUG=chromium:634467 TBR=verwaest@chromium.org Review-Url: https://codereview.chromium.org/2220203002 Cr-Commit-Position: refs/heads/master@{#38549}
-
lpy authored
Currently we have V8 RuntimeCallStats that is independently from tracing when running d8 with flag --runtime_call_stats. This patch embeds V8 runtime call stats into tracing, by having a global table of runtime call counters each isolate, resetting the table each time we enter a top level trace event, and dumping the table for each top level trace event. This will make trace file more compat, as well as enable runtime call stats in tracing system. This patch adds ~5% overhead to V8 when the category is enabled, we measure the overhead by running a script when category is enabled. BUG=v8:5089 Committed: https://crrev.com/d014866173eaa2b548c566217b2c94b1d49385fa Committed: https://crrev.com/1ca3b73bba4a7253ca8eeef39321d70e7d414331 Committed: https://crrev.com/3f936a5b17754783e92d2146eaf66c88a78ee45b Review-Url: https://codereview.chromium.org/2187693002 Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#38270} Cr-Original-Original-Commit-Position: refs/heads/master@{#38314} Cr-Original-Commit-Position: refs/heads/master@{#38403} Cr-Commit-Position: refs/heads/master@{#38510}
-
- 09 Aug, 2016 3 commits
-
-
bmeurer authored
Remove the useless information from the BinaryOperationHints and CompareOperationHints, and cache the JS operators appropriately. R=epertoso@chromium.org Review-Url: https://codereview.chromium.org/2228983002 Cr-Commit-Position: refs/heads/master@{#38506}
-
jkummerow authored
This reverts commit d9d719e7. Original review: https://codereview.chromium.org/2180273002/ With additional fixes to repair performance regressions: - check PropertyCell::kValueOffset, not Cell::kValueOffset - convert HeapNumbers to int on the fly if possible NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2227703003 Cr-Commit-Position: refs/heads/master@{#38497}
-
hablich authored
Revert of [KeyedLoadIC] Support Smi "handlers" for element loads (patchset #5 id:80001 of https://codereview.chromium.org/2180273002/ ) Reason for revert: Times out webgl errors: https://bugs.chromium.org/p/chromium/issues/detail?id=635545 Original issue's description: > [KeyedLoadIC] Support Smi "handlers" for element loads > > This is an experiment as far as performance is concerned. If Smi-configured > element loading directly from the dispatcher stub is fast enough, then we > can stop compiling LoadFastElementStubs (and drop the corresponding code). > > Committed: https://crrev.com/c9308147b341596de2733039223918a6202afa5f > Cr-Commit-Position: refs/heads/master@{#38377} BUG=chromium:635545 TBR=ishell@chromium.org,jkummerow@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2222273003 Cr-Commit-Position: refs/heads/master@{#38473}
-
- 08 Aug, 2016 1 commit
-
-
machenbach authored
Revert of [Tracing] Embed V8 runtime call stats into tracing. (patchset #8 id:140001 of https://codereview.chromium.org/2187693002/ ) Reason for revert: Leaks block chromium roll: https://codereview.chromium.org/2219083003/ Example build: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/205435 You can add the trybot from tryserver.chromium.linux, linux_chromium_asan_rel_ng, on reland. Original issue's description: > [Reland][Tracing] Embed V8 runtime call stats into tracing. > > Currently we have V8 RuntimeCallStats that is independently from tracing when > running d8 with flag --runtime_call_stats. This patch embeds V8 runtime call > stats into tracing, by having a global table of runtime call counters each > isolate, resetting the table each time we enter a top level trace event, and > dumping the table for each top level trace event. This will make trace file more > compat, as well as enable runtime call stats in tracing system. > > This patch adds ~5% overhead to V8 when the category is enabled, we measure the > overhead by running a script when category is enabled. > > BUG=v8:5089 > > Committed: https://crrev.com/d014866173eaa2b548c566217b2c94b1d49385fa > Committed: https://crrev.com/1ca3b73bba4a7253ca8eeef39321d70e7d414331 > Committed: https://crrev.com/3f936a5b17754783e92d2146eaf66c88a78ee45b > Cr-Original-Original-Commit-Position: refs/heads/master@{#38270} > Cr-Original-Commit-Position: refs/heads/master@{#38314} > Cr-Commit-Position: refs/heads/master@{#38403} TBR=cbruni@chromium.org,fmeawad@chromium.org,bmeurer@chromium.org,adamk@chromium.org,rmcilroy@chromium.org,lpy@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:5089 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2221853002 Cr-Commit-Position: refs/heads/master@{#38412}
-
- 05 Aug, 2016 2 commits
-
-
lpy authored
Currently we have V8 RuntimeCallStats that is independently from tracing when running d8 with flag --runtime_call_stats. This patch embeds V8 runtime call stats into tracing, by having a global table of runtime call counters each isolate, resetting the table each time we enter a top level trace event, and dumping the table for each top level trace event. This will make trace file more compat, as well as enable runtime call stats in tracing system. This patch adds ~5% overhead to V8 when the category is enabled, we measure the overhead by running a script when category is enabled. BUG=v8:5089 Committed: https://crrev.com/d014866173eaa2b548c566217b2c94b1d49385fa Committed: https://crrev.com/1ca3b73bba4a7253ca8eeef39321d70e7d414331 Review-Url: https://codereview.chromium.org/2187693002 Cr-Original-Original-Commit-Position: refs/heads/master@{#38270} Cr-Original-Commit-Position: refs/heads/master@{#38314} Cr-Commit-Position: refs/heads/master@{#38403}
-
jkummerow authored
This is an experiment as far as performance is concerned. If Smi-configured element loading directly from the dispatcher stub is fast enough, then we can stop compiling LoadFastElementStubs (and drop the corresponding code). Review-Url: https://codereview.chromium.org/2180273002 Cr-Commit-Position: refs/heads/master@{#38377}
-