- 07 Nov, 2017 31 commits
-
-
Michael Achenbach authored
This accompanies infra change: https://chromium-review.googlesource.com/c/chromium/tools/build/+/757096 NOTRY=true NOTREECHECKS=true Bug: chromium:726584 Change-Id: Ifaac9eef4cac1700c3fd15819c4f638cc2dc9d8e Reviewed-on: https://chromium-review.googlesource.com/757100 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#49194}
-
Toon Verwaest authored
Bug: v8:5561 Change-Id: If3a44d1e40c81a764b776725c7b28ead653437b9 Reviewed-on: https://chromium-review.googlesource.com/756833 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#49193}
-
Michael Achenbach authored
This reverts commit 34e3e7f9. Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Fuchsia/builds/474 Original change's description: > Introduce gc flag for fuzzing over compaction. > > Bug: v8:6972 > Change-Id: If1f4ee04ae00c6ae1e037bbb1ca758e952a8f843 > Reviewed-on: https://chromium-review.googlesource.com/738112 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Commit-Queue: Michał Majewski <majeski@google.com> > Cr-Commit-Position: refs/heads/master@{#49191} TBR=machenbach@chromium.org,hpayer@chromium.org,majeski@google.com Change-Id: I63a14763a4958c948fbcad1e75c284abb580e7be No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6972 Reviewed-on: https://chromium-review.googlesource.com/755596Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#49192}
-
Michal Majewski authored
Bug: v8:6972 Change-Id: If1f4ee04ae00c6ae1e037bbb1ca758e952a8f843 Reviewed-on: https://chromium-review.googlesource.com/738112Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Michał Majewski <majeski@google.com> Cr-Commit-Position: refs/heads/master@{#49191}
-
Michael Achenbach authored
NOTRY=true Bug: chromium:726584 Change-Id: I05d58c5987ffed5ae48f896e6c318034cec534f5 Reviewed-on: https://chromium-review.googlesource.com/756835Reviewed-by:
-
Michal Majewski authored
Bug: v8:6917 Change-Id: I0dc20f84257b501d217e00cb29b34dd2a985ecf9 Reviewed-on: https://chromium-review.googlesource.com/737834 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by:
-
Tobias Tebbi authored
This gives up on earlier attempts to interpret DeadValue as a signal of unreachable code. This does not work because free-floating dead value nodes, and even pure branch nodes that use them, can get scheduled so early that they get reachable. Instead, we now eagerly remove branches that use DeadValue in DeadCodeElimination and replace DeadValue inputs to value phi nodes with dummy values. Reland of https://chromium-review.googlesource.com/715716 Bug: chromium:741225 chromium:776256 Change-Id: I251efd507c967d4a8882ad8fd2fd96c4185781fe Reviewed-on: https://chromium-review.googlesource.com/727893 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#49188}
-
Ulan Degenbaev authored
Bug: chromium:774644, chromium:694255 Change-Id: I957037b14bf6508e774d6fd1c97239b31f2296e8 Reviewed-on: https://chromium-review.googlesource.com/756893Reviewed-by:
-
Michael Achenbach authored
Bug: chromium:726584 Change-Id: I49daa3e7de4f792db9908885ab94a87661950a4e Reviewed-on: https://chromium-review.googlesource.com/732654 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Hannes Payer authored
Bug: chromium:774108,v8:6792 Change-Id: I09ec58f7fdc17f1cc50d9445f8b473e17a584dc1 Reviewed-on: https://chromium-review.googlesource.com/756843Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#49185}
-
Toon Verwaest authored
Bug: v8:5561 Change-Id: Ieb44074280fa034b4f88e630e747211d73dedb6f Reviewed-on: https://chromium-review.googlesource.com/753374Reviewed-by:
-
Yang Guo authored
Now that we only have the seeded variant, let's call it number_dictionary_map. It's cleaner. R=mstarzinger@chromium.org Change-Id: I3e36ecb15140b5def835ca8ebe50ab829a21892d Reviewed-on: https://chromium-review.googlesource.com/756749Reviewed-by:
-
Marja Hölttä authored
ZoneDeque is memory-inefficient, see https://bugs.chromium.org/p/chromium/issues/detail?id=674287 As a downside, ZoneChunkList is not const correct, see https: //bugs.chromium.org/p/v8/issues/detail?id=6473 . Bug: v8:5516 Change-Id: I2db15006afd78aa932ab831cd9c0cff659229321 Reviewed-on: https://chromium-review.googlesource.com/750782Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org BUG=v8:6792 Change-Id: Ida4a0c063232a01c9526d478530fc9adf1e6ee24 Reviewed-on: https://chromium-review.googlesource.com/756740 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#49181}
-
Georg Neis authored
Bug: v8:6791 Change-Id: I10f8c6c88c534ee1e3c893176b6563af0c9f99d3 Reviewed-on: https://chromium-review.googlesource.com/753904 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#49180}
-
Yang Guo authored
Use (Seeded)NumberDictionary instead. Change-Id: I426cd0a33df7d47fe4fec0c108be5632ef7c0f19 Reviewed-on: https://chromium-review.googlesource.com/756697Reviewed-by:
-
Ulan Degenbaev authored
The flag is --parallel-marking. Bug: chromium:750084 Change-Id: I20ab5945d2cc41d44b29d7090a3436d028588540 Reviewed-on: https://chromium-review.googlesource.com/756709Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#49178}
-
Mike Stanton authored
In the fast case, the feedback should be the same across all slots (like a switch over enum values). BUG=v8:7045 Change-Id: I2c32f81cda55874ea6fc8d6a18c85d9929cff1bb Reviewed-on: https://chromium-review.googlesource.com/756701Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#49177}
-
Clemens Hammacher authored
This value was uninitialized before. Initialize it to zero. Also, fix the tracing output to actually print the start arity and not the end arity. R=rossberg@chromium.org Change-Id: I1eda3be88ca842f60e40e3fb630eca254619ae83 Reviewed-on: https://chromium-review.googlesource.com/756702Reviewed-by:
Andreas Rossberg <rossberg@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#49176}
-
Clemens Hammacher authored
The section name is printed two times currently: Once in {WasmSectionIterator::next()}, once in {ModuleDecoderImpl::DecodeSection}. This is confusing when looking at the trace output, hence remove one of the outputs. R=ahaas@chromium.org Change-Id: Icc699d5eb0e39325d2849ea6c345b9522985003b Reviewed-on: https://chromium-review.googlesource.com/756703Reviewed-by:Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#49175}
-
Clemens Hammacher authored
They are uncovered by existing test cases once we support globals and memory operations. R=ahaas@chromium.org Bug: v8:6600 Change-Id: I66c7143b66c816ab9a032c18bf6b2c82f7291f68 Reviewed-on: https://chromium-review.googlesource.com/756705Reviewed-by:
-
Michael Achenbach authored
Accompanies: https://chromium-review.googlesource.com/c/chromium/tools/build/+/753346 NOTRY=true NOTREECHECKS=true Bug: chromium:781724 Change-Id: I51e84d7ee7807e557d500c847c72e06e58175e04 Reviewed-on: https://chromium-review.googlesource.com/754687 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Georg Neis authored
The bytecode generator has special handling for comparing the result of the typeof operator against a string literal. This needs to be adapted for bigints. R=jkummerow@chromium.org, mythrie@chromium.org Bug: v8:6791 Change-Id: I42d6c9e9225ce05e19393f10e01ae496ecb70c9c Reviewed-on: https://chromium-review.googlesource.com/753465 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Georg Neis authored
Actually all it does is throw a TypeError. R=jkummerow@chromium.org Bug: v8:6791 Change-Id: I884da4eaa937519c07c3516a1713829f52e28ad8 Reviewed-on: https://chromium-review.googlesource.com/753730Reviewed-by:
-
jgruber authored
Due to lazy deserialization, we need to ensure the snapshot blob is not freed until the Isolate is destroyed. Re-enable a few tests that can handle lazy deserialization just fine. Unfortunately we can't do this for all tests as UNINITIALIZED_TEST does not sufficiently set up the isolate for lazy deserialization (there's no Isolate::snapshot_blob_). Bug: v8:6624 Change-Id: Icf0d217da3a4c5ff1506facc7869d2dd1ac3a983 Reviewed-on: https://chromium-review.googlesource.com/756694Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#49170}
-
jgruber authored
Lazy TFJ builtins rely on a mechanism that uses the SharedFunctionInfo to determine the builtin to deserialize. That obviously doesn't work if we call the lazy builtin directly, so make sure this does not happen (at least not through (Tail)CallBuiltin). Bug: v8:6624 Change-Id: Iea95d83379a5a0e47324e1fef83c005350f2f02a Reviewed-on: https://chromium-review.googlesource.com/754684Reviewed-by:
-
cjihrig authored
This commit updates the jobs for generating postmortem metadata. I96a8a7cdded6f7c37b6f1da659d63df9e3a5de2b moved the Code class to a new file without updating the postmortem jobs. This resulted in some constants used by Node.js to disappear, leading to build failures on SmartOS. See: https://github.com/nodejs/node-v8/issues/21 Bug: Change-Id: Icf5f59fe464d933c4f5a3f622b08c01bc43c6a80 Reviewed-on: https://chromium-review.googlesource.com/741919 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Yang Guo authored
This change - adds new maps for elements, global, and named dictionaries. - adds support to embed these dictionaries in the startup snapshot. - adds support to embed these dictionaries in the code cache. - refactors the rehashing logic. TBR=mstarzinger@chromium.org, ishell@chromium.org, jgruber@chromium.org Bug: v8:6593 Change-Id: I2455fe2a9cc6e93247940de99de5f124c2ada137 Reviewed-on: https://chromium-review.googlesource.com/756693Reviewed-by:
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/be72997..b5d1311 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/11a6764..af046c5 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I0fb9023e899edb09572c3c103a6f37dd8bb8aa5c Reviewed-on: https://chromium-review.googlesource.com/756574Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#49166}
-
Eric Holk authored
This reverts commit 32f30f63. Reason for revert: broken Fuchsia build, https://logs.chromium.org/v/?s=chromium%2Fbb%2Fclient.v8%2FV8_Fuchsia%2F460%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout Original change's description: > [platform] check return values from memory operations > > This change adds DCHECKs for calls such as mprotect, as well as marking some of > the memory allocation and deallocation routines as V8_MUST_USE_RESULT. This > additional checking gives us more useful information for failure in the presence > of, for example, address space exhaustion. > > Bug: > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng > Change-Id: I5bc76c1da6160262d3d556fea49d284ddd4e02c5 > Reviewed-on: https://chromium-review.googlesource.com/721267 > Commit-Queue: Eric Holk <eholk@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49164} TBR=hpayer@chromium.org,mlippautz@google.com,eholk@chromium.org Change-Id: Ie4b57b45c801dcce7884645f50ff74f833de6dc4 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/756137Reviewed-by:
Eric Holk <eholk@chromium.org> Commit-Queue: Eric Holk <eholk@chromium.org> Cr-Commit-Position: refs/heads/master@{#49165}
-
Eric Holk authored
This change adds DCHECKs for calls such as mprotect, as well as marking some of the memory allocation and deallocation routines as V8_MUST_USE_RESULT. This additional checking gives us more useful information for failure in the presence of, for example, address space exhaustion. Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I5bc76c1da6160262d3d556fea49d284ddd4e02c5 Reviewed-on: https://chromium-review.googlesource.com/721267 Commit-Queue: Eric Holk <eholk@chromium.org> Reviewed-by:
-
- 06 Nov, 2017 9 commits
-
-
Junliang Yan authored
Port ef6c175c R=ulan@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Change-Id: I045c22ac71d6ac18e10429e7ba1a7a5ef107529e Reviewed-on: https://chromium-review.googlesource.com/755894Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#49163}
-
Michael Lippautz authored
Resetting phantom handles while keeping finalizers alive leads to the problem of eagerly resetting a handle although another finalizer keeps it (transitively) alive. This becomes a problem with internal pointers to Blink as without global handle a Blink GC is free to collect wrappables. This CL untangles finalizers handling from phantom handle resets by introducing a separate path for resetting. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Bug: chromium:781728 Change-Id: Ica138b72942698fd996c6e9fe0bdc19cc432c010 Reviewed-on: https://chromium-review.googlesource.com/753724 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#49162}
-
Ulan Degenbaev authored
This test uses a lot of memory and is causing OOM crashes on bots. Bug: v8:7042 Change-Id: I63ff4d44ca8e26b65875df53ebd235976183c558 Reviewed-on: https://chromium-review.googlesource.com/755593 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Alexei Filippov authored
The sampling heap profiles can now be retrieved without stopping the profiler. BUG=v8:6887 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I491206d0bafd7d4e198622117c12aab0057e6bc6 Reviewed-on: https://chromium-review.googlesource.com/749700Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#49160}
-
Toon Verwaest authored
Previously StaNamedProperty and StaKeyedProperty were in a weird state where they claimed to not touch the accumulator, but actually did in case they were deopted in the middle. A frame was added in the middle to overwrite the accumulator again with the right value before returning from the setter, using a lot of complexity in the deoptimizer. This changes those instructions to be marked as writing to the accumulator (e.g., the result of the setter), and uses to manually store and reload into the accumulator the value being stored. If we want to avoid the additional bytecodes, we could make sure that bytecodes that claim to leave the accumulator alone don't deopt back to Advance/Dispatch but LoadAccumulatorWithValue/Advance/Dispatch. That's in a way similar to what happened before this CL, but I believe could be implemented much simpler. Bug: Change-Id: I4850a690ef5a30976701d0e050951faa46fd1c18 Reviewed-on: https://chromium-review.googlesource.com/753487Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Bug: chromium:769203 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Iffb7e92fb9c08c42f03ad28c8defb516454a2d3d Reviewed-on: https://chromium-review.googlesource.com/753740Reviewed-by:
-
Michael Achenbach authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/53fa255..be72997 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/7208715..11a6764 Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/21d33b1..4b5a724 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/9f0284f..723b259 Rolling v8/tools/swarming_client: https://chromium.googlesource.com/infra/luci/client-py/+log/5da404c..6fd3c7b This also ports a fix for gyp from: https://chromium-review.googlesource.com/c/chromium/src/+/752143 TBR=sergiyb@chromium.org Change-Id: I2f6d183094b1d4dd398cc38ca2dfe1df83b38f4b Reviewed-on: https://chromium-review.googlesource.com/753587Reviewed-by:
-
Adam Klein authored
This reverts commit 3877bf6f. Reason for revert: failed compilation on Win64/clang: https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20clang/builds/9015 Original change's description: > Snapshot: support rehashing property and element dictionaries. > > This change > - adds new maps for elements, global, and named dictionaries. > - adds support to embed these dictionaries in the startup snapshot. > - adds support to embed these dictionaries in the code cache. > - refactors the rehashing logic. > > R=ishell@chromium.org, jgruber@chromium.org, mstarzinger@chromium.org > > Bug: v8:6593 > Change-Id: I8d9a7ba7145f1af4e6e15301a4d5611f07c77f33 > Reviewed-on: https://chromium-review.googlesource.com/753323 > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49155} TBR=yangguo@chromium.org,mstarzinger@chromium.org,jgruber@chromium.org,ishell@chromium.org Change-Id: I0b45d2d07da97b9a7953abf4ad24eec4ea944306 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6593 Reviewed-on: https://chromium-review.googlesource.com/755493Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#49156}
-
Yang Guo authored
This change - adds new maps for elements, global, and named dictionaries. - adds support to embed these dictionaries in the startup snapshot. - adds support to embed these dictionaries in the code cache. - refactors the rehashing logic. R=ishell@chromium.org, jgruber@chromium.org, mstarzinger@chromium.org Bug: v8:6593 Change-Id: I8d9a7ba7145f1af4e6e15301a4d5611f07c77f33 Reviewed-on: https://chromium-review.googlesource.com/753323Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#49155}
-
