- 02 Feb, 2017 3 commits
-
-
jgruber authored
BUG= Review-Url: https://codereview.chromium.org/2663803002 Cr-Original-Commit-Position: refs/heads/master@{#42881} Committed: https://chromium.googlesource.com/v8/v8/+/65ad1e35d9a97c1126a55cc9d3014598fd224259 Review-Url: https://codereview.chromium.org/2663803002 Cr-Commit-Position: refs/heads/master@{#42883}
-
machenbach authored
Revert of [string] Migrate String.prototype.{split,replace} to TF (patchset #12 id:220001 of https://codereview.chromium.org/2663803002/ ) Reason for revert: Breaks win64 debug: https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20debug/builds/14967 Original issue's description: > [string] Migrate String.prototype.{split,replace} to TF > > BUG= > > Review-Url: https://codereview.chromium.org/2663803002 > Cr-Commit-Position: refs/heads/master@{#42881} > Committed: https://chromium.googlesource.com/v8/v8/+/65ad1e35d9a97c1126a55cc9d3014598fd224259 TBR=bmeurer@chromium.org,ishell@chromium.org,yangguo@chromium.org,jgruber@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2671673003 Cr-Commit-Position: refs/heads/master@{#42882}
-
jgruber authored
BUG= Review-Url: https://codereview.chromium.org/2663803002 Cr-Commit-Position: refs/heads/master@{#42881}
-
- 01 Feb, 2017 1 commit
-
-
binji authored
Also if the count is not specified, it should wake all waiters. BUG=v8:4777 Review-Url: https://codereview.chromium.org/2659083004 Cr-Commit-Position: refs/heads/master@{#42871}
-
- 31 Jan, 2017 1 commit
-
-
binji authored
BUG=v8:4741 Review-Url: https://codereview.chromium.org/2658143003 Cr-Commit-Position: refs/heads/master@{#42822}
-
- 20 Jan, 2017 1 commit
-
-
jgruber authored
This moves AsyncFunctionAwait{Caught,Uncaught} to CSA, and removes async-await.js. BUG=v8:5639 Review-Url: https://codereview.chromium.org/2643023002 Cr-Commit-Position: refs/heads/master@{#42579}
-
- 19 Jan, 2017 3 commits
-
-
jgruber authored
BUG=v8:5639 Review-Url: https://codereview.chromium.org/2638073002 Cr-Commit-Position: refs/heads/master@{#42508}
-
jgruber authored
Just desugar directly into the runtime call instead. BUG=v8:5639 Review-Url: https://codereview.chromium.org/2633353002 Cr-Commit-Position: refs/heads/master@{#42492}
-
littledan authored
Intl constructors are specified to prohibit structurally invalid subtags. BCP 47 defines itself to be case-insensitive. Firefox does throw on case-insensitive duplicates, following the specifications. This patch makes V8 do the same. There is some small compatibility risk, but the case is fairly niche, so I hope it does not cause much breakage. BUG=v8:4215 Review-Url: https://codereview.chromium.org/2639333003 Cr-Commit-Position: refs/heads/master@{#42487}
-
- 18 Jan, 2017 1 commit
-
-
cbruni authored
A future linear version of the hash table will only need the element count and deleted element count. Hence moving them to the beginning of the underlying fixed array makes the transition easier. BUG=v8:5717 Review-Url: https://codereview.chromium.org/2630373002 Cr-Commit-Position: refs/heads/master@{#42459}
-
- 17 Jan, 2017 1 commit
-
-
gsathya authored
Also moves some functions to prologue.js BUG=v8:5343 Review-Url: https://codereview.chromium.org/2630593004 Cr-Commit-Position: refs/heads/master@{#42417}
-
- 13 Jan, 2017 2 commits
-
-
kozyatinskiy authored
Inspector uses event name only for enqueue* events and doesn't really need name for other events. BUG=v8:5738 R=jgruber@chromium.org,gsathya@chromium.org TBR=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2628173005 Cr-Commit-Position: refs/heads/master@{#42339}
-
yangguo authored
R=jgruber@chromium.org BUG=v8::5836 Review-Url: https://codereview.chromium.org/2628963005 Cr-Commit-Position: refs/heads/master@{#42308}
-
- 12 Jan, 2017 2 commits
-
-
adamk authored
This function was only needed for extrasUtils. Since it was simply calling a builtin function, just expose that builtin instead. This requires an arguments adapter frame for the builtin. As a drive-by fix, also added an arguments adapter for the extrasUtils.resolvePromise (and a regression test). Other cleanup: removed unused native context slot for PROMISE_SET_AND_CREATE. R=gsathya@chromium.org BUG=v8:5343 Review-Url: https://codereview.chromium.org/2626793003 Cr-Commit-Position: refs/heads/master@{#42284}
-
littledan authored
With the new initialization semantics, the V8 ECMA 402 (Intl) implementation does not need to indirect through a symbol to get at the underlying object. This patch removes that indirection, simplifying the implementation. R=yangguo@chromium.org BUG=v8:5751 CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng Review-Url: https://codereview.chromium.org/2601833002 Cr-Commit-Position: refs/heads/master@{#42281}
-
- 11 Jan, 2017 1 commit
-
-
jshin authored
Move the language code checking for 4 languages requiring special case mapping to C++ from JavaScript. This is a speculative fix for crashes reported from Windows and Mac Chrome canary builds when icu-case-mapping is enabled by default. (see crbug.com/676643) In addition, tighten up comparision operators in a couple of places in i18n.js (=== and !== instead of == and !=). BUG=v8:4477, v8:4476, chromium:676643 TEST=test262/{built-ins,intl402}/Strings/*, webkit/fast/js/*, mjsunit/string-case, intl/general/case* Review-Url: https://codereview.chromium.org/2621393002 Cr-Commit-Position: refs/heads/master@{#42246}
-
- 10 Jan, 2017 2 commits
-
-
kozyatinskiy authored
... which were done after the promise has been resolved. Goal of this CL - change promise instrumentation to support better callbacks, chained after promise resolution and prepare instrumentation for adding new asyncTaskCreated instrumentation. Instrumentation changes: - asyncTaskScheduled(recurring) when promise is fulfilled or rejected, - asyncTaskCancelled when promise is collected (since [1] we can be sure that promise will survive scheduled microtasks). Minor changes: - async task type in inspector <-> debugger API transferred by enum instead of string, - Debug manages async task ids based on promise objects. More details: https://docs.google.com/document/d/1u19N45f1gSF7M39mGsycJEK3IPyJgIXCBnWyiPeuJFE [1] https://codereview.chromium.org/2581503003/ BUG=chromium:632829,v8:5738 R=dgozman@chromium.org,yangguo@chromium.org,gsathya@chromium.org Review-Url: https://codereview.chromium.org/2578923002 Cr-Commit-Position: refs/heads/master@{#42178}
-
jgruber authored
Instead of exporting/importing PromiseCreate and RejectPromise and going through them, just call the runtime function / the TF builtin on the context directly. BUG=v8:5639 Review-Url: https://codereview.chromium.org/2599003002 Cr-Commit-Position: refs/heads/master@{#42160}
-
- 09 Jan, 2017 2 commits
-
-
littledan authored
Previously, the Intl implementation tracked types two ways: - In the intl_initialized_marker_symbol - In various named properties of the intl_impl_object_symbol value As far as I can tell, these will never disagree with each other, modulo bugs in Intl itself. This patch removes the second type checking system. This reland includes a fixed type check for Intl.DateTimeFormat.prototype.formatToParts , which is the only Intl method which is not bound. All future methods will follow this pattern. The second reland ensures that a newly inserted test is only run if Intl is present. BUG=v8:5751,chromium:677055, v8:4962 CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng TBR=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2623683002 Cr-Commit-Position: refs/heads/master@{#42152}
-
jgruber authored
The two remaining uses of this intrinsic in debug.js and mirrors.js now simply rely on the runtime function. BUG=v8:5339 Review-Url: https://codereview.chromium.org/2591923003 Cr-Original-Commit-Position: refs/heads/master@{#41892} Committed: https://chromium.googlesource.com/v8/v8/+/c9cb94a06fa7a863d24dd6760b66cecd55748abf Review-Url: https://codereview.chromium.org/2591923003 Cr-Commit-Position: refs/heads/master@{#42128}
-
- 07 Jan, 2017 2 commits
-
-
machenbach authored
Revert of [intl] Remove redundant type checking system (patchset #4 id:60001 of https://codereview.chromium.org/2600913002/ ) Reason for revert: Breaks noi18n. Original issue's description: > [intl] Remove redundant type checking system > > Previously, the Intl implementation tracked types two ways: > - In the intl_initialized_marker_symbol > - In various named properties of the intl_impl_object_symbol value > > As far as I can tell, these will never disagree with each other, > modulo bugs in Intl itself. This patch removes the second type > checking system. > > This reland includes a fixed type check for > Intl.DateTimeFormat.prototype.formatToParts , which is the only Intl > method which is not bound. All future methods will follow this > pattern. > > BUG=v8:5751,chromium:677055, v8:4962 > CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng > > Review-Url: https://codereview.chromium.org/2600913002 > Cr-Commit-Position: refs/heads/master@{#42118} > Committed: https://chromium.googlesource.com/v8/v8/+/aa8a2d2789f79c2c367db406e453b9044e594e25 TBR=yangguo@chromium.org,adamk@chromium.org,littledan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5751,chromium:677055, v8:4962 Review-Url: https://codereview.chromium.org/2617323002 Cr-Commit-Position: refs/heads/master@{#42119}
-
littledan authored
Previously, the Intl implementation tracked types two ways: - In the intl_initialized_marker_symbol - In various named properties of the intl_impl_object_symbol value As far as I can tell, these will never disagree with each other, modulo bugs in Intl itself. This patch removes the second type checking system. This reland includes a fixed type check for Intl.DateTimeFormat.prototype.formatToParts , which is the only Intl method which is not bound. All future methods will follow this pattern. BUG=v8:5751,chromium:677055, v8:4962 CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng Review-Url: https://codereview.chromium.org/2600913002 Cr-Commit-Position: refs/heads/master@{#42118}
-
- 06 Jan, 2017 1 commit
-
-
gsathya authored
BUG=v8:5343 Review-Url: https://codereview.chromium.org/2616673003 Cr-Commit-Position: refs/heads/master@{#42113}
-
- 04 Jan, 2017 3 commits
-
-
adamk authored
This lets us share Builtins::kReturnReceiver, so should every-so-slightly reduce the size of the context snapshot. R=gsathya@chromium.org Review-Url: https://codereview.chromium.org/2614623003 Cr-Commit-Position: refs/heads/master@{#42076}
-
gsathya authored
Add a more low level BranchIfFastPath to take the native_context and promise_fun as args and change the existing one to use this. BUG=v8:5343 Review-Url: https://codereview.chromium.org/2592933004 Cr-Commit-Position: refs/heads/master@{#42075}
-
adamk authored
R=gsathya@chromium.org Review-Url: https://codereview.chromium.org/2615733002 Cr-Commit-Position: refs/heads/master@{#42074}
-
- 03 Jan, 2017 1 commit
-
-
gsathya authored
-- Removes remaning debug from promise.js and moves it to c++ -- Changes debug_id to be a smi in PromiseReactionJobInfo and PromiseResolveThenableJobInfo. -- Changes debug_name to be a smi in PromiseReactionJobInfo and PromiseResolveThenableJobInfo. -- Adds PromiseDebugActionName and PromiseDebugActionType enums -- Adds PromiseDebugActionNameToString and PromiseDebugActionTypeToString helper methods -- Changes variable `status` to be int in runtime functions. -- Changes debug_id to start from 1, not 0 for easier bookkeeping. BUG=v8:5343 Review-Url: https://codereview.chromium.org/2606093002 Cr-Commit-Position: refs/heads/master@{#42052}
-
- 02 Jan, 2017 1 commit
-
-
caitp authored
- Adds CodeAssembler::ConstructJS() to simplify calling JS functions as constructors, used by NewPromiseCapability() - Defines PromiseCapability as a special JSObject subclass, with a non-exensible Map, and read-only non-configurable DataDescriptors which point to its in-object fields. This allows its fields to be used by JS builtins until there is no longer any need. Currently, the performance benefit comes from https://codereview.chromium.org/2567033003/, but does not appear to regress performance in any significant way. BUG=v8:5343 TBR=ulan@chromium.org Review-Url: https://codereview.chromium.org/2567333002 Cr-Commit-Position: refs/heads/master@{#42014}
-
- 29 Dec, 2016 1 commit
-
-
gsathya authored
This patch stores the promise, resolve, reject properties of the deferred object created by CreateInternalPromiseCapability and NewPromiseCapability directly on the promise (if the promise hasn't been fulfilled), otherwise they are stored on the PromiseReactionJobInfo. This patch removes the currently unused CreateInternalPromiseCapability and inlines the call to create the deferred promise object. NewPromiseCapability is the only function that works with a deferred. This patch results in a 8.5% improvement in benchmarks over 5 runs. BUG=v8:5343 Review-Url: https://codereview.chromium.org/2590563003 Cr-Commit-Position: refs/heads/master@{#41991}
-
- 27 Dec, 2016 1 commit
-
-
littledan authored
This patch moves the creation of the Intl constructors from JavaScript to C++ in bootstrapper.cc, to match all of the other builtins exposed to the web. BUG=v8:5751 Review-Url: https://codereview.chromium.org/2586763002 Cr-Commit-Position: refs/heads/master@{#41959}
-
- 23 Dec, 2016 2 commits
-
-
gsathya authored
BUG=v8:5343 Review-Url: https://codereview.chromium.org/2604483002 Cr-Commit-Position: refs/heads/master@{#41947}
-
littledan authored
ECMA 402 v2 made Intl constructors more strict in terms of how they would initialize objects, refusing to initialize objects which have already been constructed. However, when Chrome tried to ship these semantics, we ran into web compatibility issues. This patch tries to square the circle and implement the simpler v2 object semantics while including a compatibility workaround to allow objects to sort of be initialized later, storing the real underlying Intl object in a symbol-named property. The new semantics are described in this PR against the ECMA 402 spec: https://github.com/tc39/ecma402/pull/84 BUG=v8:4360, v8:4870 LOG=Y Review-Url: https://codereview.chromium.org/2582993002 Cr-Commit-Position: refs/heads/master@{#41943}
-
- 22 Dec, 2016 1 commit
-
-
hablich authored
Revert of [regexp] Remove IsRegExp intrinsic (patchset #1 id:1 of https://codereview.chromium.org/2591923003/ ) Reason for revert: speculative revert: https://codereview.chromium.org/2596013002/ Original issue's description: > [regexp] Remove IsRegExp intrinsic > > The two remaining uses of this intrinsic in debug.js and mirrors.js now > simply rely on the runtime function. > > BUG=v8:5339 > > Review-Url: https://codereview.chromium.org/2591923003 > Cr-Commit-Position: refs/heads/master@{#41892} > Committed: https://chromium.googlesource.com/v8/v8/+/c9cb94a06fa7a863d24dd6760b66cecd55748abf TBR=bmeurer@chromium.org,jgruber@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5339 Review-Url: https://codereview.chromium.org/2592383002 Cr-Commit-Position: refs/heads/master@{#41915}
-
- 21 Dec, 2016 5 commits
-
-
gsathya authored
R=adamk@chromium.org Review-Url: https://codereview.chromium.org/2593243002 Cr-Commit-Position: refs/heads/master@{#41905}
-
gsathya authored
This patch also refactors most of PromiseThen into InternalPromiseThen to be reused with PromiseCatch and also changes InternalResolvePromise to return and not branch. BUG=v8:5343 Review-Url: https://codereview.chromium.org/2596553002 Cr-Commit-Position: refs/heads/master@{#41902}
-
jgruber authored
The two remaining uses of this intrinsic in debug.js and mirrors.js now simply rely on the runtime function. BUG=v8:5339 Review-Url: https://codereview.chromium.org/2591923003 Cr-Commit-Position: refs/heads/master@{#41892}
-
gsathya authored
BUG=v8:5343 Review-Url: https://codereview.chromium.org/2591033002 Cr-Commit-Position: refs/heads/master@{#41880}
-
gsathya authored
This removes RegExpPrototypeSpeciesGetter and IteratorPrototypeIterator and uses ReturnReceiver builtin instead. This patch also ports the PromiseSpecies to TF by reusing this builtin. BUG=v8:5343 Review-Url: https://codereview.chromium.org/2590373002 Cr-Commit-Position: refs/heads/master@{#41879}
-
- 20 Dec, 2016 2 commits
-
-
bmeurer authored
The %TypedArray% constructor must not ever try to construct an instance, but rather throw a TypeError instead. R=jarin@chromium.org BUG=v8:5763 Review-Url: https://codereview.chromium.org/2587413002 Cr-Commit-Position: refs/heads/master@{#41868}
-
littledan authored
The Intl implementation included manual checks to see if they were being called as a constructor. However, these checks are redundant, as %FunctionRemovePrototype has already marked the functions as un-constructable. This path removes the unnecessary checks. R=yangguo Review-Url: https://codereview.chromium.org/2587713002 Cr-Commit-Position: refs/heads/master@{#41867}
-