- 28 Jun, 2018 9 commits
-
-
jgruber authored
This is a reland of 7a0d6a50 Original change's description: > [build] Disable slow asserts for v8_enable_fast_mksnapshot > > Slow asserts double the time spent in mksnapshot. While we want them > enabled on our bot builds, local builds should be fast and don't > necessarily need them. > > This also adds v8_enable_fast_mksnapshot as default in gm.py. > > Bug: v8:7891,v8:6688 > Change-Id: I5ab1491f3396c4351de30dbbb80a81e2242c5db9 > Reviewed-on: https://chromium-review.googlesource.com/1116552 > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54074} TBR=jkummerow@chromium.org Bug: v8:7891, v8:6688 Change-Id: I3b1e80b3ca156b7d571ebc7f04e341f0ba716691 Reviewed-on: https://chromium-review.googlesource.com/1118139Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#54080}
-
jgruber authored
The multi-snapshot feature is only used on bots, where we need the ability to execute tests with/without mitigations controllable through a runtime flag. This disables the flag by default and only enables it on bot configs. Note: standard single-snapshot builds silently use the available snapshot regardless of the value of --untrusted-code-mitigations. Bug: v8:7891,v8:6688 Change-Id: I0d1a91e5c1c17b4d91b42d176b50ea44d2128d48 Reviewed-on: https://chromium-review.googlesource.com/1117687 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#54079}
-
Clemens Hammacher authored
We pass the {WasmModule} by non-const pointer and by non-const reference a lot. This violates the style guide, and adds the risk of accidentally modifying it. This CL makes the {WasmModule} const during compilation and instantiation. R=mstarzinger@chromium.org Bug: v8:7754 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ie1878322828b63284b341d97da595e8e91dd4f51 Reviewed-on: https://chromium-review.googlesource.com/1117194Reviewed-by:Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54078}
-
Jakob Gruber authored
This reverts commit 7a0d6a50. Reason for revert: Breaks no-slow-assert builds. Original change's description: > [build] Disable slow asserts for v8_enable_fast_mksnapshot > > Slow asserts double the time spent in mksnapshot. While we want them > enabled on our bot builds, local builds should be fast and don't > necessarily need them. > > This also adds v8_enable_fast_mksnapshot as default in gm.py. > > Bug: v8:7891,v8:6688 > Change-Id: I5ab1491f3396c4351de30dbbb80a81e2242c5db9 > Reviewed-on: https://chromium-review.googlesource.com/1116552 > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54074} TBR=jkummerow@chromium.org,jgruber@chromium.org Change-Id: I6b048e819846c4bd9a064f82e2f3c7609369cd33 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7891, v8:6688 Reviewed-on: https://chromium-review.googlesource.com/1118138Reviewed-by:
-
Michael Starzinger authored
This loads the stack limit address from the instance object instead of embedding it into the instruction stream. It is another piece towards making the generated code independent of the Isolate. R=clemensh@chromium.org BUG=v8:7424 Change-Id: I9381956adf2d7c42f6626708229cfdd5c4ca114f Reviewed-on: https://chromium-review.googlesource.com/1117189 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54076}
-
Michael Achenbach authored
This reverts commit 9cd33e9e. Reason for revert: Didn't add value. Original change's description: > [build] Temporarily make ubsan bot use no snapshot > > Currently mksnapshot fails due to ubsan issues. With a nosnap build it > will be easier to track down failures initially as normal test > failures, since mksnapshot isn't called with the sanitizer > environment variables. > > NOTRY=true > TBR=jgruber@chromium.org > > Bug: v8:7860 > Change-Id: I897a8d307d90f545c80a90e1e1a2a632ffae1c3e > Reviewed-on: https://chromium-review.googlesource.com/1116783 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54051} TBR=machenbach@chromium.org,jgruber@chromium.org Change-Id: I31e06fafb845c07bbaeb7a104d130f923d3be062 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7860 Reviewed-on: https://chromium-review.googlesource.com/1118039Reviewed-by:
-
jgruber authored
Slow asserts double the time spent in mksnapshot. While we want them enabled on our bot builds, local builds should be fast and don't necessarily need them. This also adds v8_enable_fast_mksnapshot as default in gm.py. Bug: v8:7891,v8:6688 Change-Id: I5ab1491f3396c4351de30dbbb80a81e2242c5db9 Reviewed-on: https://chromium-review.googlesource.com/1116552Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#54074}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/fde5d81..5fc0186 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/e82ab88..d96c633 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/a991ac6..b3853af TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: If6e75ab7bfac97aebaca75842a6d469a83277835 Reviewed-on: https://chromium-review.googlesource.com/1117923 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#54073}
-
Michael Achenbach authored
This reverts commit fdf69d53. Reason for revert: Speculative revert for broken GPU bots: https://ci.chromium.org/p/v8/builders/luci.v8.ci/Linux%20V8%20FYI%20Release%20%28NVIDIA%29/1638 https://ci.chromium.org/p/v8/builders/luci.v8.ci/Mac%20V8%20FYI%20Release%20%28Intel%29/1624 Original change's description: > [heap] Adds a young generation large object space > > This CL adds the young generation lage object spaces and a flag > --young-generation-large-objects that by default allocates all > large objects in this space. This is a preparation CL. The space > is not fully functional. > > Bug: chromium:852420 > Change-Id: Ib66d26fa52cda89bf04787084826aeb84b6ec1ac > Reviewed-on: https://chromium-review.googlesource.com/1099164 > Commit-Queue: Hannes Payer <hpayer@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54056} TBR=ulan@chromium.org,yangguo@chromium.org,hpayer@chromium.org Change-Id: I175514f806a19c7837022795210625ca40e3c318 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:852420 Reviewed-on: https://chromium-review.googlesource.com/1118038Reviewed-by:
-
- 27 Jun, 2018 27 commits
-
-
Sathya Gunasekaran authored
Rolling v8/test/test262/data: https://chromium.googlesource.com/external/github.com/tc39/test262/+log/330733e..a6c1d05 TBR=adamk@chromium.org,gsathya@chromium.org Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ia994bd405726120a369e841679ef6535ff6ae619 Reviewed-on: https://chromium-review.googlesource.com/1117100 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Mostyn Bramley-Moore authored
This is required for jumbo builds to work before the stable jumbo chunk algorithm[*] can reland. [*] https://chromium-review.googlesource.com/c/chromium/src/+/1102218 Bug: chromium:856964, chromium:782863 Change-Id: Ibbe0994980eb554acd4e1557e733d07526a90608 Reviewed-on: https://chromium-review.googlesource.com/1117059Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/12206d3..fde5d81 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/f989b62..e82ab88 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/c6e5ea2..de629a4 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I32e0cb2be85c85276be7403ae8832e3b7b849bc7 Reviewed-on: https://chromium-review.googlesource.com/1117376Reviewed-by:
-
Sathya Gunasekaran authored
Bug: v8:6443, v8:7569 Change-Id: Ia7e1ed9ab7e85ac366349688278ba59507d38b7e Reviewed-on: https://chromium-review.googlesource.com/1098474 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#54068}
-
Sergiy Byelozyorov authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/59ac9bd..12206d3 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/5941c1b..9c9fd97 Rolling v8/third_party/android_tools: https://chromium.googlesource.com/android_tools/+log/3545ab5..130499e Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/2e625dc..f989b62 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/d91a468..a991ac6 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: If880dd44606cbcbbf9e57ab46730ccfa844d5f84 Reviewed-on: https://chromium-review.googlesource.com/1116860Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Rodrigo Bruno authored
This is a reland of d4792e8f Original change's description: > [heap] Added per-page array buffer accouting (external memory). > > Bug: chromium:845409 > Change-Id: Ibc568cdc501edf5d84d9c6379aff58be069369af > Reviewed-on: https://chromium-review.googlesource.com/1114602 > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54028} Bug: chromium:845409 Change-Id: I6b11d7f66313bcbcc31be9217c1b780cf3eaee99 Reviewed-on: https://chromium-review.googlesource.com/1116638 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#54066}
-
Michael Starzinger authored
R=clemensh@chromium.org BUG=v8:7754 Change-Id: Ic6157ab1219bcdbdb6ac751d05602ab411d58ce2 Reviewed-on: https://chromium-review.googlesource.com/1117072 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
The name itself does not make sense any more since the {NativeModule} is shared across instances. It is also only used for debugging, so remove it, and replace it by the address of the {NativeModule} itself in debug output. R=mstarzinger@chromium.org Bug: v8:7754 Change-Id: I02f9252981b776934811a904287be31c7076e90b Reviewed-on: https://chromium-review.googlesource.com/1114965 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Tobias Tebbi authored
The motivation for this CL were the expensive UnhandledIsSorted() checks, which increase mksnapshot time (v8:7895). In addition, it is a cleanup and removes a potential for quadratic performance. Change-Id: I33e734e4e20183768dbf8222adcbb3abc1f1a6bf Reviewed-on: https://chromium-review.googlesource.com/1116960 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Stephan Herhut <herhut@chromium.org> Cr-Commit-Position: refs/heads/master@{#54063}
-
Vasili Skurydzin authored
Change-Id: Ib569f8587f18f91b89b4b8b824fa99cf1a5e6005 Reviewed-on: https://chromium-review.googlesource.com/1115359Reviewed-by:
-
Camillo Bruni authored
- Introduce ScriptEventType enum - Emit log event when deserializing scripts - Better handle deserialized and eval scripts when calculating the byte size Bug: chromium:757467, chromium:850038 Change-Id: I082161d8d1d4238a90d3607ca8b6b4e60f2f903e Reviewed-on: https://chromium-review.googlesource.com/1114845 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#54061}
-
Michael Starzinger authored
This fixes include violations where normal "foo.h" headers included inline "bar-inl.h" headers. It also removes two (almost) dead methods. R=clemensh@chromium.org BUG=v8:7754 Change-Id: I11c6ce71650db22f3c1d7cf5ca50529c94b94839 Reviewed-on: https://chromium-review.googlesource.com/1117076 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Since the Liftoff prologue is gone (https://crrev.com/c/1110222), this field is dead. R=mstarzinger@chromium.org Bug: v8:6600 Change-Id: I9d3e94a63087e7111939523c11fba4f009cecd54 Reviewed-on: https://chromium-review.googlesource.com/1116963Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: I01b0b4948973ebbe0386ae8ae08e722ad16bcab8 Reviewed-on: https://chromium-review.googlesource.com/1114616Reviewed-by:
-
Clemens Hammacher authored
Replace two more pairs of {std::unique_ptr} and {size_t} by {OwnedVector}. R=mstarzinger@chromium.org Change-Id: Ifdf03abf9759fbbb4adde76a494073625723a03d Reviewed-on: https://chromium-review.googlesource.com/1116785 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Hannes Payer authored
This CL adds the young generation lage object spaces and a flag --young-generation-large-objects that by default allocates all large objects in this space. This is a preparation CL. The space is not fully functional. Bug: chromium:852420 Change-Id: Ib66d26fa52cda89bf04787084826aeb84b6ec1ac Reviewed-on: https://chromium-review.googlesource.com/1099164 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Sergiy Byelozyorov authored
Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/f61e46d..172d331 This also disables the test that is broken by this roll. TBR=gsathya@chromium.org Bug: chromium:856119 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: If400b5b388b683d6e2d013673b53ca0c1b7572ce Reviewed-on: https://chromium-review.googlesource.com/1116794 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Jaroslav Sevcik authored
Bug: v8:7790 Change-Id: Ieeafcb7260ef577c3d64c029a50c2ed34b63fe1b Reviewed-on: https://chromium-review.googlesource.com/1116555Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#54054}
-
Dominik Inführ authored
This is a reland of 91f113e2 Original change's description: > Reland "[heap] Visit individual ephemerons instead of collections" > > This is a reland of 9aba0159 > > Original change's description: > > [heap] Visit individual ephemerons instead of collections > > > > When marking ephemerons visit individual ephemerons with key and value > > unreachable instead of simply iterating all ephemerons in all weak > > collections. Also visit ephemerons at end of concurrent marking to do > > work we would otherwise need to do in the atomic pause. > > > > Bug: chromium:844008 > > Change-Id: I3400ad1f81c0cdc0fe6506a1f1146a6743a7fcd7 > > Reviewed-on: https://chromium-review.googlesource.com/1113934 > > Commit-Queue: Dominik Inführ <dinfuehr@google.com> > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#54039} > > Bug: chromium:844008 > Change-Id: I4c44e74c7cf5fe380ffa4ce9f106bebb57bc023d > Reviewed-on: https://chromium-review.googlesource.com/1116438 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Dominik Inführ <dinfuehr@google.com> > Cr-Commit-Position: refs/heads/master@{#54046} Bug: chromium:844008 Change-Id: Ie9d606c51aacdfa9ffe77fe4cf780e30dd445d52 Reviewed-on: https://chromium-review.googlesource.com/1116639Reviewed-by:
-
Clemens Hammacher authored
We currently store the protected instructions per code object in a {std::unique_ptr<std::vector<ProtectedInstructionData>>}. This wastes memory, because it requires two heap allocations, plus the vector might over-allocate (and it currently does, because it is filled dynamically during compilation). This CL changes that to store the protected instructions in an {OwnedVector}. This requires one copy after generating the list of {ProtectedInstructionData} in an {std::vector} during compilation, but saves memory afterwards. R=mstarzinger@chromium.org Bug: chromium:856938 Change-Id: Ie290a17dc32f27fbbfe0c000a52297181c954550 Reviewed-on: https://chromium-review.googlesource.com/1116701Reviewed-by: -
Michael Achenbach authored
Currently mksnapshot fails due to ubsan issues. With a nosnap build it will be easier to track down failures initially as normal test failures, since mksnapshot isn't called with the sanitizer environment variables. NOTRY=true TBR=jgruber@chromium.org Bug: v8:7860 Change-Id: I897a8d307d90f545c80a90e1e1a2a632ffae1c3e Reviewed-on: https://chromium-review.googlesource.com/1116783Reviewed-by:
-
jgruber authored
We spend 2/3rds of all time in mksnapshot in UnhandledIsSorted. This was found by tikuta@ (see https://crbug.com/v8/7891#c15). This CL does two things: it optimizes the function a bit (it's now twice as fast), and turns all related DCHECKs into SLOW_DCHECKs, which means that they disabled by the v8_enable_fast_mksnapshot build flag. Bug: v8:7891, v8:6688, v8:7895 Change-Id: Iec2b230be39ec0a0ba0863f1153073e9bf1a47ce Reviewed-on: https://chromium-review.googlesource.com/1116556Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#54050}
-
Clemens Hammacher authored
R=mstarzinger@chromium.org Bug: v8:7754 Change-Id: I67ef360bcc4d49007e29036b49c87b6549e8d8e2 Reviewed-on: https://chromium-review.googlesource.com/1116778Reviewed-by:
-
Clemens Hammacher authored
{PrintCollection} can print any collection which is iterable via a standard for-each loop in C++. The output format of {4, 7, 11} is: [4, 7, 11] This helper avoids a few repetitions of manually outputting such collections. R=titzer@chromium.org Bug: v8:7754 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Iaa91e5465968a029815b3aa2b35948f711956cdb Reviewed-on: https://chromium-review.googlesource.com/1112005 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Dominik Inführ authored
This reverts commit 91f113e2. Reason for revert: still causes breakage on Chromium-integrated builds, failing here: CHECK_EQ(0, heap()->local_embedder_heap_tracer()->NumberOfWrappersToTrace()); Original change's description: > Reland "[heap] Visit individual ephemerons instead of collections" > > This is a reland of 9aba0159 > > Original change's description: > > [heap] Visit individual ephemerons instead of collections > > > > When marking ephemerons visit individual ephemerons with key and value > > unreachable instead of simply iterating all ephemerons in all weak > > collections. Also visit ephemerons at end of concurrent marking to do > > work we would otherwise need to do in the atomic pause. > > > > Bug: chromium:844008 > > Change-Id: I3400ad1f81c0cdc0fe6506a1f1146a6743a7fcd7 > > Reviewed-on: https://chromium-review.googlesource.com/1113934 > > Commit-Queue: Dominik Inführ <dinfuehr@google.com> > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#54039} > > Bug: chromium:844008 > Change-Id: I4c44e74c7cf5fe380ffa4ce9f106bebb57bc023d > Reviewed-on: https://chromium-review.googlesource.com/1116438 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Dominik Inführ <dinfuehr@google.com> > Cr-Commit-Position: refs/heads/master@{#54046} TBR=ulan@chromium.org,dinfuehr@google.com Change-Id: I4a059e86ba06e0b2562afc311b12d397cd78e857 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:844008 Reviewed-on: https://chromium-review.googlesource.com/1116718Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#54047}
-
Dominik Inführ authored
This is a reland of 9aba0159 Original change's description: > [heap] Visit individual ephemerons instead of collections > > When marking ephemerons visit individual ephemerons with key and value > unreachable instead of simply iterating all ephemerons in all weak > collections. Also visit ephemerons at end of concurrent marking to do > work we would otherwise need to do in the atomic pause. > > Bug: chromium:844008 > Change-Id: I3400ad1f81c0cdc0fe6506a1f1146a6743a7fcd7 > Reviewed-on: https://chromium-review.googlesource.com/1113934 > Commit-Queue: Dominik Inführ <dinfuehr@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54039} Bug: chromium:844008 Change-Id: I4c44e74c7cf5fe380ffa4ce9f106bebb57bc023d Reviewed-on: https://chromium-review.googlesource.com/1116438Reviewed-by:
-
Jakob Kummerow authored
This reverts commit 9aba0159. Reason for revert: causes widespread breakage on Chromium-integrated builds, failing here: CHECK_EQ(0, heap()->local_embedder_heap_tracer()->NumberOfWrappersToTrace()); in MarkCompactCollector::ProcessEphemeronMarking(). See e.g. https://logs.chromium.org/v/?s=chromium%2Fbb%2Fclient.v8.fyi%2FV8-Blink_Linux_64__dbg_%2F12321%2F%2B%2Frecipes%2Fsteps%2Fwebkit_unit_tests%2F0%2Fstdout and more on https://ci.chromium.org/p/v8/g/fyi/console Original change's description: > [heap] Visit individual ephemerons instead of collections > > When marking ephemerons visit individual ephemerons with key and value > unreachable instead of simply iterating all ephemerons in all weak > collections. Also visit ephemerons at end of concurrent marking to do > work we would otherwise need to do in the atomic pause. > > Bug: chromium:844008 > Change-Id: I3400ad1f81c0cdc0fe6506a1f1146a6743a7fcd7 > Reviewed-on: https://chromium-review.googlesource.com/1113934 > Commit-Queue: Dominik Inführ <dinfuehr@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54039} TBR=ulan@chromium.org,dinfuehr@google.com Change-Id: Ib44bfe8c49e8fc30c3d0f2beba03a2895530dfd6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:844008 Reviewed-on: https://chromium-review.googlesource.com/1116118Reviewed-by:
-
- 26 Jun, 2018 4 commits
-
-
Junliang Yan authored
R=joransiu@ca.ibm.com Change-Id: I9209d2cc1da2b7397fc11fd884d2b44851e734b0 Reviewed-on: https://chromium-review.googlesource.com/1115376Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#54044}
-
Bill Budge authored
This reverts commit d4792e8f. Reason for revert: Breaks V8 Linux - gc stress https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20gc%20stress/17056 Original change's description: > [heap] Added per-page array buffer accouting (external memory). > > Bug: chromium:845409 > Change-Id: Ibc568cdc501edf5d84d9c6379aff58be069369af > Reviewed-on: https://chromium-review.googlesource.com/1114602 > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54028} TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org,rfbpb@google.com Change-Id: I8664522a3155d73bac72c9949995d477d2885b8e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:845409 Reviewed-on: https://chromium-review.googlesource.com/1115481Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#54043}
-
Bill Budge authored
This reverts commit 6b810dad. Reason for revert: Depends on another change that is causing gc-stress to fail. Original change's description: > [heap] Updated spaces Verify to check external memory count. > > Bug: chromium:845409 > Change-Id: Ieb690f2d6ed699f306f1ff351cb5f62d9e2db860 > Reviewed-on: https://chromium-review.googlesource.com/1114820 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Cr-Commit-Position: refs/heads/master@{#54035} TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org,rfbpb@google.com Change-Id: I72fcebf5485b991872e375d4b7c3e4aa6f70c41b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:845409 Reviewed-on: https://chromium-review.googlesource.com/1115480Reviewed-by:
-
Bill Budge authored
This reverts commit e14086f0. Reason for revert: Breaks the build. There is another dependent change that must be reverted first. Original change's description: > Revert "[heap] Added per-page array buffer accouting (external memory)." > > This reverts commit d4792e8f. > > Reason for revert: Breaks V8 Linux - gc stress > > https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20gc%20stress/17056 > > Original change's description: > > [heap] Added per-page array buffer accouting (external memory). > > > > Bug: chromium:845409 > > Change-Id: Ibc568cdc501edf5d84d9c6379aff58be069369af > > Reviewed-on: https://chromium-review.googlesource.com/1114602 > > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#54028} > > TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org,rfbpb@google.com > > Change-Id: I9a354e72df1ab6782bd1c7c4d6b10194bcfaba2b > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:845409 > Reviewed-on: https://chromium-review.googlesource.com/1115478 > Reviewed-by: Bill Budge <bbudge@chromium.org> > Commit-Queue: Bill Budge <bbudge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54040} TBR=bbudge@chromium.org,ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org,rfbpb@google.com Change-Id: Iec078656ff3a79a9cee4de046215c55f908c62c7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:845409 Reviewed-on: https://chromium-review.googlesource.com/1115479Reviewed-by:
-
