Skip to content

V
V8
Switch branch/tag
  1. 15 Jan, 2015 1 commit
    • arv's avatar
      ES6 computed property names · 74e38e34
      arv authored 
      This adds support for computed property names, under the flag
--harmony-computed-property-names, for both object literals and
classes.

This is a revert of the revert, 7d48fd9d.

BUG=v8:3754
LOG=Y
R=dslomov@chromium.org

Review URL: https://codereview.chromium.org/798243004

Cr-Commit-Position: refs/heads/master@{#26084}
      74e38e34
  3. 18 Dec, 2014 1 commit
  5. 17 Dec, 2014 2 commits
  7. 16 Dec, 2014 2 commits
    • arv's avatar
      Revert of ES6 computed property names (patchset #1 id:1 of... · 5f22fdd5
      arv authored 
      Revert of ES6 computed property names (patchset #1 id:1 of https://codereview.chromium.org/807173002/)

Reason for revert:
Crashes Win32. It was not flake.

Original issue's description:
> ES6 computed property names
>
> This adds support for computed property names, under the flag
> --harmony-computed-property-names, for both object literals and
> classes.
>
> This is a revert of the revert, a76419f0 with
> no changes. I cannot reproduce the issue on Win8.1 or WinXP. Letting the bots
> try again.
>
> BUG=v8:3754
> LOG=Y
> TBR=dslomov@chromium.org

TBR=dslomov@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=v8:3754

Review URL: https://codereview.chromium.org/807033003

Cr-Commit-Position: refs/heads/master@{#25853}
      5f22fdd5
    • arv's avatar
      ES6 computed property names · a235b107
      arv authored 
      This adds support for computed property names, under the flag
--harmony-computed-property-names, for both object literals and
classes.

This is a revert of the revert, a76419f0 with
no changes. I cannot reproduce the issue on Win8.1 or WinXP. Letting the bots
try again.

BUG=v8:3754
LOG=Y
TBR=dslomov@chromium.org

Review URL: https://codereview.chromium.org/807173002

Cr-Commit-Position: refs/heads/master@{#25851}
      a235b107
  9. 15 Dec, 2014 2 commits
    • arv's avatar
      Revert of ES6 computed property names (patchset #9 id:160001 of... · a76419f0
      arv authored 
      Revert of ES6 computed property names (patchset #9 id:160001 of https://codereview.chromium.org/795573005/)

Reason for revert:
Crashes on Win32

http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%201/builds/1357

Test: mjsunit/harmony/computed-property-names
Flags: --stress-opt --always-opt
Command: build\Release\d8.exe --test --random-seed=-233815021 --stress-opt --always-opt --nohard-abort --nodead-code-elimination --nofold-constants --harmony-computed-property-names test\mjsunit\mjsunit.js test\mjsunit\harmony\computed-property-names.js

Run #1
Exit code: -1073741819
Result: CRASH
Expected outcomes: PASS

Run #2
Exit code: -1073741819
Result: CRASH
Expected outcomes: PASS

Run #3
Exit code: -1073741819
Result: CRASH
Expected outcomes: PASS

Original issue's description:
> ES6 computed property names
>
> This adds support for computed property names, under the flag
> --harmony-computed-property-names, for both object literals and
> classes.
>
> BUG=v8:3754
> LOG=Y

TBR=dslomov@chromium.org,wingo@igalia.com
NOTREECHECKS=true
NOTRY=true
BUG=v8:3754

Review URL: https://codereview.chromium.org/809433002

Cr-Commit-Position: refs/heads/master@{#25825}
      a76419f0
    • arv's avatar
      ES6 computed property names · 6e38caf8
      arv authored 
      This adds support for computed property names, under the flag
--harmony-computed-property-names, for both object literals and
classes.

BUG=v8:3754
LOG=Y

Review URL: https://codereview.chromium.org/795573005

Cr-Commit-Position: refs/heads/master@{#25821}
      6e38caf8
  11. 20 Nov, 2014 1 commit
  13. 18 Nov, 2014 1 commit
  15. 14 Nov, 2014 1 commit
  17. 12 Nov, 2014 1 commit
  19. 03 Nov, 2014 1 commit
  21. 24 Oct, 2014 1 commit
  23. 23 Oct, 2014 3 commits
  25. 21 Oct, 2014 4 commits
  27. 20 Oct, 2014 1 commit
  29. 09 Oct, 2014 1 commit
  31. 07 Oct, 2014 1 commit
  33. 16 Sep, 2014 2 commits
  35. 10 Sep, 2014 1 commit
  37. 22 Aug, 2014 1 commit
  39. 21 Aug, 2014 1 commit
    • marja@chromium.org's avatar
      Refactor parser Checkpoints. · ad3a1a99
      marja@chromium.org authored 
      Why this is better:

1) Not needing an extra template parameter for Checkpoints ctors. This was
especially confusing since the template parameter was named Parser and Parser is
also used as a type name and is also a concrete type. This CL makes it clear
that ParserTraits::Checkpoint is consturcted with ParserBase<ParserTraits> -
that's the only sensemaking type for the ctor param anyway.

2) This CL makes ParserBase define a Checkpoint base class (which knows how
to create and restore a checkpoint with ParserBase) which
PreParserTraits::Checkpoint and ParserTraits::Checkpoint inherit, and not the
other way around.

This is a more intuitive way to implement the "base functionality + extending
it" concept than the previous solution. The previous solution was to allow
Traits to define a Checkpoint class and make ParserBase<Traits>::ParserCheckpoint
(which defines the base functionality) inherit from it.

3) This CL moves the Checkpoint class definitions out of the SomeTraits::Type
struct; SomeTraits::Type is supposed to be a collection of typedefs and not
contain anything else.

Checkpoints were introduced in r22925 ( https://codereview.chromium.org/443903003 ).

BUG=
R=wingo@igalia.com

Review URL: https://codereview.chromium.org/485473004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23266 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      ad3a1a99
  41. 07 Aug, 2014 1 commit
  43. 04 Aug, 2014 1 commit
  45. 21 Jul, 2014 1 commit
  47. 10 Jul, 2014 1 commit
  49. 30 Jun, 2014 1 commit
  51. 20 Jun, 2014 1 commit
  53. 17 Jun, 2014 1 commit
  55. 03 Jun, 2014 1 commit
  57. 15 May, 2014 1 commit
  59. 29 Apr, 2014 1 commit
  61. 14 Apr, 2014 1 commit