- 15 Jan, 2015 1 commit
-
-
arv authored
This adds support for computed property names, under the flag --harmony-computed-property-names, for both object literals and classes. This is a revert of the revert, 7d48fd9d. BUG=v8:3754 LOG=Y R=dslomov@chromium.org Review URL: https://codereview.chromium.org/798243004 Cr-Commit-Position: refs/heads/master@{#26084}
-
- 18 Dec, 2014 1 commit
-
-
caitpotter88 authored
LOG=N BUG= R=arv@chromium.org, dslomov@chromium.org Review URL: https://codereview.chromium.org/812163003 Cr-Commit-Position: refs/heads/master@{#25895}
-
- 17 Dec, 2014 2 commits
-
-
machenbach authored
Revert of ES6 computed property names (patchset #1 id:1 of https://codereview.chromium.org/792233008/) Reason for revert: [sheriff] Still crashes on win32 (XP): http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%201/builds/1380 Original issue's description: > ES6 computed property names > > This adds support for computed property names, under the flag > --harmony-computed-property-names, for both object literals and > classes. > > This is a revert of the revert, a76419f0. > > This changes to do an early bailout in > HOptimizedGraphBuilder::VisitObjectLiteral instead of doing that in the later > loop. > > BUG=v8:3754 > LOG=Y > TBR=dslomov@chromium.org TBR=dslomov@chromium.org,arv@chromium.org NOTREECHECKS=true NOTRY=true BUG=v8:3754 Review URL: https://codereview.chromium.org/811593004 Cr-Commit-Position: refs/heads/master@{#25872}
-
arv authored
This adds support for computed property names, under the flag --harmony-computed-property-names, for both object literals and classes. This is a revert of the revert, a76419f0. This changes to do an early bailout in HOptimizedGraphBuilder::VisitObjectLiteral instead of doing that in the later loop. BUG=v8:3754 LOG=Y TBR=dslomov@chromium.org Review URL: https://codereview.chromium.org/792233008 Cr-Commit-Position: refs/heads/master@{#25868}
-
- 16 Dec, 2014 2 commits
-
-
arv authored
Revert of ES6 computed property names (patchset #1 id:1 of https://codereview.chromium.org/807173002/) Reason for revert: Crashes Win32. It was not flake. Original issue's description: > ES6 computed property names > > This adds support for computed property names, under the flag > --harmony-computed-property-names, for both object literals and > classes. > > This is a revert of the revert, a76419f0 with > no changes. I cannot reproduce the issue on Win8.1 or WinXP. Letting the bots > try again. > > BUG=v8:3754 > LOG=Y > TBR=dslomov@chromium.org TBR=dslomov@chromium.org NOTREECHECKS=true NOTRY=true BUG=v8:3754 Review URL: https://codereview.chromium.org/807033003 Cr-Commit-Position: refs/heads/master@{#25853}
-
arv authored
This adds support for computed property names, under the flag --harmony-computed-property-names, for both object literals and classes. This is a revert of the revert, a76419f0 with no changes. I cannot reproduce the issue on Win8.1 or WinXP. Letting the bots try again. BUG=v8:3754 LOG=Y TBR=dslomov@chromium.org Review URL: https://codereview.chromium.org/807173002 Cr-Commit-Position: refs/heads/master@{#25851}
-
- 15 Dec, 2014 2 commits
-
-
arv authored
Revert of ES6 computed property names (patchset #9 id:160001 of https://codereview.chromium.org/795573005/) Reason for revert: Crashes on Win32 http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%201/builds/1357 Test: mjsunit/harmony/computed-property-names Flags: --stress-opt --always-opt Command: build\Release\d8.exe --test --random-seed=-233815021 --stress-opt --always-opt --nohard-abort --nodead-code-elimination --nofold-constants --harmony-computed-property-names test\mjsunit\mjsunit.js test\mjsunit\harmony\computed-property-names.js Run #1 Exit code: -1073741819 Result: CRASH Expected outcomes: PASS Run #2 Exit code: -1073741819 Result: CRASH Expected outcomes: PASS Run #3 Exit code: -1073741819 Result: CRASH Expected outcomes: PASS Original issue's description: > ES6 computed property names > > This adds support for computed property names, under the flag > --harmony-computed-property-names, for both object literals and > classes. > > BUG=v8:3754 > LOG=Y TBR=dslomov@chromium.org,wingo@igalia.com NOTREECHECKS=true NOTRY=true BUG=v8:3754 Review URL: https://codereview.chromium.org/809433002 Cr-Commit-Position: refs/heads/master@{#25825}
-
arv authored
This adds support for computed property names, under the flag --harmony-computed-property-names, for both object literals and classes. BUG=v8:3754 LOG=Y Review URL: https://codereview.chromium.org/795573005 Cr-Commit-Position: refs/heads/master@{#25821}
-
- 20 Nov, 2014 1 commit
-
-
Andreas Rossberg authored
Also clean up flag names a little. Baseline: https://codereview.chromium.org/713413003/ R=arv@chromium.org, dslomov@chromium.org BUG= Review URL: https://codereview.chromium.org/722203006 Cr-Commit-Position: refs/heads/master@{#25435}
-
- 18 Nov, 2014 1 commit
-
-
dslomov authored
R=rossberg@chromium.org BUG=v8:2198 LOG=N Review URL: https://codereview.chromium.org/713413003 Cr-Commit-Position: refs/heads/master@{#25406}
-
- 14 Nov, 2014 1 commit
-
-
arv authored
Named class declarations and class expression have a const binding for the name that is in TDZ for the extends expression. BUG=v8:3330 LOG=Y R=dslomov@chromium.org, adamk Review URL: https://codereview.chromium.org/722793005 Cr-Commit-Position: refs/heads/master@{#25360}
-
- 12 Nov, 2014 1 commit
-
-
dslomov@chromium.org authored
1. Global{Context,Scope}=>Script{Context,Scope} 2. Enable fixed tests 3. Update comments R=rossberg@chromium.org BUG=v8:2198 LOG=N Review URL: https://codereview.chromium.org/716833002 Cr-Commit-Position: refs/heads/master@{#25291} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25291 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Nov, 2014 1 commit
-
-
arv@chromium.org authored
When --harmony-classes is enabled we did not treat static as a strict reserved word. BUG=v8:3642 LOG=Y R=rossberg@chromium.org Review URL: https://codereview.chromium.org/652743009 Cr-Commit-Position: refs/heads/master@{#25087} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25087 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 24 Oct, 2014 1 commit
-
-
dslomov@chromium.org authored
LOG=Y BUG=v8:3606 R=arv@chromium.org, marja@chromium.org Review URL: https://codereview.chromium.org/615813004 Patch from Caitlin Potter <caitpotter88@gmail.com>. Cr-Commit-Position: refs/heads/master@{#24880} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24880 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 23 Oct, 2014 3 commits
-
-
dslomov@chromium.org authored
R=rossberg@chromium.org BUG=v8:2506 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=24834 Review URL: https://codereview.chromium.org/671913002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24842 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dslomov@chromium.org authored
This reverts commit r24834 for breaking debug tests. TBR=bmeurer@chromium.org Review URL: https://codereview.chromium.org/672193002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24839 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dslomov@chromium.org authored
R=rossberg@chromium.org BUG=v8:2506 LOG=N Review URL: https://codereview.chromium.org/671913002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24834 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 21 Oct, 2014 4 commits
-
-
wingo@igalia.com authored
This will allow us to move expressions from one function to another, for example when the parser determines that a given cover grammar instance is actually the default value initializer for an arrow function. This is a re-land of https://codereview.chromium.org/636403003/ with a fix for the arm64 code generator. R=svenpanne@chromium.org BUG= Review URL: https://codereview.chromium.org/663373003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24769 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
svenpanne@chromium.org authored
This reverts r24757, which breaks the ARM64 simulator build. Simple repro: out/arm64.debug/d8 -e 'eval("(function(){ const x; var x; })")' TBR=bmeurer@chromium.org Review URL: https://codereview.chromium.org/652543006 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24762 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
svenpanne@chromium.org authored
This will allow us to move expressions from one function to another, for example when the parser determines that a given cover grammar instance is actually the default value initializer for an arrow function. R=svenpanne@chromium.org, marja@chromium.org BUG= Review URL: https://codereview.chromium.org/636403003 Patch from Andy Wingo <wingo@igalia.com>. git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24757 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
svenpanne@chromium.org authored
Basically a follow-up to https://codereview.chromium.org/667573005/. LOG=y R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/670673002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24755 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 20 Oct, 2014 1 commit
-
-
bmeurer@chromium.org authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/656143004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24735 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 09 Oct, 2014 1 commit
-
-
svenpanne@chromium.org authored
Every CompilationInfo has an ID generator now, and it is never reset/copied/assigned. Simplified FunctionState. R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/633373003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24481 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 07 Oct, 2014 1 commit
-
-
svenpanne@chromium.org authored
AST ids only need to be unique, so there is no need to fiddle around with them. R=dslomov@chromium.org Review URL: https://codereview.chromium.org/633053002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24433 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 16 Sep, 2014 2 commits
-
-
arv@chromium.org authored
This implements parsing for ClassExpression and ClassDeclaration. The runtime is not yet implemented and the value is currently hard coded to undefined. BUG=v8:3330 LOG=Y R=dslomov@chromium.org, marja@chromium.org, rossberg@chromium.org Review URL: https://codereview.chromium.org/561913002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23988 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
wingo@igalia.com authored
R=rossberg@chromium.org BUG=v8:2355 LOG=Y Review URL: https://codereview.chromium.org/573963003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23974 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Sep, 2014 1 commit
-
-
arv@chromium.org authored
This is governed by the harmony-object-literals flag. BUG=v8:3516 LOG=Y R=rossberg@chromium.org Review URL: https://codereview.chromium.org/477263002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23846 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 22 Aug, 2014 1 commit
-
-
arv@chromium.org authored
We were not correctly treating 1.0 as 1, nor 1.20 as 1.2 in accessors. BUG=v8:3507 LOG=Y R=marja@chromium.org Review URL: https://codereview.chromium.org/493173003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23321 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 21 Aug, 2014 1 commit
-
-
marja@chromium.org authored
Why this is better: 1) Not needing an extra template parameter for Checkpoints ctors. This was especially confusing since the template parameter was named Parser and Parser is also used as a type name and is also a concrete type. This CL makes it clear that ParserTraits::Checkpoint is consturcted with ParserBase<ParserTraits> - that's the only sensemaking type for the ctor param anyway. 2) This CL makes ParserBase define a Checkpoint base class (which knows how to create and restore a checkpoint with ParserBase) which PreParserTraits::Checkpoint and ParserTraits::Checkpoint inherit, and not the other way around. This is a more intuitive way to implement the "base functionality + extending it" concept than the previous solution. The previous solution was to allow Traits to define a Checkpoint class and make ParserBase<Traits>::ParserCheckpoint (which defines the base functionality) inherit from it. 3) This CL moves the Checkpoint class definitions out of the SomeTraits::Type struct; SomeTraits::Type is supposed to be a collection of typedefs and not contain anything else. Checkpoints were introduced in r22925 ( https://codereview.chromium.org/443903003 ). BUG= R=wingo@igalia.com Review URL: https://codereview.chromium.org/485473004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23266 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 07 Aug, 2014 1 commit
-
-
wingo@igalia.com authored
This enables for-of, as well as @@iterator implementations for strings and arrays. R=rossberg@chromium.org BUG=v8:2214 LOG=Y Review URL: https://codereview.chromium.org/446023002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22980 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Aug, 2014 1 commit
-
-
bmeurer@chromium.org authored
This way we don't clash with the ASSERT* macros defined by GoogleTest, and we are one step closer to being able to replace our homegrown base/ with base/ from Chrome. R=jochen@chromium.org, svenpanne@chromium.org Review URL: https://codereview.chromium.org/430503007 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22812 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 21 Jul, 2014 1 commit
-
-
rossberg@chromium.org authored
Implements code generation for arrow functions by desugaring them into a FunctionLiteral. For the moment, a normal FUNCTION_SCOPE is used, so "this" and "arguments" behave as in normal functions. Implementing the correct scoping rules is to be done later on. BUG=v8:2700 LOG= R=rossberg@chromium.org Review URL: https://codereview.chromium.org/382893003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22495 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Jul, 2014 1 commit
-
-
rossberg@chromium.org authored
All of our mjsunit suite now runs through with --harmony-scoping enabled, up to expected failures (tests checking syntax errors for const/function in strict mode). R=marja@chromium.org, ulan@chromium.org BUG=v8:2198 LOG=Y Review URL: https://codereview.chromium.org/378303003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22323 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 30 Jun, 2014 1 commit
-
-
jochen@chromium.org authored
Also split v8-core independent methods from checks.h to base/logging.h and merge v8checks with the rest of checks. The CPU::FlushICache method is moved to CpuFeatures::FlushICache RoundUp and related methods are moved to base/macros.h Remove all layering violations from src/libplatform BUG=none R=jkummerow@chromium.org LOG=n Review URL: https://codereview.chromium.org/358363002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22092 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 20 Jun, 2014 1 commit
-
-
mstarzinger@chromium.org authored
R=rossberg@chromium.org Review URL: https://codereview.chromium.org/333013002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21894 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 17 Jun, 2014 1 commit
-
-
marja@chromium.org authored
We used to allow any number of parameters in getters and setters to match JSC. This is a violation of ES5.1 and both SpiderMonkey and Chakra throw on these syntax errors. BUG=v8:3371 LOG=Y R=marja@chromium.org Review URL: https://codereview.chromium.org/329413002 Patch from Erik Arvidsson <arv@chromium.org>. git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21868 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Jun, 2014 1 commit
-
-
jochen@chromium.org authored
- this avoids using relative include paths which are forbidden by the style guide - makes the code more readable since it's clear which header is meant - allows for starting to use checkdeps BUG=none R=jkummerow@chromium.org, danno@chromium.org LOG=n Review URL: https://codereview.chromium.org/304153016 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21625 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 15 May, 2014 1 commit
-
-
marja@chromium.org authored
In some places, we pretended that there can be multiple arguments, though in practice there was only one. In other places (most importantly, PreParser), we only handled one argument. (This means that we were not able to produce a multi-argument error inside a lazy function anyway.) This CL makes it clear that there is ever only one argument. R=ulan@chromium.org BUG= Review URL: https://codereview.chromium.org/273653002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21324 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 29 Apr, 2014 1 commit
-
-
bmeurer@chromium.org authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/259183002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@21035 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 14 Apr, 2014 1 commit
-
-
marja@chromium.org authored
State of the art: - Chromium doesn't do a separate preparsing phase any more. - We start parsing with Parser, and when it sees a lazy function, it falls back to PreParser for that function. - The symbol data should contain symbols which are *outside* lazy functions. - So Parser should always produce symbol data, and PreParser should never. - Because it's this simple now, we don't need to keep track of "should produce symbol data" (i.e., whether we're inside a lazy func or not). R=ulan@chromium.org BUG= Review URL: https://codereview.chromium.org/222123003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20707 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-