- 27 Oct, 2017 22 commits
-
-
Mythri authored
We have a check on maximum number of levels that can be inlined. This in some cases causes performance cliffs, when we cannot inline a small function because it has exceeded the number of levels. This cl removes that check. The intuition is that, having gone down several levels in a particular line stopping inlining that chain and exploring a new call site may not be beneficial. Bug: v8:6871 Change-Id: I120056db38e78ce48dff010b6cf994259238582a Reviewed-on: https://chromium-review.googlesource.com/741705Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#49009}
-
Sathya Gunasekaran authored
Instead of creating a runtime call for the static class field initializer in the AST, we do it in the bytecode generator. This adds the initializer function to the ClassLiteral AST node. Bug: v8:5367 Change-Id: Iffaa6531511023812011ee19fc96cea9e5c9d3f3 Reviewed-on: https://chromium-review.googlesource.com/736315Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#49008}
-
Ross McIlroy authored
To avoid accessing the heap during asm.js compilation, use the pending error handler to store the pending warnings such that they can be reported later during finalization. As part of this change, refactor PendingCompilationErrorHandler to have a MessageDetails class holding details of either error or warning messages. BUG=v8:5203 Change-Id: I5b09254f8899b8dc57d94f1986c7183da847eae3 Reviewed-on: https://chromium-review.googlesource.com/735607 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#49007}
-
Georgia Kouveli authored
Bug: Change-Id: I41ce841cd20bab26de29437d4365f011c98ad53e Reviewed-on: https://chromium-review.googlesource.com/739392Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com> Cr-Commit-Position: refs/heads/master@{#49006}
-
Georgia Kouveli authored
This moves the handling of the receiver and the final spread argument into Generate_InterpreterPushArgs and merges the stack allocation to a single claim operation for the whole argument setup. When we start padding arguments in TF, we will simply need to claim one extra slot and store padreg to it in Generate_InterpreterPushArgs (hence the remaining TODO). This also replaces the single use of Generate_CheckStackOverflow with Generate_StackOverflowCheck and removes the former. This change is also done for arm, ia32 and x64. Bug: v8:6644 Change-Id: I8d06dda96dbc4a6f219b73c711f894320c2f6cdf Reviewed-on: https://chromium-review.googlesource.com/738031 Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com> Reviewed-by:
-
Toon Verwaest authored
This especially simplifies arm64 CallApiCallbackStub alignemnt handling. Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I26e9c075702161a3f1c70f94ec83d149d2d8f33a Reviewed-on: https://chromium-review.googlesource.com/741600Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#49004}
-
Sergiy Byelozyorov authored
This reverts commit 0b0bfc4b. Reason for revert: Breaks Chromium, see https://crrev.com/c/741484. Already reverted https://crrev.com/c/740083 before this. Original change's description: > [Memory] Unify POSIX memory management calls. > > - Moves base::OS memory management calls into platform-posix.cc, > using preprocessor to adjust for each platform. > > Bug: chromium:756050 > Change-Id: I2af4dce4379ad1fe9e22e5ab5c6d6a7faa3655b3 > Reviewed-on: https://chromium-review.googlesource.com/738890 > Commit-Queue: Bill Budge <bbudge@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48981} TBR=bbudge@chromium.org,ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org Change-Id: If4f62beec765e93c3618bd4824e2c1d4f6c0af4c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:756050 Reviewed-on: https://chromium-review.googlesource.com/741762Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#49003}
-
Sergiy Byelozyorov authored
This reverts commit 9ae967fe. Reason for revert: Breaks Chromium, see https://crrev.com/c/741484. Will also revert https://crrev.com/c/738890 after this. Original change's description: > Fix fuschia build. > > Bug:chromium:756050 > Change-Id: Ib65c9c4c19266eb1c6119367397be0769cfcc7a1 > > TBR=ulan@chromium.org > > Change-Id: Ib65c9c4c19266eb1c6119367397be0769cfcc7a1 > Reviewed-on: https://chromium-review.googlesource.com/740083 > Reviewed-by: Bill Budge <bbudge@chromium.org> > Commit-Queue: Bill Budge <bbudge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48984} TBR=bbudge@chromium.org,ulan@chromium.org,mlippautz@chromium.org,scottmg@chromium.org Change-Id: Ie4db6aeb231fe919969a19bbe51589e108127378 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:756050 Reviewed-on: https://chromium-review.googlesource.com/741761Reviewed-by:
-
Michael Achenbach authored
The status-file flags and the flags from the test case's source code must always overwrite extra flags set by bots. Bug: v8:6924 Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: I0e2aabb69da7cfb8ba6c1c79bd3851462071a6ac Reviewed-on: https://chromium-review.googlesource.com/732656 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#49001}
-
Andreas Rossberg authored
R=titzer@chromium.org Change-Id: Ie8c361efb48b56dc65719f09dfc79d505e0f3459 Reviewed-on: https://chromium-review.googlesource.com/735610 Commit-Queue: Andreas Rossberg <rossberg@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#49000}
-
Toon Verwaest authored
(This is a reland of cb84b6f6) This works in the ICs since compiled handlers are not shared anymore. Bug: chromium:759734 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I3b7d6ae34bb4cfa213f679354fac56fb51bfd5ed Reviewed-on: https://chromium-review.googlesource.com/739822Reviewed-by:
-
Ben L. Titzer authored
Because this test uses heap verification, it is quite slow. Split it into 4 smaller tests to avoid test timeout and allow them to be run in parallel. R=ahaas@chromium.org Bug: Change-Id: Ie4ac841d1d8215019bb5cfcc335daea6b10ab789 Reviewed-on: https://chromium-review.googlesource.com/738146Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#48998}
-
Michal Majewski authored
This is a reland of 5442e8b2 Original change's description: > Reland "Reuse arch/mode discovery in deopt fuzzer" > > This is a reland of a24c7c9a > Original change's description: > > Reuse arch/mode discovery in deopt fuzzer > > > > Bug: v8:6917 > > Change-Id: I1b7169c8702c8649812b17579d38d64de676ed60 > > Reviewed-on: https://chromium-review.googlesource.com/723420 > > Commit-Queue: Michał Majewski <majeski@google.com> > > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#48838} > > Bug: v8:6917 > Change-Id: I03b2c288257d44c2df9d0fa6cf4750d1c5719d59 > Reviewed-on: https://chromium-review.googlesource.com/735719 > Commit-Queue: Michał Majewski <majeski@google.com> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48916} Bug: v8:6917 Change-Id: I81419466d359b786c2a1b3a9aad3a86ed136f6f0 Reviewed-on: https://chromium-review.googlesource.com/738252Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michał Majewski <majeski@google.com> Cr-Commit-Position: refs/heads/master@{#48997}
-
Igor Sheludko authored
This should avoid changes in code serializer in a follow-up class literals improvement CL. Bug: v8:5799 Change-Id: I4e4386333bcc7abb30399d4e9abba4eee80ca932 Reviewed-on: https://chromium-review.googlesource.com/733037 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#48996}
-
Clemens Hammacher authored
This adds two tests to verify that the --liftoff flag has the indented effect, and that Liftoff compilation is off by default. R=titzer@chromium.org Bug: v8:6600 Change-Id: Ie7e13184b5068f572b78dbdf7abbcded6d859fc5 Reviewed-on: https://chromium-review.googlesource.com/733561 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
We now represent the SameValue operation explicitly in TurboFan and the operation can thus participate in all kinds of optimizations. Especially we get rid of the JSCall node in the general case, which blocks several optimizations across the call. The general, baseline performance is now always on par with StrictEqual. Once the StrictEqual operator is also a simplified operator, we should start unifying the type based optimizations in SimplifiedLowering. In the micro-benchmark we go from testStrictEqual: 1422 ms. testObjectIs: 1520 ms. testManualSameValue: 1759 ms. to testStrictEqual: 1426 ms. testObjectIs: 1357 ms. testManualSameValue: 1766 ms. which gives the expected result. Bug: v8:7007 Change-Id: I0de3ff6ff6209ab4c3edb69de6a16e387295a9c8 Reviewed-on: https://chromium-review.googlesource.com/741228Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#48994}
-
Georg Neis authored
... and use them to complete the BigInt function. Bug: v8:6791 Change-Id: Ia36db86b92d1a0cfcb783516e04d6c0e3750f194 Reviewed-on: https://chromium-review.googlesource.com/737643 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#48993}
-
Georg Neis authored
R=jkummerow@chromium.org Bug: v8:6791 Change-Id: I9eb5b9aeeb060d660ec41b7a3287089edd833197 Reviewed-on: https://chromium-review.googlesource.com/737796Reviewed-by:
-
Jakob Kummerow authored
Bug: v8:6791, v8:6995 Change-Id: I79d04d9e8fbe156570875e3ecc2a1a87c9a794ee Reviewed-on: https://chromium-review.googlesource.com/740918Reviewed-by:
-
Jaroslav Sevcik authored
This enables proper wiring into ithe control flow chain. Bug: v8:7002,chromium:777574 Change-Id: Idba59944ff6ab3c10c204bb74ace61d812e6297c Reviewed-on: https://chromium-review.googlesource.com/738183Reviewed-by:
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/f034b7d..e1ba03b Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/5da4837..52d748d Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/fb9e0ad..4ea1d22 TBR=machenbach@chromium.org,hablich@chromium.org Change-Id: Ifc6d7a2335abbff46a8e304067e26d101b90064d Reviewed-on: https://chromium-review.googlesource.com/741243Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#48989}
-
Camillo Bruni authored
This is an intermediate CL to move the complete --trace-map infrastructure to a log-based version. Change-Id: I0673052b1b87fe338e38dc609434a52af6a0652d Reviewed-on: https://chromium-review.googlesource.com/738835 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
- 26 Oct, 2017 18 commits
-
-
Alexei Filippov authored
This is a reland of c34042cc Original change's description: > [heap-profiler] Do not treat WeakMap values as weak. > > For the WeakHashTable objects only mark keys as weak while leaving values as strong references. > > BUG=chomium:773722 > > Change-Id: Iabd5ba293d05fe68a2af6503fcdd711ecc182482 > Reviewed-on: https://chromium-review.googlesource.com/730771 > Commit-Queue: Alexei Filippov <alph@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48985} TBR=ulan@chromium.org Bug: chomium:773722 Change-Id: Icede16fde528d147cde5c3f6c72f2029876b099f Reviewed-on: https://chromium-review.googlesource.com/740722Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#48987}
-
Alexei Filippov authored
This reverts commit c34042cc. Reason for revert: Wrong table type was used Original change's description: > [heap-profiler] Do not treat WeakMap values as weak. > > For the WeakHashTable objects only mark keys as weak while leaving values as strong references. > > BUG=chomium:773722 > > Change-Id: Iabd5ba293d05fe68a2af6503fcdd711ecc182482 > Reviewed-on: https://chromium-review.googlesource.com/730771 > Commit-Queue: Alexei Filippov <alph@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48985} TBR=ulan@chromium.org,alph@chromium.org,mlippautz@chromium.org Change-Id: Ia2ddef5b2422d4cbb8c4710e24ed0885a9a5b284 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chomium:773722 Reviewed-on: https://chromium-review.googlesource.com/740721Reviewed-by:
-
Alexei Filippov authored
For the WeakHashTable objects only mark keys as weak while leaving values as strong references. BUG=chomium:773722 Change-Id: Iabd5ba293d05fe68a2af6503fcdd711ecc182482 Reviewed-on: https://chromium-review.googlesource.com/730771 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
-
Bill Budge authored
Bug:chromium:756050 Change-Id: Ib65c9c4c19266eb1c6119367397be0769cfcc7a1 TBR=ulan@chromium.org Change-Id: Ib65c9c4c19266eb1c6119367397be0769cfcc7a1 Reviewed-on: https://chromium-review.googlesource.com/740083Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#48984}
-
Leszek Swirski authored
Add the --trace-feedback-updates flag (disabled by default, enabled by the v8_enable_trace_feedback_updates gn arg), which traces updates to feedback slots. Change-Id: Ib8f02f958e2adf04abda5d4ed680e29fa04895ab Reviewed-on: https://chromium-review.googlesource.com/725814Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#48983}
-
Georg Neis authored
Bug: v8:6791 Change-Id: I10bb316284ba3a0e326daad4f9b995f88d76c2a2 Reviewed-on: https://chromium-review.googlesource.com/739501Reviewed-by:
-
Bill Budge authored
- Moves base::OS memory management calls into platform-posix.cc, using preprocessor to adjust for each platform. Bug: chromium:756050 Change-Id: I2af4dce4379ad1fe9e22e5ab5c6d6a7faa3655b3 Reviewed-on: https://chromium-review.googlesource.com/738890 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#48981}
-
Toon Verwaest authored
This reverts commit cb84b6f6. Reason for revert: <INSERT REASONING HERE> Original change's description: > [lazy-accessor-pairs] Don't take the fast paths if the context needs to be switched > > This works in the ICs since compiled handlers are not shared anymore. > > As drive-by cleanup I also removed custom code to deal with compiled handler sharing for primitive and access-checked objects. > > Bug: chromium:759734 > Change-Id: Ifb394221c2398f42ea9305acc02845db6004c680 > Reviewed-on: https://chromium-review.googlesource.com/738381 > Commit-Queue: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48979} TBR=jarin@chromium.org,ishell@chromium.org,verwaest@chromium.org Change-Id: I9b7424252cbc3f18efd6b6b5b3818651c2863f5c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:759734 Reviewed-on: https://chromium-review.googlesource.com/739487Reviewed-by:
-
Toon Verwaest authored
This works in the ICs since compiled handlers are not shared anymore. As drive-by cleanup I also removed custom code to deal with compiled handler sharing for primitive and access-checked objects. Bug: chromium:759734 Change-Id: Ifb394221c2398f42ea9305acc02845db6004c680 Reviewed-on: https://chromium-review.googlesource.com/738381 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Igor Sheludko authored
Rename |property_attributes| to |initial_property_attributes| and ensure that it is used as a storage of values only for AccessorInfos installed in API Templates (i.e. ObjectTemplate and FunctionTemplate). When an AccessorInfo is installed directly into an existing JS object (via JSObject::SetAccessor) or into a DescriptorArray (when certain V8 objects' shapes are configured) it is not necessary to thread attributes being set through the AccessorInfo instance. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ibe61026f08c42549756f694129a286635ffe5769 Reviewed-on: https://chromium-review.googlesource.com/730425 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
jgruber authored
This is the first step towards lazy-deserializing bytecode handlers. Bytecode handler code objects are now serialized into the builtins snapshot area (which, like many other related concepts, has become somewhat of a misnomer now that it contains both builtins and handlers). Handlers are still eagerly-deserialized upon Isolate creation. This will change in follow-up CLs. Bug: v8:6624 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I7b257f76f5e9e90d5f7b183980bae7bc621171fc Reviewed-on: https://chromium-review.googlesource.com/738030 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Hannes Payer authored
Bug: chromium:774108,v8:6792 Change-Id: Ia312b8c6ca8608f8ac96e8caefd061900b40079b Reviewed-on: https://chromium-review.googlesource.com/739481Reviewed-by:
-
Daniel Clifford authored
Bug: chromium:778574 Change-Id: I014b16b9deabab07ca7dfb662ea8cb0dbf9c8987 Reviewed-on: https://chromium-review.googlesource.com/738148 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
This fixes jumbo build by renaming Pseudorandom function after https://chromium-review.googlesource.com/738204 Bug: chromium:777177 Change-Id: I86aa403928ad85ddd7dd779a8a43af9e34161928 Reviewed-on: https://chromium-review.googlesource.com/737637Reviewed-by:
-
Michael Starzinger authored
R=ulan@chromium.org Change-Id: I1ce0dbe909ffe3da784d5196e1c1d89f322f05c3 Reviewed-on: https://chromium-review.googlesource.com/739321Reviewed-by:
-
Hannes Payer authored
Bug: chromium:774108,v8:6792 Change-Id: I2bf361cab6da5e57302fb83d384b5f7e8e847c9a Reviewed-on: https://chromium-review.googlesource.com/738145Reviewed-by:
-
Michael Starzinger authored
This moves the initialization of the {Code::stub_key} field into the allocator for {Code} objects, essentially making the field in question immutable after allocation. R=verwaest@chromium.org BUG=v8:6792 Change-Id: I8ba2ffeea792d0d566995c08e3572ae63a7c1e94 Reviewed-on: https://chromium-review.googlesource.com/739141 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: -
Hannes Payer authored
Bug: chromium:774108,v8:6792 Change-Id: I7a458991921b5241c11db8999be433f4b33ce639 Reviewed-on: https://chromium-review.googlesource.com/738144Reviewed-by:
-
