- 15 Jan, 2019 1 commit
-
-
Leszek Swirski authored
This is more idiomatic than using a Promise. Change-Id: I61443e90ef1c0c589284851ea9be410153919eb5 Reviewed-on: https://chromium-review.googlesource.com/c/456278Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#58828}
-
- 09 Oct, 2018 1 commit
-
-
Jaroslav Sevcik authored
This addresses bunch of problems introduced by the attempt to remove indexing by function names https://chromium-review.googlesource.com/c/1267496. Now I tested with the right version of the file :-) Change-Id: Idfc8a17a0890d0453d14b949388c34c36a0b64f5 Reviewed-on: https://chromium-review.googlesource.com/c/1270575Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#56463}
-
- 08 Oct, 2018 1 commit
-
-
Jaroslav Sevcik authored
Using function ids is more reliable since there can be several functions or scripts with the same name. Also, that way we do not have to parse anything. Change-Id: If657141d0d6e27dabb49456e0275cce65e753541 Reviewed-on: https://chromium-review.googlesource.com/c/1267496Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#56431}
-
- 31 Aug, 2018 1 commit
-
-
Bret Sepulveda authored
If profiling is done with --log-source-code profview will now display a "View source" link for each function in the tree view. Clicking this will show a new source viewer, with sampled lines highlighted. See the associated bug for screenshots. This patch also fixes a bug in the profiler where the source info of only the first code object for each function would be logged, and includes some refactoring. Bug: v8:6240 Change-Id: Ib96a9cfc54543d0dc9bef4657cdeb96ce28b223c Reviewed-on: https://chromium-review.googlesource.com/1194231 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#55542}
-
- 23 Aug, 2018 1 commit
-
-
Bret Sepulveda authored
When switching log files, if a function was selected the timeline would attempt to draw its ticks and would usually crash. It would also preserve the selected section of the timeline. This patch wipes out the current state when loading a new log file, with the exception of the current mode (Summary, Bottom up, etc). As a consequence, the timeline size is now calculated in TimelineView.render so it will always be drawn at the right size. Bug: v8:6240 Change-Id: Ie15dd9b225901c8f4df614444458ae2aeaf74ccc Reviewed-on: https://chromium-review.googlesource.com/1186340Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#55339}
-
- 14 Aug, 2018 1 commit
-
-
Bret Sepulveda authored
Previously, when given a log with few ticks, the timeline would lump them all into one or two buckets. This patch allows ticks to be assigned to buckets more sparsely. This patch also fixes a bug where there was a gap on the right side of the timeline, which also caused the function tick marks to be slightly misaligned. This was more noticable with fewer buckets. Bug: v8:6240 Change-Id: Ib7353c0420caec8591590815271d329ea1a030fb Reviewed-on: https://chromium-review.googlesource.com/1174440 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#55125}
-
- 13 Aug, 2018 2 commits
-
-
Bret Sepulveda authored
This patch also includes some CSS tweaks and other minor cleanup. Bug: v8:6240 Change-Id: I86e26fe53465dff6f9a706f58e565b1f1ee559da Reviewed-on: https://chromium-review.googlesource.com/1172360 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#55089}
-
Bret Sepulveda authored
This patch reshuffles the colors used for the various tick categories in the visualization. Category rows are now light gray. The new colors are taken from the Material palette. See screenshots on the associated bug. This patch also labels the GC bucket as such, instead of having the same label as uncategorized C++. Bug: v8:6240 Change-Id: I3909a177148b98e99d63f5ec9ae02e3c6f63eb24 Reviewed-on: https://chromium-review.googlesource.com/1172139 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#55078}
-
- 08 Nov, 2017 1 commit
-
-
Franziska Hinkelmann authored
Use !== instead of !=. Bug: Change-Id: I3f8127d54b80973f9ea7bb6ddf25afd928cb3045 Reviewed-on: https://chromium-review.googlesource.com/753733Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> Cr-Commit-Position: refs/heads/master@{#49210}
-
- 10 Aug, 2017 1 commit
-
-
Leszek Swirski authored
Rather than lumping in parsing, bytecode compilation and optimized compilation all into the same VM "compile" state, seperate them out into individual states. Additionally, add support for these states to tickprocessor and profview. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I5be943e23cae042e32e9ccb24415c67c18658b4b Reviewed-on: https://chromium-review.googlesource.com/608973 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#47283}
-
- 11 Apr, 2017 1 commit
-
-
jarin authored
Review-Url: https://codereview.chromium.org/2811953003 Cr-Commit-Position: refs/heads/master@{#44561}
-
- 22 Mar, 2017 1 commit
-
-
jarin authored
This adds optimization and deoptimization counts to the Web UI. Also, the function timeline now shows optimization and deoptimization marks. Review-Url: https://codereview.chromium.org/2753543006 Cr-Commit-Position: refs/heads/master@{#44033}
-
- 17 Mar, 2017 1 commit
-
-
Leszek Swirski authored
When displaying a single function's timeline, display all its variants (colour-coded by kind) instead of just the ones with the same code-id. This allows us to see all optimised versions of a function, as well as changes between optimised and unoptimised. Drive-by -- Do some rounding to get rendering pixel-perfect. Change-Id: I385c83b39414ac5e59208b7a25b488d6a283e2b0 NOTRY=true Change-Id: I385c83b39414ac5e59208b7a25b488d6a283e2b0 Reviewed-on: https://chromium-review.googlesource.com/455833 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#43894}
-
- 08 Mar, 2017 1 commit
-
-
leszeks authored
Adds a bar below the current timeline view which can show the time when an individual function was on the stack. Functions in the call stack are now clickable to show them in this view. Sections where the function was on the stack, but not at the top, are displayed at half height. Review-Url: https://codereview.chromium.org/2737083003 Cr-Commit-Position: refs/heads/master@{#43673}
-
- 07 Mar, 2017 1 commit
-
-
jarin authored
Review-Url: https://codereview.chromium.org/2732883004 Cr-Commit-Position: refs/heads/master@{#43639}
-
- 06 Mar, 2017 2 commits
-
-
jarin authored
Review-Url: https://codereview.chromium.org/2736723003 Cr-Commit-Position: refs/heads/master@{#43614}
-
jarin authored
The function list is now filtered by category by default, and sorting improved to break ties better. Since the butterfly trees get massive, I had to start expanding the call trees on demand. This is implemented by keeping track of all ticks that cross given tree node (+ position where they crosses it). This seems to work quite well - in subsequent CL, I am planning to flip the bottom-up and top-down trees to use this. Review-Url: https://codereview.chromium.org/2730293002 Cr-Commit-Position: refs/heads/master@{#43602}
-
- 04 Mar, 2017 1 commit
-
-
jarin authored
Improvements: - top-down call tree. - interactive restriction to time interval. Review-Url: https://codereview.chromium.org/2696903002 Cr-Commit-Position: refs/heads/master@{#43599}
-