1. 20 Mar, 2019 1 commit
  2. 20 Feb, 2019 1 commit
  3. 19 Feb, 2019 1 commit
  4. 06 Feb, 2019 2 commits
    • Tamer Tas's avatar
      [testrunner] migrate testsuites to lazy loading · 8c30a2cc
      Tamer Tas authored
      V8 test suites return tests by loading them into memory up-front. Up-front
      loading has memory and loading-time overhead for the testrunner.
      
      This CL converts the test-suites to load tests during the test run in parallel.
      
      After CL, most test suites start running immediately and all test suites start
      running after 3 seconds on a modern SSD.
      
      This CL eliminates the 200 MiB memory spikes that causes memory problems in mac
      minis.
      
      Overhead of running test262 before CL:
      Line #    Mem usage     Increment   Line Contents
      =================================================
         264  225.760 MiB 195.8.000 MiB         tests = self._load_testsuite_generators(args, options)
      -------------------------------------------------
      Overhead of running test262 after CL:
      Line #    Mem usage    Increment   Line Contents
      ================================================
         264   28.840 MiB    0.000 MiB         tests = self._load_testsuite_generators(args, options)
      -------------------------------------------------
      
      R=machenbach@chromium.org
      CC=​​​yangguo@chromium.org,sergiyb@chromium.org
      
      Bug: v8:8174, v8:8552, v8:8728
      Change-Id: Iab540b9410239b05dc80b4a5228db25d8b8fb3b9
      Reviewed-on: https://chromium-review.googlesource.com/c/1454478
      Commit-Queue: Tamer Tas <tmrts@chromium.org>
      Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Reviewed-by: 's avatarSergiy Belozorov <sergiyb@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#59408}
      8c30a2cc
    • Tamer Tas's avatar
      Reland "Reland "[test] refactor testsuite configuration"" · df630e67
      Tamer Tas authored
      This is a reland of 81eec150
      
      Original change's description:
      > Reland "[test] refactor testsuite configuration"
      >
      > This is a reland of 7f92ad0a
      >
      > Original change's description:
      > > [test] refactor testsuite configuration
      > >
      > > Every testsuite configuration consist of at least 30% code duplication.
      > >
      > > The code age ranges from 10 years old to 5 years old. Implementing anything that
      > > touches the testsuite code becomes a technical fight to the death.
      > >
      > > This CL removes all the duplication by refactoring the common functionality.
      > >
      > > This CL contains structural changes without any logical changes % small bug
      > > fixes.
      > >
      > > R=machenbach@chromium.org
      > > CC=yangguo@chromium.org,sergiyb@chromium.org
      > >
      > > Bug: v8:8174, v8:8769
      > > Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2
      > > Reviewed-on: https://chromium-review.googlesource.com/c/1445881
      > > Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org>
      > > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#59361}
      >
      > Bug: v8:8174, v8:8769
      > Change-Id: I8e7078cfb875ceb3777e57084e6f8dfac09693e7
      > Reviewed-on: https://chromium-review.googlesource.com/c/1454485
      > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > Commit-Queue: Tamer Tas <tmrts@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#59369}
      
      Bug: v8:8174, v8:8790
      Change-Id: I38ab9d37bca76057441a970f26e2102e4387a857
      Reviewed-on: https://chromium-review.googlesource.com/c/1454724
      Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#59387}
      df630e67
  5. 05 Feb, 2019 4 commits
    • Tamer Tas's avatar
      Revert "Reland "[test] refactor testsuite configuration"" · ea4412ad
      Tamer Tas authored
      This reverts commit 81eec150.
      
      Reason for revert: windows mozilla test failures
      
      Original change's description:
      > Reland "[test] refactor testsuite configuration"
      > 
      > This is a reland of 7f92ad0a
      > 
      > Original change's description:
      > > [test] refactor testsuite configuration
      > > 
      > > Every testsuite configuration consist of at least 30% code duplication.
      > > 
      > > The code age ranges from 10 years old to 5 years old. Implementing anything that
      > > touches the testsuite code becomes a technical fight to the death.
      > > 
      > > This CL removes all the duplication by refactoring the common functionality.
      > > 
      > > This CL contains structural changes without any logical changes % small bug
      > > fixes.
      > > 
      > > R=machenbach@chromium.org
      > > CC=yangguo@chromium.org,sergiyb@chromium.org
      > > 
      > > Bug: v8:8174, v8:8769
      > > Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2
      > > Reviewed-on: https://chromium-review.googlesource.com/c/1445881
      > > Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org>
      > > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#59361}
      > 
      > Bug: v8:8174, v8:8769
      > Change-Id: I8e7078cfb875ceb3777e57084e6f8dfac09693e7
      > Reviewed-on: https://chromium-review.googlesource.com/c/1454485
      > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > Commit-Queue: Tamer Tas <tmrts@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#59369}
      
      TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org
      
      Change-Id: I8f5650b5f46be299c004e2fa8b708fa2c17a4dc2
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:8174, v8:8769
      Reviewed-on: https://chromium-review.googlesource.com/c/1454607Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Commit-Queue: Tamer Tas <tmrts@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#59370}
      ea4412ad
    • Tamer Tas's avatar
      Reland "[test] refactor testsuite configuration" · 81eec150
      Tamer Tas authored
      This is a reland of 7f92ad0a
      
      Original change's description:
      > [test] refactor testsuite configuration
      > 
      > Every testsuite configuration consist of at least 30% code duplication.
      > 
      > The code age ranges from 10 years old to 5 years old. Implementing anything that
      > touches the testsuite code becomes a technical fight to the death.
      > 
      > This CL removes all the duplication by refactoring the common functionality.
      > 
      > This CL contains structural changes without any logical changes % small bug
      > fixes.
      > 
      > R=machenbach@chromium.org
      > CC=yangguo@chromium.org,sergiyb@chromium.org
      > 
      > Bug: v8:8174, v8:8769
      > Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2
      > Reviewed-on: https://chromium-review.googlesource.com/c/1445881
      > Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org>
      > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#59361}
      
      Bug: v8:8174, v8:8769
      Change-Id: I8e7078cfb875ceb3777e57084e6f8dfac09693e7
      Reviewed-on: https://chromium-review.googlesource.com/c/1454485Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Commit-Queue: Tamer Tas <tmrts@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#59369}
      81eec150
    • Tamer Tas's avatar
      Revert "[test] refactor testsuite configuration" · 97068800
      Tamer Tas authored
      This reverts commit 7f92ad0a.
      
      Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win32/19148
      
      Original change's description:
      > [test] refactor testsuite configuration
      >
      > Every testsuite configuration consist of at least 30% code duplication.
      >
      > The code age ranges from 10 years old to 5 years old. Implementing anything that
      > touches the testsuite code becomes a technical fight to the death.
      >
      > This CL removes all the duplication by refactoring the common functionality.
      >
      > This CL contains structural changes without any logical changes % small bug
      > fixes.
      >
      > R=​machenbach@chromium.org
      > CC=​yangguo@chromium.org,sergiyb@chromium.org
      >
      > Bug: v8:8174, v8:8769
      > Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2
      > Reviewed-on: https://chromium-review.googlesource.com/c/1445881
      > Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org>
      > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#59361}
      
      TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org,v8-reviews@chromium.org
      
      Change-Id: I473f0d4c6b9c0239923b8c03699dbc38b7f85030
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:8174, v8:8769
      Reviewed-on: https://chromium-review.googlesource.com/c/1454599
      Commit-Queue: Tamer Tas <tmrts@chromium.org>
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#59362}
      97068800
    • Tamer Tas's avatar
      [test] refactor testsuite configuration · 7f92ad0a
      Tamer Tas authored
      Every testsuite configuration consist of at least 30% code duplication.
      
      The code age ranges from 10 years old to 5 years old. Implementing anything that
      touches the testsuite code becomes a technical fight to the death.
      
      This CL removes all the duplication by refactoring the common functionality.
      
      This CL contains structural changes without any logical changes % small bug
      fixes.
      
      R=machenbach@chromium.org
      CC=yangguo@chromium.org,sergiyb@chromium.org
      
      Bug: v8:8174, v8:8769
      Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2
      Reviewed-on: https://chromium-review.googlesource.com/c/1445881
      Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org>
      Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#59361}
      7f92ad0a
  6. 11 Sep, 2018 1 commit
  7. 01 Feb, 2018 1 commit
  8. 31 Jan, 2018 2 commits
  9. 30 Jan, 2018 2 commits
  10. 19 Dec, 2017 1 commit
  11. 13 Dec, 2017 2 commits
  12. 12 Dec, 2017 1 commit
  13. 04 Dec, 2017 1 commit
    • Michal Majewski's avatar
      Reland "Reland "[test] Creating command before execution phase."" · 68c5d01a
      Michal Majewski authored
      This is a reland of 3b065110
      Original change's description:
      > Reland "[test] Creating command before execution phase."
      > 
      > This is a reland of 98cc9e86
      > Original change's description:
      > > [test] Creating command before execution phase.
      > > 
      > > Immutable command class with shell, flags and
      > > environment.
      > > 
      > > Command creation moved from worker to the main
      > > process. Because of that there is no need to send
      > > test cases beyond process boundaries and load test
      > > suites in worker processes.
      > > 
      > > Bug: v8:6917
      > > Change-Id: Ib6a44278095b4f7141eb9b96802fe3e8117678a6
      > > Reviewed-on: https://chromium-review.googlesource.com/791710
      > > Commit-Queue: Michał Majewski <majeski@google.com>
      > > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#49746}
      > 
      > Bug: v8:6917
      > Change-Id: I49c29a8db813c47909f2cc45070ac7721a447c7a
      > Reviewed-on: https://chromium-review.googlesource.com/800370
      > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > Commit-Queue: Michał Majewski <majeski@google.com>
      > Cr-Commit-Position: refs/heads/master@{#49756}
      
      Bug: v8:6917
      Change-Id: Ia39010a0a0f63537ad12490dfab17897d70d4930
      Reviewed-on: https://chromium-review.googlesource.com/806034Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Commit-Queue: Michał Majewski <majeski@google.com>
      Cr-Commit-Position: refs/heads/master@{#49830}
      68c5d01a
  14. 01 Dec, 2017 1 commit
  15. 30 Nov, 2017 3 commits
  16. 16 Nov, 2017 2 commits
  17. 27 Oct, 2017 1 commit
  18. 16 Oct, 2017 1 commit
  19. 31 Mar, 2016 1 commit
    • machenbach's avatar
      [test] Fix deterministic test shards. · a0aac3cb
      machenbach authored
      Test case objects were sorted without key function, resulting
      in random sort order. On sharded builds, the shards are
      determined by the sort order and rely on a deterministic
      sorting. This led to random cctest and unittest cases being
      dropped or executed twice on sharded testers.
      
      TBR=jkummerow@chromium.org, hablich@chromium.org
      
      Review URL: https://codereview.chromium.org/1842673002
      
      Cr-Commit-Position: refs/heads/master@{#35151}
      a0aac3cb
  20. 10 Mar, 2016 1 commit
  21. 02 Mar, 2016 1 commit
  22. 27 Nov, 2015 1 commit
  23. 26 Mar, 2014 1 commit
  24. 18 Apr, 2013 1 commit
  25. 09 Apr, 2013 1 commit
  26. 29 Jan, 2013 1 commit
  27. 23 Jan, 2013 1 commit
  28. 18 Jan, 2013 1 commit
  29. 19 Oct, 2012 1 commit
  30. 24 Sep, 2012 1 commit