1. 17 Feb, 2022 1 commit
  2. 03 Nov, 2021 1 commit
    • Anton Bikineev's avatar
      cppgc: Force EBO to always work with GCed · 92eae6d1
      Anton Bikineev authored
      Currently, in the following struct
      
      struct LayoutObject : GarbageCollected<>, MixinA, MixinB {};
      
      the subobject that corresponds to the first base GarbageCollected<>
      always takes up some space (one word). The empty-base-optimization
      doesn't happen because the second base (MixinA) has the same subobject
      as the first base (GarbageCollected), which is the most parent class
      GarbageCollectedBase. The compiler can't "merge" them because it must
      guarantee that distinct objects of the same type have distinct
      addresses.
      
      The attribute [[no_unique_address]] doesn't work for base classes,
      unfortunately (but is a good idea for a Standard proposal). As a
      solution, the CL simply removes GarbageCollectedBase.
      
      Bug: chromium:1260797
      Change-Id: I415b10a5fbcebce3d6ee97b8870ea9ae90f383a8
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259654
      Commit-Queue: Anton Bikineev <bikineev@chromium.org>
      Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#77693}
      92eae6d1
  3. 11 Mar, 2021 1 commit
  4. 19 Oct, 2020 1 commit
  5. 10 Jul, 2020 1 commit
  6. 03 Jul, 2020 1 commit
  7. 13 May, 2020 1 commit
  8. 21 Apr, 2020 1 commit
  9. 20 Apr, 2020 1 commit
  10. 14 Apr, 2020 2 commits
  11. 08 Apr, 2020 1 commit
  12. 07 Apr, 2020 1 commit
  13. 01 Apr, 2020 1 commit
  14. 27 Mar, 2020 1 commit