1. 16 Jan, 2019 1 commit
    • Jakob Gruber's avatar
      [nojit] Convert generated memcpy functions into builtins · 61cb1133
      Jakob Gruber authored
      On ia32, arm and mips we generate miscellaneous memcpy-related functions
      at runtime:
      
      arm: memcpy for uint8-uint8 and uint16-uint8 {dest-source} pairs.
      ia32: memmove
      mips: memcpy uint8-uint8
      
      In jitless mode, runtime codegen is disallowed, so these must be
      converted into builtins.
      
      As far as I can tell, the mips64 files were dead code (#ifdef'd to
      V8_HOST_ARCH_MIPS instead of MIPS64).
      
      Note also the slightly changed implementation of ia32's MemMove's
      jump tables.
      
      Bug: v8:8675
      Change-Id: I5dc2a50fcbad332ce9f78228425b987b0d9acdf3
      Reviewed-on: https://chromium-review.googlesource.com/c/1407067Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#58839}
      61cb1133
  2. 14 Jan, 2019 1 commit
    • Jakob Gruber's avatar
      Revert "[ia32] Remove custom MemMove function" · 9eb278b8
      Jakob Gruber authored
      This reverts commit 4a9f186b.
      
      Reason for revert: Regresses microbenchmarks. https://crbug.com/v8/8675#c5
      
      Original change's description:
      > [ia32] Remove custom MemMove function
      > 
      > It isn't clear whether our custom generated MemMove function provides
      > any benefits over std::memmove. This is an attempt to remove it. If
      > bots seem unhappy we can revert.
      > 
      > Bug: v8:7777,v8:8675
      > Change-Id: I7f1a6e3050b6e635618593c04f7d51e448426ee2
      > Reviewed-on: https://chromium-review.googlesource.com/c/1405854
      > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#58748}
      
      TBR=jkummerow@chromium.org,jgruber@chromium.org
      
      # Not skipping CQ checks because original CL landed > 1 day ago.
      
      Bug: v8:7777, v8:8675
      Change-Id: Ia4ad37070f433f76b1158e90835162aefe38abdd
      Reviewed-on: https://chromium-review.googlesource.com/c/1407063Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#58766}
      9eb278b8
  3. 11 Jan, 2019 1 commit
  4. 29 Nov, 2018 1 commit