- 29 Jan, 2019 1 commit
-
-
Simon Zünd authored
This CL extends the kCircularStructure error message to include the constructors and keys involved in the circle: const a = {}; a.arr = []; a.arr[0] = a; JSON.stringify(a); TypeError: Converting circular structure to JSON --> starting at object with constructor 'Object' | property 'arr' -> object with constructor 'Array' --- index 0 closes the circle R=gsathya@chromium.org, yangguo@chromium.org Bug: v8:6513, v8:8696 Change-Id: I393aa3ce47d8bfd03734fccac63445006940ef7a Reviewed-on: https://chromium-review.googlesource.com/c/1433776Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#59152}
-
- 04 Jan, 2019 2 commits
-
-
Sigurd Schneider authored
Clang is known to use a lot of stack space for Debug builds, so this patch lowers the recursion depth of that test. Failing bot: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20full%20debug First failing run: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20full%20debug/6606 Change-Id: Ib1da016b190fa0d9d7d38bced19f600a284c7f01 Reviewed-on: https://chromium-review.googlesource.com/c/1396079 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#58555}
-
Mathias Bynens authored
The reference implementation used in the tests does not fully match the spec, so for the diverging cases we need to explicitly specify the correct expectation. Every single change in this patch has been verified against every major JavaScript engine using eshost + jsvu. All implementations match the spec (and the V8 implementation), with the following two exceptions: - One expectation was wrong because of a JavaScriptCore bug (that is, we inherited the incorrect expectation when importing the tests from WebKit). A comment was added for that one. - This work resulted in the discovery of bugs in Moddable/XS: https://github.com/Moddable-OpenSource/moddable/issues/112 Change-Id: I05d91d7acc5c8765e941fcd68c1086c2694c710c Reviewed-on: https://chromium-review.googlesource.com/c/1396081Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#58546}
-
- 14 Nov, 2018 1 commit
-
-
Jakob Kummerow authored
Clang is known to use a lot of stack space for Debug builds, so this patch lowers the recursion depth of that test after recent changes made Debug-mode stack frames a bit larger. a bit of Debug-mode stack space. Bonus: drops an unnecessary cast from SerializeJSObject to save Change-Id: I22696a1d80a6a73b5049b018e72cc8a3d8693042 Reviewed-on: https://chromium-review.googlesource.com/c/1334448Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#57516}
-
- 16 Oct, 2018 2 commits
-
-
Mathias Bynens authored
This is a reland of 0d91db0b. Proposal repository: https://github.com/tc39/proposal-well-formed-stringify Intent to ship: https://groups.google.com/d/msg/v8-users/IRu3bAC_pLM/pFwz2ti1AgAJ TBR=gsathya@chromium.org Bug: v8:7782 Change-Id: I53d006650e2b4099a111d2e5bc067e4a2c7cf4a0 Reviewed-on: https://chromium-review.googlesource.com/c/1282993Reviewed-by: Mathias Bynens <mathias@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#56689}
-
Mathias Bynens authored
This reverts commit 0d91db0b. Reason for revert: <INSERT REASONING HERE> Original change's description: > Ship well-formed JSON.stringify
> > Proposal repository: > https://github.com/tc39/proposal-global > > Intent to ship: > https://groups.google.com/d/msg/v8-users/IRu3bAC_pLM/pFwz2ti1AgAJ > > Bug: v8:7782 > Change-Id: Iaf790f134917796deac0e84cc931828934a6e589 > Reviewed-on: https://chromium-review.googlesource.com/c/1260122 > Commit-Queue: Mathias Bynens <mathias@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56650} TBR=gsathya@chromium.org,mathias@chromium.org Change-Id: Ie214a72a01fa81f754fd411808eb0bb748f89dbb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7782 Reviewed-on: https://chromium-review.googlesource.com/c/1282563Reviewed-by: Mathias Bynens <mathias@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#56663}
-
- 15 Oct, 2018 1 commit
-
-
Mathias Bynens authored
Proposal repository: https://github.com/tc39/proposal-global Intent to ship: https://groups.google.com/d/msg/v8-users/IRu3bAC_pLM/pFwz2ti1AgAJ Bug: v8:7782 Change-Id: Iaf790f134917796deac0e84cc931828934a6e589 Reviewed-on: https://chromium-review.googlesource.com/c/1260122 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#56650}
-
- 28 Nov, 2017 1 commit
-
-
Igor Sheludko authored
Modification of InstanceType enum caused JsonStringifier::Serialize_() function to consume more stack space (because of a switch statement) in non-optimized debug build which now causes stack overflow on certain depth of nested objects. The modification affects neither optimized debug nor release builds. Change-Id: Ia2925d9abbd1c32c5a4694e14c49b2d0bd119419 Reviewed-on: https://chromium-review.googlesource.com/789074 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#49657}
-
- 31 May, 2016 1 commit
-
-
yangguo authored
R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2026643003 Cr-Commit-Position: refs/heads/master@{#36610}
-
- 02 Dec, 2015 1 commit
-
-
verwaest authored
This hackily disambiguates multiple calls for the iterator protocols in ForOf / Yield* by adding -2 / -1 to the pos. BUG=v8:3953 LOG=y Review URL: https://codereview.chromium.org/1491923003 Cr-Commit-Position: refs/heads/master@{#32527}
-
- 21 Jan, 2015 1 commit
-
-
verwaest authored
BUG=259443 LOG=y Review URL: https://codereview.chromium.org/861623002 Cr-Commit-Position: refs/heads/master@{#26189}
-
- 25 Apr, 2014 1 commit
-
-
ulan@chromium.org authored
BUG=367089 LOG=N R=machenbach@chromium.org Review URL: https://codereview.chromium.org/254673005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20977 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-