1. 29 Jun, 2020 1 commit
    • Ng Zhi An's avatar
      [Py3] Get python scripts in tools closer to Py3 · 4af3f7be
      Ng Zhi An authored
      This modernizes python code without breaking Py2 compat.
      
      Ran with command:
      
      futurize --stage1 -w predictable_wrapper.py
      futurize --stage1 -w run-num-fuzzer.py
      futurize --stage1 -w run-tests.py
      futurize --stage1 -w v8_presubmit.py
      
      This only adds the absolute import, which use these semantics. It
      doesn't do anything differently in our case, these scripts are already
      doing absolute imports. But with these changes, running `futurize
      --stage2` will be less messy.
      
      Bug: v8:9871
      Change-Id: I28182ab73dac6cfcbd544c2046026f14e5157eb3
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2252555Reviewed-by: 's avatarTamer Tas <tmrts@chromium.org>
      Commit-Queue: Zhi An Ng <zhin@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#68588}
      4af3f7be
  2. 16 Jan, 2020 1 commit
    • Michael Achenbach's avatar
      [testrunner] Prevent erroneous overriding of signal handlers · d64a48db
      Michael Achenbach authored
      When an overall timeout is reached, swarming sends a SIGTERM to
      terminate the test runner. The test runner has a signal handler on the
      main process to terminate all workers gracefully.
      
      Additionally, every worker process installs a signal handler for
      terminating ongoing tests wrapped by command.Command.
      
      Also, command.Command is used on the main process to list tests for
      cctest and gtest executables, which led to overriding the test runner's
      main signal handler.
      
      This CL disables using signal handlers in commands by default and only
      explicitly enables it in safe source locations.
      
      Bug: v8:8292
      Change-Id: Ifceadaff75bdd2b77e761498bccbe00b6a3e265c
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2002528Reviewed-by: 's avatarTamer Tas <tmrts@chromium.org>
      Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#65815}
      d64a48db
  3. 19 Feb, 2019 1 commit
  4. 06 Feb, 2019 1 commit
  5. 10 Aug, 2018 3 commits
    • Michael Achenbach's avatar
      Reland "[test] Add logic to run tests on Android" · b2537f21
      Michael Achenbach authored
      This is a reland of 4c094342
      
      Original change's description:
      > [test] Add logic to run tests on Android
      > 
      > This adds a new command abstraction for running commands on Android
      > using dockered devices on swarming.
      > 
      > The new abstraction handles pushing all required files to the device.
      > The logic used for pushing and running is reused from the perf runner.
      > 
      > This adds only the mjsunit test suite. Others will be handled in
      > follow up CLs. The suite logic is enhanced with auto-detection of files
      > to be pushed to devices, for e.g. load or import statements.
      > 
      > Some test cases need an extra resource section for specifying required
      > files.
      > 
      > Remaining failing tests are marked in the status files for later
      > triage.
      > 
      > Bug: chromium:866862
      > Change-Id: I2b957559f07fdcd8c1bd2f7034f5ba7754a31fb7
      > Reviewed-on: https://chromium-review.googlesource.com/1150153
      > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
      > Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#55041}
      
      Bug: chromium:866862
      Change-Id: Icf7e04c75d4abeab7254d10ba21240e46b0022ae
      Reviewed-on: https://chromium-review.googlesource.com/1170643Reviewed-by: 's avatarSergiy Byelozyorov <sergiyb@chromium.org>
      Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#55059}
      b2537f21
    • Sergiy Byelozyorov's avatar
      Revert "[test] Add logic to run tests on Android" · 2071051e
      Sergiy Byelozyorov authored
      This reverts commit 4c094342.
      
      Reason for revert: Unfortunately this broke all perf builders.
      
      Original change's description:
      > [test] Add logic to run tests on Android
      > 
      > This adds a new command abstraction for running commands on Android
      > using dockered devices on swarming.
      > 
      > The new abstraction handles pushing all required files to the device.
      > The logic used for pushing and running is reused from the perf runner.
      > 
      > This adds only the mjsunit test suite. Others will be handled in
      > follow up CLs. The suite logic is enhanced with auto-detection of files
      > to be pushed to devices, for e.g. load or import statements.
      > 
      > Some test cases need an extra resource section for specifying required
      > files.
      > 
      > Remaining failing tests are marked in the status files for later
      > triage.
      > 
      > Bug: chromium:866862
      > Change-Id: I2b957559f07fdcd8c1bd2f7034f5ba7754a31fb7
      > Reviewed-on: https://chromium-review.googlesource.com/1150153
      > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
      > Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#55041}
      
      TBR=machenbach@chromium.org,yangguo@chromium.org,sergiyb@chromium.org
      
      Change-Id: If80129810586b709dab762c9b5724888e15daec2
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: chromium:866862
      Reviewed-on: https://chromium-review.googlesource.com/1170962Reviewed-by: 's avatarSergiy Byelozyorov <sergiyb@chromium.org>
      Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#55058}
      2071051e
    • Michael Achenbach's avatar
      [test] Add logic to run tests on Android · 4c094342
      Michael Achenbach authored
      This adds a new command abstraction for running commands on Android
      using dockered devices on swarming.
      
      The new abstraction handles pushing all required files to the device.
      The logic used for pushing and running is reused from the perf runner.
      
      This adds only the mjsunit test suite. Others will be handled in
      follow up CLs. The suite logic is enhanced with auto-detection of files
      to be pushed to devices, for e.g. load or import statements.
      
      Some test cases need an extra resource section for specifying required
      files.
      
      Remaining failing tests are marked in the status files for later
      triage.
      
      Bug: chromium:866862
      Change-Id: I2b957559f07fdcd8c1bd2f7034f5ba7754a31fb7
      Reviewed-on: https://chromium-review.googlesource.com/1150153Reviewed-by: 's avatarSergiy Byelozyorov <sergiyb@chromium.org>
      Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#55041}
      4c094342
  6. 14 Mar, 2018 1 commit
  7. 08 Dec, 2017 1 commit