- 25 Aug, 2015 1 commit
-
-
bmeurer authored
The previous hack with HInstanceOfKnownGlobal was not only slower, but also very brittle and required a lot of weird hacks to support it. And what's even more important it wasn't even correct (because a map check on the lhs is never enough for instanceof). The new implementation provides a sane runtime implementation for InstanceOf plus a fast case in the InstanceOfStub, combined with a proper specialization in the case of a known global in CrankShaft, which does only the prototype chain walk (coupled with a code dependency on the known global). As a drive-by-fix: Also fix the incorrect Object.prototype.isPrototypeOf implementation. BUG=v8:4376 LOG=y Review URL: https://codereview.chromium.org/1304633002 Cr-Commit-Position: refs/heads/master@{#30342}
-
- 03 Aug, 2015 1 commit
-
-
yangguo authored
There is only one use case for it: String.prototype.search converts a string argument into a RegExp. The cache is used to avoid repeating that conversion. However, this does not make the added complexity worthwhile. Review URL: https://codereview.chromium.org/1267493006 Cr-Commit-Position: refs/heads/master@{#29985}
-
- 30 Jul, 2015 1 commit
-
-
rmcilroy authored
Adds interpreter entry and exit trampoline builtins. Also implements the Return bytecode handler and fixes a few bugs in InterpreterAssembler highlighted by running on other architectures. MIPS and MIPS64 port contributed by Paul Lind (paul.lind@imgtec.com) BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1245133002 Cr-Commit-Position: refs/heads/master@{#29929}
-
- 20 Jul, 2015 1 commit
-
-
yangguo authored
Prior to this patch, we enter a global debug mode whenever a break point is set. By entering this mode, all code is deoptimized and activated frames are recompiled and redirected to newly compiled debug code. After this patch, we only deoptimize/redirect for functions we want to debug. Trigger for this is Debug::EnsureDebugInfo, and having DebugInfo object attached to the SFI prevents optimization/inlining. The result is that we can have optimized code for functions without break points alongside functions that do have break points, which are not optimized. R=mstarzinger@chromium.org, ulan@chromium.org BUG=v8:4132 LOG=Y Review URL: https://codereview.chromium.org/1233073005 Cr-Commit-Position: refs/heads/master@{#29758}
-
- 13 Jul, 2015 2 commits
-
-
mstarzinger authored
This also adds a script to the tools directory that allows to grep for unused bailout reasons. For now the script needs to be run manually. R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/1237623003 Cr-Commit-Position: refs/heads/master@{#29609}
-
mstarzinger authored
Note that there are currently no objects that require a pre-allocated properties backing store, all such slots are in-object properties from the begining. Hence {unused + pre_allocated - inobject == 0} holds. R=verwaest@chromium.org Review URL: https://codereview.chromium.org/1226203011 Cr-Commit-Position: refs/heads/master@{#29590}
-
- 03 Jun, 2015 1 commit
-
-
bmeurer authored
Previously the %_DateField intrinsic would also check the object and throw an exception if you happen to pass something that is not a valid JSDate, which (a) violates our policy for instrinsics and (b) is hard to optimize in TurboFan (even Crankshaft has a hard time, but there we will never inline the relevant builtins, so it doesn't show up). The throwing part is now a separate intrinsics %_ThrowIfNotADate that throws an exception in full codegen and deoptimizes in Crankshaft, which means the code for the current use cases is roughly the same (modulo some register renamings/gap moves). R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1167813003 Cr-Commit-Position: refs/heads/master@{#28782}
-
- 21 May, 2015 1 commit
-
-
arv authored
This allows you to put iterables into your array literals and the will get spread into the array. let x = [0, ...range(1, 3)]; // [0, 1, 2] This is done by treating the array literal up to the first spread element as usual, including using a boiler plate array, and then appending the remaining expressions and rest expressions. BUG=v8:3018 LOG=N Review URL: https://codereview.chromium.org/1125183008 Cr-Commit-Position: refs/heads/master@{#28534}
-
- 30 Apr, 2015 1 commit
-
-
adamk authored
BUG=v8:1569 LOG=n Review URL: https://codereview.chromium.org/1106383008 Cr-Commit-Position: refs/heads/master@{#28179}
-
- 27 Apr, 2015 1 commit
-
-
titzer authored
R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/1105133002 Cr-Commit-Position: refs/heads/master@{#28083}
-
- 16 Apr, 2015 1 commit
-
-
verwaest authored
BUG=chromium:476592 LOG=n Review URL: https://codereview.chromium.org/1086333002 Cr-Commit-Position: refs/heads/master@{#27898}
-
- 15 Apr, 2015 1 commit
-
-
adamk authored
This reverts commit 8c98cc07 because it causes flaky failures in the dromaeo.jslibeventprototype benchmark on Linux/Windows and consistent failures on Android. Also reverts the followup "Remove kForInStatementIsNotFastCase bailout reason" (commit ba24e676) to avoid breaking the build. BUG=chromium:476592 TBR=verwaest@chromium.org LOG=y Review URL: https://codereview.chromium.org/1066663005 Cr-Commit-Position: refs/heads/master@{#27859}
-
- 13 Apr, 2015 1 commit
-
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1081803002 Cr-Commit-Position: refs/heads/master@{#27783}
-
- 07 Apr, 2015 1 commit
-
-
mstarzinger authored
This enables eager optimization of top-level code with TurboFan and extends test coverage by triggering it with the --always-opt flag. Script contexts are now also properly allocated in TurboFan. R=titzer@chromium.org Review URL: https://codereview.chromium.org/1053063003 Cr-Commit-Position: refs/heads/master@{#27633}
-
- 11 Mar, 2015 1 commit
-
-
svenpanne authored
This recovers the performance loss for some ancient benchmarks. Added some comments/UNIMPLEMENTED on the way. BUG=v8:3947 LOG=n Review URL: https://codereview.chromium.org/996153002 Cr-Commit-Position: refs/heads/master@{#27131}
-
- 10 Mar, 2015 1 commit
-
-
svenpanne authored
Doing a runtime call should always be better than totally giving up (unless we have fullcode-only intrinsics, which we'll probably never have). BUG=v8:3947 LOG=n Review URL: https://codereview.chromium.org/997543002 Cr-Commit-Position: refs/heads/master@{#27110}
-
- 27 Feb, 2015 1 commit
-
-
bmeurer authored
Review URL: https://codereview.chromium.org/926553004 Cr-Commit-Position: refs/heads/master@{#26907}
-
- 14 Feb, 2015 1 commit
-
-
caitpotter88 authored
LOG=Y BUG=v8:2159 R=dslomov@chromium.org, arv@chromium.org, marja@chromium.org Review URL: https://codereview.chromium.org/816913003 Cr-Commit-Position: refs/heads/master@{#26645}
-
- 29 Jan, 2015 1 commit
-
-
titzer authored
R=jarin@chromium.org BUG= Review URL: https://codereview.chromium.org/877553007 Cr-Commit-Position: refs/heads/master@{#26318}
-
- 22 Jan, 2015 1 commit
-
-
mstarzinger authored
R=titzer@chromium.org TEST=mjsunit/regress/regress-crbug-451016 BUG=chromium:451016 LOG=N Review URL: https://codereview.chromium.org/817293005 Cr-Commit-Position: refs/heads/master@{#26229}
-
- 16 Jan, 2015 1 commit
-
-
Sven Panne authored
Contribution of PowerPC port (continuation of 422063005). The inital patch covers the core changes to the common files. Subsequent patches will cover changes to common files to support AIX and to update the ppc directories so they are current with the changes in the rest of the project. This is based off of the GitHub repository https://github.com/andrewlow/v8ppc BUG= R=svenpanne@chromium.org, danno@chromium.org, sevnpanne@chromium.org Review URL: https://codereview.chromium.org/817143002 Cr-Commit-Position: refs/heads/master@{#26091}
-
- 15 Jan, 2015 1 commit
-
-
arv authored
This adds support for computed property names, under the flag --harmony-computed-property-names, for both object literals and classes. This is a revert of the revert, 7d48fd9d. BUG=v8:3754 LOG=Y R=dslomov@chromium.org Review URL: https://codereview.chromium.org/798243004 Cr-Commit-Position: refs/heads/master@{#26084}
-
- 13 Jan, 2015 1 commit
-
-
Andy Wingo authored
The current logic appears to have been introduced in https://codereview.chromium.org/596783002. R=yangguo@chromium.org BUG= Review URL: https://codereview.chromium.org/836033005 Cr-Commit-Position: refs/heads/master@{#26043}
-
- 12 Jan, 2015 1 commit
-
-
titzer authored
R=bmeurer@chromium.org BUG= Review URL: https://codereview.chromium.org/809333002 Cr-Commit-Position: refs/heads/master@{#26020}
-
- 17 Dec, 2014 2 commits
-
-
machenbach authored
Revert of ES6 computed property names (patchset #1 id:1 of https://codereview.chromium.org/792233008/) Reason for revert: [sheriff] Still crashes on win32 (XP): http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%201/builds/1380 Original issue's description: > ES6 computed property names > > This adds support for computed property names, under the flag > --harmony-computed-property-names, for both object literals and > classes. > > This is a revert of the revert, a76419f0. > > This changes to do an early bailout in > HOptimizedGraphBuilder::VisitObjectLiteral instead of doing that in the later > loop. > > BUG=v8:3754 > LOG=Y > TBR=dslomov@chromium.org TBR=dslomov@chromium.org,arv@chromium.org NOTREECHECKS=true NOTRY=true BUG=v8:3754 Review URL: https://codereview.chromium.org/811593004 Cr-Commit-Position: refs/heads/master@{#25872}
-
arv authored
This adds support for computed property names, under the flag --harmony-computed-property-names, for both object literals and classes. This is a revert of the revert, a76419f0. This changes to do an early bailout in HOptimizedGraphBuilder::VisitObjectLiteral instead of doing that in the later loop. BUG=v8:3754 LOG=Y TBR=dslomov@chromium.org Review URL: https://codereview.chromium.org/792233008 Cr-Commit-Position: refs/heads/master@{#25868}
-
- 16 Dec, 2014 2 commits
-
-
arv authored
Revert of ES6 computed property names (patchset #1 id:1 of https://codereview.chromium.org/807173002/) Reason for revert: Crashes Win32. It was not flake. Original issue's description: > ES6 computed property names > > This adds support for computed property names, under the flag > --harmony-computed-property-names, for both object literals and > classes. > > This is a revert of the revert, a76419f0 with > no changes. I cannot reproduce the issue on Win8.1 or WinXP. Letting the bots > try again. > > BUG=v8:3754 > LOG=Y > TBR=dslomov@chromium.org TBR=dslomov@chromium.org NOTREECHECKS=true NOTRY=true BUG=v8:3754 Review URL: https://codereview.chromium.org/807033003 Cr-Commit-Position: refs/heads/master@{#25853}
-
arv authored
This adds support for computed property names, under the flag --harmony-computed-property-names, for both object literals and classes. This is a revert of the revert, a76419f0 with no changes. I cannot reproduce the issue on Win8.1 or WinXP. Letting the bots try again. BUG=v8:3754 LOG=Y TBR=dslomov@chromium.org Review URL: https://codereview.chromium.org/807173002 Cr-Commit-Position: refs/heads/master@{#25851}
-
- 15 Dec, 2014 2 commits
-
-
arv authored
Revert of ES6 computed property names (patchset #9 id:160001 of https://codereview.chromium.org/795573005/) Reason for revert: Crashes on Win32 http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%201/builds/1357 Test: mjsunit/harmony/computed-property-names Flags: --stress-opt --always-opt Command: build\Release\d8.exe --test --random-seed=-233815021 --stress-opt --always-opt --nohard-abort --nodead-code-elimination --nofold-constants --harmony-computed-property-names test\mjsunit\mjsunit.js test\mjsunit\harmony\computed-property-names.js Run #1 Exit code: -1073741819 Result: CRASH Expected outcomes: PASS Run #2 Exit code: -1073741819 Result: CRASH Expected outcomes: PASS Run #3 Exit code: -1073741819 Result: CRASH Expected outcomes: PASS Original issue's description: > ES6 computed property names > > This adds support for computed property names, under the flag > --harmony-computed-property-names, for both object literals and > classes. > > BUG=v8:3754 > LOG=Y TBR=dslomov@chromium.org,wingo@igalia.com NOTREECHECKS=true NOTRY=true BUG=v8:3754 Review URL: https://codereview.chromium.org/809433002 Cr-Commit-Position: refs/heads/master@{#25825}
-
arv authored
This adds support for computed property names, under the flag --harmony-computed-property-names, for both object literals and classes. BUG=v8:3754 LOG=Y Review URL: https://codereview.chromium.org/795573005 Cr-Commit-Position: refs/heads/master@{#25821}
-
- 24 Sep, 2014 1 commit
-
-
yangguo@chromium.org authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/596783002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24161 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-