1. 22 Feb, 2022 1 commit
  2. 27 Jan, 2022 1 commit
  3. 15 Dec, 2021 1 commit
    • Samuel Groß's avatar
      V8 Sandbox rebranding · 277fdd1d
      Samuel Groß authored
      This CL renames a number of things related to the V8 sandbox.
      Mainly, what used to be under V8_HEAP_SANDBOX is now under
      V8_SANDBOXED_EXTERNAL_POINTERS, while the previous V8 VirtualMemoryCage
      is now simply the V8 Sandbox:
      
      V8_VIRTUAL_MEMORY_CAGE => V8_SANDBOX
      V8_HEAP_SANDBOX => V8_SANDBOXED_EXTERNAL_POINTERS
      V8_CAGED_POINTERS => V8_SANDBOXED_POINTERS
      V8VirtualMemoryCage => Sandbox
      CagedPointer => SandboxedPointer
      fake cage => partially reserved sandbox
      src/security => src/sandbox
      
      This naming scheme should simplify things: the sandbox is now the large
      region of virtual address space inside which V8 mainly operates and
      which should be considered untrusted. Mechanisms like sandboxed pointers
      are then used to attempt to prevent escapes from the sandbox (i.e.
      corruption of memory outside of it). Furthermore, the new naming scheme
      avoids the confusion with the various other "cages" in V8, in
      particular, the VirtualMemoryCage class, by dropping that name entirely.
      
      Future sandbox features are developed under their own V8_SANDBOX_X flag,
      and will, once final, be merged into V8_SANDBOX. Current future features
      are sandboxed external pointers (using the external pointer table), and
      sandboxed pointers (pointers guaranteed to point into the sandbox, e.g.
      because they are encoded as offsets). This CL then also introduces a new
      build flag, v8_enable_sandbox_future, which enables all future features.
      
      Bug: v8:10391
      Change-Id: I5174ea8f5ab40fb96a04af10853da735ad775c96
      Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3322981Reviewed-by: 's avatarHannes Payer <hpayer@chromium.org>
      Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
      Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
      Commit-Queue: Samuel Groß <saelo@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#78384}
      277fdd1d
  4. 19 Oct, 2021 1 commit
  5. 25 Aug, 2021 1 commit
  6. 27 Jul, 2021 1 commit
  7. 21 Jul, 2021 1 commit
  8. 20 Jul, 2021 2 commits
  9. 21 May, 2021 1 commit
    • Michael Achenbach's avatar
      [test] Run heavy tests sequentially · ee56a986
      Michael Achenbach authored
      This adds a new status file indicator "HEAVY" to mark tests with high
      resource demands. There will be other tests running in parallel,
      but only a limited number of other heavy tests. The limit is
      controlled with a new parameter --max-heavy-tests and defaults to 1.
      
      The change also marks a variety of tests as heavy that recently had
      flaky timeouts. Heavy also implies slow, hence heavy tests are
      executed at the beginning with a higher timeout like other slow tests.
      
      The implementation is encapsulated in the test-processor chain. A
      new processor buffers heavy tests in a queue and adds buffered tests
      only if other heavy tests have ended their computation.
      
      Bug: v8:5861
      Change-Id: I89648ad0030271a3a5af588ecc9c43285b728d6d
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2905767
      Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      Reviewed-by: 's avatarLiviu Rau <liviurau@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#74712}
      ee56a986
  10. 21 Apr, 2021 1 commit
  11. 14 Apr, 2021 1 commit
  12. 12 Apr, 2021 1 commit
  13. 22 Feb, 2021 1 commit
    • Clemens Backes's avatar
      [no-wasm] Skip wasm tests if wasm is disabled · 18136654
      Clemens Backes authored
      This CL introduces a test runner flag to detect if webassembly has been
      disabled. Since all tests that require wasm are alrady skipped in
      lite mode, we introduce a has_webassembly flag for the test runner which
      checks for v8_enable_webassembly=true and v8_enable_lite_mode=false.
      As a drive-by, we also do not set the V8_ENABLE_WEBASSEMBLY
      preprocessor flag if lite mode is enabled.
      
      The status files are updated by splitting wasm tests from the
      "lite_mode" section and checking for "not has_webassembly" instead.
      
      Note that the v8_enable_webassembly=false configuration is not tested
      on any bot currently, but I will make sure that all tests keep passing
      on further changes in this configuration.
      
      R=machenbach@chromium.org
      
      Bug: v8:11238
      Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
      Change-Id: I1841eb1f1633cb47e0c079f4a4a4d769ca3a9cbb
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2710425Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Commit-Queue: Clemens Backes <clemensb@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#72898}
      18136654
  14. 12 Feb, 2021 1 commit
  15. 08 Oct, 2020 1 commit
  16. 07 Oct, 2020 1 commit
    • Michael Achenbach's avatar
      [test] Overhaul mode processing in test runner · 608b732d
      Michael Achenbach authored
      This simplifies mode processing as follows:
      - Passing the --mode parameter is deprecated.
      - The build output is now only searched in the --outdir parameter
      that was passed (previously some combinations of mode and outdir
      were possible).
      - The mode is deduced from the build artifacts based on the gn
      arguments "is_debug" and "dcheck_always_on".
      - Timeouts and status file entries in release mode with dchecks are
      treated like in debug mode.
      
      This change was prepared on the infrastructure side by deprecating
      the --mode flag and passing --outdir=out/build:
      https://crrev.com/c/2426643
      
      Bug: chromium:1132088, v8:10893
      Change-Id: I0f34ebc003b220f07df4ecdbf69ea6c06ac1f66a
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2450016Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#70363}
      608b732d
  17. 28 Sep, 2020 2 commits
  18. 05 May, 2020 1 commit
  19. 21 Jan, 2020 1 commit
  20. 22 Oct, 2019 1 commit
  21. 16 Oct, 2019 1 commit
    • Simon Zünd's avatar
      Reland "Unconditionally enable snapshot builds and remove 'v8_use_snapshot'" · 69efc4c3
      Simon Zünd authored
      This is a reland of 1c56974f
      
      This is a plain reland of the original CL. The original CL was speculatively
      reverted, but ended up not being the cause for bot failures.
      
      Original change's description:
      > Unconditionally enable snapshot builds and remove 'v8_use_snapshot'
      >
      > This CL removes 'v8_use_snapshot' and the usages of the implied
      > V8_USE_SNAPSHOT define. One test runner unittest was updated to use the
      > "asan" variant instead of the now obsolete "no_snap" variant.
      >
      > Related chromium CL: https://crrev.com/c/1796325.
      >
      > Bug: v8:8531
      > Change-Id: I5da7c9f8e9110fe7bc0f4e4f821bcb7f7d98f927
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1784282
      > Commit-Queue: Simon Zünd <szuend@chromium.org>
      > Reviewed-by: Tamer Tas <tmrts@chromium.org>
      > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > Reviewed-by: Nico Weber <thakis@chromium.org>
      > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
      > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#64290}
      
      TBR=thakis@chromium.org,machenbach@chromium.org,mstarzinger@chromium.org,jgruber@chromium.org,tmrts@chromium.org,szuend@chromium.org
      
      Bug: v8:8531
      Change-Id: Id75a802279238138f7aefec62e0b6425a5acc08d
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864649Reviewed-by: 's avatarSimon Zünd <szuend@chromium.org>
      Reviewed-by: 's avatarTamer Tas <tmrts@chromium.org>
      Commit-Queue: Simon Zünd <szuend@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#64305}
      69efc4c3
  22. 15 Oct, 2019 2 commits
  23. 11 Jul, 2019 1 commit
    • Mythri A's avatar
      Check that function was prepared before optimizing using manually · b086cb7b
      Mythri A authored
      With lazy feedback allocation and bytecode flushing we need to call
      %PrepareFunctionForOptimize before we call %OptimizeFunctionOnNextCall/
      %OptimizeOsr. This cl:
      1. Adds an additional state in pending optimized table to check if the
      optimization was triggered manually.
      2. Changes the compilation pipeline to delete the entry from pending
      optimized table only if the optimization was triggered through
      %OptimizeFunctionOnNextCall / %OptimizeOsr.
      3. Adds a check to enforce %PrepareFunctionForOptimize was called.
      4. Adds a new run-time flag to only check in the d8 test runner. We
      don't want this check enabled in other cases like clusterfuzz that doesn't
      ensure %PrepareFunctionForOptimize is called.
      
      Bug: v8:8394, v8:8801, v8:9183
      Change-Id: I9ae2b2da812e313c746b6df0b2da864c2ed5de51
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1664810
      Commit-Queue: Mythri Alle <mythria@chromium.org>
      Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#62653}
      b086cb7b
  24. 07 May, 2019 1 commit
  25. 11 Apr, 2019 1 commit
  26. 05 Apr, 2019 1 commit
    • Michael Achenbach's avatar
      [test] Expose variant flags in json output · ff0b9dd3
      Michael Achenbach authored
      For standard test failures, the variant name is enough to deduce the
      full command line of the test. This is used to create the flako
      command line on the infra side.
      
      Test failures from numfuzz have additional variant_flags, calculated
      by the fuzzer, which don't match a variant name. Exposing those in
      the test results will enable printing a proper flako command line
      on infra side for numfuzz cases.
      
      Bug: v8:8971
      Change-Id: Ie47d42a0b34037da458b474f2a9ab38f1a5d238a
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1554689Reviewed-by: 's avatarSergiy Belozorov <sergiyb@chromium.org>
      Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#60656}
      ff0b9dd3
  27. 27 Feb, 2019 1 commit
  28. 19 Feb, 2019 1 commit
  29. 07 Feb, 2019 1 commit
  30. 06 Feb, 2019 1 commit
    • Tamer Tas's avatar
      Reland "Reland "[test] refactor testsuite configuration"" · df630e67
      Tamer Tas authored
      This is a reland of 81eec150
      
      Original change's description:
      > Reland "[test] refactor testsuite configuration"
      >
      > This is a reland of 7f92ad0a
      >
      > Original change's description:
      > > [test] refactor testsuite configuration
      > >
      > > Every testsuite configuration consist of at least 30% code duplication.
      > >
      > > The code age ranges from 10 years old to 5 years old. Implementing anything that
      > > touches the testsuite code becomes a technical fight to the death.
      > >
      > > This CL removes all the duplication by refactoring the common functionality.
      > >
      > > This CL contains structural changes without any logical changes % small bug
      > > fixes.
      > >
      > > R=machenbach@chromium.org
      > > CC=yangguo@chromium.org,sergiyb@chromium.org
      > >
      > > Bug: v8:8174, v8:8769
      > > Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2
      > > Reviewed-on: https://chromium-review.googlesource.com/c/1445881
      > > Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org>
      > > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#59361}
      >
      > Bug: v8:8174, v8:8769
      > Change-Id: I8e7078cfb875ceb3777e57084e6f8dfac09693e7
      > Reviewed-on: https://chromium-review.googlesource.com/c/1454485
      > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > Commit-Queue: Tamer Tas <tmrts@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#59369}
      
      Bug: v8:8174, v8:8790
      Change-Id: I38ab9d37bca76057441a970f26e2102e4387a857
      Reviewed-on: https://chromium-review.googlesource.com/c/1454724
      Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#59387}
      df630e67
  31. 05 Feb, 2019 4 commits
    • Tamer Tas's avatar
      Revert "Reland "[test] refactor testsuite configuration"" · ea4412ad
      Tamer Tas authored
      This reverts commit 81eec150.
      
      Reason for revert: windows mozilla test failures
      
      Original change's description:
      > Reland "[test] refactor testsuite configuration"
      > 
      > This is a reland of 7f92ad0a
      > 
      > Original change's description:
      > > [test] refactor testsuite configuration
      > > 
      > > Every testsuite configuration consist of at least 30% code duplication.
      > > 
      > > The code age ranges from 10 years old to 5 years old. Implementing anything that
      > > touches the testsuite code becomes a technical fight to the death.
      > > 
      > > This CL removes all the duplication by refactoring the common functionality.
      > > 
      > > This CL contains structural changes without any logical changes % small bug
      > > fixes.
      > > 
      > > R=machenbach@chromium.org
      > > CC=yangguo@chromium.org,sergiyb@chromium.org
      > > 
      > > Bug: v8:8174, v8:8769
      > > Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2
      > > Reviewed-on: https://chromium-review.googlesource.com/c/1445881
      > > Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org>
      > > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#59361}
      > 
      > Bug: v8:8174, v8:8769
      > Change-Id: I8e7078cfb875ceb3777e57084e6f8dfac09693e7
      > Reviewed-on: https://chromium-review.googlesource.com/c/1454485
      > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > Commit-Queue: Tamer Tas <tmrts@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#59369}
      
      TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org
      
      Change-Id: I8f5650b5f46be299c004e2fa8b708fa2c17a4dc2
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:8174, v8:8769
      Reviewed-on: https://chromium-review.googlesource.com/c/1454607Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Commit-Queue: Tamer Tas <tmrts@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#59370}
      ea4412ad
    • Tamer Tas's avatar
      Reland "[test] refactor testsuite configuration" · 81eec150
      Tamer Tas authored
      This is a reland of 7f92ad0a
      
      Original change's description:
      > [test] refactor testsuite configuration
      > 
      > Every testsuite configuration consist of at least 30% code duplication.
      > 
      > The code age ranges from 10 years old to 5 years old. Implementing anything that
      > touches the testsuite code becomes a technical fight to the death.
      > 
      > This CL removes all the duplication by refactoring the common functionality.
      > 
      > This CL contains structural changes without any logical changes % small bug
      > fixes.
      > 
      > R=machenbach@chromium.org
      > CC=yangguo@chromium.org,sergiyb@chromium.org
      > 
      > Bug: v8:8174, v8:8769
      > Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2
      > Reviewed-on: https://chromium-review.googlesource.com/c/1445881
      > Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org>
      > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#59361}
      
      Bug: v8:8174, v8:8769
      Change-Id: I8e7078cfb875ceb3777e57084e6f8dfac09693e7
      Reviewed-on: https://chromium-review.googlesource.com/c/1454485Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Commit-Queue: Tamer Tas <tmrts@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#59369}
      81eec150
    • Tamer Tas's avatar
      Revert "[test] refactor testsuite configuration" · 97068800
      Tamer Tas authored
      This reverts commit 7f92ad0a.
      
      Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win32/19148
      
      Original change's description:
      > [test] refactor testsuite configuration
      >
      > Every testsuite configuration consist of at least 30% code duplication.
      >
      > The code age ranges from 10 years old to 5 years old. Implementing anything that
      > touches the testsuite code becomes a technical fight to the death.
      >
      > This CL removes all the duplication by refactoring the common functionality.
      >
      > This CL contains structural changes without any logical changes % small bug
      > fixes.
      >
      > R=​machenbach@chromium.org
      > CC=​yangguo@chromium.org,sergiyb@chromium.org
      >
      > Bug: v8:8174, v8:8769
      > Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2
      > Reviewed-on: https://chromium-review.googlesource.com/c/1445881
      > Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org>
      > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#59361}
      
      TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org,v8-reviews@chromium.org
      
      Change-Id: I473f0d4c6b9c0239923b8c03699dbc38b7f85030
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:8174, v8:8769
      Reviewed-on: https://chromium-review.googlesource.com/c/1454599
      Commit-Queue: Tamer Tas <tmrts@chromium.org>
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#59362}
      97068800
    • Tamer Tas's avatar
      [test] refactor testsuite configuration · 7f92ad0a
      Tamer Tas authored
      Every testsuite configuration consist of at least 30% code duplication.
      
      The code age ranges from 10 years old to 5 years old. Implementing anything that
      touches the testsuite code becomes a technical fight to the death.
      
      This CL removes all the duplication by refactoring the common functionality.
      
      This CL contains structural changes without any logical changes % small bug
      fixes.
      
      R=machenbach@chromium.org
      CC=yangguo@chromium.org,sergiyb@chromium.org
      
      Bug: v8:8174, v8:8769
      Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2
      Reviewed-on: https://chromium-review.googlesource.com/c/1445881
      Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org>
      Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#59361}
      7f92ad0a
  32. 19 Dec, 2018 1 commit
  33. 22 Oct, 2018 1 commit
  34. 16 Oct, 2018 1 commit