- 22 Feb, 2022 1 commit
-
-
Alexander Schulze authored
Migrate predictable_wrapper to py3. Run test in v8_presubmit. R=liviurau@chromium.org, machenbach@chromium.org Bug: chromium:1245634 Change-Id: I941e248ffcf12ce26a55a5f5889dab06ee74e66e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3448379Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Liviu Rau <liviurau@chromium.org> Commit-Queue: Alexander Schulze <alexschulze@chromium.org> Cr-Commit-Position: refs/heads/main@{#79200}
-
- 27 Jan, 2022 1 commit
-
-
Shu-yu Guo authored
Drive-by fix to align what builds the test runner considers to be able to have shared memory features and what builds can create a shared Isolate. Bug: v8:12007 Change-Id: I151513ccbfbee31e5b35c5ce8e9192732eabfee2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3421507Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#78824}
-
- 15 Dec, 2021 1 commit
-
-
Samuel Groß authored
This CL renames a number of things related to the V8 sandbox. Mainly, what used to be under V8_HEAP_SANDBOX is now under V8_SANDBOXED_EXTERNAL_POINTERS, while the previous V8 VirtualMemoryCage is now simply the V8 Sandbox: V8_VIRTUAL_MEMORY_CAGE => V8_SANDBOX V8_HEAP_SANDBOX => V8_SANDBOXED_EXTERNAL_POINTERS V8_CAGED_POINTERS => V8_SANDBOXED_POINTERS V8VirtualMemoryCage => Sandbox CagedPointer => SandboxedPointer fake cage => partially reserved sandbox src/security => src/sandbox This naming scheme should simplify things: the sandbox is now the large region of virtual address space inside which V8 mainly operates and which should be considered untrusted. Mechanisms like sandboxed pointers are then used to attempt to prevent escapes from the sandbox (i.e. corruption of memory outside of it). Furthermore, the new naming scheme avoids the confusion with the various other "cages" in V8, in particular, the VirtualMemoryCage class, by dropping that name entirely. Future sandbox features are developed under their own V8_SANDBOX_X flag, and will, once final, be merged into V8_SANDBOX. Current future features are sandboxed external pointers (using the external pointer table), and sandboxed pointers (pointers guaranteed to point into the sandbox, e.g. because they are encoded as offsets). This CL then also introduces a new build flag, v8_enable_sandbox_future, which enables all future features. Bug: v8:10391 Change-Id: I5174ea8f5ab40fb96a04af10853da735ad775c96 Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3322981Reviewed-by: Hannes Payer <hpayer@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Samuel Groß <saelo@chromium.org> Cr-Commit-Position: refs/heads/main@{#78384}
-
- 19 Oct, 2021 1 commit
-
-
Leszek Swirski authored
Disable --concurrent-inlining when v8_dict_property_const_tracking is enabled, since the latter doesn't support the former. Add statusfile variables to mark this as an incompatible flag, and otherwise disable it via flags. Change-Id: Ie2e7dac6f4a1ddc97e7e7f4d4d2c77e638e216a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3229565 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#77455}
-
- 25 Aug, 2021 1 commit
-
-
Samuel Groß authored
In a follow-up CL, the backing stores will, when the sandbox is enabled, be referenced from V8 objects through offsets rather than raw pointers. For that to work, all backing stores must be located inside the virtual memory cage. This CL prepares for that. Bug: chromium:1218005 Change-Id: Ibb989626ed7094bd4f02ca15464539f4e2bda90f Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3114136 Commit-Queue: Samuel Groß <saelo@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#76486}
-
- 27 Jul, 2021 1 commit
-
-
Michael Achenbach authored
This reverts commit 67960ba1. Reason for revert: This has been properly fixed by https://crrev.com/c/3053740. Now dcheck_always_on already defaults to false for subprojects like V8 and no other switch is required. The switch didn't fully work anyways due to https://crbug.com/1231890. Original change's description: > Reland "[build] Add V8-specific dcheck_always_on" > > This is a reland of cecc666f > > Depends on: > https://crrev.com/c/3043611 > > Original change's description: > > [build] Add V8-specific dcheck_always_on > > > > This makes the V8 dcheck control independent of Chromium's and > > prepares switching Chromium's default behavior without affecting V8 > > developers or builders. > > > > Preparation for: https://crrev.com/c/2893204 > > > > Bug: chromium:1225701 > > Change-Id: I520b96019b04196f4420716ff3500ebd6c21666f > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3038528 > > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#75827} > > Bug: chromium:1225701 > Change-Id: I56568b78592addba01793d2d14f768c9ee10103d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3041670 > Reviewed-by: Liviu Rau <liviurau@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75839} Bug: chromium:1225701, chromium:1231890 Change-Id: I7e27f5774d8e162977f30f685da4b15dadcc1084 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3055294Reviewed-by: Liviu Rau <liviurau@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#75935}
-
- 21 Jul, 2021 1 commit
-
-
Michael Achenbach authored
This is a reland of cecc666f Depends on: https://crrev.com/c/3043611 Original change's description: > [build] Add V8-specific dcheck_always_on > > This makes the V8 dcheck control independent of Chromium's and > prepares switching Chromium's default behavior without affecting V8 > developers or builders. > > Preparation for: https://crrev.com/c/2893204 > > Bug: chromium:1225701 > Change-Id: I520b96019b04196f4420716ff3500ebd6c21666f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3038528 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75827} Bug: chromium:1225701 Change-Id: I56568b78592addba01793d2d14f768c9ee10103d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3041670Reviewed-by: Liviu Rau <liviurau@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#75839}
-
- 20 Jul, 2021 2 commits
-
-
Zhi An Ng authored
This reverts commit cecc666f. Reason for revert: Many crashes on clusterfuzz bots https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Clusterfuzz%20Win64%20ASAN%20-%20release%20builder/23404/overview Original change's description: > [build] Add V8-specific dcheck_always_on > > This makes the V8 dcheck control independent of Chromium's and > prepares switching Chromium's default behavior without affecting V8 > developers or builders. > > Preparation for: https://crrev.com/c/2893204 > > Bug: chromium:1225701 > Change-Id: I520b96019b04196f4420716ff3500ebd6c21666f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3038528 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75827} Bug: chromium:1225701 Change-Id: I20329f77707caf8fba2405919aa13c67811a1469 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3042841 Auto-Submit: Zhi An Ng <zhin@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#75830}
-
Michael Achenbach authored
This makes the V8 dcheck control independent of Chromium's and prepares switching Chromium's default behavior without affecting V8 developers or builders. Preparation for: https://crrev.com/c/2893204 Bug: chromium:1225701 Change-Id: I520b96019b04196f4420716ff3500ebd6c21666f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3038528Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#75827}
-
- 21 May, 2021 1 commit
-
-
Michael Achenbach authored
This adds a new status file indicator "HEAVY" to mark tests with high resource demands. There will be other tests running in parallel, but only a limited number of other heavy tests. The limit is controlled with a new parameter --max-heavy-tests and defaults to 1. The change also marks a variety of tests as heavy that recently had flaky timeouts. Heavy also implies slow, hence heavy tests are executed at the beginning with a higher timeout like other slow tests. The implementation is encapsulated in the test-processor chain. A new processor buffers heavy tests in a queue and adds buffered tests only if other heavy tests have ended their computation. Bug: v8:5861 Change-Id: I89648ad0030271a3a5af588ecc9c43285b728d6d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2905767 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/master@{#74712}
-
- 21 Apr, 2021 1 commit
-
-
Wenyu Zhao authored
* Filtered some tests that rely on incremental_marking and shape tracking Bug: v8:11644 Change-Id: Ic9833bf1e49e6413422484858cd1054dd2500092 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2822284 Commit-Queue: Wenyu Zhao <wenyu.zhao@anu.edu.au> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#74078}
-
- 14 Apr, 2021 1 commit
-
-
Ulan Degenbaev authored
The flag is useful for disabling tests that are not supported in the third_party_heap build configuration. Example usage in the status files: ['third_party_heap', { 'testname': [SKIP], }], # third_party_heap Bug: v8:11155 Change-Id: I991532bf7cdf89d8c505e4d6cbd7cf9e4d70dd63 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2821960 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#73957}
-
- 12 Apr, 2021 1 commit
-
-
Shu-yu Guo authored
The pointer compression cage is the virtual memory reservation that all compressed pointers fall within. This CL splits pointer compression into two modes: a per-Isolate cage and a shared cage among multiple Isolates. When multiple Isolates are sharing a cage, they can decompress each others' pointers and share the same virtual memory range. Bug: v8:11460 Change-Id: I7b89b7413b8e7ca6b8b6faafd083dc387542a8b4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2783674Reviewed-by: Dan Elphick <delphick@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#73916}
-
- 22 Feb, 2021 1 commit
-
-
Clemens Backes authored
This CL introduces a test runner flag to detect if webassembly has been disabled. Since all tests that require wasm are alrady skipped in lite mode, we introduce a has_webassembly flag for the test runner which checks for v8_enable_webassembly=true and v8_enable_lite_mode=false. As a drive-by, we also do not set the V8_ENABLE_WEBASSEMBLY preprocessor flag if lite mode is enabled. The status files are updated by splitting wasm tests from the "lite_mode" section and checking for "not has_webassembly" instead. Note that the v8_enable_webassembly=false configuration is not tested on any bot currently, but I will make sure that all tests keep passing on further changes in this configuration. R=machenbach@chromium.org Bug: v8:11238 Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel Change-Id: I1841eb1f1633cb47e0c079f4a4a4d769ca3a9cbb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2710425Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#72898}
-
- 12 Feb, 2021 1 commit
-
-
Leszek Swirski authored
Add a .status file variable for the "v8_control_flow_integrity" gn arg, and disable baseline tests for now in that configuration. No-Tree-Checks: true No-Try: true Bug: v8:11439 Change-Id: I7274a168893cfd6619ce98fdd14a692217fd56c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2692206 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#72698}
-
- 08 Oct, 2020 1 commit
-
-
Michael Achenbach authored
This flattens the json output to one result record as a dict. In the past several records with different arch/mode combinations could be run, but this is deprecated since several releases. We also drop storing the arch/mode information in the record as it isn't used on the infra side for anything. This was prepared on the infra side by: https://crrev.com/c/2453562 Bug: chromium:1132088 Change-Id: I944514dc00a671e7671bcdbcaa3a72407476d7ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2456987Reviewed-by: Liviu Rau <liviurau@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#70402}
-
- 07 Oct, 2020 1 commit
-
-
Michael Achenbach authored
This simplifies mode processing as follows: - Passing the --mode parameter is deprecated. - The build output is now only searched in the --outdir parameter that was passed (previously some combinations of mode and outdir were possible). - The mode is deduced from the build artifacts based on the gn arguments "is_debug" and "dcheck_always_on". - Timeouts and status file entries in release mode with dchecks are treated like in debug mode. This change was prepared on the infrastructure side by deprecating the --mode flag and passing --outdir=out/build: https://crrev.com/c/2426643 Bug: chromium:1132088, v8:10893 Change-Id: I0f34ebc003b220f07df4ecdbf69ea6c06ac1f66a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2450016Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#70363}
-
- 28 Sep, 2020 2 commits
-
-
Michael Achenbach authored
This additionally combines --future with all other standard testing variants. This also enables using concurrent_marking in status files to skip tests in this variant. This also marks a slow test that times out in the new config. Bug: v8:10875 Change-Id: Id904f6a2c51b814eecfccb523a897de2f5d96f56 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2423719 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#70180}
-
Michael Achenbach authored
This prepares moving the build directory on bots to out/build. For a smooth transition, the performance runner will dynamically check for the build in several locations. This prepares: https://crrev.com/c/2426643 NOTREECHECKS=true Bug: chromium:1132088 Change-Id: Ia12fcdedec0f4ac2bfe087e8154c0acb8771a43f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2431364 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/master@{#70158}
-
- 05 May, 2020 1 commit
-
-
Liviu Rau authored
Slow tests are now collected in a heap with a fixed size. When the maximum size is reached we evict the fastest test after adding a new test to the heap. Bug: v8:10168 Change-Id: If3298df85d6e924451f55fe9350e293169cc849d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2106205 Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#67572}
-
- 21 Jan, 2020 1 commit
-
-
Liviu Rau authored
Bug: v8:9641 Change-Id: Ia85d14677e8eb7d2d14ff7eb150a1b0b279642f4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1998078 Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#65892}
-
- 22 Oct, 2019 1 commit
-
-
Simon Zünd authored
This CL removes the 'v8_enable_embedded_builtins' GN argument and sets the 'V8_EMBEDDED_BUILTIN' define unconditionally. Removing the now obsolete 'define' and corresponding C++ code will be done in a separate CL. R=machenbach@chromium.org Bug: v8:8519 Change-Id: Ibaa3e958121931c0ce14baf48ad401fab87c5337 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864929 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#64456}
-
- 16 Oct, 2019 1 commit
-
-
Simon Zünd authored
This is a reland of 1c56974f This is a plain reland of the original CL. The original CL was speculatively reverted, but ended up not being the cause for bot failures. Original change's description: > Unconditionally enable snapshot builds and remove 'v8_use_snapshot' > > This CL removes 'v8_use_snapshot' and the usages of the implied > V8_USE_SNAPSHOT define. One test runner unittest was updated to use the > "asan" variant instead of the now obsolete "no_snap" variant. > > Related chromium CL: https://crrev.com/c/1796325. > > Bug: v8:8531 > Change-Id: I5da7c9f8e9110fe7bc0f4e4f821bcb7f7d98f927 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1784282 > Commit-Queue: Simon Zünd <szuend@chromium.org> > Reviewed-by: Tamer Tas <tmrts@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64290} TBR=thakis@chromium.org,machenbach@chromium.org,mstarzinger@chromium.org,jgruber@chromium.org,tmrts@chromium.org,szuend@chromium.org Bug: v8:8531 Change-Id: Id75a802279238138f7aefec62e0b6425a5acc08d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864649Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Tamer Tas <tmrts@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#64305}
-
- 15 Oct, 2019 2 commits
-
-
Clemens Backes authored
This reverts commit 1c56974f. Reason for revert: Causes several bots to timeout, e.g. https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20debug/27945 Original change's description: > Unconditionally enable snapshot builds and remove 'v8_use_snapshot' > > This CL removes 'v8_use_snapshot' and the usages of the implied > V8_USE_SNAPSHOT define. One test runner unittest was updated to use the > "asan" variant instead of the now obsolete "no_snap" variant. > > Related chromium CL: https://crrev.com/c/1796325. > > Bug: v8:8531 > Change-Id: I5da7c9f8e9110fe7bc0f4e4f821bcb7f7d98f927 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1784282 > Commit-Queue: Simon Zünd <szuend@chromium.org> > Reviewed-by: Tamer Tas <tmrts@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64290} TBR=thakis@chromium.org,machenbach@chromium.org,mstarzinger@chromium.org,jgruber@chromium.org,tmrts@chromium.org,szuend@chromium.org Change-Id: I4024d818877e534b9f7908a2d14f33dca35b5924 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8531 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1862572Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64293}
-
Simon Zünd authored
This CL removes 'v8_use_snapshot' and the usages of the implied V8_USE_SNAPSHOT define. One test runner unittest was updated to use the "asan" variant instead of the now obsolete "no_snap" variant. Related chromium CL: https://crrev.com/c/1796325. Bug: v8:8531 Change-Id: I5da7c9f8e9110fe7bc0f4e4f821bcb7f7d98f927 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1784282 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: Tamer Tas <tmrts@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#64290}
-
- 11 Jul, 2019 1 commit
-
-
Mythri A authored
With lazy feedback allocation and bytecode flushing we need to call %PrepareFunctionForOptimize before we call %OptimizeFunctionOnNextCall/ %OptimizeOsr. This cl: 1. Adds an additional state in pending optimized table to check if the optimization was triggered manually. 2. Changes the compilation pipeline to delete the entry from pending optimized table only if the optimization was triggered through %OptimizeFunctionOnNextCall / %OptimizeOsr. 3. Adds a check to enforce %PrepareFunctionForOptimize was called. 4. Adds a new run-time flag to only check in the d8 test runner. We don't want this check enabled in other cases like clusterfuzz that doesn't ensure %PrepareFunctionForOptimize is called. Bug: v8:8394, v8:8801, v8:9183 Change-Id: I9ae2b2da812e313c746b6df0b2da864c2ed5de51 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1664810 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#62653}
-
- 07 May, 2019 1 commit
-
-
Michael Achenbach authored
Bug: v8:9145 Change-Id: Idb1a838666ea21cb260a141929fd80b400913836 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1596731Reviewed-by: Tamer Tas <tmrts@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#61262}
-
- 11 Apr, 2019 1 commit
-
-
Michael Achenbach authored
This will allow to distinguish between the standard runner and the num fuzzer on the infra side when generating flako command lines. The value could be inferred, but it'd be more confusing. Bug: v8:8971 Change-Id: I78f5104135d1c7fd7d98bceb4b17897e79421455 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1564050 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#60769}
-
- 05 Apr, 2019 1 commit
-
-
Michael Achenbach authored
For standard test failures, the variant name is enough to deduce the full command line of the test. This is used to create the flako command line on the infra side. Test failures from numfuzz have additional variant_flags, calculated by the fuzzer, which don't match a variant name. Exposing those in the test results will enable printing a proper flako command line on infra side for numfuzz cases. Bug: v8:8971 Change-Id: Ie47d42a0b34037da458b474f2a9ab38f1a5d238a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1554689Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#60656}
-
- 27 Feb, 2019 1 commit
-
-
Michael Achenbach authored
Also enable test runner to differentiate between clang and gcc. Bug: v8:8919 Change-Id: Icdcae0aba3644a1b1b9ddc6c037eabde27d717f7 Reviewed-on: https://chromium-review.googlesource.com/c/1491634Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#59906}
-
- 19 Feb, 2019 1 commit
-
-
Vadim Gorbachev (bmsdave) authored
There are now less that 400 days until the end of life of Python 2(aka _legacy_ Python) https://pythonclock.org/ . The code compatibility check for python2 and python3 used the following tools: futurize, flake8 You can see the reports here: https://travis-ci.com/bmsdave/v8/builds This CL was uploaded by git cl split. Bug: v8:8594 Change-Id: I661c52a70527e8ddde841fee6d4dcba282b4a938 Reviewed-on: https://chromium-review.googlesource.com/c/1470123 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#59675}
-
- 07 Feb, 2019 1 commit
-
-
Tamer Tas authored
The test name alone isn't informative alone. This CL prints the variant name during the progress reporting. tested by running test262 with all variants R=machenbach@chromium.org CC=yangguo@chromium.org,sergiyb@chromium.org Bug: v8:8728 Change-Id: I3d7d1fc6eacef3712d87404c7276fd5523bb445a Reviewed-on: https://chromium-review.googlesource.com/c/1458156 Commit-Queue: Tamer Tas <tmrts@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#59437}
-
- 06 Feb, 2019 1 commit
-
-
Tamer Tas authored
This is a reland of 81eec150 Original change's description: > Reland "[test] refactor testsuite configuration" > > This is a reland of 7f92ad0a > > Original change's description: > > [test] refactor testsuite configuration > > > > Every testsuite configuration consist of at least 30% code duplication. > > > > The code age ranges from 10 years old to 5 years old. Implementing anything that > > touches the testsuite code becomes a technical fight to the death. > > > > This CL removes all the duplication by refactoring the common functionality. > > > > This CL contains structural changes without any logical changes % small bug > > fixes. > > > > R=machenbach@chromium.org > > CC=yangguo@chromium.org,sergiyb@chromium.org > > > > Bug: v8:8174, v8:8769 > > Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2 > > Reviewed-on: https://chromium-review.googlesource.com/c/1445881 > > Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> > > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#59361} > > Bug: v8:8174, v8:8769 > Change-Id: I8e7078cfb875ceb3777e57084e6f8dfac09693e7 > Reviewed-on: https://chromium-review.googlesource.com/c/1454485 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Tamer Tas <tmrts@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59369} Bug: v8:8174, v8:8790 Change-Id: I38ab9d37bca76057441a970f26e2102e4387a857 Reviewed-on: https://chromium-review.googlesource.com/c/1454724 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#59387}
-
- 05 Feb, 2019 4 commits
-
-
Tamer Tas authored
This reverts commit 81eec150. Reason for revert: windows mozilla test failures Original change's description: > Reland "[test] refactor testsuite configuration" > > This is a reland of 7f92ad0a > > Original change's description: > > [test] refactor testsuite configuration > > > > Every testsuite configuration consist of at least 30% code duplication. > > > > The code age ranges from 10 years old to 5 years old. Implementing anything that > > touches the testsuite code becomes a technical fight to the death. > > > > This CL removes all the duplication by refactoring the common functionality. > > > > This CL contains structural changes without any logical changes % small bug > > fixes. > > > > R=machenbach@chromium.org > > CC=yangguo@chromium.org,sergiyb@chromium.org > > > > Bug: v8:8174, v8:8769 > > Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2 > > Reviewed-on: https://chromium-review.googlesource.com/c/1445881 > > Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> > > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#59361} > > Bug: v8:8174, v8:8769 > Change-Id: I8e7078cfb875ceb3777e57084e6f8dfac09693e7 > Reviewed-on: https://chromium-review.googlesource.com/c/1454485 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Tamer Tas <tmrts@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59369} TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: I8f5650b5f46be299c004e2fa8b708fa2c17a4dc2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8174, v8:8769 Reviewed-on: https://chromium-review.googlesource.com/c/1454607Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#59370}
-
Tamer Tas authored
This is a reland of 7f92ad0a Original change's description: > [test] refactor testsuite configuration > > Every testsuite configuration consist of at least 30% code duplication. > > The code age ranges from 10 years old to 5 years old. Implementing anything that > touches the testsuite code becomes a technical fight to the death. > > This CL removes all the duplication by refactoring the common functionality. > > This CL contains structural changes without any logical changes % small bug > fixes. > > R=machenbach@chromium.org > CC=yangguo@chromium.org,sergiyb@chromium.org > > Bug: v8:8174, v8:8769 > Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2 > Reviewed-on: https://chromium-review.googlesource.com/c/1445881 > Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59361} Bug: v8:8174, v8:8769 Change-Id: I8e7078cfb875ceb3777e57084e6f8dfac09693e7 Reviewed-on: https://chromium-review.googlesource.com/c/1454485Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#59369}
-
Tamer Tas authored
This reverts commit 7f92ad0a. Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win32/19148 Original change's description: > [test] refactor testsuite configuration > > Every testsuite configuration consist of at least 30% code duplication. > > The code age ranges from 10 years old to 5 years old. Implementing anything that > touches the testsuite code becomes a technical fight to the death. > > This CL removes all the duplication by refactoring the common functionality. > > This CL contains structural changes without any logical changes % small bug > fixes. > > R=machenbach@chromium.org > CC=yangguo@chromium.org,sergiyb@chromium.org > > Bug: v8:8174, v8:8769 > Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2 > Reviewed-on: https://chromium-review.googlesource.com/c/1445881 > Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59361} TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org,v8-reviews@chromium.org Change-Id: I473f0d4c6b9c0239923b8c03699dbc38b7f85030 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8174, v8:8769 Reviewed-on: https://chromium-review.googlesource.com/c/1454599 Commit-Queue: Tamer Tas <tmrts@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#59362}
-
Tamer Tas authored
Every testsuite configuration consist of at least 30% code duplication. The code age ranges from 10 years old to 5 years old. Implementing anything that touches the testsuite code becomes a technical fight to the death. This CL removes all the duplication by refactoring the common functionality. This CL contains structural changes without any logical changes % small bug fixes. R=machenbach@chromium.org CC=yangguo@chromium.org,sergiyb@chromium.org Bug: v8:8174, v8:8769 Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2 Reviewed-on: https://chromium-review.googlesource.com/c/1445881 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#59361}
-
- 19 Dec, 2018 1 commit
-
-
Igor Sheludko authored
Tbr: machenbach@chromium.org Bug: v8:8562 Change-Id: If2242c6271d400e7c4c031e10871b06438c2636d Reviewed-on: https://chromium-review.googlesource.com/c/1384088 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#58373}
-
- 22 Oct, 2018 1 commit
-
-
Ross McIlroy authored
BUG=v8:8293 Change-Id: Ic58ac512d5f32d26756e21ca929dda79f133a40e Reviewed-on: https://chromium-review.googlesource.com/c/1290982Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#56844}
-
- 16 Oct, 2018 1 commit
-
-
Sigurd Schneider authored
Change-Id: Ibacdc7b41a96fc7c7d4ff44552fe6d86ec2ef1aa Bug: v8:8312 Reviewed-on: https://chromium-review.googlesource.com/c/1282605 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#56679}
-