1. 27 Jun, 2019 1 commit
  2. 23 Aug, 2017 1 commit
    • Georg Neis's avatar
      [modules] Fix bug in module initialization. · 0cd2ea7c
      Georg Neis authored
      The initialization code of all modules must have been run
      before running any module's main code. This should have been
      fixed quite a while ago as part of another CL but somehow
      wasn't.
      
      In the process of fixing it now, I'm also moving the initialization
      phase out of Evaluate into Instantiatiate. This corresponds more
      closely to the specification and avoids confusion.
      
      Bug: v8:1569
      Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
      Change-Id: I3ea5d6be0f5d371e6a4c641778c51762f1867dc8
      Reviewed-on: https://chromium-review.googlesource.com/620653Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
      Commit-Queue: Georg Neis <neis@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#47537}
      0cd2ea7c
  3. 04 May, 2017 1 commit
  4. 02 May, 2017 1 commit
  5. 11 Apr, 2017 1 commit
    • gsathya's avatar
      [ESNext] Implement DynamicImportCall · 94283dcf
      gsathya authored
      This patch implements the runtime semantics of dynamic import.
      
      We create a new ASTNode so that we can pass the JSFunction closure() to
      the runtime function from which we get the script_url.
      
      d8 implements the embedder logic required to load and evaluate the modules.
      
      The API is mostly implemented as specified.
      
      BUG=8:5785
      
      Review-Url: https://codereview.chromium.org/2703563002
      Cr-Commit-Position: refs/heads/master@{#44551}
      94283dcf
  6. 17 Feb, 2017 1 commit
    • vabr's avatar
      Report unexpected lexical decl also without destructuring · 454816f0
      vabr authored
      https://codereview.chromium.org/2694003002/ introduced
      "SyntaxError: Lexical declaration cannot appear in a single-statement context"
      for the case when let + desctructuring from a list happen.
      
      As was pointed out in https://codereview.chromium.org/2694003002/#msg18, the
      case without destructuring would also benefit from a better message: if a
      single statement is expected and "let identifier = ..." is seen, the error is
      indeed again that the lexical declaration is not a statement. However, the current
      error is "Unexpected identifier", because the parser tries to accept "let" as
      an identifier in an expression statement, and then gives up seeing the other
      identifier after "let".
      
      This CL ensures that the parser recognises the error properly and reports
      accordingly. It also renames the existing test, which contains destructuring,
      and adds the one with a non-destructuring lexical declaration.
      
      BUG=v8:5686
      
      Review-Url: https://codereview.chromium.org/2697193007
      Cr-Commit-Position: refs/heads/master@{#43275}
      454816f0
  7. 16 Feb, 2017 1 commit
  8. 16 Jan, 2017 1 commit
  9. 12 Jan, 2017 1 commit
  10. 04 Jan, 2017 1 commit