- 09 Nov, 2011 1 commit
-
-
mikhail.naganov@gmail.com authored
Each such string requires small amount of heap memory. Heap snapshot generator copies all the strings into internal hash map for future use. The each copy requires much more memory than original v8 string. I made a workaround for this. The snapshot will copy only first 1024 symbols. A simple drive-by fix was made for a performance problem in ToCString implementation. BUG=v8:1816 TEST=none Review URL: http://codereview.chromium.org/8509003 Patch from Ilya Tikhonovsky <loislo@chromium.org>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9928 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 07 Oct, 2011 1 commit
-
-
erik.corry@gmail.com authored
BUG=1753 Review URL: http://codereview.chromium.org/8198005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9551 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 26 Sep, 2011 1 commit
-
-
mikhail.naganov@gmail.com authored
This allows getting a heap object by a heap snapshot node for further inspection. Very useful for objects from bindings that mostly have getter-provided fields. R=vegorov@google.com BUG=webkit/61179 TEST=test-heap-profiler/GetHeapValue,GetHeapValueForDeletedObject Review URL: http://codereview.chromium.org/8046006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9430 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 19 Sep, 2011 1 commit
-
-
vegorov@chromium.org authored
Review URL: http://codereview.chromium.org/7945009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9328 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 14 Sep, 2011 1 commit
-
-
mikhail.naganov@gmail.com authored
Events are still generated for tick processor on performance testing server to work, as soon as scripts will be updated, it will be safe to remove code delete events emitting code. R=erik.corry@gmail.com BUG=v8:1466 TEST=existing tests in test-profile-generator,test-cpu-profiler and mjsunit/tools Review URL: http://codereview.chromium.org/7864017 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9275 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 05 Sep, 2011 1 commit
-
-
mikhail.naganov@gmail.com authored
Do not try to serialize them into JSON to avoid crashing / hanging DevTools. R=sgjesse@chromium.org BUG=v8:1658,89268 TEST=none Review URL: http://codereview.chromium.org/7832003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9123 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 23 Aug, 2011 1 commit
-
-
mikhail.naganov@gmail.com authored
from the constructor function. This works well for binding objects, and this matches DevTools' algorithm for name assignment. R=sgjesse@chromium.org BUG=none TEST=test-heap-profiler/GetConstructorName Review URL: http://codereview.chromium.org/7709026 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9000 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 13 Jul, 2011 1 commit
-
-
sgjesse@chromium.org authored
The preprocessor defines ENABLE_LOGGING_AND_PROFILING and ENABLE_VMSTATE_TRACKING has been removed as these where required to be turned on for Crankshaft to work. To re-enable reducing the binary size by leaving out heap and CPU profiler a new set of defines needs to be created. R=ager@chromium.org BUG=v8:1271 TEST=all Review URL: http://codereview.chromium.org//7350014 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8622 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 30 Jun, 2011 1 commit
-
-
mikhail.naganov@gmail.com authored
This helps understanding what is a particular array for by just looking at its name. R=vitalyr@chromium.org Review URL: http://codereview.chromium.org/7248058 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8494 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 24 Jun, 2011 1 commit
-
-
mikhail.naganov@gmail.com authored
2000 LOC are gone! R=sgjesse@chromium.org BUG=1481 Review URL: http://codereview.chromium.org/7247018 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8406 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 30 May, 2011 1 commit
-
-
mikhail.naganov@gmail.com authored
This allows to distinguish DOMWindow objects in browser from each other. R=vitalyr@chromium.org,sgjesse@chromium.org BUG=https://bugs.webkit.org/show_bug.cgi?id=61177 TEST=cctest/test-heap-profiler/DocumentURL Review URL: http://codereview.chromium.org/7082012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8111 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 06 May, 2011 1 commit
-
-
svenpanne@chromium.org authored
header which uses BASE_EMBEDDED and/or AllStatic. Note that still only 45 out of 135 headers in src/ can be used stand-alone, but at least this is a little bit more than before... Review URL: http://codereview.chromium.org/6931031 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@7798 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 30 Mar, 2011 1 commit
-
-
mikhail.naganov@gmail.com authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/6776009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@7438 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 29 Mar, 2011 1 commit
-
-
mikhail.naganov@gmail.com authored
Diffs and retaining paths are implemented on JS side. There is no need to maintain native implementation. R=vitalyr@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/6770009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@7412 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 22 Mar, 2011 1 commit
-
-
mikhail.naganov@gmail.com authored
R=vitalyr@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/6685084 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@7308 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 18 Mar, 2011 4 commits
-
-
vitalyr@chromium.org authored
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@7271 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
vitalyr@chromium.org authored
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@7269 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
vitalyr@chromium.org authored
Review URL: http://codereview.chromium.org/6685088 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@7268 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
mikhail.naganov@gmail.com authored
I've replaced calls to HashMap::Clear with instance re-creation. This has sped up taking a heap snapshot of GMail from 33s -> 3s! R=vitalyr@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/6665038 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@7259 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Mar, 2011 5 commits
-
-
mikhail.naganov@gmail.com authored
Review URL: http://codereview.chromium.org/6626043/ git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@7126 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
mikhail.naganov@gmail.com authored
objects retained by object groups and global handles. This information is then used during heap snapshot generation to provide a more complete memory picture. This patch will be needed to fix https://bugs.webkit.org/show_bug.cgi?id=53659. Review URL: http://codereview.chromium.org/6626043 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@7125 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
mikhail.naganov@gmail.com authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/6646022/ git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@7124 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
mikhail.naganov@gmail.com authored
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@7123 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
mikhail.naganov@gmail.com authored
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@7119 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 01 Mar, 2011 1 commit
-
-
mikhail.naganov@gmail.com authored
into heap snapshots non-HeapObjects. This is needed as a preparation for adding DOM subtrees tracking. BUG=none TEST=none Review URL: http://codereview.chromium.org/6596073 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@7004 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 22 Feb, 2011 1 commit
-
-
mikhail.naganov@gmail.com authored
The main issue was due to multiple recompilations of functions. Now code objects are grouped by function using SFI object address. JSFunction objects are no longer tracked, instead we track SFI object moves. To pick a correct code version, we now sample return addresses instead of JSFunction addresses. tools/{linux|mac|windows}-tickprocessor scripts differentiate between code optimization states for the same function (using * and ~ prefixes introduced earlier). DevTools CPU profiler treats all variants of function code as a single function. ll_prof treats each optimized variant as a separate entry, because it can disassemble each one of them. tickprocessor.py not updated -- it is deprecated and will be removed. BUG=v8/1087,b/3178160 TEST=all existing tests pass, including Chromium layout tests Review URL: http://codereview.chromium.org/6551011 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@6902 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 13 Dec, 2010 1 commit
-
-
mikhail.naganov@gmail.com authored
As taking a snapshot of a large heap takes noticeable time, it's good to be able to monitor and control it. The change itself is small, big code deletes and additions are in fact moves. The only significant change is simplification of approximated retained sizes calculation algorithm. Review URL: http://codereview.chromium.org/5687003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5978 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 02 Dec, 2010 1 commit
-
-
mikhail.naganov@gmail.com authored
TEST=cctest/test-heap-profiler/HeapSnapshotGetNodeById Review URL: http://codereview.chromium.org/5537001 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5914 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 25 Nov, 2010 1 commit
-
-
yurys@chromium.org authored
Review URL: http://codereview.chromium.org/5256004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5890 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 24 Nov, 2010 1 commit
-
-
mikhail.naganov@gmail.com authored
Serialization was failing due to unset dominator pointers. TEST=test-heap-snapshot/AggregatedHeapSnapshotJSONSerialization Review URL: http://codereview.chromium.org/5314003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5888 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 23 Nov, 2010 1 commit
-
-
mikhail.naganov@gmail.com authored
Rico noticed that V8 ARM builder also fails on HeapEntry size assertion. As MSVC-specific way of fixing the problem causes aliasing problems on G++, I re-implemented conversion using unions. And #ifdefs are gone! TBR=sgjesse@chromium.org Review URL: http://codereview.chromium.org/5328001 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5872 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 22 Nov, 2010 4 commits
-
-
mikhail.naganov@gmail.com authored
TBR=sgjesse@chromium.org Review URL: http://codereview.chromium.org/5216008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5871 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
mikhail.naganov@gmail.com authored
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5870 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
mikhail.naganov@gmail.com authored
TBR=sgjesse@chromium.org Review URL: http://codereview.chromium.org/5242003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5869 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
mikhail.naganov@gmail.com authored
Approximation is done by building a dominators tree for the heap graph. Dominator nodes and retained sizes are serialized into JSON. Removed: - reachable size (it is useless, after all); - HeapEntryCalculatedData (size is now stored in the node, retaining paths in a hash map); Review URL: http://codereview.chromium.org/5154007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5867 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 18 Nov, 2010 1 commit
-
-
mikhail.naganov@gmail.com authored
Otherwise, retaned memory sizes are not precise. This increases size of heap snapshot, I will deal with this later. Heap objects and references previously missing in snapshot are now marked as 'hidden'. That means, they not shown to user, but participate in sizes calculation. Other small changes: - added 'shortcut' graph edges: e.g. to pin global objects on top level; - meta-information in JSON snapshot is no more double encoded. Review URL: http://codereview.chromium.org/5139002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5849 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 08 Nov, 2010 1 commit
-
-
mikhail.naganov@gmail.com authored
It seems that there will be no access to heap snapshots from web pages' code, only from Developer Tools, thus it makes no sense doing filtering of object by their security contexts. Review URL: http://codereview.chromium.org/4681003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5787 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 18 Oct, 2010 1 commit
-
-
mikhail.naganov@gmail.com authored
HeapNumbers do consume memory, so it's worth dumping them. However, we don't dump their values, as they are not as self-descriptive as values of strings, and they will increase snapshot size. Storing heap numbers values can be added if we will feel a sufficient demand for that. InternalFields are used, e.g. for storing references to DOM nodes event handlers. Review URL: http://codereview.chromium.org/3769007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5635 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 13 Oct, 2010 1 commit
-
-
mikhail.naganov@gmail.com authored
I created a heap snapshot in Chromium, and then started comparing it side-by-side with representations of objects provided by the debugger, fixing discrepancies. Review URL: http://codereview.chromium.org/3590029 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5612 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 01 Oct, 2010 1 commit
-
-
mikhail.naganov@gmail.com authored
during snapshot size optimization. Sorry, now I figured out that the diff implementation itself was also incorrect. Reachable nodes must be filtered from the beginning, otherwise, an object that is already disconnected, but not discarded yet, will not appear as a deleted (thankfully, this bug for some reason had appeared on the x64 port.) BUG=868 TEST=HeapSnapshotRootPreservedAfterSorting Review URL: http://codereview.chromium.org/3531005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5570 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-