1. 09 Jan, 2019 1 commit
  2. 07 Jan, 2019 1 commit
  3. 21 Dec, 2018 1 commit
  4. 18 Dec, 2018 1 commit
  5. 28 Nov, 2018 1 commit
  6. 27 Nov, 2018 1 commit
  7. 24 Nov, 2018 1 commit
  8. 14 Nov, 2018 1 commit
  9. 13 Nov, 2018 2 commits
  10. 09 Oct, 2018 1 commit
  11. 25 Sep, 2018 2 commits
    • Ross McIlroy's avatar
      Reland "[Compile] Refactor BackgroundCompileTask to enable its use by CompilerDispatcher" · dc204cc6
      Ross McIlroy authored
      This is a reland of 31228a69
      
      TBR=yangguo@chromium.org,verwaest@chromium.org
      
      Original change's description:
      > [Compile] Refactor BackgroundCompileTask to enable its use by CompilerDispatcher
      >
      > Splits background compilation data out of ScriptStreamingData and into
      > BackgroundCompileTask. Also makes BackgroundCompileTask no longer a sub-class
      > of ScriptStreamingTask, and instead have ScriptStreamingTask delegate to a
      > BackgroundCompileTask.
      >
      > As part of this change, we now create the CharacterStream on the main thread,
      > and therefore have to set the (thread-local) runtime_call_stats on the already
      > created CharacterStream when the BackgroundCompileTask is run on the background
      > thread. As such, changes to CharacterStream were needed to feed the
      > runtime_call_stats through appropriately.
      >
      > Deprecates Source::GetCachedData and StreamedSource::GetCachedData since they are
      > no longer used, and the streamed source never has cached data (streaming is
      > suppressed if cached data is available). Also removes Utf8ChunkedStream which
      > is dead code.
      >
      > BUG=v8:8041, v8:8015
      > TBR=yangguo@chromium.org
      >
      > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
      > Change-Id: Ifcc723ebf930a1dc01135fcb70929d6168471cb3
      > Reviewed-on: https://chromium-review.googlesource.com/1236353
      > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
      > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#56182}
      
      Bug: v8:8041, v8:8015
      Change-Id: Ied5132c537d4c25c6e355f289c2a9cc1f8ff98e9
      Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
      Reviewed-on: https://chromium-review.googlesource.com/1242097
      Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
      Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
      Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#56201}
      dc204cc6
    • Maya Lekova's avatar
      Revert "[Compile] Refactor BackgroundCompileTask to enable its use by CompilerDispatcher" · 875480d2
      Maya Lekova authored
      This reverts commit 31228a69.
      
      Reason for revert: Introduces new pretty consistent flakes on Linux sanitizers, one of which block LKGR. Please see https://crbug.com/v8/8219
      
      Original change's description:
      > [Compile] Refactor BackgroundCompileTask to enable its use by CompilerDispatcher
      > 
      > Splits background compilation data out of ScriptStreamingData and into
      > BackgroundCompileTask. Also makes BackgroundCompileTask no longer a sub-class
      > of ScriptStreamingTask, and instead have ScriptStreamingTask delegate to a
      > BackgroundCompileTask.
      > 
      > As part of this change, we now create the CharacterStream on the main thread,
      > and therefore have to set the (thread-local) runtime_call_stats on the already
      > created CharacterStream when the BackgroundCompileTask is run on the background
      > thread. As such, changes to CharacterStream were needed to feed the
      > runtime_call_stats through appropriately.
      > 
      > Deprecates Source::GetCachedData and StreamedSource::GetCachedData since they are
      > no longer used, and the streamed source never has cached data (streaming is
      > suppressed if cached data is available). Also removes Utf8ChunkedStream which
      > is dead code.
      > 
      > BUG=v8:8041, v8:8015
      > TBR=yangguo@chromium.org
      > 
      > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
      > Change-Id: Ifcc723ebf930a1dc01135fcb70929d6168471cb3
      > Reviewed-on: https://chromium-review.googlesource.com/1236353
      > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
      > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#56182}
      
      TBR=rmcilroy@chromium.org,yangguo@chromium.org,verwaest@chromium.org
      
      Change-Id: Ib05bcbde2e9a588bd4008d2155f75cdac5cc47f5
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:8041, v8:8015
      Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
      Reviewed-on: https://chromium-review.googlesource.com/1241958Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
      Commit-Queue: Maya Lekova <mslekova@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#56187}
      875480d2
  12. 24 Sep, 2018 1 commit
    • Ross McIlroy's avatar
      [Compile] Refactor BackgroundCompileTask to enable its use by CompilerDispatcher · 31228a69
      Ross McIlroy authored
      Splits background compilation data out of ScriptStreamingData and into
      BackgroundCompileTask. Also makes BackgroundCompileTask no longer a sub-class
      of ScriptStreamingTask, and instead have ScriptStreamingTask delegate to a
      BackgroundCompileTask.
      
      As part of this change, we now create the CharacterStream on the main thread,
      and therefore have to set the (thread-local) runtime_call_stats on the already
      created CharacterStream when the BackgroundCompileTask is run on the background
      thread. As such, changes to CharacterStream were needed to feed the
      runtime_call_stats through appropriately.
      
      Deprecates Source::GetCachedData and StreamedSource::GetCachedData since they are
      no longer used, and the streamed source never has cached data (streaming is
      suppressed if cached data is available). Also removes Utf8ChunkedStream which
      is dead code.
      
      BUG=v8:8041, v8:8015
      TBR=yangguo@chromium.org
      
      Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
      Change-Id: Ifcc723ebf930a1dc01135fcb70929d6168471cb3
      Reviewed-on: https://chromium-review.googlesource.com/1236353
      Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
      Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#56182}
      31228a69
  13. 17 Sep, 2018 1 commit
  14. 14 Sep, 2018 1 commit
  15. 07 Sep, 2018 2 commits
    • Ross McIlroy's avatar
      [Parser] Split building logic out of ProducedPreParserScopeData. · 83dee31e
      Ross McIlroy authored
      Splits PreParsedScopeDataBuilder out of ProducedPreParserScopeData to make the split between
      building PreParsedScopeData and using already build PreParserScopeData more explicit.
      
      BUG=v8:8041
      
      Change-Id: Iab42cab84c247152c14ac39f3136f985753160ec
      Reviewed-on: https://chromium-review.googlesource.com/1202104
      Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
      Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#55718}
      83dee31e
    • Ross McIlroy's avatar
      [Parser] Add support for Zone allocated ConsumedPreParsingScopeData. · 8da9dbbb
      Ross McIlroy authored
      Adds support for zone allocated (off-heap) ConsumedPreParsingScopeData to
      enable worker-thread access to PreParsingScopeData during parallel IIFE
      compile tasks.
      
      In order to avoid code-duplication, a templated
      BaseConsumedPreParsingScopeData is added which implements the logic for
      decoding the bytestream into scope data. Two implementations of this
      base class are instantiated for each of the underlying serialized scope date:
        - ZoneConsumedPreParsedScopeData for exposing ZonePreParsedScopeData
        - OnHeapConsumedPreParsedScopeData for exposing on-heap PreParsedScopeData
      The interface for each of these classes is the ConsumedPreParsingScopeData,
      which exposes the methods required by the parser to deserialize the required
      data.
      
      As a side-cleanup, moved Ucs2CharLength and Utf8LengthHelper implementations
      to cc file so that we don't get a linker error if one of them are unused by
      the cc file including the header.
      
      
      BUG=v8:8041
      
      Change-Id: Id502312d32fe4a9ddb6f5d2d9d3e3a9d30b9b27d
      Reviewed-on: https://chromium-review.googlesource.com/1199462
      Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
      Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#55711}
      8da9dbbb
  16. 04 Sep, 2018 1 commit
  17. 28 Aug, 2018 1 commit
  18. 21 Aug, 2018 2 commits
  19. 20 Aug, 2018 1 commit
  20. 02 Aug, 2018 2 commits
  21. 01 Aug, 2018 3 commits
  22. 30 Jul, 2018 1 commit
  23. 26 Jul, 2018 2 commits
  24. 23 Jul, 2018 1 commit
  25. 13 Jul, 2018 1 commit
    • Michael Lippautz's avatar
      Revert "Reland "[heap] Added External Strings to external memory accounting."" · 71dddd14
      Michael Lippautz authored
      This reverts commit 7bff339e.
      
      Reason for revert: Breaks autoroll, see bug.
      
      Bug: v8:7944
      
      Original change's description:
      > Reland "[heap] Added External Strings to external memory accounting."
      > 
      > This is a reland of 5863c0b6
      > 
      > Original change's description:
      > > [heap] Added External Strings to external memory accounting.
      > > 
      > > Bug: chromium:845409
      > > Change-Id: I3fe2b294f6e038d77787cf0870d244ba7cc20550
      > > Reviewed-on: https://chromium-review.googlesource.com/1118164
      > > Commit-Queue: Rodrigo Bruno <rfbpb@google.com>
      > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#54110}
      > 
      > Bug: chromium:845409
      > Change-Id: Ied341ec6268000343d2a577b22f2a483460b01f5
      > Reviewed-on: https://chromium-review.googlesource.com/1121736
      > Commit-Queue: Rodrigo Bruno <rfbpb@google.com>
      > Reviewed-by: Peter Marshall <petermarshall@chromium.org>
      > Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
      > Reviewed-by: Hannes Payer <hpayer@chromium.org>
      > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#54410}
      
      TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org,petermarshall@chromium.org,rfbpb@google.com
      
      Change-Id: Ie55586e84f44a2d83c7f97110d60abb86f0730c5
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: chromium:845409
      Reviewed-on: https://chromium-review.googlesource.com/1136312Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
      Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#54428}
      71dddd14
  26. 12 Jul, 2018 1 commit
  27. 11 Jul, 2018 1 commit
  28. 09 Jul, 2018 1 commit
  29. 06 Jul, 2018 1 commit
    • Sigurd Schneider's avatar
      Revert "[parser] Move some PPSD sanity checks to debug" · b672210f
      Sigurd Schneider authored
      This reverts commit f45045cc.
      
      Reason for revert: <INSERT REASONING HERE>
      
      Original change's description:
      > [parser] Move some PPSD sanity checks to debug
      > 
      > Move some of PreParsedScopeData's santity checks, such as the magic
      > value separating skippable function data from scope data, to be debug
      > only, to save memory.
      > 
      > Start position of inner skippable functions is still kept, because it's
      > too good at catching bugs, but we may want to remove it in the future
      > as well.
      > 
      > Bug: chromium:818642
      > Change-Id: If86ff1b9845e8dd3b015b4e554d0033328b145bf
      > Reviewed-on: https://chromium-review.googlesource.com/1127046
      > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
      > Reviewed-by: Marja Hölttä <marja@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#54263}
      
      TBR=marja@chromium.org,leszeks@chromium.org
      
      Change-Id: I15ceedd66d9ecb66cf65f5834d09975b41d3ed27
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: chromium:818642
      Reviewed-on: https://chromium-review.googlesource.com/1127859Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
      Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#54290}
      b672210f
  30. 05 Jul, 2018 3 commits