- 11 Oct, 2019 1 commit
-
-
Robert Sesek authored
The dispatch_semaphore_t is a higher-level, more-efficient semaphore primitive if the cross-process capabilities of semaphore_t are not needed. Bug: chromium:1012386 Change-Id: I9cc6f025f00159f9424c054a3395542b9db00b89 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1848211Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#64254}
-
- 26 Sep, 2018 1 commit
-
-
Maya Lekova authored
That change is attempting to surface the root cause of a recent flake, see the related bug. Bug: v8:8228 Change-Id: Iebed5b8f46db3fd47154031856dc7ea173cf3d7f Reviewed-on: https://chromium-review.googlesource.com/1245771Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#56244}
-
- 02 Dec, 2017 1 commit
-
-
Mathias Bynens authored
This patch normalizes the casing of hexadecimal digits in escape sequences of the form `\xNN` and integer literals of the form `0xNNNN`. Previously, the V8 code base used an inconsistent mixture of uppercase and lowercase. Google’s C++ style guide uses uppercase in its examples: https://google.github.io/styleguide/cppguide.html#Non-ASCII_Characters Moreover, uppercase letters more clearly stand out from the lowercase `x` (or `u`) characters at the start, as well as lowercase letters elsewhere in strings. BUG=v8:7109 TBR=marja@chromium.org,titzer@chromium.org,mtrofin@chromium.org,mstarzinger@chromium.org,rossberg@chromium.org,yangguo@chromium.org,mlippautz@chromium.org NOPRESUBMIT=true Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I790e21c25d96ad5d95c8229724eb45d2aa9e22d6 Reviewed-on: https://chromium-review.googlesource.com/804294 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#49810}
-
- 18 Oct, 2017 1 commit
-
-
Clemens Hammacher authored
This CL fixes all occurences that don't require special OWNER reviews, or can be reviewed by Michi. After this one, we should be able to reenable the readability/check cpplint check. R=mstarzinger@chromium.org Bug: v8:6837, v8:6921 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng;master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: Ic81d68d5534eaa795b7197fed5c41ed158361d62 Reviewed-on: https://chromium-review.googlesource.com/721120 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#48670}
-
- 13 Oct, 2017 1 commit
-
-
Mathias Bynens authored
New code should use nullptr instead of NULL. This patch updates existing use of NULL to nullptr where applicable, making the code base more consistent. BUG=v8:6928,v8:6921 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng;master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: I4687f5b96fcfd88b41fa970a2b937b4f6538777c Reviewed-on: https://chromium-review.googlesource.com/718338 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#48557}
-
- 05 Sep, 2016 1 commit
-
-
ulan authored
BUG=chromium:605349 LOG=NO Review-Url: https://codereview.chromium.org/2304203002 Cr-Commit-Position: refs/heads/master@{#39157}
-
- 23 Aug, 2016 1 commit
-
-
mic.besace authored
On FreeBSD, sem_t is a struct with a couple of uint32_t fields. It only needs dword alignment on 64 bits architectures, not the qword (pointer) alignment that the CHECK currently enforces. BUG= Review-Url: https://codereview.chromium.org/2268993002 Cr-Commit-Position: refs/heads/master@{#38829}
-
- 27 Jul, 2016 1 commit
-
-
yangguo authored
Review-Url: https://codereview.chromium.org/2175193003 Cr-Commit-Position: refs/heads/master@{#38081}
-
- 22 Jun, 2016 1 commit
-
-
ahaas authored
If the semaphore is stored as a local variable in {CompileInParallel}, then the semaphore was sometimes deallocated too early and caused the compilation tasks to crash. This only happens with libc-2.19, libc-2.21 fixes the problem. R=mlippautz@chromium.org, rossberg@chromium.org Review-Url: https://codereview.chromium.org/2080223006 Cr-Commit-Position: refs/heads/master@{#37183}
-
- 08 Jun, 2016 1 commit
-
-
mstarzinger authored
This workaround had been added because sanitizer interceptors were linking against an old version of GLIBC. The respective sanitizers within LLVM have by now be fixed, workaround can be removed. The original workaround: https://codereview.chromium.org/1407463002 R=machenbach@chromium.org BUG=chromium:536813 Review-Url: https://codereview.chromium.org/2045993003 Cr-Commit-Position: refs/heads/master@{#36816}
-
- 20 May, 2016 1 commit
-
-
ulan authored
Instead of dynamically creating semaphore for each page parallel job, we create one semaphore for MarkCompact and reuse it. This patch also removes all instrumentation code that was added to help with investigation. BUG=chromium:609249 LOG=NO Review-Url: https://codereview.chromium.org/1998213002 Cr-Commit-Position: refs/heads/master@{#36407}
-
- 09 May, 2016 1 commit
-
-
ulan authored
flaky crashes. BUG=chromium:609249 LOG=NO Review-Url: https://codereview.chromium.org/1961893002 Cr-Commit-Position: refs/heads/master@{#36106}
-
- 03 May, 2016 1 commit
-
-
bjaideep authored
native_handle_ on AIX64 is of type int, and therefore fails on an operation with a pointer type. Use kSemaphoreAlignmentMask as sizeof(int) on AIX and sizeof(pointer) otherwise. R=jochen@chromium.org, mbrandy@us.ibm.com BUG=v8:4767 LOG=N Review-Url: https://codereview.chromium.org/1936003002 Cr-Commit-Position: refs/heads/master@{#35988}
-
- 27 Apr, 2016 1 commit
-
-
ulan authored
BUG=chromium:605349 LOG=NO Review URL: https://codereview.chromium.org/1921213004 Cr-Commit-Position: refs/heads/master@{#35825}
-
- 25 Apr, 2016 2 commits
-
-
ulan authored
Reland "Check for semaphore alignment on posix platforms. (patchset #1 id:1 of https://codereview.chromium.org/1912923003/ )" This patch also fixed three misaligned semaphores. This reverts commit 80c73e2c. BUG=chromium:605349 LOG=NO Review URL: https://codereview.chromium.org/1917923002 Cr-Commit-Position: refs/heads/master@{#35773}
-
hablich authored
Revert of Check for semaphore alignment on posix platforms. (patchset #1 id:1 of https://codereview.chromium.org/1912923003/ ) Reason for revert: blocks rolling. See https://bugs.chromium.org/p/chromium/issues/detail?id=605349 for more information. This CL only triggers the problem earlier but is not the culprit. The real bug is under investigation by the GC team. Original issue's description: > Check for semaphore alignment on posix platforms. > > BUG=chromium:605349 > LOG=NO > > Committed: https://crrev.com/8d24472acfaf7e67ca20106cb1f405fc0590c849 > Cr-Commit-Position: refs/heads/master@{#35717} TBR=mlippautz@chromium.org,ulan@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:605349 LOG=N Review URL: https://codereview.chromium.org/1921533002 Cr-Commit-Position: refs/heads/master@{#35755}
-
- 22 Apr, 2016 1 commit
-
-
ulan authored
BUG=chromium:605349 LOG=NO Review URL: https://codereview.chromium.org/1912923003 Cr-Commit-Position: refs/heads/master@{#35717}
-
- 16 Mar, 2016 1 commit
-
-
ulan authored
BUG=chromium:578883 LOG=NO Review URL: https://codereview.chromium.org/1811653002 Cr-Commit-Position: refs/heads/master@{#34838}
-
- 13 Oct, 2015 1 commit
-
-
mstarzinger authored
This adds a workaround that zeroes out semaphores before they are initialized. Some versions of sem_init (e.g. GLIBC_2.0) fail to fully zero out the semaphore, leading to {errno == ENOSYS} with subsequent sem_timedwait calls. R=machenbach@chromium.org BUG=chromium:536813 LOG=n Review URL: https://codereview.chromium.org/1407463002 Cr-Commit-Position: refs/heads/master@{#31232}
-
- 30 Sep, 2015 1 commit
-
-
mstarzinger authored
This enables linter checking for "readability/namespace" violations during presubmit and instead marks the few known exceptions that we allow explicitly. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1371083003 Cr-Commit-Position: refs/heads/master@{#31019}
-
- 02 Sep, 2014 1 commit
-
-
jarin@chromium.org authored
R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/527273003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23625 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 29 Aug, 2014 1 commit
-
-
svenpanne@chromium.org authored
This is basically https://codereview.chromium.org/513923005/ with a few changes: * Makefile.nacl and v8.gyp are untouched. * MAP_NORESERVE-handling is more defensive. * Added ugly busy-wait emulation of sem_timedwait. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/521473003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23513 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Aug, 2014 1 commit
-
-
bmeurer@chromium.org authored
This way we don't clash with the ASSERT* macros defined by GoogleTest, and we are one step closer to being able to replace our homegrown base/ with base/ from Chrome. R=jochen@chromium.org, svenpanne@chromium.org Review URL: https://codereview.chromium.org/430503007 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22812 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 30 Jun, 2014 1 commit
-
-
jochen@chromium.org authored
Also split v8-core independent methods from checks.h to base/logging.h and merge v8checks with the rest of checks. The CPU::FlushICache method is moved to CpuFeatures::FlushICache RoundUp and related methods are moved to base/macros.h Remove all layering violations from src/libplatform BUG=none R=jkummerow@chromium.org LOG=n Review URL: https://codereview.chromium.org/358363002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22092 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Jun, 2014 1 commit
-
-
jochen@chromium.org authored
- this avoids using relative include paths which are forbidden by the style guide - makes the code more readable since it's clear which header is meant - allows for starting to use checkdeps BUG=none R=jkummerow@chromium.org, danno@chromium.org LOG=n Review URL: https://codereview.chromium.org/304153016 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21625 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 29 Apr, 2014 1 commit
-
-
bmeurer@chromium.org authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/259183002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@21035 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 14 Jan, 2014 1 commit
-
-
bmeurer@chromium.org authored
Some libraries (e.g. Dinkumware) perform strict checks on whether the symbols defined in classic C library headers (e.g. <stdio.h>), or in C++-style C library headers (e.g. <cmath>) are used correctly (respectively, in the global namespace, or in namespace std). BUG= R=danno@chromium.org Review URL: https://codereview.chromium.org/121303005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18578 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 02 Sep, 2013 1 commit
-
-
bmeurer@chromium.org authored
Drop the previous Semaphore class from platform files. Add new Semaphore class using the new TimeDelta class for the WaitFor() operation. Consistently assert correct behaviour for the different implementations. Improve test coverage of the Semaphore class. R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/23748003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16473 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-