- 09 Apr, 2020 16 commits
-
-
Clemens Backes authored
This reverts commit f902ef32. Reason for revert: Makes gc-stress unhappy: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20gc%20stress/27404 Original change's description: > [wasm] Cleanup wasm script creation > > - Do not expose CreateWasmScript since we should now use > WasmEngine:GetOrCreateScript instead, > - Initialize all Script fields in CreateWasmScript, not in > WasmModuleObject::New, > - Do not pass code size estimate argument, since we can always use the > actual native module's committed code space. > > R=clemensb@chromium.org > > Bug: v8:10349 > Change-Id: If9250d62ffc271ab6efc3b9c45958a305c9d1827 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2135633 > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67083} TBR=clemensb@chromium.org,thibaudm@chromium.org Change-Id: Iac2978af1a300ec079baebab0feb8c9598711738 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10349 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2144058Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#67085}
-
Nico Hartmann authored
This reverts commit 3e1c7040. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN%20-%20concurrent%20marking/12665 Original change's description: > Reland "cppgc: Add page memory allocation backend" > > This is a port of src/components/gc that was added recently. > > Differences: > - Added back bucketing to the page pool, as that guarantees that > arenas used for specific types do not have their pages used by other > arenas. > - Replaced base::flat_map with std::map. This may cause performance > regressions when using PageMemoryRegionTree in hot paths. A > vector-like representation may be used to fix such a regression > > This reverts commit 656c68a7. > > Bug: chromium:1056170 > Change-Id: I638183c944255ebcaab47d2b94b1980d54479746 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2143814 > Reviewed-by: Maya Lekova <mslekova@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67080} TBR=mlippautz@chromium.org,mslekova@chromium.org Change-Id: I04b048dd979c32e9275c972307796d5f75865037 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1056170 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2144114Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#67084}
-
Thibaud Michaud authored
- Do not expose CreateWasmScript since we should now use WasmEngine:GetOrCreateScript instead, - Initialize all Script fields in CreateWasmScript, not in WasmModuleObject::New, - Do not pass code size estimate argument, since we can always use the actual native module's committed code space. R=clemensb@chromium.org Bug: v8:10349 Change-Id: If9250d62ffc271ab6efc3b9c45958a305c9d1827 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2135633Reviewed-by:
-
Thibaud Michaud authored
R=ahaas@chromium.org Bug: v8:10408 Change-Id: I6a4a1d82333cf31520526c766357c78d3d8dd206 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2140941 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#67082}
-
Clemens Backes authored
Templates provide better error messages and make debugging easier. R=zhin@chromium.org Bug: v8:10364 Change-Id: Ia3581c4458e8edb3b24371605000b0b00bb5069d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2140936 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67081}
-
Michael Lippautz authored
This is a port of src/components/gc that was added recently. Differences: - Added back bucketing to the page pool, as that guarantees that arenas used for specific types do not have their pages used by other arenas. - Replaced base::flat_map with std::map. This may cause performance regressions when using PageMemoryRegionTree in hot paths. A vector-like representation may be used to fix such a regression This reverts commit 656c68a7. Bug: chromium:1056170 Change-Id: I638183c944255ebcaab47d2b94b1980d54479746 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2143814Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#67080}
-
Omer Katz authored
GetHeapFromPayload returned the page header address instead of the value of the first field of the header. Bug: chromium:1056170 Change-Id: I4de5be975accced32460d6fab91543e6a5b07ba0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2143825 Auto-Submit: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#67079}
-
Clemens Backes authored
This increases source code size, but the code is simple and repetitive. Complexity is reduced by removing the macros. R=zhin@chromium.org Bug: v8:10364 Change-Id: I989c4d78aaebe00c7fbb525d88a6670cd0fe3b92 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2141732Reviewed-by:
-
Leszek Swirski authored
Fix off-thread space merging unit tests, by a) Doing a GC on each test teardown (avoiding leaking GC state between tests), and b) Removing the AllocationStep when merging, which could cause a deadlock if incremental marking triggered a free-list refill. Bug: v8:10142 Change-Id: Id2670115f96ab3b13613ea357bd44a639d0151e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2142260 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#67077}
-
Michael Lippautz authored
This CL provides a basic allocator that allocates normal-sized objects on pages without ever reusing them. This allows for already using the backref from page to heap which is used in some critical places (pre-finalizers, write barrier, Persistent). Bug: chromium:1056170 Change-Id: Ifada9b7e984827906c267d1a3a521576587feaeb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2141736 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Dominik Inführ authored
Add flag FLAG_concurrent_allocation that when enabled protects all runtime allocations in the old space with a mutex. Prerequisite for concurrent allocation. Still disabled by default. Bug: v8:10315 Change-Id: I37e59b3d51fe3aad112f0b556ea867cc0a2496e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2140937 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Maya Lekova authored
This reverts commit d4056c61. Reason for revert: Fails on GCC, please check https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20gcc/6184 Original change's description: > cppgc: Add page memory allocation backend > > This is a port of src/components/gc that was added recently. > > Differences: > - Added back bucketing to the page pool, as that guarantees that > arenas used for specific types do not have their pages used by other > arenas. > - Replaced base::flat_map with std::map. This may cause performance > regressions when using PageMemoryRegionTree in hot paths. A > vector-like representation may be used to fix such a regression > > Bug: chromium:1056170 > Change-Id: I03e3abe55faf7bb50c8011dafc23396889bf66db > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2139586 > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Omer Katz <omerkatz@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67073} TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org,bikineev@chromium.org,omerkatz@chromium.org Change-Id: I1e421898bb8a08f32d8eb2355ed547e0ee38b429 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1056170 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2140949Reviewed-by:
-
Michael Lippautz authored
This is a port of src/components/gc that was added recently. Differences: - Added back bucketing to the page pool, as that guarantees that arenas used for specific types do not have their pages used by other arenas. - Replaced base::flat_map with std::map. This may cause performance regressions when using PageMemoryRegionTree in hot paths. A vector-like representation may be used to fix such a regression Bug: chromium:1056170 Change-Id: I03e3abe55faf7bb50c8011dafc23396889bf66db Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2139586 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#67073}
-
Ng Zhi An authored
While working on some AVX stuff, saw that these ops were missing from the test cases. Change-Id: Ie41be465a0715323096c6549b21aa9e994eaac3e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2137472Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67072}
-
Ng Zhi An authored
Bug: v8:10180 Change-Id: I5e7e83c23b6029cc5b55c2aadee77898173a77f0 Fixed: v8:9543 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2110951Reviewed-by:
-
Shu-yu Guo authored
Apple currently objects to cleanupSome but agrees to shipping the rest of WeakRefs. Separate out cleanupSome to its own flag so the rest of WeakRefs may ship. Bug: v8:8179 Change-Id: I6159fc743c9cb658860d4260b0dcb95e54630fdc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2141011 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#67070}
-
- 08 Apr, 2020 24 commits
-
-
Shu-yu Guo authored
Bug: v8:8179 Change-Id: I0cd43db6558db616690de2dd012bf7518c49345d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2138563 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Emanuel Ziegler authored
Expose Wasm error classes to the V8 API such that they can be accessed from embedding environments like Blink. Follow-up in change I19568e6c0906de518fd6e5b417ef7e045e9d43c8 R=ahaas@chromium.org R=ulan@chromium.org Change-Id: I238288de73283a06c5075d0060977b366c0fbe09 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2137416 Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> Reviewed-by:
-
Clemens Backes authored
This test is already skipped in different configuration, but it still generally flakes. We need to investigate more before re-enabling it in all configuration that we want to support. R=nicohartmann@chromium.org Bug: v8:10410 Change-Id: I382e168add952d8e9f4802306a9029ea9651a389 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2142263 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Milad Farazmand authored
Port 44826509 Original Commit Message: This flips the --debug-in-liftoff flag to be on by default. There are still some outstanding issues with that configuration, but not more than with the interpreter configuration. Thus flip now, such that we can fully focus on stabilizing that config. R=clemensb@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ie18137fe5f1b9533a0882b5e57d8c320ee340387 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2142311 Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Reviewed-by:
-
Paolo Severini authored
This fixes an issue in WasmScript::ClearBreakPoint, which is was still removing breakpoints in the interpreter, even when debugging in Liftoff. The existing test inspector/debugger/wasm-stepping-liftoff.js does not require any changes. Change-Id: I5c60839ffde91cdd11d9f808a3102f2cc1324087 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2136872Reviewed-by:
-
Clemens Backes authored
Several JS tests are already skipped in that config. This CL adds a wasm test that also started flaking. TBR=thibaudm@chromium.org Bug: v8:10410, chromium:772010 Change-Id: Ie16d60a5066a56005d9cf1e4951d6ed1c17e4dc7 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2142256Reviewed-by:
-
Daniel Clifford authored
This fix is a bit of overkill, but ensures that verifier methods are available across library boundaries. Change-Id: I120560f8e8e0be0ffcba43b46197efca4db0a62c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2141739Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#67063}
-
Philip Pfaffe authored
Change-Id: If7691bc70aac4a8f2ba8fe383bd44a829a9a0bdb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2132265Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Philip Pfaffe <pfaffe@chromium.org> Cr-Commit-Position: refs/heads/master@{#67062}
-
Anton Bikineev authored
This change comprises a few tiny changes wrt Member: 1) Move member policies to a separate file so that some of them (CheckingPolicy) can be reused by Persistent; 2) SFINAE out incompatible pointers from heterogeneous ctor/asgnmt; 3) Rename kMemberSentinel to kSentinelPointer. Bug: chromium:1056170 Change-Id: I4482998e6ba61005a5d0861dcae9fab2aa43702c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2139587Reviewed-by:
-
Mythri A authored
For keyed stores we recompute handlers when we see a new map so that we could transition to the most general elements kind we have seen so far. When recomputing these handlers we drop the deprecated maps. Instead we could TryUpdate deprecated maps. This would be inline with what TurboFan does and also may be better for performance. Bug: chromium:1053939 Change-Id: Id38b60538d56f4b376460c0faece20768a18f25f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2130129 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#67060}
-
Georg Neis authored
This is still unused but will eventually be used by fuzzers. Bug: v8:10249 Change-Id: Ib592a5a8da1399ad8fb5a277ea94fda68b382058 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2141735Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#67059}
-
Georg Neis authored
JSNativeContextSpecialization lowered this operator to a regular property store, potentially ignoring a request to set the "name" property of a function. This CL performs the lowering only if there's no such request. Bug: chromium:1068494 Change-Id: Ia2eaf05af9c8402f9e6450ee519a7c36c18cd44e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2139581 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Clemens Backes authored
Debugging with multiple isolates involved is known to be broken. TBR=thibaudm@chromium.org Bug: v8:10359 Change-Id: I2f32cd4b7b53492508948a85e9750167b25b8d89 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2140938Reviewed-by:
-
Tobias Tebbi authored
The two refactorings are somewhat orthogonal, but intersect at the class and instance type list generation, which is why it's easier to put them in one CL. For the removal of HasIndexedField, the removal is motivated by the fact that is no longer necessary, and that using a flag to store this kind of information is hacky. For the class list changes, this is a cleanup in that we no longer generate third-order macros, but instead normal macro lists. There is a functional change and bug-fix in that we no longer include abstract classes in lists that refer to instance types or maps. It's still somewhat broken though, so I can't test abstract internal classes yet, though. Coming in a follow-up CL. TBR=ulan@chromium.org Bug: v8:7793 Change-Id: Ided8591370570ca3810d7991f53177ca32e03048 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2108034 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
The macro magic used to assemble the operator cache in machine-operator.cc was quite involved and difficult to follow. This change replaces many macros with templates and simplifies the logic. Similar changes could also be applied to other operator builders. Change-Id: Ie4268c59b7c663f1aac360c87e9cce3100c90a29 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2132246 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#67055}
-
Anton Bikineev authored
Bug: chromium:1056170 Change-Id: I98bbff8d2938c6b34fe2c358d504ba6211ec8b54 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2140931Reviewed-by:
-
Liviu Rau authored
Seems I need a new one No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: If3befbd243d17a885aea360ec27e372fa05bbb2b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2140934Reviewed-by:
Liviu Rau <liviurau@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/master@{#67053}
-
Clemens Backes authored
Debugging with multiple isolates involved is known to be broken. Thus skip another test which flakes currently. TBR=thibaudm@chromium.org Bug: v8:10359 Change-Id: Ib0758794623cca1cf9bdd6d6d8aa673ceffd9d7c No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2140933Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#67052}
-
Zhou, Zhiguo authored
This reorders the SIMD opcodes together with their implementations on x64, ia32 according to src/wasm/wasm-opcodes.h. Bug: v8:9909 Change-Id: Ib2e75927b3b44ebc951005222c8641c256d8872c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2135074Reviewed-by:
-
Anton Bikineev authored
Headers containing only implementation details are better to stay in a separate dir to indicate the user that they shouldn't be included. Bug: chromium:1056170 Change-Id: I10f84ddf709b146396aadc820ec33bc6a49b2dac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2139585Reviewed-by:
-
Clemens Backes authored
This is a reland of 44826509. TSan issue were fixed in https://crrev.com/c/2139574. One test failing in the 'stress' variant is skipped for now, until we figure out what the intended behaviour actually is. Original change's description: > [wasm] Debug in Liftoff by default > > This flips the --debug-in-liftoff flag to be on by default. > There are still some outstanding issues with that configuration, but not > more than with the interpreter configuration. Thus flip now, such that > we can fully focus on stabilizing that config. > > R=ecmziegler@chromium.org > > Bug: v8:10351 > Change-Id: I7681f40aa2516557ef3ab4efd9a2c1f88e3b4df7 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2135727 > Reviewed-by: Emanuel Ziegler <ecmziegler@chromium.org> > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67018} Bug: v8:10351, v8:10403 Change-Id: I4c2f1af46233546d6ebeb638c7ef10aac56cd92d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2139575 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Emanuel Ziegler <ecmziegler@chromium.org> Cr-Commit-Position: refs/heads/master@{#67049}
-
Yang Guo authored
TBR=verwaest@chromium.org Change-Id: If18d402f9b0b9c500307fd454eafe93de701599c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2141731Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#67048}
-
Clemens Backes authored
The compare operations pass a hard-coded first argument to the emit function. Instead of implementing this via a lambda, put it in a separate {BindFirst} helper, similar to {std::bind_front} (C++20). R=zhin@chromium.org Bug: v8:10364 Change-Id: If48c87a3df5ea6fa2b155873e4586af5d6b21119 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2139580Reviewed-by: -
Michael Lippautz authored
Neither Member, nor GarbageCollected objects (and friends) should be allocated on the stack. Create a special test fixture that allows for writing idiomatic unit tests that depend on allocation but do not pull in garbage collection. Bug: chromium:1056170 Change-Id: I4118201a51658f7247412434a867d35c91299439 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2139583Reviewed-by:
-
