1. 21 May, 2019 1 commit
    • Simon Zünd's avatar
      [torque] More flexibel and uniform error reporting · bdfd1e4b
      Simon Zünd authored
      This CL changes the existing TorqueError struct into a more general
      TorqueMessage by adding a "kind" enum. The contextual for lint errors
      is removed and replaced by a list of TorqueMessages.
      
      A MessageBuilder is introduced to help with the different
      combinations of present information and method of reporting. A lint
      error with custom SourcePosition can be reported like this:
      
      Lint("naming convention error").Position(<src_pos_var>);
      
      While a fatal error, with CurrentSourcePosition can be thrown
      like this:
      
      Error("something went horrible wrong").Throw();
      
      This approach is both backwards compatible and should prove flexible
      enough to add more information to messages or add other message kinds.
      
      Bug: v8:7793
      Change-Id: Ib04fa188e34b3e8e9a6526a086f80da8f690a6f5
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617245
      Commit-Queue: Simon Zünd <szuend@chromium.org>
      Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
      Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#61696}
      bdfd1e4b
  2. 16 Apr, 2019 1 commit
    • Simon Zünd's avatar
      Reland^3 "[torque] Throw exception instead of aborting if something goes wrong" · 2d8f2e86
      Simon Zünd authored
      This is a reland of ffe6940f
      
      The UBSan issue is fixed with https://crrev.com/c/1566511
      
      TBR=tebbi@chromium.org
      
      Original change's description:
      > Reland^2 "[torque] Throw exception instead of aborting if something goes wrong"
      >
      > This is a reland of 251d1623
      >
      > The reland fixes ASAN component builds by adding RTTI build config to both
      > torque executables. Big thanks to sigurds for finding the fix.
      >
      > Original change's description:
      > > Reland "[torque] Throw exception instead of aborting if something goes wrong"
      > >
      > > This is a reland of 3bd49f9b
      > >
      > > The issue on the windows bot is apparently a compiler bug in MSVC related to
      > > move construction. The fix seems to be to change the order of the fields in
      > > "JsonParseResult" (go figure).
      > >
      > > Drive-by-change: Fix LS on windows by emitting correct line endings and
      > > enabling exceptions for the LS executable as well.
      > >
      > > Original change's description:
      > > > [torque] Throw exception instead of aborting if something goes wrong
      > > >
      > > > This CL enables exceptions for the Torque compiler and Torque language
      > > > server. Instead of aborting when something goes wrong during
      > > > compilation, a TorqueError is thrown, containing the error message
      > > > and a source position. The compiler executable still prints the error
      > > > and aborts, while the language server will pass this information
      > > > along to the client (not included in this CL).
      > > >
      > > > R=danno@chromium.org
      > > >
      > > > Bug: v8:8880
      > > > Change-Id: Iad83c46fb6a91c1babbc0ae7dbd94fbe4e7f1663
      > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526003
      > > > Reviewed-by: Daniel Clifford <danno@chromium.org>
      > > > Commit-Queue: Simon Zünd <szuend@chromium.org>
      > > > Cr-Commit-Position: refs/heads/master@{#60512}
      > >
      > > Bug: v8:8880
      > > Change-Id: I00e6591bbb4c516dd7540a7e27196853bc637f11
      > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545995
      > > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
      > > Commit-Queue: Simon Zünd <szuend@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#60736}
      >
      > Bug: v8:8880
      > Change-Id: Iba198d771169283e83e74324f27aa9e90b8d8975
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1563770
      > Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
      > Commit-Queue: Simon Zünd <szuend@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#60804}
      
      Bug: v8:8880
      Change-Id: I5b7e40ad27bff8f7bfa22240954c2cb75083ad82
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1564065Reviewed-by: 's avatarSimon Zünd <szuend@chromium.org>
      Commit-Queue: Simon Zünd <szuend@chromium.org>
      Auto-Submit: Simon Zünd <szuend@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#60860}
      2d8f2e86
  3. 12 Apr, 2019 2 commits
    • Simon Zünd's avatar
      Revert "Reland^2 "[torque] Throw exception instead of aborting if something goes wrong"" · d7801445
      Simon Zünd authored
      This reverts commit ffe6940f.
      
      Reason for revert: Breaks UBSan bot
      
      Original change's description:
      > Reland^2 "[torque] Throw exception instead of aborting if something goes wrong"
      > 
      > This is a reland of 251d1623
      > 
      > The reland fixes ASAN component builds by adding RTTI build config to both
      > torque executables. Big thanks to sigurds for finding the fix.
      > 
      > Original change's description:
      > > Reland "[torque] Throw exception instead of aborting if something goes wrong"
      > >
      > > This is a reland of 3bd49f9b
      > >
      > > The issue on the windows bot is apparently a compiler bug in MSVC related to
      > > move construction. The fix seems to be to change the order of the fields in
      > > "JsonParseResult" (go figure).
      > >
      > > Drive-by-change: Fix LS on windows by emitting correct line endings and
      > > enabling exceptions for the LS executable as well.
      > >
      > > Original change's description:
      > > > [torque] Throw exception instead of aborting if something goes wrong
      > > >
      > > > This CL enables exceptions for the Torque compiler and Torque language
      > > > server. Instead of aborting when something goes wrong during
      > > > compilation, a TorqueError is thrown, containing the error message
      > > > and a source position. The compiler executable still prints the error
      > > > and aborts, while the language server will pass this information
      > > > along to the client (not included in this CL).
      > > >
      > > > R=danno@chromium.org
      > > >
      > > > Bug: v8:8880
      > > > Change-Id: Iad83c46fb6a91c1babbc0ae7dbd94fbe4e7f1663
      > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526003
      > > > Reviewed-by: Daniel Clifford <danno@chromium.org>
      > > > Commit-Queue: Simon Zünd <szuend@chromium.org>
      > > > Cr-Commit-Position: refs/heads/master@{#60512}
      > >
      > > Bug: v8:8880
      > > Change-Id: I00e6591bbb4c516dd7540a7e27196853bc637f11
      > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545995
      > > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
      > > Commit-Queue: Simon Zünd <szuend@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#60736}
      > 
      > Bug: v8:8880
      > Change-Id: Iba198d771169283e83e74324f27aa9e90b8d8975
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1563770
      > Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
      > Commit-Queue: Simon Zünd <szuend@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#60804}
      
      TBR=sigurds@chromium.org,tebbi@chromium.org,szuend@chromium.org
      
      Change-Id: I30ccec8ac28158c102a4e9a01074432172685f96
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:8880
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1564207Reviewed-by: 's avatarSimon Zünd <szuend@chromium.org>
      Commit-Queue: Simon Zünd <szuend@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#60805}
      d7801445
    • Simon Zünd's avatar
      Reland^2 "[torque] Throw exception instead of aborting if something goes wrong" · ffe6940f
      Simon Zünd authored
      This is a reland of 251d1623
      
      The reland fixes ASAN component builds by adding RTTI build config to both
      torque executables. Big thanks to sigurds for finding the fix.
      
      Original change's description:
      > Reland "[torque] Throw exception instead of aborting if something goes wrong"
      >
      > This is a reland of 3bd49f9b
      >
      > The issue on the windows bot is apparently a compiler bug in MSVC related to
      > move construction. The fix seems to be to change the order of the fields in
      > "JsonParseResult" (go figure).
      >
      > Drive-by-change: Fix LS on windows by emitting correct line endings and
      > enabling exceptions for the LS executable as well.
      >
      > Original change's description:
      > > [torque] Throw exception instead of aborting if something goes wrong
      > >
      > > This CL enables exceptions for the Torque compiler and Torque language
      > > server. Instead of aborting when something goes wrong during
      > > compilation, a TorqueError is thrown, containing the error message
      > > and a source position. The compiler executable still prints the error
      > > and aborts, while the language server will pass this information
      > > along to the client (not included in this CL).
      > >
      > > R=danno@chromium.org
      > >
      > > Bug: v8:8880
      > > Change-Id: Iad83c46fb6a91c1babbc0ae7dbd94fbe4e7f1663
      > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526003
      > > Reviewed-by: Daniel Clifford <danno@chromium.org>
      > > Commit-Queue: Simon Zünd <szuend@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#60512}
      >
      > Bug: v8:8880
      > Change-Id: I00e6591bbb4c516dd7540a7e27196853bc637f11
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545995
      > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
      > Commit-Queue: Simon Zünd <szuend@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#60736}
      
      Bug: v8:8880
      Change-Id: Iba198d771169283e83e74324f27aa9e90b8d8975
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1563770Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
      Commit-Queue: Simon Zünd <szuend@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#60804}
      ffe6940f
  4. 10 Apr, 2019 2 commits
    • Maya Lekova's avatar
      Revert "Reland "[torque] Throw exception instead of aborting if something goes wrong"" · 69e90801
      Maya Lekova authored
      This reverts commit 251d1623.
      
      Reason for revert: Breaks ASAN debug builders for ClusterFuzz, see https://ci.chromium.org/p/v8/builders/ci/V8%20Clusterfuzz%20Linux64%20ASAN%20-%20debug%20builder/8115
      
      Original change's description:
      > Reland "[torque] Throw exception instead of aborting if something goes wrong"
      > 
      > This is a reland of 3bd49f9b
      > 
      > The issue on the windows bot is apparently a compiler bug in MSVC related to
      > move construction. The fix seems to be to change the order of the fields in
      > "JsonParseResult" (go figure).
      > 
      > Drive-by-change: Fix LS on windows by emitting correct line endings and
      > enabling exceptions for the LS executable as well.
      > 
      > Original change's description:
      > > [torque] Throw exception instead of aborting if something goes wrong
      > >
      > > This CL enables exceptions for the Torque compiler and Torque language
      > > server. Instead of aborting when something goes wrong during
      > > compilation, a TorqueError is thrown, containing the error message
      > > and a source position. The compiler executable still prints the error
      > > and aborts, while the language server will pass this information
      > > along to the client (not included in this CL).
      > >
      > > R=danno@chromium.org
      > >
      > > Bug: v8:8880
      > > Change-Id: Iad83c46fb6a91c1babbc0ae7dbd94fbe4e7f1663
      > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526003
      > > Reviewed-by: Daniel Clifford <danno@chromium.org>
      > > Commit-Queue: Simon Zünd <szuend@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#60512}
      > 
      > Bug: v8:8880
      > Change-Id: I00e6591bbb4c516dd7540a7e27196853bc637f11
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545995
      > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
      > Commit-Queue: Simon Zünd <szuend@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#60736}
      
      TBR=danno@chromium.org,tebbi@chromium.org,szuend@chromium.org
      
      Change-Id: I0b22db1652bd46fbb7167f75b710ed5e408ea8ac
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:8880
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1561311Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
      Commit-Queue: Maya Lekova <mslekova@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#60747}
      69e90801
    • Simon Zünd's avatar
      Reland "[torque] Throw exception instead of aborting if something goes wrong" · 251d1623
      Simon Zünd authored
      This is a reland of 3bd49f9b
      
      The issue on the windows bot is apparently a compiler bug in MSVC related to
      move construction. The fix seems to be to change the order of the fields in
      "JsonParseResult" (go figure).
      
      Drive-by-change: Fix LS on windows by emitting correct line endings and
      enabling exceptions for the LS executable as well.
      
      Original change's description:
      > [torque] Throw exception instead of aborting if something goes wrong
      >
      > This CL enables exceptions for the Torque compiler and Torque language
      > server. Instead of aborting when something goes wrong during
      > compilation, a TorqueError is thrown, containing the error message
      > and a source position. The compiler executable still prints the error
      > and aborts, while the language server will pass this information
      > along to the client (not included in this CL).
      >
      > R=danno@chromium.org
      >
      > Bug: v8:8880
      > Change-Id: Iad83c46fb6a91c1babbc0ae7dbd94fbe4e7f1663
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526003
      > Reviewed-by: Daniel Clifford <danno@chromium.org>
      > Commit-Queue: Simon Zünd <szuend@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#60512}
      
      Bug: v8:8880
      Change-Id: I00e6591bbb4c516dd7540a7e27196853bc637f11
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545995Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
      Commit-Queue: Simon Zünd <szuend@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#60736}
      251d1623
  5. 28 Mar, 2019 2 commits
    • Simon Zünd's avatar
      Revert "[torque] Throw exception instead of aborting if something goes wrong" · c3b51ac0
      Simon Zünd authored
      This reverts commit 3bd49f9b.
      
      Reason for revert: Build failure on Win Bot
      
      Original change's description:
      > [torque] Throw exception instead of aborting if something goes wrong
      > 
      > This CL enables exceptions for the Torque compiler and Torque language
      > server. Instead of aborting when something goes wrong during
      > compilation, a TorqueError is thrown, containing the error message
      > and a source position. The compiler executable still prints the error
      > and aborts, while the language server will pass this information
      > along to the client (not included in this CL).
      > 
      > R=​danno@chromium.org
      > 
      > Bug: v8:8880
      > Change-Id: Iad83c46fb6a91c1babbc0ae7dbd94fbe4e7f1663
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526003
      > Reviewed-by: Daniel Clifford <danno@chromium.org>
      > Commit-Queue: Simon Zünd <szuend@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#60512}
      
      TBR=danno@chromium.org,mvstanton@chromium.org,szuend@chromium.org
      
      Change-Id: Iac253da404eaf6e534267f59a42ca93667c205e4
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:8880
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1543849Reviewed-by: 's avatarSimon Zünd <szuend@chromium.org>
      Commit-Queue: Simon Zünd <szuend@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#60513}
      c3b51ac0
    • Simon Zünd's avatar
      [torque] Throw exception instead of aborting if something goes wrong · 3bd49f9b
      Simon Zünd authored
      This CL enables exceptions for the Torque compiler and Torque language
      server. Instead of aborting when something goes wrong during
      compilation, a TorqueError is thrown, containing the error message
      and a source position. The compiler executable still prints the error
      and aborts, while the language server will pass this information
      along to the client (not included in this CL).
      
      R=danno@chromium.org
      
      Bug: v8:8880
      Change-Id: Iad83c46fb6a91c1babbc0ae7dbd94fbe4e7f1663
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526003Reviewed-by: 's avatarDaniel Clifford <danno@chromium.org>
      Commit-Queue: Simon Zünd <szuend@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#60512}
      3bd49f9b
  6. 04 Mar, 2019 1 commit
  7. 26 Feb, 2019 1 commit