- 08 Jun, 2018 1 commit
-
-
Michael Achenbach authored
Bug: v8:7812 Change-Id: Ia5a9c68e0aeb9d993ca2cd5f855ff39e172890e8 Reviewed-on: https://chromium-review.googlesource.com/1090282Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#53601}
-
- 05 Jun, 2018 1 commit
-
-
Michael Achenbach authored
Bug: chromium:846711 Change-Id: I04e448c90f557f5ec23feae5989ece89e3c88dbc Reviewed-on: https://chromium-review.googlesource.com/1073453Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#53508}
-
- 22 May, 2018 1 commit
-
-
Michael Lippautz authored
This is to allow testing object stats collection. No-try: true Bug: v8:7760 Change-Id: I1e5318f18bfb3799b90c0ee0aec6df87a794b32c Reviewed-on: https://chromium-review.googlesource.com/1065478 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#53274}
-
- 17 May, 2018 1 commit
-
-
Michael Achenbach authored
This is to speed up slow nosnap runs. Allocation verification is covered by running mksnapshot on other builders. Change-Id: I9c286f7dd4abac9cf1be45be4a483a7b36d09f8a Reviewed-on: https://chromium-review.googlesource.com/1059113Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#53234}
-
- 08 May, 2018 1 commit
-
-
Eric Holk authored
D8 enables the Wasm trap handler by default now, but we need to make sure the older bounds check case still gets test coverage too, as bounds checks will continue to be a supported configuration. Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I5b0bdded6929a9b3a8480e87d038398b8d2a0fd8 Reviewed-on: https://chromium-review.googlesource.com/1048835Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Eric Holk <eholk@chromium.org> Cr-Commit-Position: refs/heads/master@{#53078}
-
- 20 Apr, 2018 1 commit
-
-
Michael Achenbach authored
This makes testing with random gc stress use the status file entrees for gc fuzzing as well, since many test cases not suitable for one, are not suitable for the other. This also skips two more tests that rely on assert(Un)Optimized, which is unreliable with gc fuzzing. TBR=sigurds@chromium.org Change-Id: I33a617b251d5cf65cf6e486d07ec55cde050b8ab Reviewed-on: https://chromium-review.googlesource.com/1021082 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52701}
-
- 18 Apr, 2018 2 commits
-
-
Michael Achenbach authored
NOTRY=true TBR=sergiyb@chromium.org Bug: chromium:830557 Change-Id: I61510297e5195eb74425c71e41c4d95f080a280d Reviewed-on: https://chromium-review.googlesource.com/1016420Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52659}
-
Michael Achenbach authored
Prepares for: https://crrev.com/c/1015000 NOTRY=true Bug: chromium:830557 Change-Id: I51c12867d95de19350e0e55aaf097bbb479348dc Reviewed-on: https://chromium-review.googlesource.com/1015004 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#52657}
-
- 28 Mar, 2018 3 commits
-
-
Michael Achenbach authored
This is a reland of 712b66da Breakage is fixed on infra side by: https://crrev.com/c/983417 Original change's description: > [build] Remove legacy isolate configurations > > Bug: chromium:669910 > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: Iad58563fd4bb35501493f88af83362b1206a186c > Reviewed-on: https://chromium-review.googlesource.com/982630 > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52267} Bug: chromium:669910 Change-Id: I6c06a1fe9587206aa4e983befb105327bfec4154 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/983573Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52273}
-
Michael Achenbach authored
This reverts commit 712b66da. Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20builder/builds/32049 Original change's description: > [build] Remove legacy isolate configurations > > Bug: chromium:669910 > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: Iad58563fd4bb35501493f88af83362b1206a186c > Reviewed-on: https://chromium-review.googlesource.com/982630 > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52267} TBR=machenbach@chromium.org,yangguo@chromium.org,sergiyb@chromium.org,jgruber@chromium.org Change-Id: I1955325b0b419b38d793ab205131de8de08cb50a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:669910 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/983418Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52268}
-
Michael Achenbach authored
Bug: chromium:669910 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Iad58563fd4bb35501493f88af83362b1206a186c Reviewed-on: https://chromium-review.googlesource.com/982630Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52267}
-
- 21 Mar, 2018 1 commit
-
-
jgruber authored
Embedded builtins are now based off the v8_enable_embedded_builtins gn flag instead, which conditionally defines V8_EMBEDDED_BUILTINS. Bug: v8:6666 Change-Id: I44d40d30fce3a3ed9bbf973d46c4990ba3fade40 Reviewed-on: https://chromium-review.googlesource.com/964361 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52092}
-
- 12 Mar, 2018 1 commit
-
-
Michael Starzinger authored
The feature in question has been enabled by default for a while and we no longer need to maintain a configuration without it enabled. Note that this change only removes the mechanical pieces. Further cleanup enabled by this will be done as follow-ups. R=clemensh@chromium.org BUG=v8:7549 Change-Id: I90e5bcddabe74a18a4d2a88132e8dc93317bcff4 Reviewed-on: https://chromium-review.googlesource.com/958424 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Michael Hablich <hablich@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#51883}
-
- 06 Mar, 2018 2 commits
-
-
Ross McIlroy authored
We now unconditionally both parse and compile StreamedSource on the background thread. BUG=v8:5203 Change-Id: I42d6fe9059bc1745da3a415d270f46cf1c08b306 Reviewed-on: https://chromium-review.googlesource.com/948854Reviewed-by: Mythri Alle <mythria@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#51758}
-
Ilija Pavlovic authored
For MIPS architecture release 6, following tests will be skipped: cctest/test-run-machops/RunFloat64MulAndFloat64Add1 cctest/test-run-machops/RunFloat64MulAndFloat64Add2 cctest/test-run-machops/RunFloat64MulAndFloat64Sub1 cctest/test-run-machops/RunFloat64MulAndFloat64Sub2 TEST= BUG= Change-Id: Id359580b809d1387d504d98b6d25d6c112cfda78 Reviewed-on: https://chromium-review.googlesource.com/945689Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Cr-Commit-Position: refs/heads/master@{#51754}
-
- 05 Mar, 2018 1 commit
-
-
jgruber authored
This enables the v8_enable_embedded_builtins gn flag on non-ia32 builds and adds a new --stress-off-heap-code test mode to fyi bots. v8_enable_embedded_builtins=true changes accesses to constants and external references to go through the root list in builtins code. --stress-off-heap-code copies builtins code off-heap on isolate creation. A few drive-by-fixes: - ensure that we actually inspect the correct builtin during isolate-independence testing. - relax tests to decrease maintenance (now we only fail if a builtin should be isolate-independent but isn't). - switch to a different off-heap-trampoline register on arm due to conflicts with custom stub linkages. Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel_ng Bug: v8:6666 Change-Id: I09ad3c75cb4342f4c548ea780f275993730896c8 Reviewed-on: https://chromium-review.googlesource.com/934281 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Hablich <hablich@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#51717}
-
- 01 Mar, 2018 1 commit
-
-
Ilija Pavlovic authored
Introducing a new status-file variable: mips_arch_variant. With this variable, in status files will be possible to define selections which are based on MIPS architecture revisions/variants. TEST= BUG= Change-Id: Ifd682552db2f26be4e56dc94ad50bed063ff14c5 Reviewed-on: https://chromium-review.googlesource.com/941212Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Cr-Commit-Position: refs/heads/master@{#51647}
-
- 20 Feb, 2018 1 commit
-
-
Michael Achenbach authored
This is a partial revert of: https://crrev.com/c/890938 and https://crrev.com/c/893982 Before this CL, the test runner blocked on ongoing tests in order to process their results after an internal timeout. However, the logic required for this feature was overly complicated and prevented an acceptable implementation for fast aborts. Furthermore, also the fuzzers suffered from timeouts on swarming due to hanging tests. Instead, we now abort immediately on internal timeout (used on fuzzers), SIGINT (Ctrl-C) and SIGTERM. Ongoing tests are immediately terminated and their results are disregarded. On SIGTERM and SIGINT, we return with non-zero exit codes, and zero on internal timeout. This will also properly return json output, when the external hard timeout is reached on swarming (causes SIGTERM). TBR=sergiyb@chromium.org Bug: v8:7423, chromium:813065 Change-Id: Ib20f835f58a0970693bdd3b21dc5d766d8e115d8 Reviewed-on: https://chromium-review.googlesource.com/924852Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#51399}
-
- 16 Feb, 2018 1 commit
-
-
Michael Achenbach authored
NOTRY=true Bug: v8:7455 Change-Id: Icb82e8196bc16b4c8b0eebb3c5820e6b3d581735 Reviewed-on: https://chromium-review.googlesource.com/924309Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#51336}
-
- 14 Feb, 2018 1 commit
-
-
Tobias Tebbi authored
Change-Id: I31d5dddd74aa8b1bcd386a13fe34449dd6933547 Reviewed-on: https://chromium-review.googlesource.com/919163Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#51293}
-
- 12 Feb, 2018 2 commits
-
-
Michael Achenbach authored
This reverts commit 9808093e. Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug/builds/19149 Original change's description: > Update test configurations for code serializer > > Update test configurations on the bots to test for serializing > after execute (--cache=after-execute) and producing full code > cache (--cache=full-code-cache) options. We no longer need > to test serializing before execute (--cache=code) on the bots. > > Bug: v8:7302 > Change-Id: I123b07028d9231f6da6145b72b62b9ee31352388 > Reviewed-on: https://chromium-review.googlesource.com/869931 > Commit-Queue: Mythri Alle <mythria@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#51235} TBR=machenbach@chromium.org,yangguo@chromium.org,mythria@chromium.org Change-Id: I47e03101804194c21b0edf418b744b0ccb66cbf6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7302 Reviewed-on: https://chromium-review.googlesource.com/913134Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#51236}
-
Mythri authored
Update test configurations on the bots to test for serializing after execute (--cache=after-execute) and producing full code cache (--cache=full-code-cache) options. We no longer need to test serializing before execute (--cache=code) on the bots. Bug: v8:7302 Change-Id: I123b07028d9231f6da6145b72b62b9ee31352388 Reviewed-on: https://chromium-review.googlesource.com/869931 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#51235}
-
- 09 Feb, 2018 2 commits
-
-
Michael Achenbach authored
The suppression flag must be set before loading the tests to have an effect. This got turned around in https://crrev.com/c/899366 and is fixed again by this CL. TBR=sergiyb@chromium.org NOTRY=true Bug: v8:6917 Change-Id: Ie58465288a0d6eec9a99a23d610710de9e1cdddd Reviewed-on: https://chromium-review.googlesource.com/911114Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#51209}
-
Clemens Hammacher authored
This new variant is executed on a small number of bots as part of the "extra" suite. It checks that the wasm-jit-to-native flag can still be disabled if unexpected failures pop up on a release branch. R=machenbach@chromium.org Bug: v8:7417 Change-Id: I1658cb2f04302fa80915b59bfedd85d980742db5 Reviewed-on: https://chromium-review.googlesource.com/909213Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#51204}
-
- 08 Feb, 2018 1 commit
-
-
Michael Achenbach authored
Timeouts on num-fuzzer only lead to false positives, as tests might take unpredictably longer. This CL forgives timeouts through a global override mechanism of the expected outcomes. This allows to remove already existing scattered code that allowed timeouts in some test suites only. Bug: v8:6917 Change-Id: Ib131765d360e335789c1952bc6793ed051e016ea Reviewed-on: https://chromium-review.googlesource.com/908454 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#51188}
-
- 03 Feb, 2018 1 commit
-
-
Michal Majewski authored
Bug: v8:6917 Change-Id: I4267900b6beed44eeae3df9b3b7a3e58402d6e6e Reviewed-on: https://chromium-review.googlesource.com/899366 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#51084}
-
- 02 Feb, 2018 2 commits
-
-
Michael Achenbach authored
TBR=sergiyb@chromium.org NOTRY=true Bug: v8:6917 Change-Id: Ie585754c84f42cd864ab3b161a1ae27f7c2d2ab5 Reviewed-on: https://chromium-review.googlesource.com/899303Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#51070}
-
Michael Achenbach authored
Load mjsunit.js inside the realm as otherwise the functions are not available in the realm's scope. This also prints timestamps after each test to easier track down slow tests. We also pass --omit-quit to not stop too early. This also adds the ability to skip certain tests for endurance fuzzing and skips some tests with known problems. TBR=ulan@chromium.org,hpayer@chromium.org Bug: v8:6972, v8:7400 Change-Id: I44464c28bfb10c84f2e59972e7b86945a47ca3b3 Reviewed-on: https://chromium-review.googlesource.com/899008Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#51066}
-
- 01 Feb, 2018 6 commits
-
-
Michal Majewski authored
Bug: v8:6917 Change-Id: I2fb63e05336798606dee558d4adc253d5aace040 Reviewed-on: https://chromium-review.googlesource.com/897807Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michał Majewski <majeski@google.com> Cr-Commit-Position: refs/heads/master@{#51038}
-
Michal Majewski authored
Bug: v8:6917 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I6bfea537347fb236d41b31f0c6c64c108928bf28 Reviewed-on: https://chromium-review.googlesource.com/897784Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michał Majewski <majeski@google.com> Cr-Commit-Position: refs/heads/master@{#51033}
-
Michal Majewski authored
Only test processors code left. It enabled to move more stuff to the base runner, like progress indicators creation. Bug: v8:6917 Change-Id: Ie6dd211cec561a07d92bcc4431ea88eb1842c8fa Reviewed-on: https://chromium-review.googlesource.com/897624Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michał Majewski <majeski@google.com> Cr-Commit-Position: refs/heads/master@{#51030}
-
Michal Majewski authored
System tests updated to pass. I will cleanup the code in a separate CL removing the old code. Bug: v8:6917 Change-Id: Ie49efe06c43faade846e322b35c4a2068137a88b Reviewed-on: https://chromium-review.googlesource.com/897565Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michał Majewski <majeski@google.com> Cr-Commit-Position: refs/heads/master@{#51025}
-
Michal Majewski authored
Bug: v8:6917 Change-Id: Ibc6a7e049a17b8f9bef6b2f5cb187c11f89cf638 Reviewed-on: https://chromium-review.googlesource.com/897564Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michał Majewski <majeski@google.com> Cr-Commit-Position: refs/heads/master@{#51024}
-
Michal Majewski authored
Bug: v8:6917 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Id5a7b41502dfd4be43496b1edb958522a8eb0c31 Reviewed-on: https://chromium-review.googlesource.com/895588 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#51023}
-
- 31 Jan, 2018 6 commits
-
-
Michael Achenbach authored
TBR=majeski@google.com NOTRY=true Bug: v8:6917 Change-Id: I8ca2297ab9641b81a91ee7f8ff594bbe4b9e369b Reviewed-on: https://chromium-review.googlesource.com/895366Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#51005}
-
Michael Achenbach authored
TBR=majeski@google.com NOTRY=true Bug: v8:6917 Change-Id: I088dc4492df6c1dda1f86fbd6d7153a46a4117e0 Reviewed-on: https://chromium-review.googlesource.com/895600Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#51000}
-
Michal Majewski authored
Bug: v8:6917 Change-Id: I543c232489e6b93f5f98ccf63eea475535d82613 Reviewed-on: https://chromium-review.googlesource.com/893566 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#50998}
-
Michal Majewski authored
Bug: v8:6917 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I254d2e545709029346f585b02a9edf91d3f27893 Reviewed-on: https://chromium-review.googlesource.com/893321Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michał Majewski <majeski@google.com> Cr-Commit-Position: refs/heads/master@{#50996}
-
Michal Majewski authored
Bug: v8:6917 Change-Id: Ie18390ae0849e8d5341e4c2a7b757fae886c2986 Reviewed-on: https://chromium-review.googlesource.com/895582 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#50994}
-
Michal Majewski authored
Bug: v8:6917 Change-Id: I562680ebbc4b3140fb0e5be7cab7d5ebb658bbac Reviewed-on: https://chromium-review.googlesource.com/893272Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Michał Majewski <majeski@google.com> Cr-Commit-Position: refs/heads/master@{#50989}
-