1. 26 Dec, 2018 1 commit
  2. 20 Dec, 2018 1 commit
  3. 17 Dec, 2018 1 commit
  4. 08 Dec, 2018 1 commit
  5. 07 Dec, 2018 1 commit
  6. 07 Nov, 2018 1 commit
  7. 24 Oct, 2018 1 commit
  8. 18 Sep, 2018 1 commit
  9. 04 Sep, 2018 1 commit
  10. 23 Jul, 2018 1 commit
  11. 04 Jul, 2018 1 commit
  12. 05 Apr, 2018 1 commit
    • Alexey Kozyatinskiy's avatar
      Reland "[debug] introduced runtime side effect check" · 71018812
      Alexey Kozyatinskiy authored
      This is a reland of 7a2c3713
      
      Original change's description:
      > [debug] introduced runtime side effect check
      > 
      > This CL demonstrates minimum valuable addition to existing debug evaluate
      > without side effects mechanism.
      > With this CL user can evaluate expressions like:
      > [a,b] // create any kind of temporary array literals
      > [a,b].reduce((x,y) => x + y, 0); // use reduce method
      > [1,2,3].fill(2); // change temporary arrays
      > 
      > The core idea: any change of the object created during evaluation without
      > side effects is side effect free. As soon as we try to store this temporary
      > object to object existed before evaluation we will terminate execution.
      > 
      > Implementation:
      > - track all objects allocated during evaluation and mark them as temporary,
      > - patch all bytecodes which change objects.
      > 
      > A little more details (including performance analysis): [1].
      > 
      > [1] https://docs.google.com/document/d/10qqAtZADspPnpYa6SEdYRxrddfKIZJIzbLtGpsZQkRo/edit#
      > 
      > Bug: v8:7588
      > Change-Id: I69f7b96e1ebd7ad0022219e8213211c7be72a111
      > Reviewed-on: https://chromium-review.googlesource.com/972615
      > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      > Reviewed-by: Yang Guo <yangguo@chromium.org>
      > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#52370}
      
      Bug: v8:7588
      Change-Id: Ibc92bf19155f2ddaedae39b0c576b994e84afcf8
      Reviewed-on: https://chromium-review.googlesource.com/996760Reviewed-by: 's avatarAleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#52373}
      71018812
  13. 04 Apr, 2018 2 commits
    • Aleksey Kozyatinskiy's avatar
      Revert "[debug] introduced runtime side effect check" · 539a2443
      Aleksey Kozyatinskiy authored
      This reverts commit 7a2c3713.
      
      Reason for revert: msan is broken
      
      Original change's description:
      > [debug] introduced runtime side effect check
      > 
      > This CL demonstrates minimum valuable addition to existing debug evaluate
      > without side effects mechanism.
      > With this CL user can evaluate expressions like:
      > [a,b] // create any kind of temporary array literals
      > [a,b].reduce((x,y) => x + y, 0); // use reduce method
      > [1,2,3].fill(2); // change temporary arrays
      > 
      > The core idea: any change of the object created during evaluation without
      > side effects is side effect free. As soon as we try to store this temporary
      > object to object existed before evaluation we will terminate execution.
      > 
      > Implementation:
      > - track all objects allocated during evaluation and mark them as temporary,
      > - patch all bytecodes which change objects.
      > 
      > A little more details (including performance analysis): [1].
      > 
      > [1] https://docs.google.com/document/d/10qqAtZADspPnpYa6SEdYRxrddfKIZJIzbLtGpsZQkRo/edit#
      > 
      > Bug: v8:7588
      > Change-Id: I69f7b96e1ebd7ad0022219e8213211c7be72a111
      > Reviewed-on: https://chromium-review.googlesource.com/972615
      > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      > Reviewed-by: Yang Guo <yangguo@chromium.org>
      > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#52370}
      
      TBR=ulan@chromium.org,rmcilroy@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,leszeks@chromium.org
      
      Change-Id: Ied1739c6308b13a4981189e0999f5912316cf456
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:7588
      Reviewed-on: https://chromium-review.googlesource.com/996135Reviewed-by: 's avatarAleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#52371}
      539a2443
    • Alexey Kozyatinskiy's avatar
      [debug] introduced runtime side effect check · 7a2c3713
      Alexey Kozyatinskiy authored
      This CL demonstrates minimum valuable addition to existing debug evaluate
      without side effects mechanism.
      With this CL user can evaluate expressions like:
      [a,b] // create any kind of temporary array literals
      [a,b].reduce((x,y) => x + y, 0); // use reduce method
      [1,2,3].fill(2); // change temporary arrays
      
      The core idea: any change of the object created during evaluation without
      side effects is side effect free. As soon as we try to store this temporary
      object to object existed before evaluation we will terminate execution.
      
      Implementation:
      - track all objects allocated during evaluation and mark them as temporary,
      - patch all bytecodes which change objects.
      
      A little more details (including performance analysis): [1].
      
      [1] https://docs.google.com/document/d/10qqAtZADspPnpYa6SEdYRxrddfKIZJIzbLtGpsZQkRo/edit#
      
      Bug: v8:7588
      Change-Id: I69f7b96e1ebd7ad0022219e8213211c7be72a111
      Reviewed-on: https://chromium-review.googlesource.com/972615
      Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#52370}
      7a2c3713
  14. 03 Apr, 2018 1 commit
  15. 15 Mar, 2018 1 commit
  16. 06 Mar, 2018 1 commit
  17. 02 Mar, 2018 1 commit
  18. 14 Feb, 2018 1 commit
  19. 30 Jan, 2018 1 commit
  20. 08 Dec, 2017 1 commit
  21. 27 Oct, 2017 2 commits
  22. 25 Oct, 2017 1 commit
    • Jakob Kummerow's avatar
      [bigint] Fix abstract equality with junk strings · 98df94cd
      Jakob Kummerow authored
      Abstract equality comparison of a BigInt and a String converts the
      latter to BigInt. This conversion can fail; since we do not want to
      pass a context to the comparison function, we must signal such failure
      without throwing an exception.
      This CL uses the existing ShouldThrow enum to configure behavior of
      String-to-BigInt conversion, moving it out of Object into globals.h.
      
      Bug: v8:6791, v8:6979
      Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
      Change-Id: Ibb98675079b8392cf03bbcbbbd5556108500a32d
      Reviewed-on: https://chromium-review.googlesource.com/734172
      Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
      Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
      Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#48946}
      98df94cd
  23. 07 Sep, 2017 1 commit
  24. 06 Sep, 2017 1 commit
  25. 25 Apr, 2017 1 commit
    • ulan's avatar
      Decouple root visitors from object visitors. · e671ed36
      ulan authored
      This patch adds a new interface called RootVisitor and changes the root
      iteration functions to accept a RootVisitor instead of an ObjectVisitor.
      
      Future CLs will change ObjectVisitor to provide the host object to all
      visiting functions, which will bring it in sync with static visitors.
      
      Having separate visitors for roots and objects removes ambiguity in
      VisitPointers and reduces chances of forgetting to record slots.
      
      This is intended as pure refactoring. All places that require behavior
      change are marked with TODO and will addressed in future CLs.
      
      BUG=chromium:709075
      
      Review-Url: https://codereview.chromium.org/2801073006
      Cr-Commit-Position: refs/heads/master@{#44852}
      e671ed36
  26. 12 Jan, 2017 1 commit
  27. 26 Oct, 2016 1 commit
    • neis's avatar
      [runtime] Let native setters have a return value. · f33a4078
      neis authored
      Native setters (see AccessorInfo in accessors.h) didn't have the ability
      to return a result value. As a consequence of this, for instance, Reflect.set
      on the length property of arrays had the wrong behavior:
      
      var y = [];
      Object.defineProperty(y, 0, {value: 42, configurable: false})
      Reflect.set(y, 'length', 0)
      
      The Reflect.set call used to return true. Now it returns false as
      required by the spec.
      
      BUG=v8:5401
      
      Review-Url: https://codereview.chromium.org/2397603003
      Cr-Commit-Position: refs/heads/master@{#40579}
      f33a4078
  28. 02 Sep, 2016 1 commit
    • franzih's avatar
      [api] Add interceptor for defineProperty(). · 7c401bd8
      franzih authored
      With the Indexed/GenericNamedPropertyDefinerCallback it is possible to intercept Object.defineProperty() calls.
      
      Requests that call JSReceiver::OrdinaryDefineOwnProperty() internally, also trigger the interceptor. This includes Object.freeze(), Object.preventExtensions(), and Object.seal().
      
      As without this patch, the query interceptor triggers on
      defineProperty, unless the definer callback
      intercepts the request.
      
      As without this patch, the query interceptor triggers on defineProperty, unless the definer callback intercepts the request.
      
      BUG=
      
      Committed: https://crrev.com/b9d985975cf3bab0ded0cec9fafd3799f9bde29a
      Review-Url: https://codereview.chromium.org/2272383002
      Cr-Original-Commit-Position: refs/heads/master@{#39094}
      Cr-Commit-Position: refs/heads/master@{#39122}
      7c401bd8
  29. 01 Sep, 2016 2 commits
    • jkummerow's avatar
      Revert of [api] Add interceptor for defineProperty(). (patchset #9 id:160001... · 9fe4efe5
      jkummerow authored
      Revert of [api] Add interceptor for defineProperty(). (patchset #9 id:160001 of https://codereview.chromium.org/2272383002/ )
      
      Reason for revert:
      Breaks cctest/test-api-interceptors/QueryInterceptor on the waterfall
      
      Original issue's description:
      > [api] Add interceptor for defineProperty().
      >
      > With the Indexed/GenericNamedPropertyDefinerCallback it is possible to intercept Object.defineProperty() calls.
      >
      > Requests that call JSReceiver::OrdinaryDefineOwnProperty() internally, also trigger the interceptor. This includes Object.freeze(), Object.preventExtensions(), and Object.seal().
      >
      > BUG=
      >
      > Committed: https://crrev.com/b9d985975cf3bab0ded0cec9fafd3799f9bde29a
      > Cr-Commit-Position: refs/heads/master@{#39094}
      
      TBR=jochen@chromium.org,franzih@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=
      
      Review-Url: https://codereview.chromium.org/2303533004
      Cr-Commit-Position: refs/heads/master@{#39095}
      9fe4efe5
    • franzih's avatar
      [api] Add interceptor for defineProperty(). · b9d98597
      franzih authored
      With the Indexed/GenericNamedPropertyDefinerCallback it is possible to intercept Object.defineProperty() calls.
      
      Requests that call JSReceiver::OrdinaryDefineOwnProperty() internally, also trigger the interceptor. This includes Object.freeze(), Object.preventExtensions(), and Object.seal().
      
      BUG=
      
      Review-Url: https://codereview.chromium.org/2272383002
      Cr-Commit-Position: refs/heads/master@{#39094}
      b9d98597
  30. 07 Jun, 2016 1 commit
  31. 06 Jun, 2016 1 commit
  32. 13 May, 2016 1 commit
    • cbruni's avatar
      [counters] Annotate v8 with more runtime call counters. · 407d9fce
      cbruni authored
      By fully annotating the API with runtime counters we can properly measure
      how much time we spend in total in v8. When --runtime-call-stats is specified
      we now disable the fast-paths for callbacks to properly measure them.
      As a drive-by-fix this CL unifies the LOG messages in api.cc.
      Additionally we added missing timers to gain better resolution in the parser
      and callbacks.
      
      BUG=
      
      Review-Url: https://codereview.chromium.org/1923893002
      Cr-Commit-Position: refs/heads/master@{#36248}
      407d9fce
  33. 27 Apr, 2016 1 commit
  34. 10 Mar, 2016 2 commits
  35. 09 Mar, 2016 1 commit
  36. 08 Mar, 2016 1 commit