- 05 Oct, 2015 1 commit
-
-
machenbach authored
This reverts commit 280a6f8e. Reland of https://codereview.chromium.org/1380593002/ BUG=chromium:535160 LOG=n CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_rel; Review URL: https://codereview.chromium.org/1390473003 Cr-Commit-Position: refs/heads/master@{#31094}
-
- 03 Oct, 2015 3 commits
-
-
Michael Hablich authored
TBR=machenbach@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1387763002 . Cr-Commit-Position: refs/heads/master@{#31093}
-
ofrobots authored
The buffer used for appending filenames to the string printed to the perf_basic_prof log was unnecessarily too small. Bump it up to be at least kUtf8BufferSize. Truncation of filenames makes it really hard to work with profiles gathered on Node.js. Because of the way Node.js works, you can have node module dependencies in deeply nested directories. The last thing you want when investigating a performance problem is to have script names be truncated. This patch is a stop-gap. Ideally, I want no truncation of the filename at all and use a dynamically growing buffer. That would be a larger change, and I wanted to have a quick fix available that can be back-ported to Node.js LTS release. R=yangguo@chromium.org,yurys@chromium.org BUG= Review URL: https://codereview.chromium.org/1388543002 Cr-Commit-Position: refs/heads/master@{#31092}
-
v8-autoroll authored
Rolling v8/tools/clang to 071be3c47dbf2dfb347629bbfb0afe462cbc571b TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review URL: https://codereview.chromium.org/1379053003 Cr-Commit-Position: refs/heads/master@{#31091}
-
- 02 Oct, 2015 29 commits
-
-
mbrandy authored
A subset of the LiveRangeUnitTests (SplitInvalidPreStart, InvalidSplitEnd, SplitInvalidPostEnd) fail or hang on AIX in release mode. These tests fork a child which is expected to crash in register-allocator code after feeding in bad inputs. In debug mode, they behave as expected due to hitting a debug assert. In release mode, however, the tests rely only on the fact that dereferencing a null pointer will cause a SEGFAULT. This is true on most platforms, but not AIX. An AIX process has valid low memory pages mapped for reading and will not fault. Thus, these tests fail or hang because the child process survives the load from address zero and either completes (with undefined results) or goes into an infinite loop. R=bmeurer@chromium.org, danno@chromium.org, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1384733002 Cr-Commit-Position: refs/heads/master@{#31090}
-
rmcilroy authored
Adds support for calling runtime functions from the interpreter. Adds the CallRuntime bytecode which takes a Runtime::FunctionId of the function to call and the arguments in sequential registers. Adds a InterpreterCEntry builtin to enable the interpreter to enter C++ code based on the functionId. Also renames Builtin::PushArgsAndCall to Builtin::InterpreterPushArgsAndCall and groups all the interpreter builtins together. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1362383002 Cr-Commit-Position: refs/heads/master@{#31089}
-
rmcilroy authored
Adds the following owners to interpreter/ directory: - oth@chromium.org - mstarzinger@chromium.org - bmeurer@chromium.org Also sets noparent on the directory. Review URL: https://codereview.chromium.org/1374533005 Cr-Commit-Position: refs/heads/master@{#31088}
-
danno authored
Previous to this patch, both the lithium and TurboFan register allocators tracked allocated registers by "indices", rather than the register codes used elsewhere in the runtime. This patch ensures that codes are used everywhere, and in the process cleans up a bunch of redundant code and adds more structure to how the set of allocatable registers is defined. Some highlights of changes: * TurboFan's RegisterConfiguration class moved to V8's top level so that it can be shared with Crankshaft. * Various "ToAllocationIndex" and related methods removed. * Code that can be easily shared between Register classes on different platforms is now shared. * The list of allocatable registers on each platform is declared as a list rather than implicitly via the register index <-> code mapping. Committed: https://crrev.com/80bc6f6e11f79524e3f1ad05579583adfd5f18b2 Cr-Commit-Position: refs/heads/master@{#30913} Committed: https://crrev.com/7b7a8205d9a00c678fb7a6e032a55fecbc1509cf Cr-Commit-Position: refs/heads/master@{#31075} Review URL: https://codereview.chromium.org/1287383003 Cr-Commit-Position: refs/heads/master@{#31087}
-
bmeurer authored
Properly share both the constructor and the non-constructor maps for bound functions. Previously we had only the non-constructor map shared on the native context, and we had to create a new map for every bound function whose [[BoundTargetFunction]] is a constructor (in the ES6 sense). This should repair the most recent regression on Speedometer. CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg R=jarin@chromium.org BUG=chromium:536114,chromium:535408,v8:4430 LOG=n Review URL: https://codereview.chromium.org/1379323002 Cr-Commit-Position: refs/heads/master@{#31086}
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1376143006 Cr-Commit-Position: refs/heads/master@{#31085}
-
danno authored
Revert of [swarming] Isolate v8 testing. (patchset #8 id:140001 of https://codereview.chromium.org/1380593002/ ) Reason for revert: Prime suspect in breakage of V8 Linux -- no snap Original issue's description: > [swarming] Isolate v8 testing. > > Add gyp support and isolates for default test suites. > Add two default isolates, one (default) for using the > test suite collection we call "default" on the bots. One > (developer_default) for also supporting the way developers > call the driver (i.e. without argument, which includes > the unittests). > > BUG=chromium:535160 > LOG=n > > Committed: https://crrev.com/9bd83f58f29ab0c7c5b71b00bcb1df3a9e641f05 > Cr-Commit-Position: refs/heads/master@{#31081} TBR=tandrii@chromium.org,jochen@chromium.org,maruel@chromium.org,machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:535160 Review URL: https://codereview.chromium.org/1370993008 Cr-Commit-Position: refs/heads/master@{#31084}
-
danno authored
Revert of Reland: Remove register index/code indirection (patchset #20 id:380001 of https://codereview.chromium.org/1287383003/ ) Reason for revert: Failures on MIPS Original issue's description: > Remove register index/code indirection > > Previous to this patch, both the lithium and TurboFan register > allocators tracked allocated registers by "indices", rather than > the register codes used elsewhere in the runtime. This patch > ensures that codes are used everywhere, and in the process cleans > up a bunch of redundant code and adds more structure to how the > set of allocatable registers is defined. > > Some highlights of changes: > > * TurboFan's RegisterConfiguration class moved to V8's top level > so that it can be shared with Crankshaft. > * Various "ToAllocationIndex" and related methods removed. > * Code that can be easily shared between Register classes on > different platforms is now shared. > * The list of allocatable registers on each platform is declared > as a list rather than implicitly via the register index <-> > code mapping. > > Committed: https://crrev.com/80bc6f6e11f79524e3f1ad05579583adfd5f18b2 > Cr-Commit-Position: refs/heads/master@{#30913} > > Committed: https://crrev.com/7b7a8205d9a00c678fb7a6e032a55fecbc1509cf > Cr-Commit-Position: refs/heads/master@{#31075} TBR=akos.palfi@imgtec.com,bmeurer@chromium.org,jarin@chromium.org,paul.lind@imgtec.com,titzer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1380863004 Cr-Commit-Position: refs/heads/master@{#31083}
-
ulan authored
BUG= Review URL: https://codereview.chromium.org/1375853005 Cr-Commit-Position: refs/heads/master@{#31082}
-
machenbach authored
Add gyp support and isolates for default test suites. Add two default isolates, one (default) for using the test suite collection we call "default" on the bots. One (developer_default) for also supporting the way developers call the driver (i.e. without argument, which includes the unittests). BUG=chromium:535160 LOG=n Review URL: https://codereview.chromium.org/1380593002 Cr-Commit-Position: refs/heads/master@{#31081}
-
cbruni authored
R=mvstanton@chromium.org BUG= Review URL: https://codereview.chromium.org/1368403003 Cr-Commit-Position: refs/heads/master@{#31080}
-
ulan authored
This disables aggressive compaction for non-memory reducer GCs. BUG=chromium:502247 LOG=NO Review URL: https://codereview.chromium.org/1375703003 Cr-Commit-Position: refs/heads/master@{#31079}
-
rmcilroy authored
Revert of [Interpreter] Add CallRuntime support to the interpreter. (patchset #8 id:220001 of https://codereview.chromium.org/1362383002/ ) Reason for revert: Now breaking arm32 debug bot (worked locally even with --debug-code, so I'll need to figure out what's different on the bot) Original issue's description: > [Interpreter] Add CallRuntime support to the interpreter. > > Adds support for calling runtime functions from the interpreter. Adds the > CallRuntime bytecode which takes a Runtime::FunctionId of the function to call > and the arguments in sequential registers. Adds a InterpreterCEntry builtin > to enable the interpreter to enter C++ code based on the functionId. > > Also renames Builtin::PushArgsAndCall to Builtin::InterpreterPushArgsAndCall > and groups all the interpreter builtins together. > > BUG=v8:4280 > LOG=N > TBR=bmeurer@chromium.org,oth@chromium.org,mstarzinger@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4280 Review URL: https://codereview.chromium.org/1379933003 Cr-Commit-Position: refs/heads/master@{#31078}
-
machenbach authored
BUG=v8:4459 LOG=n NOTRY=true NOTREECHECKS=true TBR=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1384663004 Cr-Commit-Position: refs/heads/master@{#31077}
-
rmcilroy authored
Adds support for calling runtime functions from the interpreter. Adds the CallRuntime bytecode which takes a Runtime::FunctionId of the function to call and the arguments in sequential registers. Adds a InterpreterCEntry builtin to enable the interpreter to enter C++ code based on the functionId. Also renames Builtin::PushArgsAndCall to Builtin::InterpreterPushArgsAndCall and groups all the interpreter builtins together. BUG=v8:4280 LOG=N Committed: https://crrev.com/40e8424b744f8b6e3e1d93e20f23487419911dfc Cr-Commit-Position: refs/heads/master@{#31064} Review URL: https://codereview.chromium.org/1362383002 Cr-Commit-Position: refs/heads/master@{#31076}
-
danno authored
Previous to this patch, both the lithium and TurboFan register allocators tracked allocated registers by "indices", rather than the register codes used elsewhere in the runtime. This patch ensures that codes are used everywhere, and in the process cleans up a bunch of redundant code and adds more structure to how the set of allocatable registers is defined. Some highlights of changes: * TurboFan's RegisterConfiguration class moved to V8's top level so that it can be shared with Crankshaft. * Various "ToAllocationIndex" and related methods removed. * Code that can be easily shared between Register classes on different platforms is now shared. * The list of allocatable registers on each platform is declared as a list rather than implicitly via the register index <-> code mapping. Committed: https://crrev.com/80bc6f6e11f79524e3f1ad05579583adfd5f18b2 Cr-Commit-Position: refs/heads/master@{#30913} Review URL: https://codereview.chromium.org/1287383003 Cr-Commit-Position: refs/heads/master@{#31075}
-
cbruni authored
BUG=v8:4217 LOG=Y Review URL: https://codereview.chromium.org/1381543005 Cr-Commit-Position: refs/heads/master@{#31074}
-
machenbach authored
BUG=chromium:535160,v8:4459 LOG=n NOTRY=true Review URL: https://codereview.chromium.org/1384683002 Cr-Commit-Position: refs/heads/master@{#31073}
-
ulan authored
This restores size_of_objects and removed unused fields. BUG=chromium:538539 LOG=NO Review URL: https://codereview.chromium.org/1380953003 Cr-Commit-Position: refs/heads/master@{#31072}
-
mlippautz authored
R=ulan@chromium.org BUG= Review URL: https://codereview.chromium.org/1384453005 Cr-Commit-Position: refs/heads/master@{#31071}
-
mlippautz authored
See bug description. R=hpayer@chromium.org BUG=chromium:538257 LOG=N Review URL: https://codereview.chromium.org/1381633005 Cr-Commit-Position: refs/heads/master@{#31070}
-
jkummerow authored
The problem was harmless, but made --enable-slow-asserts unhappy. BUG=chromium:538086 LOG=n R=cbruni@chromium.org Review URL: https://codereview.chromium.org/1384673003 Cr-Commit-Position: refs/heads/master@{#31069}
-
mstarzinger authored
This lowers JSCreateFunctionContext nodes to call the above stub for help with allocating function contexts when possible. It also contains an implementation for inlined allocations of such contexts, which is still behind a flag until inlined allocations are ready for prime time. TEST=unittests/JSTypedLoweringTest.JSCreateFunctionContext R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/1380113002 Cr-Commit-Position: refs/heads/master@{#31068}
-
ishell authored
BUG=v8:4458 LOG=N NOTRY=true Review URL: https://codereview.chromium.org/1387533002 Cr-Commit-Position: refs/heads/master@{#31067}
-
rmcilroy authored
Revert of [Interpreter] Add CallRuntime support to the interpreter. (patchset #6 id:180001 of https://codereview.chromium.org/1362383002/ ) Reason for revert: Broke Arm64 bot (CEntry stub is trying to pop arguments off stack when argv_in_reg, so I need to fix this). Original issue's description: > [Interpreter] Add CallRuntime support to the interpreter. > > Adds support for calling runtime functions from the interpreter. Adds the > CallRuntime bytecode which takes a Runtime::FunctionId of the function to call > and the arguments in sequential registers. Adds a InterpreterCEntry builtin > to enable the interpreter to enter C++ code based on the functionId. > > Also renames Builtin::PushArgsAndCall to Builtin::InterpreterPushArgsAndCall > and groups all the interpreter builtins together. > > BUG=v8:4280 > LOG=N > > Committed: https://crrev.com/40e8424b744f8b6e3e1d93e20f23487419911dfc > Cr-Commit-Position: refs/heads/master@{#31064} TBR=bmeurer@chromium.org,oth@chromium.org,mstarzinger@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4280 Review URL: https://codereview.chromium.org/1387543002 Cr-Commit-Position: refs/heads/master@{#31066}
-
Djordje.Pesic authored
BUG= Review URL: https://codereview.chromium.org/1384453003 Cr-Commit-Position: refs/heads/master@{#31065}
-
rmcilroy authored
Adds support for calling runtime functions from the interpreter. Adds the CallRuntime bytecode which takes a Runtime::FunctionId of the function to call and the arguments in sequential registers. Adds a InterpreterCEntry builtin to enable the interpreter to enter C++ code based on the functionId. Also renames Builtin::PushArgsAndCall to Builtin::InterpreterPushArgsAndCall and groups all the interpreter builtins together. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1362383002 Cr-Commit-Position: refs/heads/master@{#31064}
-
paul.lind authored
BUG= Review URL: https://codereview.chromium.org/1370353003 Cr-Commit-Position: refs/heads/master@{#31063}
-
v8-autoroll authored
Rolling v8/third_party/icu to 94e4b770ce2f6065d4261d29c32683a6099b9d93 Rolling v8/tools/swarming_client to e4c0e242eeec361886ed2b89591a505ebe24db43 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review URL: https://codereview.chromium.org/1383963002 Cr-Commit-Position: refs/heads/master@{#31062}
-
- 01 Oct, 2015 7 commits
-
-
machenbach authored
Swarming won't support an incremental data file. By just sorting the lowest hanging fruits to the beginning we already get a big bang for the buck (>80% of the improvement we get otherwise). This will require semi-regular manual updates of the slowest tests. BUG=chromium:535160 LOG=n Review URL: https://codereview.chromium.org/1385443002 Cr-Commit-Position: refs/heads/master@{#31061}
-
alph authored
Review URL: https://codereview.chromium.org/1378253002 Cr-Commit-Position: refs/heads/master@{#31060}
-
ishell authored
Disable vector store ICs for mjsunit/call-counts because slot indices change when --vector-stores is enabled. Review URL: https://codereview.chromium.org/1381073003 Cr-Commit-Position: refs/heads/master@{#31059}
-
rmcilroy authored
Adds support for short operands, starting with kIdx16. Introduces BytecodeTraits to enable compile time determination of various traits for a bytecode, such as size, operands, etc. Reworks BytecodeIterator, BytecodeArrayBuilder and Bytecodes::Decode to support 16 bit operands. Adds support to Interpreter to load 16 bit operands. Also fixes a bug with ToBoolean where it wouldn't get emitted at the start of a block, and added a test. BytecodeTraits template magic inspired by oth@chromium.org. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1370893002 Cr-Commit-Position: refs/heads/master@{#31058}
-
titzer authored
R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/1377423002 Cr-Commit-Position: refs/heads/master@{#31057}
-
alph authored
It was supposed to be used by the CPU profiler. But as long as these ranges are not built when profiler is not running, once the profiler is started there're no ranges for already compiled functions. So basically this code never worked. As long as now CPU profiler uses another approach this code is no longer needed. Review URL: https://codereview.chromium.org/1376333003 Cr-Commit-Position: refs/heads/master@{#31056}
-
neis authored
R=verwaest@chromium.org BUG= Review URL: https://codereview.chromium.org/1378343002 Cr-Commit-Position: refs/heads/master@{#31055}
-