- 21 Nov, 2019 1 commit
-
-
Georg Neis authored
It could also be a DeadValue. A regression test will take a while but the fix is straightforward. Bug: chromium:1027045 Change-Id: I49a66668b7189b7ea7d6d79d514b9e0de3edc966 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1928853 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#65094}
-
- 19 Nov, 2019 1 commit
-
-
Georg Neis authored
... by disallowing checkpoint elimination across function boundaries. See the comment in checkpoint-elimination.cc and the tests for details. Bug: v8:9945 Change-Id: Ibf4ab6f0e4e709e26d3c4428a082ef45dcbeb8b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906208 Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#65027}
-
- 10 Jul, 2018 2 commits
-
-
Georg Neis authored
R=jarin@chromium.org Bug: v8:7790 Change-Id: I79c6904a9969afc6aac7530c5d876da15018b3bc Reviewed-on: https://chromium-review.googlesource.com/1129142 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#54344}
-
Georg Neis authored
No changes were needed. R=jarin@chromium.org Bug: v8:7790 Change-Id: I5842a39db1395ab25f61aab2443c0061f613a883 Reviewed-on: https://chromium-review.googlesource.com/1128897Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#54342}
-
- 18 Jul, 2016 1 commit
-
-
jarin authored
This makes sure that we preserve call's tailness even if we have introduced a loop exit between the call and the return. BUG=chromium:628773 Review-Url: https://codereview.chromium.org/2155123002 Cr-Commit-Position: refs/heads/master@{#37832}
-
- 01 Jul, 2016 1 commit
-
-
mstarzinger authored
This makes the elimination of checkpoints flowing effect-wise into nodes having the {Return} operator more permissive. We can cut out checkpoints even when they are not wholly owned by the return. This also alleviates a problem where TCO no longer applies. R=jarin@chromium.org TEST=mjsunit/regress/regress-crbug-624747 BUG=chromium:624747 Review-Url: https://codereview.chromium.org/2118793002 Cr-Commit-Position: refs/heads/master@{#37480}
-
- 29 Jun, 2016 3 commits
-
-
mstarzinger authored
Reland of [turbofan] Implicitly emit eager checkpoint at graph building. (patchset #1 id:1 of https://codereview.chromium.org/2104973004/ ) Reason for revert: Can be cleanly relanded without any changes after a fix to redundancy elimination. Kudos go to Benedikt. Depends on: https://codereview.chromium.org/2112463002/ Original issue's description: > Revert of [turbofan] Implicitly emit eager checkpoint at graph building. (patchset #13 id:260001 of https://codereview.chromium.org/2074703002/ ) > > Reason for revert: > Causers flaky failures on the waterfall on Mac with the following error in the builtin QuickSort method: > > # > # Fatal error in Zone > # Allocation failed - process out of memory > # > > Original issue's description: > > [turbofan] Implicitly emit eager checkpoint at graph building. > > > > This makes preparation of eager checkpoints within the graph builder > > implicit. Every sub-expression visitation is now guaranteed to emit > > valid checkpoints in AstContext. > > > > R=jarin@chromium.org > > BUG=v8:5021 > > > > Committed: https://crrev.com/74e328efee7995aeee6d568f9d14f9bbc1087100 > > Cr-Commit-Position: refs/heads/master@{#37368} > > TBR=jarin@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:5021 > > Committed: https://crrev.com/45190a4fbfa5199f6ddf5ed9a7e2f50be865e0db > Cr-Commit-Position: refs/heads/master@{#37372} TBR=jarin@chromium.org BUG=v8:5021 Review-Url: https://codereview.chromium.org/2107163002 Cr-Commit-Position: refs/heads/master@{#37395}
-
mstarzinger authored
Revert of [turbofan] Implicitly emit eager checkpoint at graph building. (patchset #13 id:260001 of https://codereview.chromium.org/2074703002/ ) Reason for revert: Causers flaky failures on the waterfall on Mac with the following error in the builtin QuickSort method: # # Fatal error in Zone # Allocation failed - process out of memory # Original issue's description: > [turbofan] Implicitly emit eager checkpoint at graph building. > > This makes preparation of eager checkpoints within the graph builder > implicit. Every sub-expression visitation is now guaranteed to emit > valid checkpoints in AstContext. > > R=jarin@chromium.org > BUG=v8:5021 > > Committed: https://crrev.com/74e328efee7995aeee6d568f9d14f9bbc1087100 > Cr-Commit-Position: refs/heads/master@{#37368} TBR=jarin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5021 Review-Url: https://codereview.chromium.org/2104973004 Cr-Commit-Position: refs/heads/master@{#37372}
-
mstarzinger authored
This makes preparation of eager checkpoints within the graph builder implicit. Every sub-expression visitation is now guaranteed to emit valid checkpoints in AstContext. R=jarin@chromium.org BUG=v8:5021 Review-Url: https://codereview.chromium.org/2074703002 Cr-Commit-Position: refs/heads/master@{#37368}
-
- 01 Jun, 2016 2 commits
-
-
mstarzinger authored
R=bmeurer@chromium.org BUG=v8:5021 Review-Url: https://codereview.chromium.org/2022033004 Cr-Commit-Position: refs/heads/master@{#36637}
-
mstarzinger authored
This adds a very simplistic reduction of {CheckPoint} nodes via the new {CheckpointElimination}, eliminating redundant check points that appear in an effect chain of operations that are all {kNoWrite}. Such a chain allows an arbitrary check point to be chosen. The current approach will end up choosing the first one for all deopts in the chain. R=bmeurer@chromium.org TEST=unittests/CheckpointEliminationTest.CheckPointChain BUG=v8:5021 Review-Url: https://codereview.chromium.org/2022913003 Cr-Commit-Position: refs/heads/master@{#36634}
-