- 28 Sep, 2015 13 commits
-
-
alph authored
Drive-by: remove unnecessary includes. Review URL: https://codereview.chromium.org/1356223004 Cr-Commit-Position: refs/heads/master@{#30987}
-
oth authored
BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1374613002 Cr-Commit-Position: refs/heads/master@{#30986}
-
mstarzinger authored
R=hpayer@chromium.org Review URL: https://codereview.chromium.org/1372063002 Cr-Commit-Position: refs/heads/master@{#30985}
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1370123002 Cr-Commit-Position: refs/heads/master@{#30984}
-
oth authored
The comparison operators and ToBoolean are implemented by calling into the runtime. There are new runtime methods are prefixed with Interpreter to make use case clear. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1369123002 Cr-Commit-Position: refs/heads/master@{#30983}
-
neis authored
The main changes are: - Fix treatment of loops, which was incorrect and sometimes resulted in the wrong completion value. - Get rid of unnecessary variables. This is in preparation of implementing ES6 completion semantics. R=rossberg BUG= Review URL: https://codereview.chromium.org/1362333002 Cr-Commit-Position: refs/heads/master@{#30981}
-
caitpotter88 authored
BUG=v8:2899 LOG=N R= Review URL: https://codereview.chromium.org/1364583004 Cr-Commit-Position: refs/heads/master@{#30979}
-
machenbach authored
This was copied into test262. BUG=v8:4254 NOTRY=true LOG=n Review URL: https://codereview.chromium.org/1368313002 Cr-Commit-Position: refs/heads/master@{#30976}
-
ishell authored
This is a second step towards merging FeedbackVectorSlot and FeedbackVectorICSlot. Review URL: https://codereview.chromium.org/1376443002 Cr-Commit-Position: refs/heads/master@{#30971}
-
neis authored
R=rossberg BUG= Review URL: https://codereview.chromium.org/1371963002 Cr-Commit-Position: refs/heads/master@{#30970}
-
ishell authored
This is a first step towards merging FeedbackVectorSlot and FeedbackVectorICSlot. Review URL: https://codereview.chromium.org/1369973002 Cr-Commit-Position: refs/heads/master@{#30964}
-
mstarzinger authored
R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1365803004 Cr-Commit-Position: refs/heads/master@{#30963}
-
machenbach authored
Fails since test262-es6 is tested without i18n support. BUG=v8:4437 LOG=n NOTRY=true TBR=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1368293002 Cr-Commit-Position: refs/heads/master@{#30960}
-
- 26 Sep, 2015 1 commit
-
-
machenbach authored
Fails since test262-es6 is tested without i18n support. BUG=v8:4437 LOG=n NOTRY=true TBR=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1369113002 Cr-Commit-Position: refs/heads/master@{#30952}
-
- 25 Sep, 2015 10 commits
-
-
mlippautz authored
Revert of "[heap] Add more tasks for parallel compaction" (patchset #4 id:100001 of https://codereview.chromium.org/1365743003/ ) Reason for revert: failing again: https://chromegw.corp.google.com/i/client.v8/builders/V8%20Mac/builds/4505/steps/Mozilla%20%28flakes%29/logs/regress-416628 Original issue's description: > Reland of "[heap] Add more tasks for parallel compaction" > > - We now compute the number of parallel compaction tasks, depending on the > evacuation candidate list, the number of cores, and some hard limit. > - Free memory is moved over to compaction tasks (up to some limit) > - Moving over memory is done by dividing the free list of a given space up among > other free lists. Since this is potentially slow we limit the maximum amount > of moved memory. > > This reverts commit bfccd518. > > BUG=chromium:524425 > LOG=N > > Committed: https://crrev.com/7e283d746a194ceaaca114e2ba17504653d6a109 > Cr-Commit-Position: refs/heads/master@{#30945} TBR=hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:524425 Review URL: https://codereview.chromium.org/1371653002 Cr-Commit-Position: refs/heads/master@{#30947}
-
mlippautz authored
- We now compute the number of parallel compaction tasks, depending on the evacuation candidate list, the number of cores, and some hard limit. - Free memory is moved over to compaction tasks (up to some limit) - Moving over memory is done by dividing the free list of a given space up among other free lists. Since this is potentially slow we limit the maximum amount of moved memory. This reverts commit bfccd518. BUG=chromium:524425 LOG=N Review URL: https://codereview.chromium.org/1365743003 Cr-Commit-Position: refs/heads/master@{#30945}
-
ulan authored
BUG=chromium:490559 LOG=NO Review URL: https://codereview.chromium.org/1352453004 Cr-Commit-Position: refs/heads/master@{#30944}
-
vogelheim authored
R=jochen@chromium.org BUG= Review URL: https://codereview.chromium.org/1366173002 Cr-Commit-Position: refs/heads/master@{#30942}
-
mstarzinger authored
This prevents the internal gc-idle-time-handler.h to be usable outisde of the "heap" directory. The logic inside that component is only useful within the GC and is now properly encapsulated. R=ulan@chromium.org Review URL: https://codereview.chromium.org/1368983002 Cr-Commit-Position: refs/heads/master@{#30939}
-
machenbach authored
Looks like we never ran test262-es6 on mac. After merging into test262 we've got these failures. Skipping for now. BUG=v8:4437 LOG=n NOTRY=true NOTREECHECKS=true TBR=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1372603002 Cr-Commit-Position: refs/heads/master@{#30937}
-
machenbach authored
BUG=v8:4254 LOG=n NOTRY=true Review URL: https://codereview.chromium.org/1365293002 Cr-Commit-Position: refs/heads/master@{#30936}
-
bmeurer authored
This name makes it clear that the flag (also the variant in the Compiler) is talking about specializing to the function context instead of i.e. the native context. R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/1372513003 Cr-Commit-Position: refs/heads/master@{#30934}
-
jarin authored
Verifies consistency of node inputs and uses: - node inputs should agree with the input count computed from the node's operator. - effect inputs should have effect outputs (or be a sentinel). - control inputs should have control outputs (or be a sentinel). - frame state inputs should be frame states (or be a sentinel). - if the node has control uses, it should produce control. - if the node has effect uses, it should produce effect. - if the node has frame state uses, it must be a frame state. I also removed some tests, either because they did not seem to be useful (scheduler) or they tested dead functionality (diamond effect phi). Review URL: https://codereview.chromium.org/1368913002 Cr-Commit-Position: refs/heads/master@{#30927}
-
bmeurer authored
The actual Function.prototype.toMethod was removed some time already, but there were some stuff (esp. %ToMethod) left in the tree, including tests for %ToMethod. This code (and esp. the tests) cause trouble in the process of moving bound functions away from JSFunction; so since the code is unused anyway, we can as well remove it. The original removal of Function.prototype.toMethod was in February 2015 in 68e48975. R=jarin@chromium.org BUG=v8:3330 LOG=n Review URL: https://codereview.chromium.org/1366063002 Cr-Commit-Position: refs/heads/master@{#30925}
-
- 24 Sep, 2015 10 commits
-
-
stefan.penner authored
Since https://codereview.chromium.org/366103005 the promise tests null out various globals, to ensure the promise implementation doesn’t itself rely on functions patchable by monkeys. Unfortunately, doing so breaks test assertion failures which rely on those globals. This isn’t the ideal solution, but does improve the current state. R=littledan@chromium.org,domenic@chromium.org LOG=N BUG= Review URL: https://codereview.chromium.org/1370583002 Cr-Commit-Position: refs/heads/master@{#30922}
-
oth authored
+ Add bytecodes for conditional and unconditional jumps. + Add bytecodes for test/compare operations. + Expose jumps in bytecode-array-builder and add BytecodeLabel class for identifying jump targets. + Add support for if..then...else in the bytecode-generator. + Implement jump bytecodes in the interpreter. Test/compare operations dependent on runtime call for comparisons. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1343363002 Cr-Commit-Position: refs/heads/master@{#30918}
-
mstarzinger authored
This introduces the NodeProperties::ChangeOp helper which guards node operator changes so that additional checking can be done without any additional dependencies being pulled into the Node class. For now only the input count is checked, but additional checking might follow. R=jarin@chromium.org Review URL: https://codereview.chromium.org/1366753003 Cr-Commit-Position: refs/heads/master@{#30916}
-
danno authored
Revert of Remove register index/code indirection (patchset #17 id:320001 of https://codereview.chromium.org/1287383003/ ) Reason for revert: Failures on greedy RegAlloc, Fuzzer Original issue's description: > Remove register index/code indirection > > Previous to this patch, both the lithium and TurboFan register > allocators tracked allocated registers by "indices", rather than > the register codes used elsewhere in the runtime. This patch > ensures that codes are used everywhere, and in the process cleans > up a bunch of redundant code and adds more structure to how the > set of allocatable registers is defined. > > Some highlights of changes: > > * TurboFan's RegisterConfiguration class moved to V8's top level > so that it can be shared with Crankshaft. > * Various "ToAllocationIndex" and related methods removed. > * Code that can be easily shared between Register classes on > different platforms is now shared. > * The list of allocatable registers on each platform is declared > as a list rather than implicitly via the register index <-> > code mapping. > > Committed: https://crrev.com/80bc6f6e11f79524e3f1ad05579583adfd5f18b2 > Cr-Commit-Position: refs/heads/master@{#30913} TBR=akos.palfi@imgtec.com,bmeurer@chromium.org,jarin@chromium.org,paul.lind@imgtec.com,titzer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1365073002 Cr-Commit-Position: refs/heads/master@{#30914}
-
danno authored
Previous to this patch, both the lithium and TurboFan register allocators tracked allocated registers by "indices", rather than the register codes used elsewhere in the runtime. This patch ensures that codes are used everywhere, and in the process cleans up a bunch of redundant code and adds more structure to how the set of allocatable registers is defined. Some highlights of changes: * TurboFan's RegisterConfiguration class moved to V8's top level so that it can be shared with Crankshaft. * Various "ToAllocationIndex" and related methods removed. * Code that can be easily shared between Register classes on different platforms is now shared. * The list of allocatable registers on each platform is declared as a list rather than implicitly via the register index <-> code mapping. Review URL: https://codereview.chromium.org/1287383003 Cr-Commit-Position: refs/heads/master@{#30913}
-
pierre.langlois authored
This patch checks the type of the lhs operand of a floating point comparison for ARM, and commutes the operands if it is #0.0. It allows us to optimize a comparison with zero, as the vcmp instruction accepts #0.0 as rhs operand. Code before for "0.0 < 0.123": ------------------------------ movw ip, #29360 movt ip, #37224 movw r9, #31981 movt r9, #16319 vmov d0, ip, r9 mov ip, #0 vmov d1, ip, ip vcmp.f64 d1, d0 vmrs APSR, FPSCR bcc +12 Code after: ----------- movw ip, #29360 movt ip, #37224 movw r9, #31981 movt r9, #16319 vmov d0, ip, r9 vcmp.f64 d0, #0.0 vmrs APSR, FPSCR bgt +12 BUG= Review URL: https://codereview.chromium.org/1361913003 Cr-Commit-Position: refs/heads/master@{#30911}
-
rmcilroy authored
Adds LdaGlobal bytecode and augments BytecodeGenerator to load globals for global variables and function calls. Modified TestBytecodeGenerator to add the ability to specify that a bytecode operand has an unknown value (used so we don't need to figure out the slot index of a global). Also added a helper which checks equality of BytecodeArray with the expected snipptets. Modified TestInterpreter to allow it to take snippets of JS and have the BytecodeGenerator generate the bytecode rather than having to build a BytecodeArray manually. This is used to enable the global tests. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1361113002 Cr-Commit-Position: refs/heads/master@{#30910}
-
martyn.capewell authored
Reduce operations of the form f64cmp(fp32to64(x), k) to f32cmp(x, k) when k can be encoded as a 32-bit float. Review URL: https://codereview.chromium.org/1365623002 Cr-Commit-Position: refs/heads/master@{#30909}
-
machenbach authored
NOTRY=true Review URL: https://codereview.chromium.org/1367933002 Cr-Commit-Position: refs/heads/master@{#30906}
-
pierre.langlois authored
This patch explicitly names commuted conditions for floating point comparisons, instead of relying on CommuteFlagsCondition. Otherwise, a bug in this function would not be caught. BUG= Review URL: https://codereview.chromium.org/1364773002 Cr-Commit-Position: refs/heads/master@{#30905}
-
- 23 Sep, 2015 6 commits
-
-
bmeurer authored
Introduce a new macro TO_STRING that maps to %_ToString and use that instead of calling into any of the ToString/NonStringToString JavaScript builtins. Also remove the TO_STRING_INLINE macro, which is basically obsolete with %_ToString. We still have a few uses of ToString left (via the utils export mechanism), where we need to investigate whether we will tank badly if we replace them with TO_STRING as well. CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_layout_dbg,v8_linux_nosnap_dbg R=yangguo@chromium.org BUG=v8:4307 LOG=n Review URL: https://codereview.chromium.org/1323543002 Cr-Commit-Position: refs/heads/master@{#30895}
-
gdeepti authored
Remove sumOfAbsoluteDifferences functions. BUG=v8:4124 LOG=Y R=bbudge@chromium.org, littledan@chromium.org Review URL: https://codereview.chromium.org/1356413002 Cr-Commit-Position: refs/heads/master@{#30894}
-
machenbach authored
Revert of [heap] Add more tasks for parallel compaction (patchset #11 id:200001 of https://codereview.chromium.org/1354383002/ ) Reason for revert: [Sheriff] May have caused this new flake: http://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/5412 Original issue's description: > [heap] Add more tasks for parallel compaction > > - We now compute the number of parallel compaction tasks, depending on the > evacuation candidate list, the number of cores, and some hard limit. > - Free memory is moved over to compaction tasks (up to some limit) > - Moving over memory is done by dividing the free list of a given space up among > other free lists. Since this is potentially slow we limit the maximum amount > of moved memory. > > BUG=chromium:524425 > LOG=N > > Committed: https://crrev.com/0e842418835eea85886a06cf37052895bc8a17db > Cr-Commit-Position: refs/heads/master@{#30886} TBR=hpayer@chromium.org,mlippautz@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:524425 Review URL: https://codereview.chromium.org/1356363005 Cr-Commit-Position: refs/heads/master@{#30888}
-
jkummerow authored
Whenever a generalization is computed, the inputs must be checked for being cleared, and if they are, the generalization must be Type::Any. Hopefully this fixes Chromium issue 527994 as well. BUG=v8:4325,chromium:527994 LOG=n Review URL: https://codereview.chromium.org/1361103002 Cr-Commit-Position: refs/heads/master@{#30887}
-
mlippautz authored
- We now compute the number of parallel compaction tasks, depending on the evacuation candidate list, the number of cores, and some hard limit. - Free memory is moved over to compaction tasks (up to some limit) - Moving over memory is done by dividing the free list of a given space up among other free lists. Since this is potentially slow we limit the maximum amount of moved memory. BUG=chromium:524425 LOG=N Review URL: https://codereview.chromium.org/1354383002 Cr-Commit-Position: refs/heads/master@{#30886}
-
ishell authored
NOTRY=true Review URL: https://codereview.chromium.org/1364583003 Cr-Commit-Position: refs/heads/master@{#30885}
-