1. 13 May, 2022 1 commit
  2. 27 Apr, 2022 1 commit
  3. 24 Mar, 2022 1 commit
  4. 30 Sep, 2021 1 commit
  5. 24 Sep, 2021 1 commit
  6. 23 Sep, 2021 1 commit
  7. 02 Sep, 2021 1 commit
  8. 24 Jun, 2021 3 commits
  9. 07 Jun, 2021 1 commit
  10. 03 Mar, 2021 1 commit
  11. 09 Feb, 2021 1 commit
  12. 01 Feb, 2021 1 commit
    • Peter Wong's avatar
      [torque] Port String.prototype.includes/indexOf and StringIndexOf · 5a2c53f9
      Peter Wong authored
      - Removed no longer used StringBuiltinAssembler methods (DispatchOnStringEncodings, PointerToStringDataAtIndex)
      - Removed no longer used Runtime functions (StringIncludes, StringIndexOf, StringIndexOfUnchecked).
      - Overall builtin code size is reduced (652 bytes on Mac x64.release build), builtin size breakdown:
      
      BEFORE
      ======
      TFS Builtin, StringIndexOf, 1092
      TFJ Builtin, StringPrototypeIncludes, 1784
      TFJ Builtin, StringPrototypeIndexOf, 1536
      Total = 4412
      
      AFTER
      =====
      TFC Builtin, StringIndexOf, 2036 (+944)
      TFJ Builtin, StringPrototypeIncludes, 1072 (-712)
      TFJ Builtin, StringPrototypeIndexOf, 652 (-884)
      Total = 3760 (-652)
      
      
      Bug: v8:8996
      Change-Id: I9a88c095e2097f7d570e58e744d6692dc524ddf4
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2660995
      Commit-Queue: Peter Wong <peter.wm.wong@gmail.com>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#72456}
      5a2c53f9
  13. 04 Dec, 2020 1 commit
    • Tobias Tebbi's avatar
      [torque] uniform flattening and string access in Torque · 65d2c4b4
      Tobias Tebbi authored
      Port String::Flatten to Torque (using a fast C call for the
      non-allocating part) and provide fast and easy access to sequential
      string data in Torque: GetStringData() flattens if necessary and
      computes slices that allow direct access.
      
      Applications: String.prototype.replaceAll, String.prototype.endsWith,
        and String.prototype.beginsWith now use GetStringData() and direct
        slice access instead of the slow StringCharCodeAt and they no
        longer bail out to the runtime for flattening.
      
      Drive-by changes:
        - Expose String instance type bits as bitfields and enums in Torque.
        - Fix method lookup in Torque to include superclass methods.
        - Use char8 and char16 types in more places.
        - Allow fast C calls with void return type.
        - Add Torque macros to create subslices.
        - Add no-GC scopes to runtime functions loading external string data.
      
      
      Bug: v8:7793
      Change-Id: I763b9b24212770307c9b2fe9f070f21f65d68d58
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565515
      Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#71611}
      65d2c4b4
  14. 30 Nov, 2020 1 commit
  15. 20 Nov, 2020 1 commit
  16. 12 Nov, 2020 1 commit
  17. 11 Nov, 2020 1 commit
  18. 06 Nov, 2020 1 commit
    • Mythri A's avatar
      [csa][cleanup] TNodify StringAdd_CheckNone buitin · 452ca36b
      Mythri A authored
      StringAdd_CheckNone is called from Turbofan with an empty context. This
      builtin needs context when calling the StringAdd runtime function which
      could potentially throw. Turbofan does bounds check before calling this
      builtin so it is safe to pass an empty context. To enable TNodification
      of this builtin this cl adds a new type that either accepts a context
      or an empty context (Smi::Zero) and updates the builtin to use this new
      type.
      
      Bug: v8:6949, v8:11074
      Change-Id: Iff12b391ff95109649f2c81fe081e277850f60d6
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2523205
      Commit-Queue: Mythri Alle <mythria@chromium.org>
      Reviewed-by: 's avatarDan Elphick <delphick@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#71018}
      452ca36b
  19. 05 Nov, 2020 1 commit
  20. 01 Oct, 2020 1 commit
    • Dan Elphick's avatar
      [CSA] Tnodify CodeAssembler::Parameter · 74a9b9c4
      Dan Elphick authored
      CodeAssembler::Parameter now takes a Type template parameter and
      performs a checked cast to it. There is also UncheckedParameter which
      returns a TNode but doesn't check the cast. The original Parameter
      method is still there as UntypedParameter.
      
      Parameter<T>(x) in many cases replaces CAST(Parameter(x)), where the
      cast is performed inside Parameter. Since Parameter is not a macro,
      this means it cannot see the original expression or its file name and
      line number. So the error messages are vaguely useful, Parameter<T>()
      takes a SourceLocation parameter which with a default value of
      SourceLocation::Current(), which at least gives us the file name and
      line number for the error message.
      
      Bug: v8:6949, v8:10933
      Change-Id: I27157bec7dc7462210c1eb9c430c0180217d25c1
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2435106Reviewed-by: 's avatarBill Budge <bbudge@chromium.org>
      Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
      Reviewed-by: 's avatarSantiago Aboy Solanes <solanes@chromium.org>
      Commit-Queue: Dan Elphick <delphick@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#70264}
      74a9b9c4
  21. 29 Sep, 2020 1 commit
  22. 10 Jun, 2020 1 commit
  23. 03 Jun, 2020 1 commit
  24. 06 May, 2020 1 commit
  25. 19 Feb, 2020 1 commit
  26. 17 Feb, 2020 1 commit
  27. 13 Jan, 2020 1 commit
  28. 04 Dec, 2019 1 commit
  29. 11 Nov, 2019 1 commit
  30. 05 Nov, 2019 1 commit
  31. 30 Oct, 2019 1 commit
  32. 24 Oct, 2019 1 commit
  33. 23 Oct, 2019 1 commit
  34. 22 Oct, 2019 1 commit
    • Igor Sheludko's avatar
      [builtins] Port String.prototype.substr to Torque · 3c57ad21
      Igor Sheludko authored
      ... and refactor String.prototype.substring.
      
      This is done to simplify cleaning up callers of ConvertToRelativeIndex()
      in a follow-up CL.
      
      This CL also introduces Smi-overflow friendly helper function
        ClampToIndexRange(index: JSAny, min: uintptr, max: uintptr): uintptr
      
      which can be used in other String builtins as a better alternative to
        NumberMin(NumberMax(value, min), max)
      pattern.
      
      Bug: v8:8996, v8:4153
      Change-Id: Ie1bb5ab305ebf851c033d109ffe9e6afb9418274
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1872392
      Commit-Queue: Igor Sheludko <ishell@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#64463}
      3c57ad21
  35. 16 Oct, 2019 1 commit
  36. 07 Oct, 2019 1 commit
  37. 01 Oct, 2019 2 commits