- 27 May, 2016 1 commit
-
-
jshin authored
intl/number-format/parse-percent.js intl/date-format/parse-mdyhms.js intl/number-format/parse-decimal.js intl/date-format/parse-MMMdy.js Also added a few more test cases. BUG=v8:3454 TEST=The tests listed above. Review-Url: https://codereview.chromium.org/1988073003 Cr-Commit-Position: refs/heads/master@{#36555}
-
- 18 May, 2016 1 commit
-
-
littledan authored
This patch ensures that Intl bound method getters can't be retargeted to other Intl types. If that were to happen, then a RUNTIME_ASSERT would trigger later. This patch throws a TypeError instead, as the specification requires. BUG=v8:4870 Review-Url: https://codereview.chromium.org/1986763003 Cr-Commit-Position: refs/heads/master@{#36330}
-
- 12 May, 2016 1 commit
-
-
littledan authored
This patch removes the following properties, as their use count is very low, they are V8-only, and not on a standards track. - v8Parse - resolved - pattern v8BreakIterator is left in as it has significantly more usage. BUG=v8:3785 R=adamk,jshin@chromium.org Review-Url: https://codereview.chromium.org/1968893002 Cr-Commit-Position: refs/heads/master@{#36190}
-
- 11 May, 2016 1 commit
-
-
jshin authored
When I18N is enabled, use ICU's case conversion API and transliteration API [1] to implement String.prototype.to{Upper,Lower}Case and String.prototype.toLocale{Upper,Lower}Case. * ICU-based case conversion was implemented in runtime-i18n.cc/i18n.js * The above 4 functions are overridden with those in i18n.js when --icu_case_mapping flag is turned on. To control the override by the flag, they're overriden in icu-case-mapping.js Previously, toLocale{U,L}Case just called to{U,L}Case so that they didn't support locale-sensitive case conversion for Turkic languages (az, tr), Greek (el) and Lithuanian (lt). Before ICU APIs for the most general case are called, a fast-path for Latin-1 is tried. It's taken from Blink and adopted as necessary. This fast path is always tried for to{U,L}Case. For toLocale{U,L}Case, it's only taken when a locale (explicitly specified or default) is not in {az, el, lt, tr}. With these changes, a build with --icu_case_mapping=true passes a bunch of tests in test262/intl402/Strings/* and intl/* that failed before. Handling of pure ASCII strings (aligned at word boundary) are not as fast as Unibrow's implementation that uses word-by-word case conversion. OTOH, Latin-1 input handling is faster than Unibrow. General Unicode input handling is slower but more accurate. See https://docs.google.com/spreadsheets/d/1KJCJxKc1FxFXjwmYqABS0_2cNdPetvnd8gY8_HGSbrg/edit?usp=sharing for the benchmark. This CL started with http://crrev.com/1544023002#ps200001 by littledan@, but has changed significantly since. [1] See why transliteration API is needed for uppercasing in Greek. http://bugs.icu-project.org/trac/ticket/10582 R=yangguo BUG=v8:4476,v8:4477 LOG=Y TEST=test262/{built-ins,intl402}/Strings/*, webkit/fast/js/*, mjsunit/string-case, intl/general/case* Review-Url: https://codereview.chromium.org/1812673005 Cr-Commit-Position: refs/heads/master@{#36187}
-
- 02 May, 2016 1 commit
-
-
machenbach authored
BUG=v8:4280 LOG=N TBR=rmcilroy@chromium.org, rmcilroy@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/1934283002 Cr-Commit-Position: refs/heads/master@{#35931}
-
- 29 Apr, 2016 1 commit
-
-
machenbach authored
This prepares for pulling chromium's build as dependency for gn. After this, the files in build and gypfiles need to stay in sync until chromium is updated. BUG=chromium:474921 LOG=n Review-Url: https://codereview.chromium.org/1848553003 Cr-Commit-Position: refs/heads/master@{#35898}
-
- 19 Apr, 2016 1 commit
-
-
machenbach authored
BUG=v8:4437,v8:2899,chromium:604310 LOG=n Review URL: https://codereview.chromium.org/1402373002 Cr-Commit-Position: refs/heads/master@{#35614}
-
- 07 Apr, 2016 1 commit
-
-
clemensh authored
Nothing too important, but it helps localizing the cause of an error much faster. By the way, I also changed the output for assertThrows and assertDoesNotThrow a bit. All new arguments are optional, so everything is backwards compatible. R=jfb@chromium.org, titzer@chromium.org BUG= Review URL: https://codereview.chromium.org/1866693002 Cr-Commit-Position: refs/heads/master@{#35322}
-
- 29 Mar, 2016 1 commit
-
-
yangguo authored
R=jochen@chromium.org BUG=v8:4361 LOG=N Review URL: https://codereview.chromium.org/1819313002 Cr-Commit-Position: refs/heads/master@{#35099}
-
- 24 Feb, 2016 1 commit
-
-
littledan authored
The Intl object used to keep around functions which are bound to the receiver and memoized in the object (as required by the ECMA-402 spec) in ordinary properties with names like __boundformat__. This patch instead stores those methods in private symbol properties, so they are not exposed to users. A search in GitHub didn't find any uses of __boundformat__ (whereas the same search found plenty of usages of other V8 Intl features), so I think this should be fine in terms of web compatibility. BUG=v8:3785 R=adamk LOG=Y Review URL: https://codereview.chromium.org/1728823002 Cr-Commit-Position: refs/heads/master@{#34230}
-
- 12 Dec, 2015 1 commit
-
-
littledan authored
A couple of the Intl tests made calls to getDefaultTimeZone(), which doesn't exist in V8; however, these were not core to the test. Rather than marking the whole test as failing, just comment out that unimportant part of the test. R=adamk Review URL: https://codereview.chromium.org/1522533003 Cr-Commit-Position: refs/heads/master@{#32819}
-
- 08 Dec, 2015 1 commit
-
-
littledan authored
ECMAScript dates act as if the Gregorian changeover happened at the beginning of time. This patch fixes up internationalized date formatting to set that changeover properly, as opposed to the ICU default which is in the 16th century. BUG=chromium:537382 R=adamk,cira LOG=Y Review URL: https://codereview.chromium.org/1501113002 Cr-Commit-Position: refs/heads/master@{#32669}
-
- 22 Oct, 2015 1 commit
-
-
littledan authored
The patch in https://crrev.com/ddb5c2d999c5ee6e31c4a9599bb3ddb293cc3f49 moved all fractional digit settings to default values due to a coding error. These were not even correct default values, and users observed errors where percentages were written as "23.0%" instead of "23%". This patch fixes the setting propagation when appropriate and it changes the default max fractional digits of a percentage to 0, per spec. BUG=chromium:544122 R=mnita,jochen CC=hichris123,adamk LOG=Y Review URL: https://codereview.chromium.org/1420883002 Cr-Commit-Position: refs/heads/master@{#31468}
-
- 14 Oct, 2015 1 commit
-
-
machenbach authored
BUG=v8:2899 LOG=n TBR=jochen@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1396293006 Cr-Commit-Position: refs/heads/master@{#31248}
-
- 07 Oct, 2015 1 commit
-
-
machenbach authored
NOTRY=true Review URL: https://codereview.chromium.org/1395503002 Cr-Commit-Position: refs/heads/master@{#31151}
-
- 05 Oct, 2015 1 commit
-
-
machenbach authored
This reverts commit 280a6f8e. Reland of https://codereview.chromium.org/1380593002/ BUG=chromium:535160 LOG=n CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_rel; Review URL: https://codereview.chromium.org/1390473003 Cr-Commit-Position: refs/heads/master@{#31094}
-
- 02 Oct, 2015 4 commits
-
-
danno authored
Revert of [swarming] Isolate v8 testing. (patchset #8 id:140001 of https://codereview.chromium.org/1380593002/ ) Reason for revert: Prime suspect in breakage of V8 Linux -- no snap Original issue's description: > [swarming] Isolate v8 testing. > > Add gyp support and isolates for default test suites. > Add two default isolates, one (default) for using the > test suite collection we call "default" on the bots. One > (developer_default) for also supporting the way developers > call the driver (i.e. without argument, which includes > the unittests). > > BUG=chromium:535160 > LOG=n > > Committed: https://crrev.com/9bd83f58f29ab0c7c5b71b00bcb1df3a9e641f05 > Cr-Commit-Position: refs/heads/master@{#31081} TBR=tandrii@chromium.org,jochen@chromium.org,maruel@chromium.org,machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:535160 Review URL: https://codereview.chromium.org/1370993008 Cr-Commit-Position: refs/heads/master@{#31084}
-
machenbach authored
Add gyp support and isolates for default test suites. Add two default isolates, one (default) for using the test suite collection we call "default" on the bots. One (developer_default) for also supporting the way developers call the driver (i.e. without argument, which includes the unittests). BUG=chromium:535160 LOG=n Review URL: https://codereview.chromium.org/1380593002 Cr-Commit-Position: refs/heads/master@{#31081}
-
machenbach authored
BUG=v8:4459 LOG=n NOTRY=true NOTREECHECKS=true TBR=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1384663004 Cr-Commit-Position: refs/heads/master@{#31077}
-
machenbach authored
BUG=chromium:535160,v8:4459 LOG=n NOTRY=true Review URL: https://codereview.chromium.org/1384683002 Cr-Commit-Position: refs/heads/master@{#31073}
-
- 28 Sep, 2015 1 commit
-
-
caitpotter88 authored
BUG=v8:2899 LOG=N R= Review URL: https://codereview.chromium.org/1364583004 Cr-Commit-Position: refs/heads/master@{#30979}
-
- 17 Sep, 2015 3 commits
-
-
jkummerow authored
Now run-tests.py understands "suite/foo/bar" with forward slashes for command-line test selection on all test suites on all platforms. Previously, file-based suites like mjsunit also accepted "mjsunit/foo\bar"; that behavior is sacrificed here in favor of unification. For the cctest suite, OTOH, it wasn't possible on Windows to select specific tests at all. Original review: https://codereview.chromium.org/1348653003/ This reverts commit 5f44a910. NOTRY=true Review URL: https://codereview.chromium.org/1356613002 Cr-Commit-Position: refs/heads/master@{#30798}
-
jkummerow authored
Revert of [test] Fix cctest path separators on Windows (patchset #2 id:20001 of https://codereview.chromium.org/1348653003/ ) Reason for revert: mozilla tests are failing on Windows Original issue's description: > [test] Fix cctest path separators on Windows > > Now run-tests.py understands "suite/foo/bar" with forward slashes for > command-line test selection on all test suites on all platforms. > > Previously, file-based suites like mjsunit also accepted "mjsunit/foo\bar"; > that behavior is sacrificed here in favor of unification. For the cctest > suite, OTOH, it wasn't possible on Windows to select specific tests at all. > > Committed: https://crrev.com/b36cfdb39ae648b49a1396c4f669df9b1f57996c > Cr-Commit-Position: refs/heads/master@{#30794} TBR=machenbach@google.com,machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1349163002 Cr-Commit-Position: refs/heads/master@{#30795}
-
jkummerow authored
Now run-tests.py understands "suite/foo/bar" with forward slashes for command-line test selection on all test suites on all platforms. Previously, file-based suites like mjsunit also accepted "mjsunit/foo\bar"; that behavior is sacrificed here in favor of unification. For the cctest suite, OTOH, it wasn't possible on Windows to select specific tests at all. Review URL: https://codereview.chromium.org/1348653003 Cr-Commit-Position: refs/heads/master@{#30794}
-
- 05 Aug, 2015 1 commit
-
-
mathias authored
TEST=test/intl/string/normalization BUG=v8:4303 LOG=N Review URL: https://codereview.chromium.org/1274653002 Cr-Commit-Position: refs/heads/master@{#30030}
-
- 20 Jul, 2015 1 commit
-
-
yangguo authored
The choice for the symbol seems to be locale-dependent. R=jochen@chromium.org BUG=v8:4314 LOG=N Review URL: https://codereview.chromium.org/1238133003 Cr-Commit-Position: refs/heads/master@{#29750}
-
- 17 Jul, 2015 1 commit
-
-
hichris123 authored
NumberFormat previously just used a min of 0 digits after the decimal and a max of 3. This CL changes it so that we use the ICU currency data, and set the min and max to the number of numbers after the decimal point for each currency. This CL also fixes a small bug where if the minimum fraction digits is above 3 but the maximum fraction digits isn't set, then it returns with only three numbers after the decimal point. BUG=435465,473104,304722 LOG=Y Review URL: https://codereview.chromium.org/1231613006 Cr-Commit-Position: refs/heads/master@{#29734}
-
- 10 Oct, 2014 1 commit
-
-
yangguo@chromium.org authored
ES5.1 section 6 ("Source Text"): "Throughout the rest of this document, the phrase “code unit” and the word “character” will be used to refer to a 16-bit unsigned value used to represent a single 16-bit unit of text." This changed in ES6 draft section 10.1 ("Source Text"): "The ECMAScript code is expressed using Unicode, version 5.1 or later. ECMAScript source text is a sequence of code points. All Unicode code point values from U+0000 to U+10FFFF, including surrogate code points, may occur in source text where permitted by the ECMAScript grammars." This patch is to reflect this spec change. BUG=v8:3617 LOG=Y R=jochen@chromium.org Review URL: https://codereview.chromium.org/640193002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24510 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 26 Aug, 2014 1 commit
-
-
mstarzinger@chromium.org authored
R=bmeurer@chromium.org BUG=v8:3522,v8:3526 LOG=N Review URL: https://codereview.chromium.org/505113002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23388 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 22 Aug, 2014 1 commit
-
-
Jacob.Bramley@arm.com authored
This test times out with Turbo Fan enabled. See issue 3526 for details. BUG= R=ulan@chromium.org, wingo@igalia.com Review URL: https://codereview.chromium.org/494173002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23297 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 14 Aug, 2014 1 commit
-
-
mstarzinger@chromium.org authored
R=verwaest@chromium.org Review URL: https://codereview.chromium.org/473873002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23130 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 23 Jul, 2014 2 commits
-
-
jochen@chromium.org authored
The intl tests still fail locally. BUG=v8:3454 LOG=N R=verwaest@chromium.org Review URL: https://codereview.chromium.org/410083004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22558 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jochen@chromium.org authored
Update the following 4 intl tests after ICU 52 roll. date-format/parse-MMMdy.js date-format/parse-mdyhms.js number-format/parse-decimal.js number-format/parse-percent.js BUG=v8:3454 TEST=intl/* tests pass. LOG=Y R=jochen@chromium.org Review URL: https://codereview.chromium.org/410733003 Patch from Jungshik Shin <jshin@chromium.org>. git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22544 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 22 Jul, 2014 1 commit
-
-
jochen@chromium.org authored
BUG=v8:3452 R=svenpanne@chromium.org LOG=y Review URL: https://codereview.chromium.org/411493002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22523 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 01 Apr, 2014 3 commits
-
-
jochen@chromium.org authored
There were some tests that are supposed to protect against js messing with the meta data, however, they just didn't try hard enough. BUG=354967 R=dcarney@chromium.org LOG=y Committed: https://code.google.com/p/v8/source/detail?r=20375 Review URL: https://codereview.chromium.org/215293005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20388 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
machenbach@chromium.org authored
Store i18n meta data in hidden symbols instead of js accessible properties BUG=354967 LOG=N TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/220673002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20377 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jochen@chromium.org authored
There were some tests that are supposed to protect against js messing with the meta data, however, they just didn't try hard enough. BUG=354967 R=dcarney@chromium.org LOG=y Review URL: https://codereview.chromium.org/215293005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20375 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 12 Feb, 2014 1 commit
-
-
ulan@chromium.org authored
BUG=v8:3113 LOG=Y R=jochen@chromium.org, rmcilroy@chromium.org, rodolph.perfetta@arm.com Review URL: https://codereview.chromium.org/148293020 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19311 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 31 Jan, 2014 1 commit
-
-
svenpanne@chromium.org authored
BUG=v8:2943 LOG=Y TEST=Unit tests for "real life" use cases, edge cases, various types of normalization. ========================== This is identical to the previous CL https://codereview.chromium.org/40133004/ with two differences: * Added a dummy implementation of String.prototype.normalize to be used when v8 is compiled without intl support * Rebased the the test files for webkit. That was the only reason for the previous failure (and revert). Thank you, Mihai R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/68133016 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18972 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 22 Nov, 2013 1 commit
-
-
yangguo@chromium.org authored
The changes are (excluding presubmit.py) mechanical. I added the following lines after the check and iterated the presubmit script until all errors went away: f = open(name, "w"); if contents.endswith('\n\n'): f.write(contents[0:-1]) else: f.write(contents + '\n') R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/82803005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18017 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-