- 19 May, 2016 3 commits
-
-
mlippautz authored
- Removing null checks as we always have the CodeRange object (it might be invalid, but it's there) - Account for reserved area (Win64) in SetUp so we the caller doesn't need to be aware of it R=ulan@chromium.org Review-Url: https://codereview.chromium.org/1991253002 Cr-Commit-Position: refs/heads/master@{#36377}
-
ahaas authored
This patch moves the wrapper code from the remembered-set to the scavenger and the mark-compact code. The wrapper code inspected a slot address to see if the object that belongs to the address is in the from-space. If it was in the from-space, then some callback was executed on the object. If the object got move to the to-space, then the wrapper returned KEEP_SLOT, otherwise REMOVE_SLOT. This logic does not really belong to the remembered set, so I moved it away from there. R=ulan@chromium.org Review-Url: https://codereview.chromium.org/1994933002 Cr-Commit-Position: refs/heads/master@{#36364}
-
yangguo authored
The cached resource data pointer is a source of non-determinism when creating the snapshot. Long-term we may not keep the native source in memory anyways, so caching the resource data pointer will not be possible. R=ulan@chromium.org BUG=v8:4886 LOG=N Review-Url: https://codereview.chromium.org/1990183002 Cr-Commit-Position: refs/heads/master@{#36361}
-
- 18 May, 2016 2 commits
-
-
machenbach authored
Revert of [heap] Do not invoke GC to make heap iterable. (patchset #5 id:80001 of https://codereview.chromium.org/1961373003/ ) Reason for revert: Breaks https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/3551 Original issue's description: > [heap] Do not invoke GC to make heap iterable. > > Remove kMakeHeapIterableMask since the heap is always iterable. > > BUG=chromium:580959 > LOG=n > > Committed: https://crrev.com/7c1cac4888a248fda3fa6de3624f32a6babb37e9 > Cr-Commit-Position: refs/heads/master@{#36333} TBR=ulan@chromium.org,yangguo@chromium.org,hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:580959 Review-Url: https://codereview.chromium.org/1987363002 Cr-Commit-Position: refs/heads/master@{#36335}
-
hpayer authored
Remove kMakeHeapIterableMask since the heap is always iterable. BUG=chromium:580959 LOG=n Review-Url: https://codereview.chromium.org/1961373003 Cr-Commit-Position: refs/heads/master@{#36333}
-
- 17 May, 2016 1 commit
-
-
bmeurer authored
This adds back the instanceof operator support in the backends and introduces a @@hasInstance protector cell on the isolate that guards the fast path for the InstanceOfStub. This way we recover the ~10% regression on Octane EarleyBoyer in Crankshaft and greatly improve TurboFan and Ignition performance of instanceof. R=ishell@chromium.org TBR=hpayer@chromium.org,rossberg@chromium.org BUG=chromium:597249, v8:4447 LOG=n Review-Url: https://codereview.chromium.org/1980483003 Cr-Commit-Position: refs/heads/master@{#36275}
-
- 12 May, 2016 2 commits
-
-
cbruni authored
BUG= Review-Url: https://codereview.chromium.org/1870693002 Cr-Commit-Position: refs/heads/master@{#36206}
-
cbruni authored
Currently we do not check for @@isConcatSpreadable properly. If the Symbol is set on the Array.prototype or Object.prototype the current fast paths fail. This CL adds a fix to globally invalidate a isConcatSpreadable_protector. Drive-by-fix: use named accessors for context variables LOG=N BUG=chromium:542504, v8:903 Review-Url: https://codereview.chromium.org/1409123003 Cr-Commit-Position: refs/heads/master@{#36201}
-
- 11 May, 2016 1 commit
-
-
ulan authored
BUG=chromium:609761 LOG=NO Review-Url: https://codereview.chromium.org/1964143004 Cr-Commit-Position: refs/heads/master@{#36183}
-
- 10 May, 2016 2 commits
-
-
mlippautz authored
Revert of [heap] Fine-grained JSArrayBuffer tracking (patchset #7 id:200001 of https://codereview.chromium.org/1936233002/ ) Reason for revert: Breaks readonly test https://uberchromegw.corp.google.com/i/client.v8/builders/V8%20Linux/builds/10121 Original issue's description: > [heap] Fine-grained JSArrayBuffer tracking > > Track based on JSArrayBuffer addresses instead of the attached backing store. > This way we can later on iterate buffers on a single page. > > BUG=chromium:581412 > LOG=N > R=jochen@chromium.org, hpayer@chromium.org > > Committed: https://crrev.com/4cdf71e2d07c038d7af84e41c6e6d0093af0f0de > Cr-Commit-Position: refs/heads/master@{#36140} TBR=hpayer@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:581412 Review-Url: https://codereview.chromium.org/1961403002 Cr-Commit-Position: refs/heads/master@{#36143}
-
mlippautz authored
Track based on JSArrayBuffer addresses instead of the attached backing store. This way we can later on iterate buffers on a single page. BUG=chromium:581412 LOG=N R=jochen@chromium.org, hpayer@chromium.org Review-Url: https://codereview.chromium.org/1936233002 Cr-Commit-Position: refs/heads/master@{#36140}
-
- 03 May, 2016 5 commits
-
-
mlippautz authored
Reland of [heap] Fix clearing slots for map and size during LeftTrimFixedArray (patchset #1 id:1 of https://codereview.chromium.org/1947473002/ ) Reason for revert: Unrelated to waterfall failures. Original issue's description: > Revert of [heap] Fix clearing slots for map and size during LeftTrimFixedArray (patchset #1 id:1 of https://codereview.chromium.org/1943263002/ ) > > Reason for revert: > GC-stress failures: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/3305/steps/Mjsunit/logs/array-copywithin > > Original issue's description: > > [heap] Fix clearing slots for map and size during LeftTrimFixedArray > > > > BUG=chromium:598319 > > LOG=N > > > > Committed: https://crrev.com/5aa1d9c3cfde4389fb5a34e98a5dccbca9dc9f12 > > Cr-Commit-Position: refs/heads/master@{#35970} > > TBR=ulan@chromium.org,mlippautz@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:598319 > > Committed: https://crrev.com/a4129bb45a3bb8cc68bb2e07ee1e0a734f04ce4b > Cr-Commit-Position: refs/heads/master@{#35979} TBR=ulan@chromium.org,yangguo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:598319 Review-Url: https://codereview.chromium.org/1947503002 Cr-Commit-Position: refs/heads/master@{#35986}
-
yangguo authored
Revert of [heap] Fix clearing slots for map and size during LeftTrimFixedArray (patchset #1 id:1 of https://codereview.chromium.org/1943263002/ ) Reason for revert: GC-stress failures: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/3305/steps/Mjsunit/logs/array-copywithin Original issue's description: > [heap] Fix clearing slots for map and size during LeftTrimFixedArray > > BUG=chromium:598319 > LOG=N > > Committed: https://crrev.com/5aa1d9c3cfde4389fb5a34e98a5dccbca9dc9f12 > Cr-Commit-Position: refs/heads/master@{#35970} TBR=ulan@chromium.org,mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:598319 Review-Url: https://codereview.chromium.org/1947473002 Cr-Commit-Position: refs/heads/master@{#35979}
-
yangguo authored
v8::Object::{Set,Get,Delete}HiddenValue have long been deprecated. Please use v8::Object::{Set,Has,Get}Private instead. R=jochen@chromium.org LOG=Y Review-Url: https://codereview.chromium.org/1942233002 Cr-Commit-Position: refs/heads/master@{#35977}
-
mlippautz authored
BUG=chromium:598319 LOG=N Review-Url: https://codereview.chromium.org/1943263002 Cr-Commit-Position: refs/heads/master@{#35970}
-
danno authored
Review-Url: https://codereview.chromium.org/1903723003 Cr-Commit-Position: refs/heads/master@{#35963}
-
- 29 Apr, 2016 1 commit
-
-
mlippautz authored
- Move the concurrent unmapping to MemoryAllocator - Hide (private) members where possible - MemoryAllocator:Free is now the bottleneck for freeing - Pooled pages are either allocated from a set of pooled pages are obtained through work stealing from the concurrent unmapper BUG=chromium:605866, chromium:581412 LOG=N This reverts commit 25ff296c. Review-Url: https://codereview.chromium.org/1929503002 Cr-Commit-Position: refs/heads/master@{#35910}
-
- 28 Apr, 2016 1 commit
-
-
neis authored
Instead of replacing the array with an empty one after resuming, overwrite contents with a new Oddball. This will simplify the work to be done by the bytecode graphbuilder and potentially allow for more optimization. (For full-codegen generators, nothing changes.) BUG=v8:4907 LOG=n Review-Url: https://codereview.chromium.org/1923253002 Cr-Commit-Position: refs/heads/master@{#35872}
-
- 27 Apr, 2016 1 commit
-
-
hablich authored
Revert of [heap] Uncommit pooled pages concurrently (patchset #5 id:120001 of https://codereview.chromium.org/1913083002/ ) Reason for revert: Creates a spike of OOM(v8) crashers on Win32. Original issue's description: > [heap] Uncommit pooled pages concurrently > > - Move the concurrent unmapping to MemoryAllocator > - Hide (private) members where possible > - MemoryAllocator:Free is now the bottleneck for freeing > - Pooled pages are either allocated from a set of pooled pages are obtained > through work stealing from the concurrent unmapper > > BUG=chromium:605866, chromium:581412 > LOG=N > > Committed: https://crrev.com/2158df87116906160cebc3ad20c97f454822da03 > Cr-Commit-Position: refs/heads/master@{#35797} TBR=hpayer@chromium.org,mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:605866, chromium:581412 Review URL: https://codereview.chromium.org/1925563003 Cr-Commit-Position: refs/heads/master@{#35819}
-
- 26 Apr, 2016 1 commit
-
-
mlippautz authored
- Move the concurrent unmapping to MemoryAllocator - Hide (private) members where possible - MemoryAllocator:Free is now the bottleneck for freeing - Pooled pages are either allocated from a set of pooled pages are obtained through work stealing from the concurrent unmapper BUG=chromium:605866, chromium:581412 LOG=N Review URL: https://codereview.chromium.org/1913083002 Cr-Commit-Position: refs/heads/master@{#35797}
-
- 25 Apr, 2016 1 commit
-
-
mlippautz authored
BUG=chromium:581412 LOG=N Review URL: https://codereview.chromium.org/1900423002 Cr-Commit-Position: refs/heads/master@{#35768}
-
- 22 Apr, 2016 1 commit
-
-
adamk authored
The feature was deprecated in M49 and flagged off in M50. This patch removes it entirely from the codebase. Review URL: https://codereview.chromium.org/1909433003 Cr-Commit-Position: refs/heads/master@{#35714}
-
- 20 Apr, 2016 1 commit
-
-
mlippautz authored
In a full mark-compact GC, instead of copying memory to old space for pages that have more than X% live bytes, we just move the whole page over to old space. X=70 (default value) BUG=chromium:581412 LOG=N TBR=hpayer@chromium.org This reverts commit 8b333727. Review URL: https://codereview.chromium.org/1901093002 Cr-Commit-Position: refs/heads/master@{#35649}
-
- 19 Apr, 2016 2 commits
-
-
machenbach authored
Revert of
[heap] Add page evacuation mode for new->old (patchset #21 id:800001 of https://codereview.chromium.org/1863983002/ ) Reason for revert: [Sheriff] Breaks: https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug/builds/102 Original issue's description: > [heap] Add page evacuation mode for new->old > > In a full mark-compact GC, instead of copying memory to old space for > pages that have more than X% live bytes, we just move the whole page over to old > space. > > X=70 (default value) > > BUG=chromium:581412 > LOG=N > > Committed: https://crrev.com/0d7e23a6edd3822970983030a77a5b80cd337911 > Cr-Commit-Position: refs/heads/master@{#35610} TBR=hpayer@chromium.org,ulan@chromium.org,mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:581412 Review URL: https://codereview.chromium.org/1896883003 Cr-Commit-Position: refs/heads/master@{#35619} -
mlippautz authored
In a full mark-compact GC, instead of copying memory to old space for pages that have more than X% live bytes, we just move the whole page over to old space. X=70 (default value) BUG=chromium:581412 LOG=N Review URL: https://codereview.chromium.org/1863983002 Cr-Commit-Position: refs/heads/master@{#35610}
-
- 18 Apr, 2016 1 commit
-
-
yangguo authored
There were a couple of issues with it: - interpreter is not supported - the source position was just accidentally correct for full-codegen - the eval origin could have been cached Also fixes a few other places to use AbstractCode. R=mstarzinger@chromium.org Committed: https://crrev.com/2f3a171adc9e620c2235bf0562145b9d4eaba66d Cr-Commit-Position: refs/heads/master@{#35257} Committed: https://crrev.com/ad4e8a27963b704bb70ec8bac0991c57296b1d16 Cr-Commit-Position: refs/heads/master@{#35481} Review URL: https://codereview.chromium.org/1854713002 Cr-Commit-Position: refs/heads/master@{#35581}
-
- 15 Apr, 2016 2 commits
-
-
ulan authored
BUG= Review URL: https://codereview.chromium.org/1887343004 Cr-Commit-Position: refs/heads/master@{#35540}
-
cbruni authored
BUG= Committed: https://crrev.com/5210f167e802a3758aac1f2900a6560c8de07831 Cr-Commit-Position: refs/heads/master@{#35231} Review URL: https://codereview.chromium.org/1834373003 Cr-Commit-Position: refs/heads/master@{#35516}
-
- 14 Apr, 2016 2 commits
-
-
yangguo authored
Revert of Correctly annotate eval origin. (patchset #5 id:80001 of https://codereview.chromium.org/1854713002/ ) Reason for revert: performance impact Original issue's description: > Correctly annotate eval origin. > > There were a couple of issues with it: > - interpreter is not supported > - the source position was just accidentally correct for full-codegen > - the eval origin could have been cached > > Also fixes a few other places to use AbstractCode. > > R=mstarzinger@chromium.org > > Committed: https://crrev.com/2f3a171adc9e620c2235bf0562145b9d4eaba66d > Cr-Commit-Position: refs/heads/master@{#35257} > > Committed: https://crrev.com/ad4e8a27963b704bb70ec8bac0991c57296b1d16 > Cr-Commit-Position: refs/heads/master@{#35481} TBR=mstarzinger@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1888013002 Cr-Commit-Position: refs/heads/master@{#35491}
-
yangguo authored
There were a couple of issues with it: - interpreter is not supported - the source position was just accidentally correct for full-codegen - the eval origin could have been cached Also fixes a few other places to use AbstractCode. R=mstarzinger@chromium.org Committed: https://crrev.com/2f3a171adc9e620c2235bf0562145b9d4eaba66d Cr-Commit-Position: refs/heads/master@{#35257} Review URL: https://codereview.chromium.org/1854713002 Cr-Commit-Position: refs/heads/master@{#35481}
-
- 13 Apr, 2016 2 commits
-
-
ofrobots authored
Left trimming assumes that nobody other than the JSArray has a reference to the backing store. Sampling heap profiler may profile the backing store and keep a reference too it. This reference was never updated on a left-trim, causing a crash. R=alph@chromium.org, hpayer@chromium.org, mattloring@google.com BUG= Review URL: https://codereview.chromium.org/1885723002 Cr-Commit-Position: refs/heads/master@{#35449}
-
richard_chamberlain authored
This patch replaces the unused 'take_snapshot' parameter on FatalProcessOutOfMemory() with a 'is_heap_oom' parameter. The parameter is set to true on error paths where the JS heap is out of memory, as distinct from a malloc() failure i.e. process out of memory. The message output to stderr or passed to embedding applications via FatalErrorCallback is 'Javascript heap out of memory' rather than 'process out of memory'. BUG= R=jochen@chromium.org, verwaest@chromium.org, michael_dawson@ca.ibm.com Review URL: https://codereview.chromium.org/1873443002 Cr-Commit-Position: refs/heads/master@{#35431}
-
- 12 Apr, 2016 3 commits
-
-
jfb authored
The usage of __attribute__((format(x, y)) was either wrong or missing from multiple functions, leading to erroneous formats. This CL: - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h. - Uses it appropriately. - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further cleanup could be done). - Fixes a bunch of incorrect formats. Original CL: https://codereview.chromium.org/1869433004 Reverted in: https://codereview.chromium.org/1867383002 Reverted again in: https://codereview.chromium.org/1877823003 Reverts due to non-CQ bots: - First: v8_win_dbg, v8_win64_dbg, v8_mac_dbg - Second: gc mole (added to v8_linux_rel_ng for this patch) R= jochen@chromium.org TBR= ahaas@chromium.org,bmeurer@chromium.org,yangguo@chromium.org Review URL: https://codereview.chromium.org/1872203005 Cr-Commit-Position: refs/heads/master@{#35423}
-
ulan authored
This ensures that GC tracer scope is nested in a trace event. BUG= Review URL: https://codereview.chromium.org/1881993002 Cr-Commit-Position: refs/heads/master@{#35413}
-
hlopko authored
When the embedder sets the heap tracer, V8, during marking, will collect all reachable wrappers, and then ask embedder to trace its heap. The embedder is expected to call PersistentBase::RegisterExternalReference with all wrappers reachable from the given ones. This fixed point iteration happens in MarkCompact::ProcessEphemeralMarking. For more efficient object visiting during marking, we need a special JS_API_OBJECT_TYPE (in tandem with already existing JS_SPECIAL_API_OBJECT_TYPE) and corresponding visitor (JSApiObjectVisitor). BUG=chromium:468240 LOG=no Review URL: https://codereview.chromium.org/1844413002 Cr-Commit-Position: refs/heads/master@{#35412}
-
- 11 Apr, 2016 5 commits
-
-
https://codereview.chromium.org/1877453002/machenbach authored
Reason for revert: Breaks gc mole: https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/9421 Original issue's description: > Fix printf formats > > The usage of __attribute__((format(x, y)) was either wrong or missing from multiple functions, leading to erroneous formats. This CL: > > - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h. > - Uses it appropriately. > - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further cleanup could be done). > - Fixes a bunch of incorrect formats. > > Original CL: https://codereview.chromium.org/1869433004 > Reverted in: https://codereview.chromium.org/1867383002 > > R= jochen@chromium.org > TBR= bmeurer@chromium.org, yangguo@chromium.org, ahaas@chromium.org > > Committed: https://crrev.com/bf505329288e1b75bab0e6800371a9aac40fa5cc > Cr-Commit-Position: refs/heads/master@{#35394} TBR=jochen@chromium.org,ahaas@chromium.org,bmeurer@chromium.org,yangguo@chromium.org,jfb@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1877823003 Cr-Commit-Position: refs/heads/master@{#35396}
-
jfb authored
The usage of __attribute__((format(x, y)) was either wrong or missing from multiple functions, leading to erroneous formats. This CL: - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h. - Uses it appropriately. - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further cleanup could be done). - Fixes a bunch of incorrect formats. Original CL: https://codereview.chromium.org/1869433004 Reverted in: https://codereview.chromium.org/1867383002 R= jochen@chromium.org TBR= bmeurer@chromium.org, yangguo@chromium.org, ahaas@chromium.org Review URL: https://codereview.chromium.org/1877453002 Cr-Commit-Position: refs/heads/master@{#35394}
-
verwaest authored
BUG= Committed: https://crrev.com/8764f87a3399ba433a4ce6f32161181c713af95c Cr-Commit-Position: refs/heads/master@{#35376} Review URL: https://codereview.chromium.org/1864703003 Cr-Commit-Position: refs/heads/master@{#35386}
-
machenbach authored
Revert of Turn StoreIC::Megamorphic into a builtin, get rid of the non-monomorphic-cache (patchset #5 id:80001 of https://codereview.chromium.org/1864703003/ ) Reason for revert: [Sheriff] Check during mksnapshot: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20ASAN%20mipsel%20-%20debug%20builder/builds/5950/steps/compile/logs/stdio Original issue's description: > Turn StoreIC::Megamorphic into a builtin, get rid of the non-monomorphic-cache > > BUG= > > Committed: https://crrev.com/8764f87a3399ba433a4ce6f32161181c713af95c > Cr-Commit-Position: refs/heads/master@{#35376} TBR=mvstanton@chromium.org,hpayer@chromium.org,verwaest@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1875033003 Cr-Commit-Position: refs/heads/master@{#35379}
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1878573002 Cr-Commit-Position: refs/heads/master@{#35378}
-