- 21 Jun, 2018 40 commits
-
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: Ib8725fb5d7cd6909c522e3dca015e192a3dc6b01 Reviewed-on: https://chromium-review.googlesource.com/1110124Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#53941}
-
Yang Guo authored
TBR=clemensh@chromium.org Bug: v8:7872 Change-Id: I1f61e1ec7ffd86c7e8f74821fa0c4cd59bef57b2 Reviewed-on: https://chromium-review.googlesource.com/1110134Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Georg Neis authored
Also add a DCHECK to a branch that can only be taken for the null prototype. R=sigurds@chromium.org Change-Id: Ib94fe8f25ecfd1a4baa576915e6edfa60bcd771b Reviewed-on: https://chromium-review.googlesource.com/1109961 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#53939}
-
Rodrigo Bruno authored
Bug: chromium:845409 Change-Id: Ica0f7417a0d695900fa0578cd1248499ffa55f08 Reviewed-on: https://chromium-review.googlesource.com/1109965 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#53938}
-
Yang Guo authored
This reverts commit 18d0d7f6. Reason for revert: Tentative revert. This has somehow broken the custom snapshot build https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/19822 Original change's description: > Ship Symbol.prototype.description > > Intent to ship: > https://groups.google.com/forum/#!msg/v8-users/9U2kEQw8pb8/Sn91yUx5BQAJ > > Bug: v8:7807 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: Ia9e73495b08b432371dfb0ccc571af969ae4d59f > Reviewed-on: https://chromium-review.googlesource.com/1107210 > Commit-Queue: Joyee Cheung <joyee@igalia.com> > Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53933} TBR=kozyatinskiy@chromium.org,gsathya@chromium.org,luoe@chromium.org,joyee@igalia.com Change-Id: I28835d35d594ed8e14d824627e6aadb0360618f7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7807 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1110237Reviewed-by:
-
Alexey Kozyatinskiy authored
After this CL all liveedit tests call the same LiveEdit::PatchScript method. This method will be updated later. As well some new liveedit cctests added, unfortunately part of them do not work with current implementation. R=dgozman@chromium.org,yangguo@chromium.org Bug: v8:7862 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3521af12b0f95b39d13aaafb1d1cf60f3f642a97 Reviewed-on: https://chromium-review.googlesource.com/1108382 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#53936}
-
Georg Neis authored
R=sigurds@chromium.org Change-Id: I0478c38641cfba6ccbe5ffd0ba6e50d1040e6e58 Reviewed-on: https://chromium-review.googlesource.com/1109836Reviewed-by:
-
Mathias Bynens authored
Bug: v8:6890, v8:7825, v8:7834, v8:7874 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Idc5e532977e2309de55a27ea6513301389b3a525 Reviewed-on: https://chromium-review.googlesource.com/1110120Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#53934}
-
Joyee Cheung authored
Intent to ship: https://groups.google.com/forum/#!msg/v8-users/9U2kEQw8pb8/Sn91yUx5BQAJ Bug: v8:7807 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia9e73495b08b432371dfb0ccc571af969ae4d59f Reviewed-on: https://chromium-review.googlesource.com/1107210 Commit-Queue: Joyee Cheung <joyee@igalia.com> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#53933}
-
Dan Elphick authored
Pipe through Isolate into several elements.cc functions, to avoid using HeapObject::GetIsolate. In some cases, uses ReadOnlyObject::GetIsolate which is allowed. (Autogenerated using Leszek's clang-bubble-getisolate) Bug: v8:7786 Change-Id: Idcbfaadf95c3c2b96d03b606da5594774bac2f7e Reviewed-on: https://chromium-review.googlesource.com/1107706Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#53932}
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: If9cf209b26978ad11dc2cf9c01b92c40bcba1a49 Reviewed-on: https://chromium-review.googlesource.com/1109826 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Peter Marshall authored
Each local ABT is logically for one page. We passed the space in to the constructor, but this is wrong because the space a page is in can change, e.g. for compaction pages. Instead, pass the page to the local ABT constructor and always get the space from this. To do this we need to push the AllocateLocalTracker() helper and friends down to Page, rather than its superclass MemoryChunk. Unfortunately, we need to keep ReleaseLocalTracker() on MemoryChunk even though only Pages can have local trackers, because we can't do virtual dispatch on MemoryChunk::ReleaseAllocatedMemory() which would allow us to clean up the tracker memory nicely for pages only. We also have to make sure we update external bytes accounting properly when swapping spaces, as in SemiSpace::Swap(). Change-Id: Iff02e41dd12a6b04a57fcc32f9e2b4f049fcbc24 Reviewed-on: https://chromium-review.googlesource.com/1107635 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
The name {CallerOwnedBuffer} does not make sense in all situations, especially if such an object is returned instead of being passed as argument. I am working on moving the wasm wire bytes off the JS heap, and hence will return unowned references via the API. To prepare this change, I deprecate the existing {CallerOwnedBuffer} and introduce a new {BufferReference} struct with proper field names. R=titzer@chromium.org, adamk@chromium.org Bug: v8:7868 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ic8953951447038a831b15a336a52a199bfbeafd5 Reviewed-on: https://chromium-review.googlesource.com/1108207Reviewed-by:Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#53929}
-
Toon Verwaest authored
Change-Id: I142735622cb741fa8d84ec1036febb720a467363 Reviewed-on: https://chromium-review.googlesource.com/1109918Reviewed-by:
-
Clemens Hammacher authored
R=titzer@chromium.org Bug: v8:7754 Change-Id: I6f86d8d835009d864ba059055ee5bade4a52ab2e Reviewed-on: https://chromium-review.googlesource.com/1109917Reviewed-by:
-
Clemens Hammacher authored
Other fuzzers already have this ability. This CL adds it to the fuzzer. The input has to be valid bytes, otherwise we cannot generate the text representation. R=titzer@chromium.org CC=gdeepti@chromium.org Change-Id: If1ba8accc707bee3b042e93f4201949f0233c90e Reviewed-on: https://chromium-review.googlesource.com/1109794 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Ben L. Titzer authored
This completes the transition to Assembler::Options, which reduces the assemblers's dependency on isolates, and there is now only one way to create an Assembler, which is to use the options. Note that some operations on assemblers still need an isolate, such as GetCode(), and in these cases, the isolate is an additional argument to the method. R=jgruber@chromium.org CC=mstarzinger@chromium.org Change-Id: I413209d816c63a7c3640f1c226764693dcad1e7f Reviewed-on: https://chromium-review.googlesource.com/1106169 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#53925}
-
Toon Verwaest authored
[unibrow] -1 used by kNoPreviousCharacter and kEndOfInput isn't a valid Lead/Trail char. Drop superfluous check. Change-Id: Ie6b8e61230e25ab0321d0672d71f64fd593714bf Reviewed-on: https://chromium-review.googlesource.com/1109829 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#53924}
-
Peter Marshall authored
For bounds accesses, we definitely want to see these dchecks fire in all configurations. Change-Id: I54516794e32aaf0b00a2b1d88ffaf449f5a20b7b Reviewed-on: https://chromium-review.googlesource.com/1109835 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
For consistency with the existing Validate/Complete methodology. Drive-by: Use it in {PrintRawWasmCode}. R=titzer@chromium.org Bug: v8:7754 Change-Id: I6f08ad7456ded2bdb9b06bb9f288e2609d4010e7 Reviewed-on: https://chromium-review.googlesource.com/1109793Reviewed-by: -
Peter Marshall authored
Change-Id: If133fe47a086ed273446ee7e8f8af85bf9fc8389 Reviewed-on: https://chromium-review.googlesource.com/1108203 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Bug: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I98ac4de406630c14280927240e9471049af3e790 Reviewed-on: https://chromium-review.googlesource.com/1108118Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#53920}
-
Clemens Hammacher authored
This is a reland of c2f1090d, fixing jumbo builds. Original change's description: > [wasm] Move serialization tests to own file > > Move out all serialization related tests to > {test-wasm-serialization.cc}, to reduce the size of > {test-run-wasm-module.cc}. > > R=titzer@chromium.org > > Bug: v8:7754 > Change-Id: I0b2133baf69e2557df27d1733cc267d1d4cf7452 > Reviewed-on: https://chromium-review.googlesource.com/1107980 > Reviewed-by: Ben Titzer <titzer@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53909} TBR=titzer@chromium.org Bug: v8:7754 Change-Id: Ic0bb02b1b782676c6100daa2d588adce8b54c388 Reviewed-on: https://chromium-review.googlesource.com/1109838Reviewed-by:
-
Rodrigo Bruno authored
Bug: chromium:852748 Change-Id: Iac1c52d45e84af190415aeae5df167ab501b4bc4 Reviewed-on: https://chromium-review.googlesource.com/1109821Reviewed-by:
-
Simon Zünd authored
All other sorting benchmarks use arrays of roughly the same length. This CL adds a set of benchmarks that sort arrays of various lengths. Two data configurations are used for each length: Completely random and already sorted. R=jgruber@chromium.org Bug: v8:7382 Change-Id: Ib80a3421a68029c8e4f823605bab7b2d7fe1ae34 Reviewed-on: https://chromium-review.googlesource.com/1109509 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
-
Clemens Hammacher authored
The {parameter_count} is always equal to {kParameterCount}, so just use {kParameterCount} directly. R=ishell@chromium.org Bug: v8:7754 Change-Id: I136387b5f2da3af10bb36215f947ff0e0d872928 Reviewed-on: https://chromium-review.googlesource.com/1109820Reviewed-by:Igor Sheludko <ishell@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#53916}
-
Peter Marshall authored
Currently we have to access the unreachable ArrayBuffer object to get the backing store pointer when we want to free it. This means we need the original ArrayBuffer object to stay alive until we collect all of the pointers to free (currently done sequentially after marking). We want to move this step to a background task that does not block GC finishing - to do that we need the backing store pointers so that the original page (where the ArrayBuffers live) can be freed. Change-Id: Ifaf070d777939cb23c46da637a25d75f9c863bd8 Reviewed-on: https://chromium-review.googlesource.com/1102434 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Yang Guo authored
This reverts commit c2f1090d. Reason for revert: breaks jumbo build: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20Jumbo%20-%20limited/1309 Original change's description: > [wasm] Move serialization tests to own file > > Move out all serialization related tests to > {test-wasm-serialization.cc}, to reduce the size of > {test-run-wasm-module.cc}. > > R=titzer@chromium.org > > Bug: v8:7754 > Change-Id: I0b2133baf69e2557df27d1733cc267d1d4cf7452 > Reviewed-on: https://chromium-review.googlesource.com/1107980 > Reviewed-by: Ben Titzer <titzer@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53909} TBR=titzer@chromium.org,clemensh@chromium.org Change-Id: I2c6ce0c128b34cc28c1f87e02bb584f2a79428e2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7754 Reviewed-on: https://chromium-review.googlesource.com/1109837Reviewed-by:
-
Simon Zünd authored
This CL adds sorting of a randomized array to the PreSorted benchmark to act as a baseline/reference point. R=jgruber@chromium.org Bug: v8:7382 Change-Id: I45b77a6584d5d9a4f14a807f3796af7197673eaa Reviewed-on: https://chromium-review.googlesource.com/1109508Reviewed-by:
-
Igor Sheludko authored
Bug: v8:7754 Change-Id: I5de3f1fb1c1c44312238c05f53257ca75136d093 Reviewed-on: https://chromium-review.googlesource.com/1109690 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This CL reverts commit 38bec2ea and implements the same functionality via Assembler::RecordRelocInfo. Bug: v8:6666 Change-Id: I2e6b60697f68e956257f4c0877342da1bffca361 Reviewed-on: https://chromium-review.googlesource.com/1107710 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Creddy authored
Change-Id: I02710e807fa2cd36849b4ab9d76cde2e99f02911 Reviewed-on: https://chromium-review.googlesource.com/1107983 Commit-Queue: Chandan Reddy <chandanreddy@google.com> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#53910}
-
Clemens Hammacher authored
Move out all serialization related tests to {test-wasm-serialization.cc}, to reduce the size of {test-run-wasm-module.cc}. R=titzer@chromium.org Bug: v8:7754 Change-Id: I0b2133baf69e2557df27d1733cc267d1d4cf7452 Reviewed-on: https://chromium-review.googlesource.com/1107980Reviewed-by: -
Ivica Bogosavljevic authored
Byteswap operations are used a lot in WASM on big endian architecture. This CL removed unused 1-byte swapping, rewrite tests so they have better coverage and cleans up some other minor things. TEST=cctest/test-run-wasm/RunWasmTurbofan_I32DivSOnDifferentRegisters Change-Id: I60466bbd5fe3f64e8e55684265dc43e92fcabc2c Reviewed-on: https://chromium-review.googlesource.com/1106379 Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Sreten Kovacevic <sreten.kovacevic@mips.com> Cr-Commit-Position: refs/heads/master@{#53908}
-
Igor Sheludko authored
Bug: v8:7754, v8:6600 Change-Id: I4db943d4a4a02a14bba670f89661ea98c5e306dd Reviewed-on: https://chromium-review.googlesource.com/1107919 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This is a reland of 2c1e4aa9 Original change's description: > [test] Initialize slow-dcheck runtime flag with compile time value > > This makes sure slow dchecks are part of the snapshot when the compile > time flag is set. It'll also obviate the need to set the runtime flag > in general, making configurations simpler. > > It's still possible to opt out at runtime for the non-snapshot dchecks > using the negated runtime flag. > > Bug: v8:7853 > Change-Id: Iadfc46ed691d32e9d39717e2ea0383e784660d1d > Reviewed-on: https://chromium-review.googlesource.com/1105050 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53819} TBR=jgruber@chromium.org Bug: v8:7853 Change-Id: I21d82ea907c0beead4ad2bc90fecc4dc9036dc1b Reviewed-on: https://chromium-review.googlesource.com/1109418Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
jgruber authored
The assertion is invalid if dst aliases src, which is the case in InterpreterOnStackReplacement: __ SmiUntag(x1, FieldMemOperand(x1, FixedArray::OffsetOfElementAt( DeoptimizationData::kOsrPcOffsetIndex))); This didn't fail so far because slow asserts in snapshotted code are never executed. Bug: v8:7853 Change-Id: I5b2dad780da94b5821aa9a624a3fcb9d083b3aa3 Reviewed-on: https://chromium-review.googlesource.com/1109503Reviewed-by: -
Rodrigo Bruno authored
Bug: chromium:852748 Change-Id: Ifdadf3188815fe38741e6f0e817070972e7f445b Reviewed-on: https://chromium-review.googlesource.com/1108205 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by:
-
Georg Neis authored
It doesn't depend on anything from PropertyAccessBuilder other than CompilationDependencies. Move it there instead. R=jarin@chromium.org Bug: v8:7790 Change-Id: I0545a990829f4591ebf5089b6a9e8c1a96899b93 Reviewed-on: https://chromium-review.googlesource.com/1107797Reviewed-by:
-
Michael Achenbach authored
This reverts commit 8e0f67be. Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20debug/20949 Original change's description: > Reland "[async] Expose async hooks to d8" > > This is a reland of 3c4d0316 > > Original change's description: > > [async] Expose async hooks to d8 > > > > This implementation follows the Node.js API as a guideline. > > > > Change-Id: I09274ea25ccdbb9794a7440d6c14f26b9febb4f4 > > Reviewed-on: https://chromium-review.googlesource.com/1065818 > > Commit-Queue: Maya Lekova <mslekova@chromium.org> > > Reviewed-by: Ali Ijaz Sheikh <ofrobots@google.com> > > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#53551} > > Change-Id: If2114db2ff179c6b07a40bc0c2dac3a41f37aea9 > Bug: chromium:850530 > Reviewed-on: https://chromium-review.googlesource.com/1088890 > Commit-Queue: Maya Lekova <mslekova@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53901} TBR=ofrobots@google.com,sergiyb@chromium.org,gsathya@chromium.org,bmeurer@chromium.org,mslekova@chromium.org Change-Id: Id55809a46bc5118103391fdbdfb52415182d3fd4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:850530 Reviewed-on: https://chromium-review.googlesource.com/1109038Reviewed-by:
-
