1. 23 Aug, 2021 1 commit
    • Corentin Pescheloche's avatar
      [cpu-profiler] Add method to estimate mem size of ProfilerCodeObserver · 731fd3f5
      Corentin Pescheloche authored
      This patchset introduces instrumentation of the memory usage of the
      datatructures maintained by the CPU profiler.
      It captures:
      * The total size of the strings held in StringsStorage for CodeEntries
      * Estimated size held by CodeMap's entries.
      
      The target is to surface that metric through telemetry to get better
      visibility into the memory profile of CpuProfiler.
      
      For now, STL containers overhead is ignored as it is implementation
      specific.
      
      Change-Id: I8c6a0cd4f14348fe8832dec1f24861befc67d700
      Bug: chromium:1241491
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3101580
      Auto-Submit: Corentin Pescheloche <cpescheloche@fb.com>
      Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#76438}
      731fd3f5
  2. 28 Jul, 2021 1 commit
  3. 22 Dec, 2020 1 commit
  4. 11 Nov, 2020 1 commit
  5. 30 Mar, 2020 1 commit
  6. 24 May, 2019 1 commit
  7. 27 Nov, 2018 1 commit
  8. 16 Jul, 2018 1 commit
  9. 24 May, 2018 1 commit
  10. 07 May, 2018 2 commits
  11. 04 May, 2018 1 commit
  12. 10 Feb, 2018 1 commit
  13. 28 Jul, 2017 1 commit
  14. 30 Sep, 2016 1 commit
  15. 20 Jun, 2016 1 commit
  16. 09 Jun, 2016 1 commit
    • lpy's avatar
      Move hashmap into src/base. · 2fd55667
      lpy authored
      We ported hashmap.h into libsampler as a workaround before, so the main focus of
      this patch is to reduce code duplication. This patch moves the hashmap into
      src/base as well as creates DefaultAllocationPolicy using malloc and free.
      
      BUG=v8:5050
      LOG=n
      
      Review-Url: https://codereview.chromium.org/2010243003
      Cr-Commit-Position: refs/heads/master@{#36873}
      2fd55667
  17. 12 Apr, 2016 1 commit
  18. 11 Apr, 2016 2 commits
  19. 08 Apr, 2016 2 commits
    • jfb's avatar
      Revert of Fix printf formats (patchset #8 id:140001 of... · 4c4fdc2d
      jfb authored
      Revert of Fix printf formats (patchset #8 id:140001 of https://codereview.chromium.org/1869433004/ )
      
      Reason for revert:
      One small issue easily fixed here: https://codereview.chromium.org/1867333003/
      
      But it looks like MSVS 2013 doesn't like some of the formats and exists with the unhelpful:
      Stderr:
      f:\dd\vctools\crt\crtw32\stdio\output.c(1125) : Assertion failed: ("Incorrect
      format specifier", 0)
      
      It's easier to revert for now, I'll dig more into the docs:
      https://msdn.microsoft.com/en-us/library/56e442dc(v=vs.120).aspx
      https://msdn.microsoft.com/en-us/library/tcxf1dw6(v=vs.120).aspx
      
      And then resubmit, making sure I run these bots.
      
      Original issue's description:
      > Fix printf formats
      >
      > The usage of __attribute__((format(x, y)) was either wrong or missing from multiple functions, leading to erroneous formats. This CL:
      >
      >  - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h.
      >  - Uses it appropriately.
      >  - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further cleanup could be done).
      >  - Fixes a bunch of incorrect formats.
      >
      > R= jochen@chromium.org, bmeurer@chromium.org, yangguo@chromium.org, ahaas@chromium.org
      >
      > Committed: https://crrev.com/6ebf9fbb93d31f9be41156a3325d58704ed4933d
      > Cr-Commit-Position: refs/heads/master@{#35365}
      
      TBR=jochen@chromium.org,bmeurer@chromium.org,yangguo@chromium.org,ahaas@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      
      Review URL: https://codereview.chromium.org/1867383002
      
      Cr-Commit-Position: refs/heads/master@{#35366}
      4c4fdc2d
    • jfb's avatar
      Fix printf formats · 6ebf9fbb
      jfb authored
      The usage of __attribute__((format(x, y)) was either wrong or missing from multiple functions, leading to erroneous formats. This CL:
      
       - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h.
       - Uses it appropriately.
       - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further cleanup could be done).
       - Fixes a bunch of incorrect formats.
      
      R= jochen@chromium.org, bmeurer@chromium.org, yangguo@chromium.org, ahaas@chromium.org
      
      Review URL: https://codereview.chromium.org/1869433004
      
      Cr-Commit-Position: refs/heads/master@{#35365}
      6ebf9fbb
  20. 01 Oct, 2015 2 commits
  21. 30 Sep, 2015 1 commit
  22. 20 Feb, 2015 1 commit