- 20 Jun, 2017 40 commits
-
-
Aseem Garg authored
This reverts commit 2f83ffa9. Reason for revert: Bots failed after this landed. Need to figure out if it is related. Original change's description: > [WASM SIMD] Store simd lowering compare ops result as -1 instead of 1 > > BUG: v8:6020 > Change-Id: I3148511233ee6f89acd71644e0c43f72ccc5eef0 > Reviewed-on: https://chromium-review.googlesource.com/538160 > Reviewed-by: Bill Budge <bbudge@chromium.org> > Reviewed-by: Mircea Trofin <mtrofin@chromium.org> > Commit-Queue: Aseem Garg <aseemgarg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#46071} TBR=bbudge@chromium.org,gdeepti@chromium.org,mtrofin@chromium.org,aseemgarg@chromium.org Change-Id: I300eadd02ab2d20817461e6f9a2c23c138b42256 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/541717Reviewed-by:
Aseem Garg <aseemgarg@chromium.org> Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Cr-Commit-Position: refs/heads/master@{#46072}
-
Aseem Garg authored
BUG: v8:6020 Change-Id: I3148511233ee6f89acd71644e0c43f72ccc5eef0 Reviewed-on: https://chromium-review.googlesource.com/538160Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Mircea Trofin <mtrofin@chromium.org> Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Cr-Commit-Position: refs/heads/master@{#46071}
-
Sathya Gunasekaran authored
Mask the lower byte before doing the compare. Bug: v8:5717, v8:6455 Change-Id: I0c7e8b79adc36fb5ee643eae2e42fd892cd560fd Reviewed-on: https://chromium-review.googlesource.com/527885 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#46070}
-
Adam Klein authored
Also remove support for "python macros" as the last existing one is removed in this patch. Change-Id: I537d604a0a1c9ca11cd5c195841b9f5a0ec74850 Reviewed-on: https://chromium-review.googlesource.com/540836 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
Daniel Ehrenberg <littledan@chromium.org> Cr-Commit-Position: refs/heads/master@{#46069}
-
machenbach authored
Revert of [parser] Forbid \08 in strict strings (patchset #3 id:40001 of https://codereview.chromium.org/2950633002/ ) Reason for revert: Breaks layout test: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/16403 See: https://github.com/v8/v8/wiki/Blink-layout-tests Original issue's description: > [parser] Forbid \08 in strict strings and in untagged templates > > This was never legal; the spec only allows '\0' in strict-mode strings or templates > when not followed by a decimal digit. Previously we were only enforcing that it > not be followed by an _octal_ digit. > > This was already fixed for numeric literals, but not for escape sequences in strings. > > BUG=v8:6504 > > Review-Url: https://codereview.chromium.org/2950633002 > Cr-Commit-Position: refs/heads/master@{#46046} > Committed: https://chromium.googlesource.com/v8/v8/+/b102540e44a72157098014a20399193a461153d2 TBR=vogelheim@chromium.org,bakkot@gmail.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:6504 Review-Url: https://codereview.chromium.org/2946953002 Cr-Commit-Position: refs/heads/master@{#46068}
-
Michael Achenbach authored
This reverts commit da607264. Reason for revert: Looked wrong. The persistent layout test failures started in the next revision. The failure on the revision of the reverted CL was just a flake. Original change's description: > Revert "Fix GCC 7 build errors" > > This reverts commit c0f1ff24. > > Reason for revert: Speculative revert for layout test timeout: > https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/16402 > > Original change's description: > > Fix GCC 7 build errors > > > > BUG=chromium:691681 > > R=franzih@chromium.org > > > > Change-Id: Id7e5698487f16dc217a804f6d3f24da7213c72b9 > > Reviewed-on: https://chromium-review.googlesource.com/530227 > > Commit-Queue: Toon Verwaest <verwaest@chromium.org> > > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#46045} > > TBR=adamk@chromium.org,franzih@chromium.org,mic.besace@gmail.com,verwaest@chromium.org > > Change-Id: I2119a87a95ed9eb88b7b32ae436edf28dfc86c16 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:691681 > Reviewed-on: https://chromium-review.googlesource.com/541227 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#46065} TBR=adamk@chromium.org,machenbach@chromium.org,franzih@chromium.org,mic.besace@gmail.com,verwaest@chromium.org Change-Id: Ieee7f6b3b80d380e720206e7b43c4b580918b1d7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:691681 Reviewed-on: https://chromium-review.googlesource.com/541228Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#46067}
-
Sathya Gunasekaran authored
Bug: v8:5717 Change-Id: Icc601c409ac79195991facf1cb2027aab6145ff8 Reviewed-on: https://chromium-review.googlesource.com/540659 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#46066}
-
Michael Achenbach authored
This reverts commit c0f1ff24. Reason for revert: Speculative revert for layout test timeout: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/16402 Original change's description: > Fix GCC 7 build errors > > BUG=chromium:691681 > R=franzih@chromium.org > > Change-Id: Id7e5698487f16dc217a804f6d3f24da7213c72b9 > Reviewed-on: https://chromium-review.googlesource.com/530227 > Commit-Queue: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#46045} TBR=adamk@chromium.org,franzih@chromium.org,mic.besace@gmail.com,verwaest@chromium.org Change-Id: I2119a87a95ed9eb88b7b32ae436edf28dfc86c16 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:691681 Reviewed-on: https://chromium-review.googlesource.com/541227Reviewed-by:
-
Clemens Hammacher authored
On an error during {ProcessExports()}, we would just continue execution, resulting in a DCHECK failure later. I did not find any tests for exported globals, so I added a few (including a regression test for the referenced bug). R=ahaas@chromium.org BUG=chromium:734295 Change-Id: I35370de934c274f870680c662ef848c72268a7bc Reviewed-on: https://chromium-review.googlesource.com/539401 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#46064}
-
Daniel Vogelheim authored
R=marja@chromium.org Bug: chromium:726625 Change-Id: I3f451a47b5a60a4c367d04a5466acd9e2f90df14 Reviewed-on: https://chromium-review.googlesource.com/530849Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#46063}
-
Clemens Hammacher authored
If one wasm instance imports an exported function of another instance, we unwrap the js-to-wasm wrapper of the export and use the underlying code object directly. However, the code object does not keep the wasm instance alive. It is only connected via a WeakCell. With this CL, we explicitly store a FixedArray of all wasm instances from which we imported functions to keep them alive at least as long as the instance which imports the code. R=mtrofin@chromium.org, ahaas@chromium.org BUG=chromium:734345 Change-Id: I8dcfc9a4ea2d791a62d8cb7255039e481c50bdfd Reviewed-on: https://chromium-review.googlesource.com/539738Reviewed-by:
-
Ross McIlroy authored
This reverts commit d58bb2dc. Reason for revert: New test breaks on optimize-for-size: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20debug/builds/16469/steps/OptimizeForSize/logs/GCShortCutting Original change's description: > [IdentityMap] Fix size if GC short-cuts objects. > > BUG=chromium:704132 > > Change-Id: I6146c907d4f26147676f7dde4974c44fe541e8fe > Reviewed-on: https://chromium-review.googlesource.com/541362 > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#46059} TBR=rmcilroy@chromium.org,mstarzinger@chromium.org Change-Id: Ib2ba207dcc1b3193d3645090e9c0a9676f38c353 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:704132 Reviewed-on: https://chromium-review.googlesource.com/541224Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#46061}
-
Ulan Degenbaev authored
This patch replaces IterateBlackObject with two functions: - RecordWrites, - ProcessBlackAllocatedObject. The RecordWrites function is a write barrier, and its behaviour depends on whether the concurrent marking is on or not. The ProcessBlackAllocatedObject is the same indepenent from the concurrent marker. BUG=chromium:694255 Change-Id: I1666371fbdac9b26c6f875b9e1d1751da4ea1960 Reviewed-on: https://chromium-review.googlesource.com/541441 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#46060}
-
Ross McIlroy authored
BUG=chromium:704132 Change-Id: I6146c907d4f26147676f7dde4974c44fe541e8fe Reviewed-on: https://chromium-review.googlesource.com/541362 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#46059}
-
Michael Starzinger authored
This adapts the predicate in question to be geared towards TurboFan now that Crankshaft is no longer being used. It makes the predicate respect the --allocation-site-pretenuring flag again in all cases. R=mlippautz@chromium.org BUG=v8:6408 Change-Id: Ib2753f70d7904764859a2d91815a675745416239 Reviewed-on: https://chromium-review.googlesource.com/541321Reviewed-by:
-
Camillo Bruni authored
Change-Id: I353d5959eef5369ae42ed7a176d6e59e94cc2d77 Reviewed-on: https://chromium-review.googlesource.com/541424Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#46057}
-
Alexey Kozyatinskiy authored
Inspector uses only BREAK_POSITION_ALIGNED, no tests pass STATEMENT_ALIGNED. It's exposed only with debugger API but I'm pretty sure that nobody actually uses it and as far as mirrors API is deprecated - it's time to remove it. R=jgruber@chromium.org Bug: none Change-Id: I28d62e145811d3eb6f4d64007c47c51b2ecbaf0f Reviewed-on: https://chromium-review.googlesource.com/536934 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
-
Dusan Simicic authored
Remove ast_id parameter from CallSize() which is not removed in https: //codereview.chromium.org/2944013002 Bug: Change-Id: I40c9460bf105c9a91f614a9ab2360eee70ab9b78 Reviewed-on: https://chromium-review.googlesource.com/541437Reviewed-by:
Ivica Bogosavljevic <ivica.bogosavljevic@imgtec.com> Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@imgtec.com> Cr-Commit-Position: refs/heads/master@{#46055}
-
Ulan Degenbaev authored
BUG=chromium:694255 Change-Id: I65b4ecc7630ece32e351c1c6acea3960f7b6778b Reviewed-on: https://chromium-review.googlesource.com/541380Reviewed-by:
-
Dusan Simicic authored
Add support for S32x4Shuffle, S16x8Shuffle, S8x16Shuffle for mips and mips64 architectures. Bug: Change-Id: I2c062525ed94edfcb38a53f4bbef02131e313ba3 Reviewed-on: https://chromium-review.googlesource.com/531007 Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@imgtec.com> Reviewed-by:
-
Michael Lippautz authored
AllocationSite objects survive if a page moves within new space. The intended behavior was to update the count only when they are visited by the Scavenger the first time, as they would die afterwards. This fixes that case where we would move a page within new space where most objects survive. We would unnecessarily update the AllocationSite in this case. Bug: chromium:651354 Change-Id: Ife4dd3e7f60320e0050e7c83dfc5457f66e2287c Reviewed-on: https://chromium-review.googlesource.com/541302Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#46052}
-
Michael Starzinger authored
This makes sure that the coercion of global import values to numbers remains non-observable to JavaScript. It allows instantiation failures to fall back to JavaScript proper without accidentally causing some side-effect to happen twice. Also coercions might invalidate previous checks done during linking or throw exceptions. R=clemensh@chromium.org TEST=mjsunit/regress/regress-6431 BUG=v8:6431 Change-Id: Ibe2f7a336bc0fb25532d526746ecc802e04bbd5c Reviewed-on: https://chromium-review.googlesource.com/512544 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#46051}
-
Clemens Hammacher authored
The constructor of WireBytesRef checks that offset+length is still in the uint32_t range. This CL avoids triggering this check on illegally size strings. R=ahaas@chromium.org BUG=chromium:734246 Change-Id: Iab5c7013aa3e0ac5060bc4733e712a1652679b1a Reviewed-on: https://chromium-review.googlesource.com/539402Reviewed-by:
-
Loo Rong Jie authored
https://codereview.chromium.org/2632713003 with workaround for old GCC. Drive-by: fix unused variable in src/wasm/wasm-js.cc Bug:chromium:457078 Change-Id: I6c1b65076bae783c31869552bc87d05c28550e26 Reviewed-on: https://chromium-review.googlesource.com/538463 Commit-Queue: Loo Rong Jie <loorongjie@gmail.com> Reviewed-by:
-
Camillo Bruni authored
Change-Id: Ie91d29f2e2ec7dc6dc4f824212c17d70a57d8b08 Reviewed-on: https://chromium-review.googlesource.com/541316Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#46048}
-
mvstanton authored
RelocInfo no longer needs CODE_TARGET_WITH_ID thanks to the removal of Crankshaft. BUG=v8:6408 R=mstarzinger@chromium.org Review-Url: https://codereview.chromium.org/2951473002 Cr-Commit-Position: refs/heads/master@{#46047}
-
bakkot authored
This was never legal; the spec only allows '\0' in strict-mode strings or templates when not followed by a decimal digit. Previously we were only enforcing that it not be followed by an _octal_ digit. This was already fixed for numeric literals, but not for escape sequences in strings. BUG=v8:6504 Review-Url: https://codereview.chromium.org/2950633002 Cr-Commit-Position: refs/heads/master@{#46046}
-
Michaël Zasso authored
BUG=chromium:691681 R=franzih@chromium.org Change-Id: Id7e5698487f16dc217a804f6d3f24da7213c72b9 Reviewed-on: https://chromium-review.googlesource.com/530227 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Especially in wasm, many builtins don't actually need a context parameter. We currently pass Smi::kZero instead. This CL allows to generate a CallDescriptor for calling stubs without passing a context, resulting in reduced compile time and code size, and increased performance when executing these builtins. We were calling the ThrowWasm* functions without passing a context anyway (directly from code-generator-<arch>.h). With this change, we will also call the StackCheck builtin without passing a (null) context. This saves two bytes of code in each function plus each loop, and also slightly reduces compile time (very noisy, but statistically significant). Drive-by: Use NoContextConstant instead of SmiConstant(Smi::kZero). R=mstarzinger@chromium.org, ahaas@chromium.org Change-Id: If794cc4c262a9cca8d29a68010803c01a2eef4a3 Reviewed-on: https://chromium-review.googlesource.com/541423Reviewed-by:
-
Toon Verwaest authored
Bug: Change-Id: I491709b44337e6329c9e1d1f273cb596d25b13a8 Reviewed-on: https://chromium-review.googlesource.com/541216Reviewed-by:
-
Michael Lippautz authored
A follow up will allow inserting slots during GC without emiting fences Bug: chromium:651354 Change-Id: Ia1d0f88e3658bca31933bdb013db15a5c2ecd849 Reviewed-on: https://chromium-review.googlesource.com/541400 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
bmeurer authored
Add a new JSCallWithArrayLike operator that is backed by the CallWithArrayLike builtin, and use that operator for both Function.prototype.apply and Reflect.apply inlining. Also unify the handling of JSCallWithArrayLike and JSCallWithSpread in the JSCallReducer to reduce the copy&paste overhead. Drive-by-fix: Add a lot of test coverage for Reflect.apply and Function.prototype.apply in optimized code, especially for some corner cases, which was missing so far. BUG=v8:4587,v8:5269 R=petermarshall@chromium.org Review-Url: https://codereview.chromium.org/2950773002 Cr-Commit-Position: refs/heads/master@{#46041}
-
Toon Verwaest authored
Bug: Change-Id: Ib0090647de77510ce5f3bda67e45c7d7474ac779 Reviewed-on: https://chromium-review.googlesource.com/541337Reviewed-by:
-
Ross McIlroy authored
Changes the handling of TestResultScopes to allow them to be reused by logical tests by rewiring instead of using a new TestResultScope. Also does the following: - moves some fields about in TestResultScope to reduce it's size - moves RegisterListFreeEvent to the end of ReleaseRegisters to enable it to be tail-called. This increases the allowed depth of logical expressions which the compiler can handle without overflowing the stack by about 2x on x64. BUG=chromium:731861 Change-Id: I7733797bec5e52d07eec6332c07e2a886f2bbde1 Reviewed-on: https://chromium-review.googlesource.com/539521 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#46039}
-
Peter Marshall authored
We can remove a lot of native code and rely on CallOrConstructVarargs to do the stack manipulation for us. This will also take advantage of the fast-path for double arrays in CallOrConstructDoubleVarargs. We can also remove Runtime_SpreadIterableFixed because it isn't used anymore. We just call directly into spread_iterable from CSA. Bug: v8:6488, chromium:704966 Change-Id: I81a18281f062619851134fff7ce88471566ee3b5 Reviewed-on: https://chromium-review.googlesource.com/535615Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#46038}
-
Daniel Ehrenberg authored
Previously, Date.toString() and friends were completely implementation-defined. However, they actually seemed to match each other's behavior with the exception of how years less than 1000 are formatted. The rough consensus among browsers seemed to be %04d, so this was standardized at TC39 [1]. V8 previously used %4d (it was the only one to do so); this patch adopts the new standard. [1] https://github.com/tc39/ecma262/commit/5d4acf3377e1b0ad4a4660c57108db1b28ef20ff Bug: v8:6076 Change-Id: I8c795a4e1b71187ad7c24a1aee8d7d66719a2586 Reviewed-on: https://chromium-review.googlesource.com/536733 Commit-Queue: Daniel Ehrenberg <littledan@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
For each Managed<T> (which is a Foreign), we create a weak global handle with a finalizer which deletes the referenced C++ object once the Foreign is dead. Before calling this finalizer, the garbage collector needs to mark the referenced object black (i.e. live), because the finalizer might resurrect it. Since this is never done for managed objects, we can use the more lightweight phantom handle semantics, which allows the referenced object to be garbage collected right away. However, we can't access the global handle via the WeakCallbackInfo, because the global handle will already be garbage collected. So we need to store it explicitly. This is solved by storing the global handle together with the finalizer. In order to implement this, ownership of the ManagedObjectFinalizer is moved from the isolate to the managed object. R=ulan@chromium.org, mtrofin@chromium.org BUG=v8:6505, chromium:734345 Change-Id: I94a245df601f70e19355d82439d30099e159231b Reviewed-on: https://chromium-review.googlesource.com/539578 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Alexey Kozyatinskiy authored
This test checks how much time we spent for generating Debugger.paused notification. R=machenbach@chromium.org Bug: chromium:688036 Change-Id: Ie8a52aafe6c8d93401b0b2a90a202ddff7de78ef Reviewed-on: https://chromium-review.googlesource.com/538584 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
-
Sathya Gunasekaran authored
Bug: v8:6443 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I20b1006a5c5ff24a730f15286cf0f340ba047b78 Reviewed-on: https://chromium-review.googlesource.com/526001Reviewed-by:
-
Camillo Bruni authored
Bug: chromium:734162, chromium:734051, v8:6211 Change-Id: I5c3e7578e9278b8f19ff16ad4d963f490dcc6c8c Reviewed-on: https://chromium-review.googlesource.com/541415 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#46033}
-
