- 27 Jul, 2022 1 commit
-
-
Frank Tang authored
TC39 2022-07-22 decided to take PR701 to skip order check on DateTimeFormat formatRange and formatRangeToParts See https://github.com/tc39/ecma402/pull/701 https://docs.google.com/presentation/d/1UUvbf3FFu9PGtrPAKPdMad9DZuVFLIvkAsAxyJZyvxM for details. Bug: v8:13094 Change-Id: I9ade938726f2a79e0ab2b5deb7fe36c001f2722f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779042Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#81985}
-
- 20 Nov, 2021 1 commit
-
-
Frank Tang authored
Remove two flags for feature shipped in m95 --harmony_intl_displaynames_v2 --harmony_intl_more_timezone Bug: v8:11637, v8:11661 Change-Id: I9432865722664f64c64b5bf7fde5e05e6b324b20 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3292518Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#78005}
-
- 27 May, 2021 1 commit
-
-
Frank Tang authored
https://tc39.es/proposal-intl-extend-timezonename/ https://chromestatus.com/guide/edit/4506375298220032 Bugs: v8:11661 Change-Id: I6d7e1bccf5a26ca02d39dc72d9362134a60ad6b9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2757899Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#74809}
-
- 25 Jan, 2021 1 commit
-
-
Frank Tang authored
Implement https://github.com/tc39/ecma402/pull/500 For the legacy [optional] Unwrap*Format steps, use OrdinaryHasInstance instead of InstanceofOperator. ECMA402 agree w/ PR500 on 2021-1-14 Bug: v8:10981 Change-Id: Ic697aa245b11fecaf998127c009e59a821aaa01e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2444092Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#72303}
-
- 09 Jul, 2020 1 commit
-
-
Frank Tang authored
Bug: v8:10686 Change-Id: I5a7b47dd4ed10142a795de56c4739ab072e63421 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2286814 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68773}
-
- 08 Jul, 2020 1 commit
-
-
Frank Tang authored
Reflect recent change to the proposal http://tc39.es/proposal-intl-DateTimeFormat-formatRange/#sec-intl.datetimeformat.prototype.formatRange Bug: v8:10681 Change-Id: Ie2e0e85816aeaeb2615d482ccd3ea345a5056c93 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2286813 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68748}
-
- 12 Jun, 2020 1 commit
-
-
Frank Tang authored
https://tc39.es/proposal-intl-datetime-style/ (Jun 10, 2020) fix extra s in message Bug: v8:10613 Change-Id: I2ef4f4004c1e8f0a58bf4409578876d1553de59b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2242258 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68329}
-
- 24 Apr, 2020 2 commits
-
-
Frank Tang authored
I2S https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/fractionalSecondDigits%7Csort:date/blink-dev/ISa0b6fOefY/pBlgkvZhBAAJ I2P https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/Intent$20to$20Implement$3A$20Add$20millisecondDigits$20option$20to$20Intl.DateTimeFormat%7Csort:date/blink-dev/WXd9nh03a1M/z7QeIMgrBgAJ Chrome Status: https://www.chromestatus.com/feature/5704965743968256 Latest spec: https://github.com/tc39/ecma402/pull/347 LGTMs: bratell.d@gmail.com / chrishtr@chromium.org / mkwst@chromium.org Bug: v8:9284 Change-Id: I4d2cca515ce65d41b38ebdef00b429fa873ea624 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2116989 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#67381}
-
Frank Tang authored
Remove harmony-intl-{other-calendars,add-calendar-numbering-system} https://www.chromestatus.com/features/5440249461211136 Bug: v8:9154 Change-Id: I8331d3cbd55e19ab1b1f983fef2e772fa7dc856c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2163816Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#67377}
-
- 31 Oct, 2019 1 commit
-
-
Frank Tang authored
Afer the getBestPattern, replace the HhKk by the hour cycle char. Not fix formatRange yet. Bug: v8:9930 Change-Id: I0833539ba308d4b2f58f20ae1a137f782a82fe49 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1892126Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#64691}
-
- 30 Oct, 2019 1 commit
-
-
Frank Tang authored
Remove unicode keyword/value "ca" and "nu" from the resolvedOptions().locale, if it does not match the option "calendar" / "numberingSystem". Bug: v8:9887 Change-Id: Idabc7e266e8e5f847f919324a93e39df4df440c8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1877708Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#64663}
-
- 11 Oct, 2019 1 commit
-
-
Frank Tang authored
* Change the logic to reflect the spec change of https://github.com/tc39/proposal-intl-datetime-style/pull/37/ * Move enum value of kUndefined to 0 to make unset behavior the same as kUndefined. * Change the expectation of existing tests * Additional tests - https://github.com/tc39/test262/pull/2385 Bug: v8:9826 Change-Id: Ic437b5f6414aa641ae73766d8c5fd5b9d352a230 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1846722Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#64255}
-
- 07 Oct, 2019 1 commit
-
-
Frank Tang authored
Remove test expectations whose behavior is not specified or contradicts the Stage 3 PR https://github.com/tc39/ecma402/pull/349 which we plan to land soon. The Chinese calendar (and other calendars) now need to choose different patterns for non-default calendars to support the correct behavior. Bug: v8:9320 Change-Id: Ia84e0eb1f7244b0d2d252071cf985d97f2acec58 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1838437 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#64149}
-
- 01 Oct, 2019 1 commit
-
-
Frank Tang authored
* Throws RangeError only when the calendar and numberingSystem is ill-formed. * Set the calendar and numberingSystem to the locale only if the values are valid. * Fix the order of GetOption of "localeMatcher". * Add more unit tests. See https://github.com/tc39/ecma402/pull/175 for details. Bug: v8:9786, v8:9787, v8:9788 Change-Id: Ic0f918ad7d9afb0b7c8df39caa0f44ef07ca10c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1830345 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#64070}
-
- 25 Sep, 2019 1 commit
-
-
Frank Tang authored
It is controlled by flag harmony_intl_other_calendars. But this is also pretty intern-dependent with harmony_intl_add_calendar_numbering_system and should be launched all together to be meaningful. https://github.com/tc39/ecma402/pull/349/ #349 Normative: Allow calendar to determine choice of pattern https://github.com/tc39/ecma402/pull/351 #351 Normative: Permit relatedYear and yearName in output Bug: v8:9155 Change-Id: I67cd6bba6276bbb995186a9fe6202429d724ba61 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588401Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#63972}
-
- 12 Sep, 2019 1 commit
-
-
Frank Tang authored
harmony_intl_bigint shipped in m76 harmony_intl_date_format_range shipped in m76 harmony_intl_datetime_style shipped in m76 harmony_intl_numberformat_unified shipped in m77 Bug: v8:9272, v8:9273, v8:9274 Change-Id: Icc640e011021e691373bc61725013578b7185e50 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1799263 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#63736}
-
- 29 Apr, 2019 1 commit
-
-
Frank Tang authored
Implement ECMA402 PR https://github.com/tc39/ecma402/pull/175 Add numberingSystem option to NumberFormat And numberingSystem and calendar option to DateTimeFormat Bug: v8:9154 Change-Id: Ic4e85a232a9ad26c17ee20385f839b0e09a56c77 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1575919Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#61061}
-
- 19 Apr, 2019 1 commit
-
-
Frank Tang authored
Design Doc: https://goo.gl/PGUQ1d Use template to share code between formatRange and formatRangeToParts Lazy crate DateIntervalFormat inside formatRange/formatRangeToParts to reduce performance impact. Bug: v8:7729 Change-Id: I130748a5ff7ca11235e6608195d365e58d440580 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1556573 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#60930}
-
- 09 Apr, 2019 1 commit
-
-
Frank Tang authored
While dateStyle or timeStye is specified, we should not add property listed in "Table Components of date and time formats" per https://tc39.github.io/proposal-intl-datetime-style/#sec-initializedatetimeformat Bug: v8:9107 Change-Id: I3e39112ed5f99b05f30b2f50f3cd3102d094f98e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559213Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#60725}
-
- 24 Mar, 2019 1 commit
-
-
Frank Tang authored
https://rawgit.com/fabalbon/proposal-intl-DateTimeFormat-formatRange/master/out/ Design Doc https://goo.gl/PGUQ1d Bug: v8:7729 Change-Id: I38b53ffdf610400b4132a25da99dac4be67bdf4b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1510574Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#60418}
-
- 01 Feb, 2019 1 commit
-
-
Frank Tang authored
See https://github.com/tc39/proposal-intl-datetime-style Design Doc: https://goo.gl/v7n7zV Bug: v8:8702 Change-Id: If45a901e369003ded6c0c690a65f0429800d5ecc Reviewed-on: https://chromium-review.googlesource.com/c/1417372 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#59264}
-
- 25 Jan, 2019 1 commit
-
-
Frank Tang authored
Remove hc from -u- if does not agree with the resolved one. Bug: v8:7482 Change-Id: I635c5357b8fd2b630ed80577a9b6a116e9a0e3f4 Reviewed-on: https://chromium-review.googlesource.com/c/1417170 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#59084}
-
- 08 Jan, 2019 1 commit
-
-
Frank Tang authored
This is a PARTIAL reland of 8d094249 Only land the newly added tests files Original change's description: > [Intl] Validate u extension type > > Fix intl402/*/ignore-invalid-unicode-ext-values > Add tests for other valid/invalid -u- ext values. > > Bug: v8:7481 > Change-Id: I429effd071bb03599a1e767bb2a9e9918a91b850 > Reviewed-on: https://chromium-review.googlesource.com/c/1351307 > Commit-Queue: Frank Tang <ftang@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58173} Bug: v8:7481 Change-Id: I0a1c5701ade330026e2cf7eb554c6390b048a68d Reviewed-on: https://chromium-review.googlesource.com/c/1396737Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#58604}
-
- 03 Jan, 2019 1 commit
-
-
Frank Tang authored
This reverts commit 8d094249. Reason for revert: Cause Memory regression TBR=gsathya@chromium.org Original change's description: > [Intl] Validate u extension type > > Fix intl402/*/ignore-invalid-unicode-ext-values > Add tests for other valid/invalid -u- ext values. > > Bug: v8:7481 > Change-Id: I429effd071bb03599a1e767bb2a9e9918a91b850 > Reviewed-on: https://chromium-review.googlesource.com/c/1351307 > Commit-Queue: Frank Tang <ftang@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58173} TBR=cira@chromium.org,jshin@chromium.org,gsathya@chromium.org,ftang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7481 Change-Id: Idabf2183684f264271ebe2b8c0ca10ae8e30d811 Reviewed-on: https://chromium-review.googlesource.com/c/1393499Reviewed-by:
Frank Tang <ftang@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#58506}
-
- 14 Dec, 2018 1 commit
-
-
Frank Tang authored
Bug: v8:7482 Change-Id: Icd3383e350555907c01ec65d2620477973117ea3 Reviewed-on: https://chromium-review.googlesource.com/c/1368864Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#58258}
-
- 12 Dec, 2018 1 commit
-
-
Frank Tang authored
Fix intl402/*/ignore-invalid-unicode-ext-values Add tests for other valid/invalid -u- ext values. Bug: v8:7481 Change-Id: I429effd071bb03599a1e767bb2a9e9918a91b850 Reviewed-on: https://chromium-review.googlesource.com/c/1351307 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#58173}
-
- 07 Dec, 2018 1 commit
-
-
Frank Tang authored
Simplified test for default locale under test/intl Remove GetDefaultLocale from runtime Move Intl::DefaultLocale from intl-object.h to internal function inside intl-object.cc Bug: v8:5751 Change-Id: I885abf30ff33d5213ee99c07ac1e92d3c5065d8b Reviewed-on: https://chromium-review.googlesource.com/c/1358022Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#58081}
-
- 01 Nov, 2018 1 commit
-
-
Frank Tang authored
To fix the to-be-landed-soon test262 test failure in test262/intl402/DateTimeFormat/prototype/resolvedOptions/order The spec change from "any order" to "table " order in https://github.com/tc39/ecma402/pull/279 Change the order of creating each property Move the code inside SetPropertyFromPattern into ResolvedOptions so we can easily follow the spec. Bug: v8:8379 Change-Id: Ibe9ea72a2557474fd81a9f350fffa298f4b7738f Reviewed-on: https://chromium-review.googlesource.com/c/1302803Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#57200}
-
- 26 Sep, 2018 1 commit
-
-
Frank Tang authored
Bug: v8:8066 Change-Id: I931de0472941fca8f68739a05fa38dee308d59f4 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng;luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1212467Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#56227}
-
- 14 Sep, 2018 1 commit
-
-
PhistucK authored
Previously, DateTimeFormat.prototype.formatToParts returned an object with the property key 'dayperiod' which is incorrect as per the spec. This patch updates the property key to say 'dayPeriod', making this spec compliant. R=cira@chromium.org Bug: chromium:865351 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I37f50797387bc69d5e29d7c2911bc5cc0fad37ac Reviewed-on: https://chromium-review.googlesource.com/1145304Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: PhistucK <phistuck@gmail.com> Cr-Commit-Position: refs/heads/master@{#55922}
-
- 13 Sep, 2018 1 commit
-
-
Adam Klein authored
Also fix type-check to check receiver for JSReceiver, not JSObject, and add a test for DateTimeFormat verifying that it already has the proper behavior. Bug: chromium:881023 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I950c86094dfb9634e0b7e49bcbbb022fa81a71f7 Reviewed-on: https://chromium-review.googlesource.com/1225612 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#55880}
-
- 04 Sep, 2018 1 commit
-
-
Frank Tang authored
Bug: v8:8066 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng;luci.chromium.try:linux_chromium_rel_ng Change-Id: I74fe09bb6bb4428d57c66811b77f5f35144f717f Reviewed-on: https://chromium-review.googlesource.com/1186153 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#55625}
-
- 30 Aug, 2018 1 commit
-
-
Frank Tang authored
Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I9adf2b15b76e26e6e59a7732da714da7d44daf69 Reviewed-on: https://chromium-review.googlesource.com/1195071Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#55510}
-
- 02 Aug, 2018 1 commit
-
-
Jungshik Shin authored
Etc/GMT* time zones are listed in the INAN time zone database and they should be accepted as valid. This CL will be followed by a CL for moving time zone name checks to C++ that will accept all the time zone names (e.g. EST5EDT, Hongkong, ROK, Zulu). Bug: chromium:364374 Test: intl/date-format/timezone.js Test: mjsunit/regress/regress-crbug-364374 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: If0e5327d7e980504a9cb3d2b641e907ebce61180 Reviewed-on: https://chromium-review.googlesource.com/1159546 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#54879}
-
- 25 Apr, 2018 1 commit
-
-
Jungshik Shin authored
https://github.com/tc39/ecma402/pull/194 requires that TimeClip be called before formatting in Intl.DateTimeFormat. Bug: v8:7471 Test: test262/intl402/DateTimeFormat/prototype/format/time-clip* Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Iad80376ae7598aab3e4df84a6cbbcd8691e16e09 Reviewed-on: https://chromium-review.googlesource.com/1027442Reviewed-by:
Daniel Ehrenberg <littledan@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#52796}
-
- 21 Apr, 2018 1 commit
-
-
Timothy Gu authored
With certain ICU data bundles (such as the Node.js "small-icu"), %GetDefaultICULocale() may return a more specific language tag (e.g. "en-US") than what's available (e.g. "en"). In those cases, consider the more specific language tag supported. This CL also resolves the following Node.js issue: https://github.com/nodejs/node/issues/15223 Bug: v8:7024 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ifda0776b3418734d5caa8af4e50c17cda95add73 Reviewed-on: https://chromium-review.googlesource.com/668350 Commit-Queue: Daniel Ehrenberg <littledan@chromium.org> Reviewed-by:
Daniel Ehrenberg <littledan@chromium.org> Cr-Commit-Position: refs/heads/master@{#52716}
-
- 12 Apr, 2018 1 commit
-
-
Jungshik Shin authored
This is to fix an assertion failure in formatToParts when Chinese calendar is specified with 'u-ca-chinese'. See https://github.com/tc39/ecma402/issues/225 . This CL is a temporary work-around to get v8 match the spec in terms of the external behavior, but it's not taking the steps in the spec, yet. Moreover, the spec may have to be revised as to how to pick the best match pattern when the default calendar for a locale is different from the calendar specified via 'u-ca'. How to handle 'related year' part also needs to be specified. Bug: chromium:826549 Test: intl/date-format/format-with-extensions Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I1f9a2467e86e71e024bc9babe18f16e49746008e Reviewed-on: https://chromium-review.googlesource.com/1006915Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#52556}
-
- 27 Jan, 2018 1 commit
-
-
Jungshik Shin authored
Bug: chromium:801602 Test: intl/date-format/month-far-future.js Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ie2279680e8879c943cbf0873a933d2633e759212 Reviewed-on: https://chromium-review.googlesource.com/868376Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#50914}
-
- 19 Oct, 2017 1 commit
-
-
Jungshik Shin authored
intl.js throws an exception when datetime-value to format is Infinity or NaN, but there was a way to thwart the check. Moreover, intl.js and runtime-intl.cc have unnecessary conversions of 'Number->Date->Number'. I removed the unnecessary conversion and made 'Number' be passed to %InternalDateFormat. With this streamlining, the work-around mentioned above does not work anymore. Add a check in runtime_intl.cc for Infinity/NaN and throw a RangeError. Add invalid-time test for invalid datetime-values passed to Intl.DateTimeFormat.format(). Bug: chromium:774833 Test: intl/date-format/invalid-time.js Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: Idc575e532a86ee110dc4bb945ae023d6516650ee Reviewed-on: https://chromium-review.googlesource.com/724860 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#48765}
-
- 12 Jul, 2017 1 commit
-
-
Daniel Ehrenberg authored
In certain timezones, being at noon UTC doesn't guarantee that you'll be the same day in local time. This patch fixes that false assumption. Thanks to Holmes He for reporting the issue. Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: I7432c0eb1e13fdf11c665e59dabaebeb79bff8c8 Reviewed-on: https://chromium-review.googlesource.com/568021Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Daniel Ehrenberg <littledan@chromium.org> Cr-Commit-Position: refs/heads/master@{#46584}
-