1. 28 Jan, 2019 1 commit
  2. 10 Jan, 2019 1 commit
  3. 26 Dec, 2018 1 commit
  4. 17 Dec, 2018 1 commit
  5. 17 Apr, 2018 1 commit
  6. 14 Apr, 2018 1 commit
    • Jakob Kummerow's avatar
      [ubsan] Change Address typedef to uintptr_t · 2459046c
      Jakob Kummerow authored
      The "Address" type is V8's general-purpose type for manipulating memory
      addresses. Per the C++ spec, pointer arithmetic and pointer comparisons
      are undefined behavior except within the same array; since we generally
      don't operate within a C++ array, our general-purpose type shouldn't be
      a pointer type.
      
      Bug: v8:3770
      Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
      Change-Id: Ib96016c24a0f18bcdba916dabd83e3f24a1b5779
      Reviewed-on: https://chromium-review.googlesource.com/988657
      Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
      Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#52601}
      2459046c
  7. 05 Feb, 2018 1 commit
  8. 09 Jan, 2018 1 commit
  9. 26 Sep, 2017 1 commit
  10. 03 Aug, 2017 1 commit
  11. 02 Aug, 2017 1 commit
  12. 13 Jul, 2017 1 commit
  13. 10 Jul, 2017 1 commit
  14. 17 Jan, 2017 1 commit
  15. 16 Jan, 2017 1 commit
  16. 19 Dec, 2016 1 commit
  17. 08 Dec, 2016 1 commit
  18. 08 Aug, 2016 1 commit
  19. 21 Jul, 2016 1 commit
    • rmcilroy's avatar
      [Interpreter] Avoid accessing on-heap literal in VisitLiteral. · 6b5949a8
      rmcilroy authored
      Move VisitLiteral to decide what type of literal is being emitted by
      checking the raw ASTValue type, instead of the internalized on-heap
      value. This is required for concurrent bytecode generation.
      
      As part of this change, the NUMBER AstValue constructor is modified to
      try to convert numbers without a dot to SMIs where possible. This is to
      maintain the behavior in NewNumber where such numbers are internalized as
      SMIs, and ensures that we still emit LdaSmi bytecodes for these values
      in the generated bytecode.
      
      BUG=v8:5203
      
      Review-Url: https://codereview.chromium.org/2152853002
      Cr-Commit-Position: refs/heads/master@{#37931}
      6b5949a8
  20. 29 Jun, 2016 1 commit
  21. 06 Feb, 2016 1 commit
    • ishell's avatar
      [api] Make ObjectTemplate::SetNativeDataProperty() work even if the... · da213b6e
      ishell authored
      [api] Make ObjectTemplate::SetNativeDataProperty() work even if the ObjectTemplate does not have a constructor.
      
      Previously ObjectTemplate::New() logic relied on the fact that all the accessor properties are already installed in the initial map of the function object of the constructor FunctionTemplate.
      When the FunctionTemplate were instantiated the accessors of the instance templates from the whole inheritance chain were accumulated and added to the initial map.
      ObjectTemplate::SetSetAccessor() used to explicitly ensure that the ObjectTemplate has a constructor and therefore an initial map to add all accessors to.
      
      The new approach is to add all the accessors and data properties to the object exactly when the ObjectTemplate is instantiated. In order to keep it fast we now cache the object boilerplates in the Isolate::template_instantiations_cache (the former function_cache), so the object creation turns to be a deep copying of the boilerplate object.
      
      BUG=chromium:579009
      LOG=Y
      
      Committed: https://crrev.com/6a118774244d087b5979e9291d628a994f21d59d
      Cr-Commit-Position: refs/heads/master@{#33674}
      
      Review URL: https://codereview.chromium.org/1642223003
      
      Cr-Commit-Position: refs/heads/master@{#33798}
      da213b6e
  22. 03 Feb, 2016 1 commit
    • hablich's avatar
      Revert of [api] Make ObjectTemplate::SetNativeDataProperty() work even if the... · db47a31f
      hablich authored
      Revert of [api] Make ObjectTemplate::SetNativeDataProperty() work even if the ObjectTemplate does not have a … (patchset #3 id:80001 of https://codereview.chromium.org/1642223003/ )
      
      Reason for revert:
      Fails a lot of layout tests and blocks the roll. Can be easily reproduced with a local Chromium checkout.
      
      Reference: https://codereview.chromium.org/1652413003/
      
      Original issue's description:
      > [api] Make ObjectTemplate::SetNativeDataProperty() work even if the ObjectTemplate does not have a constructor.
      >
      > Previously ObjectTemplate::New() logic relied on the fact that all the accessor properties are already installed in the initial map of the function object of the constructor FunctionTemplate.
      > When the FunctionTemplate were instantiated the accessors of the instance templates from the whole inheritance chain were accumulated and added to the initial map.
      > ObjectTemplate::SetSetAccessor() used to explicitly ensure that the ObjectTemplate has a constructor and therefore an initial map to add all accessors to.
      >
      > The new approach is to add all the accessors and data properties to the object exactly when the ObjectTemplate is instantiated. In order to keep it fast we now cache the object boilerplates in the Isolate::template_instantiations_cache (the former function_cache), so the object creation turns to be a deep copying of the boilerplate object.
      >
      > This CL also prohibits non-primitive properties in ObjectTemplate to avoid potential cross-context leaks.
      >
      > BUG=chromium:579009
      > LOG=Y
      >
      > Committed: https://crrev.com/6a118774244d087b5979e9291d628a994f21d59d
      > Cr-Commit-Position: refs/heads/master@{#33674}
      
      TBR=verwaest@chromium.org,ishell@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=chromium:579009
      
      Review URL: https://codereview.chromium.org/1660263003
      
      Cr-Commit-Position: refs/heads/master@{#33698}
      db47a31f
  23. 02 Feb, 2016 1 commit
    • ishell's avatar
      [api] Make ObjectTemplate::SetNativeDataProperty() work even if the... · 6a118774
      ishell authored
      [api] Make ObjectTemplate::SetNativeDataProperty() work even if the ObjectTemplate does not have a constructor.
      
      Previously ObjectTemplate::New() logic relied on the fact that all the accessor properties are already installed in the initial map of the function object of the constructor FunctionTemplate.
      When the FunctionTemplate were instantiated the accessors of the instance templates from the whole inheritance chain were accumulated and added to the initial map.
      ObjectTemplate::SetSetAccessor() used to explicitly ensure that the ObjectTemplate has a constructor and therefore an initial map to add all accessors to.
      
      The new approach is to add all the accessors and data properties to the object exactly when the ObjectTemplate is instantiated. In order to keep it fast we now cache the object boilerplates in the Isolate::template_instantiations_cache (the former function_cache), so the object creation turns to be a deep copying of the boilerplate object.
      
      This CL also prohibits non-primitive properties in ObjectTemplate to avoid potential cross-context leaks.
      
      BUG=chromium:579009
      LOG=Y
      
      Review URL: https://codereview.chromium.org/1642223003
      
      Cr-Commit-Position: refs/heads/master@{#33674}
      6a118774
  24. 10 Dec, 2015 1 commit
  25. 26 Nov, 2015 1 commit
  26. 15 Oct, 2015 1 commit
  27. 30 Sep, 2015 1 commit
  28. 20 Aug, 2015 1 commit
    • mstarzinger's avatar
      Separate UnicodeCache out into an own file. · 4e39437a
      mstarzinger authored
      This make inclusion of unicode-inl.h in object.h absolete. Now most
      compilation units don't require that header. It also breaks a cycle
      within declarations of the scanner.h header.
      
      This tries to remove includes of "-inl.h" headers from normal ".h"
      headers, thereby reducing the chance of any cyclic dependencies and
      decreasing the average size of our compilation units.
      
      Note that this change still leaves 3 violations of that rule in the
      code, checked with the "tools/check-inline-includes.sh" tool.
      
      R=yangguo@chromium.org
      
      Review URL: https://codereview.chromium.org/1287893006
      
      Cr-Commit-Position: refs/heads/master@{#30268}
      4e39437a
  29. 13 Aug, 2015 2 commits
  30. 20 Dec, 2014 1 commit
  31. 19 Dec, 2014 1 commit
  32. 22 Sep, 2014 1 commit
  33. 08 Sep, 2014 1 commit
  34. 02 Sep, 2014 1 commit
  35. 04 Aug, 2014 1 commit
  36. 30 Jun, 2014 1 commit
  37. 20 Jun, 2014 1 commit
  38. 03 Jun, 2014 1 commit
  39. 27 May, 2014 1 commit