- 21 Mar, 2018 16 commits
-
-
Hannes Payer authored
Change-Id: If8678bd244a0a4e21b1967c15da80e49643a33ea Reviewed-on: https://chromium-review.googlesource.com/973001Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#52101}
-
jgruber authored
ppc is still failing: https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20ppc64%20-%20sim/builds/10180 TBR=yangguo@chromium.org No-Try: true No-Presubmit: true Bug: v8:6666, v8:7571 Change-Id: I99ddc97543b374014587970310ac5172ed514892 Reviewed-on: https://chromium-review.googlesource.com/973005 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#52100}
-
Andreas Haas authored
The multi-return tests and fuzzer used a custom call descriptor which was based on the default RegisterConfiguration. This meant that for the tests, all available registers could be used to pass parameters and to return values. This caused a problem, because in some cases we need a scratch register in the frame deconstruction. With this CL I change both the tests and the fuzzer to use the WebAssembly call descriptor. Thereby we only use 2 registers for returns, and one of the other registers can be used as scratch register. WebAssembly is the only use case at the moment which wants to return values not only through registers but also over the stack. Therefore I think it's acceptable to only test the WebAssembly usecase. R=mstarzinger@chromium.org Bug: chromium:813288 Change-Id: I31bed757af5f3e8589d2b3dfb6f0112ddecd1a20 Reviewed-on: https://chromium-review.googlesource.com/970656Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#52099}
-
Clemens Hammacher authored
Liftoff does not need to reference its own code object, so don't allocate a handle for that purpose. This also allows to create LiftoffAssembler instances in background tasks where no handle scope is available. R=ahaas@chromium.org Bug: v8:6600 Change-Id: I2911aebd14aaa8450456cb8eea16cea547e0b671 Reviewed-on: https://chromium-review.googlesource.com/972081Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#52098}
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true No-Presubmit: true Bug: chromium:810393 Change-Id: If783fc2d3edcfda6bf5d460de7216a974b28744d Reviewed-on: https://chromium-review.googlesource.com/968482 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#52097}
-
Marja Hölttä authored
BUG=v8:7308 Change-Id: Ibbb224cc6be69f769158b3c1ea3411ceec8301a9 Reviewed-on: https://chromium-review.googlesource.com/968923Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#52096}
-
Marja Hölttä authored
BUG=chromium:813630 Change-Id: I9eeaeb8830533c178c8073f48f036f9af8887a55 Reviewed-on: https://chromium-review.googlesource.com/972901Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#52095}
-
jgruber authored
Continuations are called directly from the deoptimizer, and thus cannot be lazy. This also changes the corresponding assertion to an unconditional CHECK in order to catch this type of mistake early. Drive-by: Sort Builtins::IsLazy. Bug: chromium:823292 Change-Id: I739429ef574e40d7b9ba40cd209175054eb73349 Reviewed-on: https://chromium-review.googlesource.com/972282Reviewed-by:
-
Marja Hölttä authored
Exposing it inside Internals was a hack. The downside of this CL is that heap object tagging is in two places now (v8.h and globals.h). BUG=v8:7308 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ic7115ab20d67109dd2b62c772d52eeb84fa7d9f7 Reviewed-on: https://chromium-review.googlesource.com/968423Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#52093}
-
jgruber authored
Embedded builtins are now based off the v8_enable_embedded_builtins gn flag instead, which conditionally defines V8_EMBEDDED_BUILTINS. Bug: v8:6666 Change-Id: I44d40d30fce3a3ed9bbf973d46c4990ba3fade40 Reviewed-on: https://chromium-review.googlesource.com/964361 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52092}
-
jgruber authored
On {mips,mips64,ppc,s390}, target addresses are specially coded into the instruction stream, i.e. split between a series of instructions. This adds support for that case, similar to what happens with runtime external references. Bug: v8:6666,v8:7571 Change-Id: Ie6f62bc0ca3183f005d8380f6f8b908fa12ea62b Reviewed-on: https://chromium-review.googlesource.com/970824 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: -
Junliang Yan authored
Bug: v8:7571 Change-Id: Ifb59192ecefaa0f7968578a3b547b9e1fbe7c7d7 Reviewed-on: https://chromium-review.googlesource.com/971828 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Tom Anderson authored
Following CL [1], it is required to remove the thin_archive config everywhere complete_static_lib is set. [1] https://chromium-review.googlesource.com/c/chromium/src/+/954344 BUG=chromium:801925 R=machenbach Change-Id: Id75e06543545924771820500c53df3d5ee58774b Reviewed-on: https://chromium-review.googlesource.com/972550Reviewed-by:
-
jgruber authored
This is a reland of b105df6d Original change's description: > Fix kArchRootsPointer typo on s390 > > TBR=jarin@chromium.org > > Bug: v8:6666 > Change-Id: I9f4654955f297c54e67b98afb42125b659e35fd3 > Reviewed-on: https://chromium-review.googlesource.com/971042 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52074} TBR=jarin@chromium.org Bug: v8:6666 Change-Id: Iaae31c52f6099bf9007bd196ca9d4bcf8177aaca Reviewed-on: https://chromium-review.googlesource.com/972801Reviewed-by:
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/a7e9a83..d7db4b1 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I4927c9c2c90853b8587ac1f5146bb91b4e745b7d Reviewed-on: https://chromium-review.googlesource.com/972640 Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#52087}
-
jing.bao authored
Change-Id: I53136c1c296b112e9521fa21e85e945267e51059 Reviewed-on: https://chromium-review.googlesource.com/963702Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Aseem Garg <aseemgarg@chromium.org> Commit-Queue: Jing Bao <jing.bao@intel.com> Cr-Commit-Position: refs/heads/master@{#52086}
-
- 20 Mar, 2018 24 commits
-
-
Alexei Filippov authored
BUG=chromium:823874 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1df9347ead62dc84150f5549c29815600609c55b Reviewed-on: https://chromium-review.googlesource.com/972181 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#52085}
-
Corentin Wallez authored
BUG=chromium:815092 Change-Id: Iec8207dddc56bbcc06ffe7755fc3dc7120bc4368 Reviewed-on: https://chromium-review.googlesource.com/971355Reviewed-by:
-
Michael Achenbach authored
This reverts commit 9afde91b. Reason for revert: https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm/builds/6616 Original change's description: > [builtins] Load external references from the external-reference-table > > Off-heap code cannot embed external references. With this CL, we load > from the external reference table (reached through the root pointer) > instead. > > In a follow-up, the table could be stored within the isolate itself, > removing one more level of indirection. > > Bug: v8:6666 > Change-Id: I4c612ad3d4112ec03c3b389f5bfb9cdc3dc8a671 > Reviewed-on: https://chromium-review.googlesource.com/970468 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52073} TBR=yangguo@chromium.org,mstarzinger@chromium.org,jgruber@chromium.org Change-Id: Iecc2a68e54339e153f1d1e882d8972d5c9cff442 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6666 Reviewed-on: https://chromium-review.googlesource.com/971902Reviewed-by:
-
Michael Achenbach authored
This reverts commit b105df6d. Reason for revert: https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm/builds/6616 Original change's description: > Fix kArchRootsPointer typo on s390 > > TBR=jarin@chromium.org > > Bug: v8:6666 > Change-Id: I9f4654955f297c54e67b98afb42125b659e35fd3 > Reviewed-on: https://chromium-review.googlesource.com/971042 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52074} TBR=jarin@chromium.org,jgruber@chromium.org Change-Id: Ibff56d207b12a0664e6ed66e5f6f4c725206e526 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6666 Reviewed-on: https://chromium-review.googlesource.com/971901Reviewed-by:
-
Eric Holk authored
The new API supersedes the old `RegisterDefaultSignalHandler` and flag combination. Now the embedder must explicitly call `EnableWebAssemblyTrapHandler` to activate the trap handler and optionally install the default signal handler. The old flag is now used only by D8 to decide whether to call this function. Bug: v8:5277 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I05fbb2138138bfc95b14361aabd712db84789b4a Reviewed-on: https://chromium-review.googlesource.com/963179 Commit-Queue: Eric Holk <eholk@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#52081}
-
Eric Holk authored
This moves the Wasm-specific metadata from being fields on the ArrayBuffer into a table managed by WasmMemoryTracker. Bug: chromium:776273 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Id8b050bfdfe0fbe9436fb055e92c08d503d3c2ba Reviewed-on: https://chromium-review.googlesource.com/850550 Commit-Queue: Eric Holk <eholk@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#52080}
-
Kim-Anh Tran authored
Previously a step-dependent reference was captured, which would not exist anymore as soon as we change steps in async compilation. This fix makes sure that we capture the pointer by copy, not by reference. Change-Id: I7ff7e87b67b2fd379e6642d844a4c770cadf1f6c Reviewed-on: https://chromium-review.googlesource.com/970964Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@google.com> Cr-Commit-Position: refs/heads/master@{#52079}
-
Eric Holk authored
This was a bug found while working on https://crrev.com/c/850550 Change-Id: I92b04d1814e75f0a1817f8409496612a3597cd20 Reviewed-on: https://chromium-review.googlesource.com/966997 Commit-Queue: Eric Holk <eholk@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Avoid loading to a general purpose register if the bit pattern consists of a consecutive block of 1 bits. Drive-by: Change a parameter from int8_t to byte such that the AVX_OP macro works on these methods. R=mstarzinger@chromium.org Change-Id: Ib469ddd29d92ddeabe98460d2951b01159a6548a Reviewed-on: https://chromium-review.googlesource.com/969123 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
If FLAG_enable_embedded_constant_pool is false, the field for the builtin index would alias the field for the constant pool offset in the code object. This makes constant_pool() return the builtin index, but it also makes set_constant_pool() override the builtin index (and vice versa). This CL fixes this by making all constant_pool accessors honor that flag. R=mstarzinger@chromium.org Change-Id: I88803a4f28bd5a2fe85a310708c7a365cc457339 Reviewed-on: https://chromium-review.googlesource.com/970586Reviewed-by:
-
Igor Sheludko authored
Bug: v8:7206, chromium:576312 Change-Id: I1628e7966a40fa7d6f628bd972b0ad0142a5d349 Reviewed-on: https://chromium-review.googlesource.com/970825Reviewed-by:
Mythri Alle <mythria@google.com> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#52075}
-
jgruber authored
TBR=jarin@chromium.org Bug: v8:6666 Change-Id: I9f4654955f297c54e67b98afb42125b659e35fd3 Reviewed-on: https://chromium-review.googlesource.com/971042Reviewed-by:
-
jgruber authored
Off-heap code cannot embed external references. With this CL, we load from the external reference table (reached through the root pointer) instead. In a follow-up, the table could be stored within the isolate itself, removing one more level of indirection. Bug: v8:6666 Change-Id: I4c612ad3d4112ec03c3b389f5bfb9cdc3dc8a671 Reviewed-on: https://chromium-review.googlesource.com/970468 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Peter Marshall authored
Part of ongoing work to remove the construct_stub field of the SFI. Generate_InternalArrayConstructor was actually incorrect for packed internal arrays, where it would instead create a regular internal array because it loaded the constructor function from the context every time. Ultimately InternalArray should be removed, or the constructor ported to CSA in the meantime. But for now, it is off the critical path for the construct_stub removal. Also fix a bug: Runtime_NewArray expects a type_info parameter, which should be in rbx (on x64). Because we now go through JSBuiltinsConstructStubHelper first, rbx is loaded with a value that doesn't look like a heap object, which causes a crash in NewArray. Fix that by first loading undefined explicitly (which is what the ArrayConstructor builtin does already). Bug: v8:7503 Change-Id: Ic92fa8864b0af2d32200eb0176ba55ccff03b114 Reviewed-on: https://chromium-review.googlesource.com/970823 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Vasili Skurydzin authored
src/base/debug/stack_trace_posix.cc: suppressed unused function warnings for functions DemangleSymbols, OutputPointer(in order to compile with -Werror flag) test/cctest/test-isolate-independent-builtins.cc: corrections to make ByteInText test case compatible with aix. (affects aix only) Change-Id: I49e45e63545404c77aaed3f51b26557f6f03455e Reviewed-on: https://chromium-review.googlesource.com/927484Reviewed-by:
-
Camillo Bruni authored
We currently never shrink the StringTable which causes excessive memory usage on certain websites. This CL tries to mitigate this by shrinking the StringTable if it is very empty (nof_elements * 16 < capacity) hopefully avoiding costly reallocations. Bug: chromium:818642, v8:5443 Change-Id: I4e6a95b3a6992b499fa6dd59ae159c51f089965a Reviewed-on: https://chromium-review.googlesource.com/970465Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
jgruber authored
Loading external references from off-heap builtins will be root-pointer-relative. At least initially, these loads will happen in CSA and thus need access to the root pointer value. Bug: v8:6666 Change-Id: Iae4c89061df442f5afd03f93e5ba35c4e125b850 Reviewed-on: https://chromium-review.googlesource.com/970264Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#52069}
-
Yang Guo authored
Win64 MSVC build seems to be fixed. Bug: v8:178 Change-Id: I6d3ec22511a7a3c25467c486d3d05df0939c7c87 Reviewed-on: https://chromium-review.googlesource.com/970469 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
The embedders should use the EmbedderGraph API. The similar structure can be created with the following steps: 1) Create a root node for each retainer info group. 2) Iterate all handles using Isolate::VisitHandlesWithClassIds. 3) Add an edge from the retainer info node to the v8 wrapper node. 4) Add an edge from the v8 wrapper node to the retainer info node. See how HeapSnapshotRetainedObjectInfo is converted to the new API. Bug: chromium:749490 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I124ae3853354863b4f888e6aa2ea13777dcaa37d Reviewed-on: https://chromium-review.googlesource.com/948842 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Leszek Swirski authored
This reverts commit 520b025f. Reason for revert: Breaks internal-snapshot build: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20internal%20snapshot/builds/14603 Original change's description: > Remove SFI code field > > Remove the SharedFunctionInfo code field, inferring the code object > from the function_data field instead. In some cases, the function_data > field can now hold a Code object (e.g. some WASM cases). > > Bug: chromium:783853 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng > Change-Id: I1219a4d6aa5abaa9fee54dda883da7a3186e347a > Reviewed-on: https://chromium-review.googlesource.com/952452 > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52064} TBR=yangguo@chromium.org,mstarzinger@chromium.org,jgruber@chromium.org,leszeks@chromium.org,bmeurer@chromium.org,verwaest@chromium.org Change-Id: Iaf464ed29ba4317bbbb255c1aec76fb65cddba84 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:783853 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/970647Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#52066}
-
sreten.kovacevic authored
Port CallIndirect and CallRuntime methods. Also, implement methods for allocation and deallocation of stack slots, which are used in trace memory operations. Bug: v8:6600 Change-Id: I99e0115dcf6d971229892b27b4b4f01d0c5441e8 Reviewed-on: https://chromium-review.googlesource.com/970262 Commit-Queue: Sreten Kovacevic <sreten.kovacevic@mips.com> Reviewed-by:
Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Cr-Commit-Position: refs/heads/master@{#52065}
-
Leszek Swirski authored
Remove the SharedFunctionInfo code field, inferring the code object from the function_data field instead. In some cases, the function_data field can now hold a Code object (e.g. some WASM cases). Bug: chromium:783853 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I1219a4d6aa5abaa9fee54dda883da7a3186e347a Reviewed-on: https://chromium-review.googlesource.com/952452Reviewed-by:
-
Clemens Hammacher authored
This adds support for i64.eqz, and all binary comparisons (i64.eq, i64.ne, i64.lt_s, i64.le_s, i64.lt_u, i64.le_u, i64.gt_s, i64.ge_s, i64.gt_u, i64.and i64.ge_u). R=titzer@chromium.org Bug: v8:6600 Change-Id: Ic6c59529b007220698e09d5959394bcfb6590173 Reviewed-on: https://chromium-review.googlesource.com/969125 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Predrag Rudic authored
Embedded builtins cause many failures therefore we'll disable them. Bug: v8:7571 Change-Id: I20fae241b2fab4ed41339de3a469d514e16c3894 Reviewed-on: https://chromium-review.googlesource.com/970542 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
