- 02 Jun, 2020 1 commit
-
-
George Wort authored
Display UsePositions in the intervals in live ranges in turbolizer. Uses are shown as vertical red lines. Bug: v8:7327 Change-Id: Iab8d08989b9113d1b7d393252de5988e8b25b8de Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2224215 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#68102}
-
- 01 Jun, 2020 1 commit
-
-
George Wort authored
Hide the arrow button div for snapping the live range panel when a new file is loaded. Bug: v8:7327 Change-Id: I576444f12a0557cc6716eb0214586b54a042a899 Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2224838Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#68087}
-
- 27 May, 2020 1 commit
-
-
George Wort authored
Display register allocation live ranges alongside sequences in turbolizer. The existing --trace-turbo flag now also outputs the register allocation data as part of the json file alongside the instruction sequence data that is already produced before and after register allocation is performed. This data includes live range intervals for each virtual and fixed register and the state of their assignments. This json data can now be displayed in turbolizer alongside the instruction sequences. The information is presented as a grid, with each grid cell representing a LifeTimePosition of a certain virtual register, determined by the column and row indices respectively. Each LifeTimePosition is shown to be part of an instruction id which itself is shown to be part of a block id. Each interval is shown as a coloured rectangle positioned over the relevant cells, and displaying text to indicate the state of their assignment. The Resizer object has been extended to allow the grid's html panel to be varied in size in the same manner that the left and right panels can be. The size of the grid itself must also be adjusted whenever the div container changes size. The RangeView class is introduced and is created and held by the single SequenceView object used to display the InstructionSequence data before and after register allocation. A checkbox allows the user to show/hide the range view, this is disabled when register allocation data is not provided or more than 249 instructions are in the sequence. The latter being required due to the css grid-row-col limit of 1000 alond with helping alleviate performance issues. The SequenceView object tracks the phase index currently selected as well as whether or not it is currently being shown. This ensures that the RangeView is not hidden and shown when switching between before and after register allocation, allowing for a smoother transition between the two. The scroll position is also saved and restored for convenience. The data about the instruction sequence required for the display is held by the RangeView object and reset whenever a new instruction sequence is shown. The grid div must sync its scroll with the headers and row labels so as to ensure a consistent view. The register allocation data is extracted from the json, with each register row showing all intervals within the relevant ranges. When the view is switched between before and after register allocation, the relevant intervals are swapped in. Bug: v8:7327 Notry: true Change-Id: I183535a2410a7d663382f387199885250fb98691 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2184232Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#68019}
-
- 14 May, 2020 1 commit
-
-
Santiago Aboy Solanes authored
Basically, remove 'Turbolizer is currently migrating to TypeScript.' Bug: v8:7327 Change-Id: I83df1b4cf568e17c2e9393865702e5bb722a8b95 Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2199353Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#67794}
-
- 04 Dec, 2019 1 commit
-
-
Santiago Aboy Solanes authored
Bug: v8:7327 Change-Id: I0baece9baa3147c9cf0b555879b0cbb138f5e871 Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940158 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#65334}
-
- 26 Nov, 2019 1 commit
-
-
Santiago Aboy Solanes authored
... after executing their action. This allows to search for a regex, click "hide unselected nodes", and then immediately using graph view's keyboard shortcuts (e.g i, o, r). Bug: v8:7327 Change-Id: Ieb7dbb3f1e32a78131500f8fb8b7805417c60e4e Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1930906Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#65166}
-
- 21 Nov, 2019 1 commit
-
-
Santiago Aboy Solanes authored
Remove sep(Left|Right)Snap as they were never read from Bug: v8:7327 Change-Id: Id09fa0ec606a75d40cc946b354bc1a260f3b68ac Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1928855 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#65100}
-
- 20 Nov, 2019 3 commits
-
-
Santiago Aboy Solanes authored
We now keep the same percentage of the window occupied by the panel when toggling Maximize (both maximizing, or un-maximizing). This also means that it no longer forces the side panels open when toggling maximizing. Also took the opportunity and cleaned up names and resizer.ts. Bug: v8:7327 Change-Id: I60b574a833f3059e447aa17fae8a687d32ac29d5 Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1903970Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#65085}
-
Santiago Aboy Solanes authored
After searching now we are focused on the svg, which allows using the keyboard shortcuts after searching. Bug: v8:7327 Change-Id: I57f5490ecb9858971aefae66b9808460108dc936 Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1925147Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#65084}
-
Santiago Aboy Solanes authored
Source: https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes Bug: v8:7327 Change-Id: I2f91b7dc619d70ae29600ae7f304d9944994c863 Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1925151Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#65083}
-
- 14 Nov, 2019 1 commit
-
-
Santiago Aboy Solanes authored
Allows the use of PageUp and PageDown in sequence and schedule phases. Since graphmultiview had a tabindex of 0, it was sitting on top of sequence and schedule. This blocked the use of PageUp and PageDown to scroll in these phases. Bug: v8:7327 Change-Id: I4fc129cd9d5ea82e469cd4b67c12a455ec920317 Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1914207Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#64947}
-
- 07 Nov, 2019 1 commit
-
-
Santiago Aboy Solanes authored
Bug: v8:7327 Change-Id: I79c55d93b8a9f05b81fcbb1897d946cb56e99370 Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1901270Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#64833}
-
- 04 Nov, 2019 1 commit
-
-
Santiago Aboy Solanes authored
PR wasn't defined correctly and it was causing issues. Added prettify to the npm packages, and removed the (not needed) explicit prettify.css. Bug: v8:7327 Change-Id: Ieb8999d63df6764354dd628516e0ed9270b8a862 Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1893344 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#64726}
-
- 30 Oct, 2019 1 commit
-
-
Santiago Aboy Solanes authored
In the case where we fail on the 'before register allocation' phase, we will have the instructions to print, but turbolizer will fail to show them because it will look for the non-existent offsets. Bug: v8:7327 Change-Id: I52e520dcb662fe9931f1bb29cd2c16cd62913158 Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1889883Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#64650}
-
- 21 Oct, 2019 2 commits
-
-
Santiago Aboy Solanes authored
Before this change, the activeElement used to be the body and not multiview. Then, the EventListener wasn't triggering. Bug: v8:7327 Change-Id: I9782159ffd510c9a7afd83695f20ede9e774ac20 Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1868624 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#64422}
-
Sigurd Schneider authored
Since the resizers (the handles used to resize the panes) were getting bigger when selected, they obscured part of the scrollbar making the scrollbar too hard to select. Also, when they were snapped, the right resizer totally obscured the scrollbar. Bug: v8:7327 Change-Id: I04f3df00181df2265890ef54706091b3bc36f23e Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1869191Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#64421}
-
- 17 Oct, 2019 1 commit
-
-
Santiago Aboy Solanes authored
The top bar was being scrolled down since the whole viewpane was scrollable. It will now work in the way the "Dissasembly" tab works: the content is scrollable, but not the pane. This change makes Schedule and Sequence consistent within the other panels. As a drive-by fix, remove some unused constants. Bug: v8:7327, v8:9517 Notry: true Change-Id: I22f8abb6524cb297f43930fc8036b36b7ce59751 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1863203 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#64347}
-
- 16 Oct, 2019 3 commits
-
-
Santiago Aboy Solanes authored
Mainly updating '@types/d3' Change-Id: Ia3df5f4c29c4bf7cfe167a8b03ab20a2ad532cde Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1863195Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#64327}
-
Santiago Aboy Solanes authored
They have no function and are confusing to first time users, who think that you have to click that to upload a file. It would be better to not add them at all, but the logic searches for 'li.last-tab' and it seems hard to unravel. Bug: v8:7327 Notry: true Change-Id: I07e903947e15ccc0d5431488a4c4fcded999f91d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1863194 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#64325}
-
Santiago Aboy Solanes authored
It's already on the 'Graph view' section and fits better there. Bug: v8:7327 Notry: true Change-Id: Ie7024f1db02c5cf6b451f5f5401fd01195996848 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1863192 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#64319}
-
- 23 Aug, 2019 2 commits
-
-
Sigurd Schneider authored
Change-Id: I9988ea2dfeccbfaa9e0197920703ab430a43acb7 Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1674026 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#63375}
-
Sigurd Schneider authored
Bug: v8:7327 Change-Id: Ia8e5d51b12cc86734523860af88d4c3948e0f0c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660614 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#63371}
-
- 09 Aug, 2019 1 commit
-
-
Santiago Aboy Solanes authored
Bug: v8:9396 Change-Id: Ic5082b91cc61a286bd6a440009bf18202e853339 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1730997Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#63141}
-
- 09 Jul, 2019 1 commit
-
-
Pierre Langlois authored
The info tab says that 'i' reveals outputs and 'o' reveals inputs, it should be the opposite. Bug: v8:7327 Change-Id: I1bf96653129e14ef315a01dc2c7a3083c9caa5bb Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1692929 Commit-Queue: Pierre Langlois <pierre.langlois@arm.com> Auto-Submit: Pierre Langlois <pierre.langlois@arm.com> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#62603}
-
- 26 Jun, 2019 1 commit
-
-
Sigurd Schneider authored
Also show constant for ArchNops that encode assigning from a constant. Change-Id: I84590005dda62ebf445aada57f826f5ffcd5a802 Bug: v8:7327 Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1672943 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#62388}
-
- 07 Jun, 2019 3 commits
-
-
Santiago Aboy Solanes authored
It was hiding the nodes, but never showing them. Therefore it wasn't 'toggling'. Change-Id: I6fe57860f44ba05abac0f1575678a494f9d07ae8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1649557Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#62057}
-
Santiago Aboy Solanes authored
Some of the tooltips had the wrong text on them when hovering over with the mouse. Change-Id: I4d1ba37b0fad276356b76d16710a5dba7dedc6ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1649556Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#62056}
-
Sigurd Schneider authored
Change-Id: Ia7d37e72b16123e98b2f2e4d4e5d614f9b8c8d9e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1649558 Auto-Submit: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by: Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#62053}
-
- 18 Mar, 2019 2 commits
-
-
Pierre Langlois authored
Bug: v8:7327 Change-Id: I2a140cf79d3be83a34401f5e4a8033fd9d89568b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526011 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#60306}
-
Sigurd Schneider authored
Change-Id: I8fee653d2e331c2e796115b4cb88a2138e456177 Bug: v8:7327 Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528730Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Auto-Submit: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#60305}
-
- 28 Feb, 2019 2 commits
-
-
Sigurd Schneider authored
after previous change, which moved icons to .png format and to subdirectory img/. Bug: v8:7327 Notry: true Change-Id: Iebbbe175cc65ed1f2e505084344a2b55864732e7 Reviewed-on: https://chromium-review.googlesource.com/c/1494009 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#59940}
-
Sigurd Schneider authored
Change-Id: I19abd54f3c7825a99cbebd370092259cf8c21945 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1494007Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#59939}
-
- 15 Jan, 2019 3 commits
-
-
Sigurd Schneider authored
Notry: true Bug: v8:7327 Change-Id: I9cdea29db2b409d773a16e3d6c29ef4325257162 Reviewed-on: https://chromium-review.googlesource.com/c/1409437 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58815}
-
Sigurd Schneider authored
This allows to reset the layout to the the inital layout of the graph, which only contains the control nodes. Change-Id: I7ab9fb1615057df99983369cd0fcdd42a68e1924 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1409436 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58814}
-
Sigurd Schneider authored
This enables per-phase toolbox items, which makes the toolbar easier to understand and use. Change-Id: I1b44d28595c118f0ba55dd64eea54415b51b93aa Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1409435Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58813}
-
- 14 Jan, 2019 5 commits
-
-
Sigurd Schneider authored
The URL must not have a leading slash, and the file needs to be included in the deployment script. TBR=neis@chromium.org Change-Id: Idd3fc25c052cb720d4956f630a8ddca7e5d36a1a Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1409432Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58799}
-
Sigurd Schneider authored
This is a first step towards support for opening more than one turbolizer json file at once. Change-Id: Id51ce47c59492ba63de03eceb0163fa1701ea500 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1407057 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58790}
-
Sigurd Schneider authored
..as mentioned in the info tab. Change-Id: I9ddbe1ad7eb3242ad7839650aecc7305a902fb0d Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1407056 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58789}
-
Sigurd Schneider authored
..instead of wrongly keeping the location from the previous view if the selection became empty after attaching it. Change-Id: I606010ad86034c2ec06e00c82143a22ca2d88274 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1407055 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58788}
-
Sigurd Schneider authored
..and display them in the extended node title (on hover). Notry: true Bug: v8:7327 Change-Id: Ic9cd6207269686edb42ecf1bee8f7ef7b6caa035 Reviewed-on: https://chromium-review.googlesource.com/c/1407054 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58783}
-