- 11 Sep, 2018 3 commits
-
-
Frank Tang authored
The ICU API for maximizing and minimizing a locale ID takes ICU format locale id as an input so that a BCP 47 language tag must be converted to the corresponding ICU locale id. Bug: v8:7982 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I1cb1dacbf057bbc8bb8beb9b62d1ec4becd82624 Reviewed-on: https://chromium-review.googlesource.com/1150934Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#55768}
-
jgruber authored
In many cases, the condition already explains the assertion and a string message clutters the code without adding value. This wrapper macro is actually very useful in such cases. Change-Id: I44f27c1c9255f5fc80453c92565f07f8f3cbacae Reviewed-on: https://chromium-review.googlesource.com/1216183Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#55767}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/0e1589b..b34c179 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/c869f29..c80faf4 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/25c380c..727453b TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: If839c89bcb13325a129d3c9dd9afced27617f09e Reviewed-on: https://chromium-review.googlesource.com/1217727 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#55766}
-
- 10 Sep, 2018 26 commits
-
-
Ujjwal Sharma authored
This reverts commit dd5ea32a. Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ic902fb239cc4b83563a2d92a2ae2e1569d21f549 Reviewed-on: https://chromium-review.googlesource.com/1217642Reviewed-by:
-
Michael Lippautz authored
Split off from https://chromium-review.googlesource.com/c/v8/v8/+/1196484 Bug: chromium:879045 Change-Id: I58b1a2ad10729f54c9a452dcfecd7511660460f6 Reviewed-on: https://chromium-review.googlesource.com/1216285 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#55764}
-
Igor Sheludko authored
Only read-only pages don't have properly initialized reservation object. Bug: v8:8096 Change-Id: I83f4baa414dc2ca5a397a9897088060b6cac4783 Reviewed-on: https://chromium-review.googlesource.com/1216562Reviewed-by:
-
Georg Neis authored
Such as: - JSArray (length) - Root strings, code objects, oddballs Bug: v8:7790 Change-Id: Ibed83be71b013c090c5a2b6a342c8771ad06916c Reviewed-on: https://chromium-review.googlesource.com/1215224 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#55762}
-
jgruber authored
The motivation behind this change is that the WasmArgumentsAdaptor builtin needed too many registers on ia32 and was blocking work on adding a root register. Bug: v8:6666 Change-Id: I9d39af96e8520acc092f5ef4b7f0a159fe4e3b12 Reviewed-on: https://chromium-review.googlesource.com/1209788 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Igor Sheludko authored
... in order to avoid page allocator filtering when notifying leak sanitizer. Bug: v8:8015 Change-Id: I2a3222030dbbf0c467808d0f397a064c40324189 Reviewed-on: https://chromium-review.googlesource.com/1216182Reviewed-by:
-
jgruber authored
To support all possible cases, we must limit the number of register args for TFS builtins on ia32 to 3. Out of the 6 allocatable registers, esi is taken as the context register and ebx is the root register. One register must remain available to store the jump/call target. Thus 3 registers remain for arguments. The reason this applies to TFS builtins specifically is because this becomes relevant for builtins used as targets of Torque function pointers (which must have a register available to store the target). Bug: v8:6666 Change-Id: I17d9450cc29c983ddaffc2deb36f45c1c414e166 Reviewed-on: https://chromium-review.googlesource.com/1209287 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Simon Zünd authored
This CL adds naming convention errors for: - Variable names - Torque Macro/Builtin names - Parameter names R=tebbi@chromium.org Bug: v8:7793 Change-Id: Icfe20e53524234f0b4534f0102aff6b14121dfbc Reviewed-on: https://chromium-review.googlesource.com/1213184 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#55758}
-
Dan Elphick authored
Previously the builtins table had a value for every single OperandScale/Bytecode combination regardless of whether it was valid. This change makes it so that only valid bytecode handlers are stored in the builtins table. This prevents placeholders being serialized into the snapshot (and embedded into the binary) saving 9KB in CODE_SPACE/OLD_SPACE and 2.5KB in the embedded data as well as 66 entries in the builtins table. To do this, it generates a new header file bytecodes-builtins-list.h which is created from the BYTECODE_LIST and OPERAND_SCALE_LIST macros. Since list macros cannot be used to conditionally generate elements in the C-preprocessor, this is done by generator executable, compiled from interpreter/generate-flat-headers.cc. Additionally the generator creates the flat bytecode list so that it is transposed from the previous result, i.e. the results are grouped by bytecode and then operand scale rather than operand scale then bytecode. This should give better locality for commonly used bytecodes and may allow less commonly used ExtraWide bytecodes to never be mapped into memory at all. The cost to storing the handlers densely is that looking up a handler now requires a binary search through the builtins table, but this should only happen during debugging. It is also fixable at least for non-wide handlers and could be improved for wide ones if the need arises. Bug: v8:8068 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Iaad22a952e2858f508030c5ddc082f91bf59f667 Reviewed-on: https://chromium-review.googlesource.com/1209304 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#55757}
-
Georg Neis authored
- Provide MapData::SerializeDescriptors method for serializing the whole descriptor array. - Trigger this in JSObjectData::SerializeAsBoilerplate. - Further make things more consistent across the broker. Bug: v8:7790 Change-Id: Ie6499da8857f7c6561f7c44922aeffcea4876be7 Reviewed-on: https://chromium-review.googlesource.com/1199102 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Georg Neis authored
- Provide getters for all member variables. - Add missing flags for cycle detection. - Be more consistent in stylistic matters. Bug: v8:7790 Change-Id: I87c3901b203acc4254ec48f5cc895b2e68ff32aa Reviewed-on: https://chromium-review.googlesource.com/1196431 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Sreten Kovacevic authored
Issues that caused failure of this test have been resolved with commit https://chromium-review.googlesource.com/c/v8/v8/+/1213183, so it can be re-enabled. Change-Id: I441998e5e63fce7a7e718b593c8e58a71841b78e Reviewed-on: https://chromium-review.googlesource.com/1215168Reviewed-by:
-
Florian Sattler authored
Bug: v8:8015 Change-Id: I3a3bd587e1f126b533a1eaea1ff9f74c2d0102b0 Reviewed-on: https://chromium-review.googlesource.com/1209847Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55753}
-
Michael Starzinger authored
This new instance type will be used for wrapper objects representing exported exceptions. Currently the objects are empty and only serve as an identity for exported exceptions. Eventually they will also need to reference the signature underlying the exception to perform a signature check upon import. R=clemensh@chromium.org TEST=mjsunit/wasm/exceptions-import BUG=v8:8091 Change-Id: Ifdd561fc000090f4a985aeb45549fd7110849646 Reviewed-on: https://chromium-review.googlesource.com/1215166 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Sreten Kovacevic authored
* Enable Liftoff wasm cctests on BE for mips and mips64 * Fix issues that were introduced with these tests and that are linked with Load/Store instructions * Change endianness on GetGlobal and SetGlobal, as done in TF * Skip I32Binop tests that fail with OOM error and seem to not be related directly to this task Bug: v8:6600 Change-Id: Ib62ca5e3c681326d28e70a5157d8646e0c8d0b51 Reviewed-on: https://chromium-review.googlesource.com/1213183 Commit-Queue: Sreten Kovacevic <skovacevic@wavecomp.com> Reviewed-by:
Ivica Bogosavljevic <ibogosavljevic@wavecomp.com> Reviewed-by:
-
Tobias Tebbi authored
This CL makes sure, that logical operators (||, &&) always have return type never. Together with a check that never is never passed as a function argument, this prevents faulty evaluation as in !(x || y). Before, the logical operators had a behavior similar to (bool labels Taken, NotTaken), with a fast exit if the left-hand side allowed shor-circuit evaluation, but returning the right-hand side otherwise. Since we want to allow existing (a || b || c) patterns in the codebase, this requires weakening the restriction that the left- and right-hand side need to have the same type. Now the possibilites are: bool, never never, bool never, never bool, bool constexpr bool, constexpr bool Bug: v8:8137 Change-Id: I9576b337dc4008ac58b4625e77fef4e73bcdd6e3 Reviewed-on: https://chromium-review.googlesource.com/1215162Reviewed-by:
Daniel Clifford <danno@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#55750}
-
Clemens Hammacher authored
If there are many workers and we are very unlucky, the cmpxchg loop can in fact fail for more than 5 times. This CL removes this unneeded limitation to avoid spurious failures. R=mstarzinger@chromium.org Bug: chromium:824443 Change-Id: I0a6adde1330c8a8389a42b36bf44e516fae8c574 Reviewed-on: https://chromium-review.googlesource.com/1213170Reviewed-by:
-
Clemens Hammacher authored
R=mstarzinger@chromium.org Bug: v8:8015, chromium:824443 Change-Id: I017e8bf9033fba1afdddcc5e3057860519dfc119 Reviewed-on: https://chromium-review.googlesource.com/1213210Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/66badbd..25c380c TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Iaf3e13ec8f9174321c61016c622a046a71ef6335 Reviewed-on: https://chromium-review.googlesource.com/1214867 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Simon Zünd authored
This CL fixes a bug that allowed calls to Array.p.shift on zero-length arrays where the 'length' is read-only without throwing a TypeError. R=bmeurer@chromium.org, jgruber@chromium.org Bug: chromium:882233 Change-Id: Ib129ab4c4f4f233e7bb553effa77539badfbe26e Reviewed-on: https://chromium-review.googlesource.com/1215164Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Simon Zünd <szuend@google.com> Cr-Commit-Position: refs/heads/master@{#55746}
-
Georg Neis authored
It used to call the old IterableToList, which had the wrong semantics for holes. Bug: v8:8133 Change-Id: Idd5acd55a155bc43df7552135a44151bb2db38e9 Reviewed-on: https://chromium-review.googlesource.com/1213204Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#55745}
-
Igor Sheludko authored
Bug: v8:8096 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: If44c1a9a76c517fe329485d385f445b2be9f5ec2 Reviewed-on: https://chromium-review.googlesource.com/1213186Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I7ae9463768969d2821b19fa0d8c8a498d51f6b40 Reviewed-on: https://chromium-review.googlesource.com/1209943Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55743}
-
Stephan Herhut authored
This will replace "<?>" in certain debug output with the empty string. There should be no end-user visible changes, though. Change-Id: I80db2f2169532c600662977025185378004f7cd5 Reviewed-on: https://chromium-review.googlesource.com/1213188 Commit-Queue: Stephan Herhut <herhut@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
Bug: v8:6344, v8:8015 Change-Id: I6d96f039b47980f9df8d06c4097b70012fce3c82 Reviewed-on: https://chromium-review.googlesource.com/1215163Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/f022f91..66badbd Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/a191af9..7ca3ffa TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I06c1f34978d0cbb0a3deb1ae5b5d3b732c289186 Reviewed-on: https://chromium-review.googlesource.com/1215009 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
- 09 Sep, 2018 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/ead23c2..c869f29 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/4d2b901..f022f91 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ib6ed7ffe55424e26cf9189c71edf26a96b010e62 Reviewed-on: https://chromium-review.googlesource.com/1214588 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
- 08 Sep, 2018 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/6533d05..0e1589b Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/bcc3e49..ead23c2 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/dd2c588..4d2b901 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I09c274664aa830bc8ad5892230fdc78f3753d25d Reviewed-on: https://chromium-review.googlesource.com/1214584 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
- 07 Sep, 2018 9 commits
-
-
Frank Tang authored
Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I2642a8a693f9803949bc279892dffdcac0b6144c Reviewed-on: https://chromium-review.googlesource.com/1212465 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Sathya Gunasekaran authored
Makes for a nicer stack trace Bug: v8:5367 Change-Id: I6d77907e08c2c4efc7a1b25016c7e83841c7c574 Reviewed-on: https://chromium-review.googlesource.com/1211444 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Daniel Ehrenberg <littledan@chromium.org> Cr-Commit-Position: refs/heads/master@{#55736}
-
Michael Achenbach authored
NOTRY=true TBR=yangguo@chromium.org Change-Id: Ic5e8ea11035ad77d4a47e600283f83941ca5af43 Reviewed-on: https://chromium-review.googlesource.com/1213213Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#55735}
-
Michael Achenbach authored
The isolates step times out due to some very slow tests. Marking as slow changes the test order and increases throughput. NOTRY=true TBR=yangguo@chromium.org Change-Id: Iaaf6fe93e7f0e17266923d1ab6f0fe7b09abea9e Reviewed-on: https://chromium-review.googlesource.com/1213212Reviewed-by:
-
Mike Stanton authored
An unnecessary call to ToString() on the array index caused trips to the runtime. The fix also includes performance micro-benchmarks so we'll have a harder time regressing this case in future. TBR=tebbi@chromium.org Bug: v8:8112 Change-Id: I781e8b1bbe2eb56db961cf33b0dca8523868b83d Reviewed-on: https://chromium-review.googlesource.com/1213207 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
🎉 Mathias Bynens authoredThis is a reland of 4dac9872 Original change's description: > Ship globalThis
🎉 > > Proposal repository: > https://github.com/tc39/proposal-global > > Intent to ship: > https://groups.google.com/d/msg/v8-users/Vkoh0wXRwaM/Yt7MpzhkAgAJ > > Bug: v8:5537 > Change-Id: I60a6c5375165d89548db12fef454a64137d04c27 > Reviewed-on: https://chromium-review.googlesource.com/1195494 > Reviewed-by: Adam Klein <adamk@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Commit-Queue: Mathias Bynens <mathias@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55543} TBR=adamk@chromium.org,machenbach@chromium.org,gsathya@chromium.org,mathias@chromium.org No-Presubmit: true Bug: v8:5537 Change-Id: I1e20d606bb027d7afca713ffde87e183b6f610bd Reviewed-on: https://chromium-review.googlesource.com/1208633Reviewed-by:Mathias Bynens <mathias@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#55732}
-
Benedikt Meurer authored
For strict equality `a === b` with Symbol feedback we need to check only one side via CheckSymbol, since the resulting comparison can only be true if both sides are symbols. For consistency with the receivers case we check the left side, so CheckSymbol(a). This significantly reduces the number of CheckSymbol operations in optimized code for the ARES-6 Air benchmark. Bug: v8:6344 Change-Id: I50420f8d862fec31214b7e86b17919edcfc1f23e Reviewed-on: https://chromium-review.googlesource.com/1213173 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#55731}
-
Michael Achenbach authored
Seems like most lifeedit tests are not predicable. NOTRY=true TBR=yangguo@chromium.org Bug: v8:8147 Change-Id: Ia0a3871112f5a6f4b5821ee401bfdfd26dd8f9e5 Reviewed-on: https://chromium-review.googlesource.com/1213211Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/test/test262/data: https://chromium.googlesource.com/external/github.com/tc39/test262/+log/86b5efe..f10582e TBR=adamk@chromium.org,gsathya@chromium.org Change-Id: I487211c0d77c74f88fa3b5fda23363cb255cfaa8 Reviewed-on: https://chromium-review.googlesource.com/1213344 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
