- 11 Feb, 2014 14 commits
-
-
marja@chromium.org authored
(Second try, with fixes. First try: https://codereview.chromium.org/149913006/ ) The long-term goal is to move all recursive descent functions from Parser and PreParser into ParserBase, but first they need to be unified. Notes: - The functions moved in this CL: ParseIdentifier, ParseIdentifierName, ParseIdentifierNameOrGetOrSet, ParseIdentifierOrStrictReservedWord. - IOW, this CL removes Parser::ParseIdentifier and PreParser::ParseIdentifier and adds ParserBase::ParseIdentifier, etc. - Error reporting used to require virtual funcs; now error reporting is moved to the Traits too, and ParserBase no longer needs to be virtual. - I had to move PreParser::Identifier out of the PreParser class, because otherwise PreParserTraits cannot use it in a typedef. BUG=v8:3126 LOG=N R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/158913003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19265 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yangguo@chromium.org authored
The stack trace string is an ancient relic that is no longer being used. We use the structured stack trace object instead. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/159013002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19264 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
palfia@homejinni.com authored
Port r19244 (08e0afd9) BUG= R=mvstanton@chromium.org, plind44@gmail.com Review URL: https://codereview.chromium.org/159423003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19263 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
mvstanton@chromium.org authored
Map collection complicates a test that wants to assert on code opt/deopt because of prototype-chain changes. It can happen that a gc occurs in the stack guard at the start of optimized function foo that deopts function foo because of a map being collected and deoptimizing it's dependent code. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/159653002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19258 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
machenbach@chromium.org authored
R=bmeurer@chromium.org TBR=bmeurer@chromium.org Review URL: https://codereview.chromium.org/159633002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19254 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
This assert fails when dumping native counters on x64. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/151033003 Patch from Weiliang Lin <weiliang.lin@intel.com>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19253 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yangguo@chromium.org authored
R=dcarney@chromium.org Review URL: https://codereview.chromium.org/156783004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19252 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yangguo@chromium.org authored
This would help a lot with native Javascript code. R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/156373003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19251 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/152813006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19250 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
Now stores to inobject fields do no longer prevent hoisting and combining of loads from other inobject fields. R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/144423010 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19249 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
This reverts commit r19427 for breaking the build. Will reland with fix. TBR=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/143203005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19248 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
Now stores to inobject fields do no longer prevent hoisting and combining of loads from other inobject fields. R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/144423010 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19247 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
palfia@homejinni.com authored
Port r19244 (08e0afd9) BUG= R=plind44@gmail.com Review URL: https://codereview.chromium.org/159393002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19246 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
haitao.feng@intel.com authored
R=verwaest@chromium.org Review URL: https://codereview.chromium.org/157303002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19245 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Feb, 2014 16 commits
-
-
mvstanton@chromium.org authored
R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/137403009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19244 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
plind44@gmail.com authored
NaN value is different on MIPS and x86 architectures, and TEST(NaNx) tests checks the case where a x86 NaN value is serialized into the snapshot on the simulator during cross compilation. BUG= R=plind44@gmail.com Review URL: https://codereview.chromium.org/144473008 Patch from Balazs Kilvady <kilvadyb@homejinni.com>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19241 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
marja@chromium.org authored
This reverts commit r19230. Reason: Build failures on NaCl. BUG= TBR=marja@chromium.org,mstarzinger@chromium.org Review URL: https://codereview.chromium.org/158873006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19234 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
plind44@gmail.com authored
MIPS: Fix r19175 "Avoid embedding x86 NaN constant in MacroAssembler code when snapshot is created." BUG= R=plind44@gmail.com Review URL: https://codereview.chromium.org/148523015 Patch from Balazs Kilvady <kilvadyb@homejinni.com>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19232 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
marja@chromium.org authored
The long-term goal is to move all recursive descent functions from Parser and PreParser into ParserBase, but first they need to be unified. Notes: - The functions moved in this CL: ParseIdentifier, ParseIdentifierName, ParseIdentifierNameOrGetOrSet, ParseIdentifierOrStrictReservedWord. - IOW, this CL removes Parser::ParseIdentifier and PreParser::ParseIdentifier and adds ParserBase::ParseIdentifier, etc. - Error reporting used to require virtual funcs; now error reporting is moved to the Traits too, and ParserBase no longer needs to be virtual. - I had to move PreParser::Identifier out of the PreParser class, because otherwise PreParserTraits cannot use it in a typedef. BUG=v8:3126 LOG=N R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/149913006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19230 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
ishell@chromium.org authored
Reland of r19102: Check elimination improvement: propagation of state through phis is supported, CheckMap narrowing implemented with tests. R=verwaest@chromium.org Review URL: https://codereview.chromium.org/146623006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19229 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
verwaest@chromium.org authored
R=ishell@chromium.org Review URL: https://codereview.chromium.org/146623007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19228 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
ulan@chromium.org authored
BUG=v8:3143 LOG=N R=verwaest@chromium.org Review URL: https://codereview.chromium.org/144473005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19226 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
machenbach@chromium.org authored
If not specified, depot tools tend to ask for an email on the command line once in a while, which makes the automated script hang. BUG= R=ulan@chromium.org Review URL: https://codereview.chromium.org/158733002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19223 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yangguo@chromium.org authored
This relands r19196 with fixes. BUG=v8:3109 LOG=Y R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/141323007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19222 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
verwaest@chromium.org authored
BUG= R=ishell@chromium.org Review URL: https://codereview.chromium.org/137883008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19221 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
mstarzinger@chromium.org authored
Some of the third-party test cases in the mjsunit test suite were originally taken from WebKit and are now fully covered by the equally named test suite. Mapping of test cases: - array-isarray.js -> test/webkit/Array-isArray.js - array-splice-webkit.js -> test/webkit/array-splice.js R=machenbach@chromium.org BUG= Review URL: https://codereview.chromium.org/158803002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19220 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
verwaest@chromium.org authored
R=dcarney@chromium.org Review URL: https://codereview.chromium.org/155513008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19219 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
machenbach@chromium.org authored
R=bmeurer@chromium.org TBR=bmeurer@chromium.org Review URL: https://codereview.chromium.org/135973011 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19214 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/135503004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19213 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
marja@chromium.org authored
Notes: - This makes Parser and PreParser produce the same errors with the added test cases (this was not the case before). - ParseBlock already does Expect(Token::LBRACE), so no need to check it twice. BUG=v8:3126 LOG=N R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/148233011 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19212 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 08 Feb, 2014 1 commit
-
-
haitao.feng@intel.com authored
The direction is to use "movl, movq, movp" instead of introducing new Macro assembler instructions. R=verwaest@chromium.org Review URL: https://codereview.chromium.org/101083002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19210 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 07 Feb, 2014 9 commits
-
-
rossberg@chromium.org authored
Plenty of test failures on test262, Mozilla, Webkit. Will have to investigate. TBR=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/139983003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19203 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
rossberg@chromium.org authored
ES6 makes the Function object properties "length" and "name" configurable; switch the implementation over to follow that. Doing so exposed a problem in the handling of non-writable, but configurable properties backed by foreign callback accessors internally. As an optimization, if such an accessor property is re-defined with a new value, its setter was passed the new value directly, keeping the property as an accessor property. However, this is not correct should the property be non-writable, as its setter will then simply ignore the updated value. Adjust the enabling logic for this optimization accordingly, along with adding a test. LOG=N R=rossberg@chromium.org, rossberg BUG=v8:3045 Review URL: https://codereview.chromium.org/116083006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19200 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yangguo@chromium.org authored
This reverts r19196. TBR=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/147443008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19199 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
marja@chromium.org authored
This also makes the "delayed strict mode violations" mechanism in PreParser unnecessary. The attached tests didn't pass before this CL but now they do. BUG=v8:3126 LOG=N R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/157453003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19197 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yangguo@chromium.org authored
\u0085 (NEL) is now considered a whitespace in accordance to http://www.unicode.org/Public/6.3.0/ucd/PropList.txt R=mstarzinger@chromium.org BUG=v8:3109 LOG=Y Review URL: https://codereview.chromium.org/146983007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19196 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
svenpanne@chromium.org authored
Fixed a few more cctests and removed some which were broken for ages and/or tested nothing useful anymore. Note that cctests are now fully LeakSanitized (at least on x64)! R=dcarney@chromium.org Review URL: https://codereview.chromium.org/157463002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19195 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
danno@chromium.org authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/157443002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19194 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
marja@chromium.org authored
BUG=3126 LOG=N R=ulan@chromium.org Review URL: https://codereview.chromium.org/140183005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19193 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
marja@chromium.org authored
These tests ensure that PreParser doesn't start producing less data when it's getting refactored. BUG=3126 LOG=N R=ulan@chromium.org Review URL: https://codereview.chromium.org/157373002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19192 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-