- 10 Jan, 2022 17 commits
-
-
Romain Pokrzywka authored
LocalFactory::AllocateRaw() only allows the kOld and kSharedOld allocation types, but NewArrayList() calls NewFixedArray() without an explicit allocation argument, which then defaults to kYoung. Add an allocation argument to NewArrayList() with the same default value as for NewFixedArray() and pass kOld when calling it from NewScriptWithId() to avoid tripping the DCHECK with LocalFactory. Follow-up to https://crrev.com/c/3211575 Bug: chromium:1244145 Change-Id: I88d394bda250c45bf49141b78c09f6ca4a61dbe3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3354087Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#78540}
-
Benedikt Meurer authored
The special symbols defined in heap-symbols.h were extracted out of src/heap/heap.{cc,h} a long time ago because they logically belong to the objects and not to the implementation of the GC/heap, so they should have the same ownership as the objects that use them in src/objects. Bug: none Change-Id: I9a87c1600dc26b0fc5e620a13d409fb9116235e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3375546Reviewed-by:Hannes Payer <hpayer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/main@{#78539}
-
Shu-yu Guo authored
Bug: v8:11708 Change-Id: Ibf0f91b9e63646f226a2e70ec4a1733820e968ae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3373135 Auto-Submit: Shu-yu Guo <syg@chromium.org> Reviewed-by:
-
Piotr Sikora authored
Signed-off-by:
Piotr Sikora <piotrsikora@google.com> Change-Id: I776b98676df0094c141a395cfbe10801153e1076 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3343881Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#78537}
-
Liviu Rau authored
Bug: v8:12538 Change-Id: I57496ee0f50df92000c445c07acc8d6ee763d4e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3377123Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/main@{#78536}
-
Piotr Sikora authored
Signed-off-by:
-
Piotr Sikora authored
Signed-off-by:
-
Piotr Sikora authored
Signed-off-by:
-
Clemens Backes authored
We should only check the "SIMD sibling" register if we are handling a SIMD register. This avoids unneeded spills, and in this particular case ran into a DCHECK because there are only 29 registers, but we tried checking #29. R=thibaudm@chromium.org Bug: v8:12330, v8:1285007 Change-Id: Ife8b295ac958990611ca8816bbfbfb5124a4297d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3372916Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#78532}
-
Piotr Sikora authored
Tested with both GCC and Clang on s390x (under QEMU). Signed-off-by:
-
Al Muthanna Athamina authored
Bug: v8:12538 Change-Id: I89e7fcde7226d680f3385f527cb2e456829a476d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3376962Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Cr-Commit-Position: refs/heads/main@{#78530}
-
Manos Koukoutos authored
This is a reland of be6bd4f4. The reason for revert was two bots timing out. On further inspection, the timeouts seem unrelated. Original change's description: > [wasm] Fast paths in EvaluateInitExpression > > We add fast paths for the most common types of expressions in > {EvaluateInitExpression} to improve instantiation time. We fall back to > full expression decoding for less common operators, or for expressions > with operands. > > Bug: chromium:1284557 > Change-Id: I39a1816176974058b801cdad6eaaa6da156cea04 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3367627 > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> > Cr-Commit-Position: refs/heads/main@{#78497} Bug: chromium:1284557 Change-Id: I209458c1fa36ae41899434b90759ebe3fe5e2a57 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3375545Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#78529}
-
Clemens Backes authored
Without the comma, the two strings '--no-enable-sse3' and '--noenable-ssse3' will be concatenated, resulting in missing detection for the no_simd_hardware flag. R=liviurau@chromium.org Bug: v8:12521 Change-Id: Icbdc5e8057d1eeead472f76efd52c379bffbe5b6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3372914Reviewed-by:
-
Al Muthanna Athamina authored
Bug: v8:12483 Change-Id: Ic488540c3d4905813a705b0fb6d742d267c994c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3366239 Auto-Submit: Almothana Athamneh <almuthanna@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Bug: v8:12529 Change-Id: I73c8176cf0b3570f1424b85038467d5b965d3d04 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3375548 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#78526}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/66cd756..12badc1 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I11dd012d8a4c8775f6ddeac2190df8ce496da986 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3376582 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78525}
-
Yujie Wang authored
- Implement `kRiscvF32x4RecipApprox`, `kRiscvF32x4RecipSqrtApprox`, `kRiscvF32x4Qfma`, `kRiscvF32x4Qfms`, `kRiscvF64x2Qfma` and `kRiscvF64x2Qfms` in `code-generator-riscv64.cc` - Reuse lane-select, min-max and trunc instrctions in `instruction-selector-riscv64.cc` Bug: v8:11976 Change-Id: I8566f7e082a3d7071ec9fc64c742da82425a4d4d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3364077Reviewed-by:
Yahan Lu <yahan@iscas.ac.cn> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#78524}
-
- 09 Jan, 2022 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/208eb9e..66cd756 Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/c884e7a..a0ace99 Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/4bf418e..58d1647 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Ifc8c5d9708af08c0765e8f3567cfb64aab267d7f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3371679 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78523}
-
- 08 Jan, 2022 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/3fd1fd5..208eb9e Rolling v8/buildtools/linux64: git_revision:387b368dfe63fec317f8e609d90c634807f2764e..git_revision:f1b1412521b41e47118b29863224171e434a27a2 Rolling v8/third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/abc362f..5023a5c Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/9552069..d3cc7ad Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/17ca796..6e330f7 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Id6780cf6c36e72f0ded9dc918b470ebe4b65755d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3373548 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78522}
-
- 07 Jan, 2022 15 commits
-
-
Clemens Backes authored
Inlining the field accesses make the code simpler by avoiding the abstraction of the accessor, and makes stepping through the code for debugging easier. R=thibaudm@chromium.org Bug: v8:12330 Change-Id: I51bd0e88baa5ffba5bd4bfcca36e95caab7468c3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3372913Reviewed-by:
-
Clemens Backes authored
Since the accessors are only called from other methods in the same class, we can just access the field directly. This makes stepping through easier and makes the code simpler by avoiding an unneeded abstraction. R=thibaudm@chromium.org Bug: v8:12330 Change-Id: I39727324e82fcfd15b3b242c53ed5534e2e5511d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3372912Reviewed-by:
-
Austin Sullivan authored
This should have been updated in https://crrev.com/c/3370408 Bug: chromium:1284506 Change-Id: Ie44d80b507c9a798ce6f4776672270f9d4b12195 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3371463Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/main@{#78519}
-
Frank Tang authored
Bug: v8:11544 Change-Id: I3206ca3e0c505b14e4497ccb2af25a31940a1c1e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2967755Reviewed-by:
-
Clemens Backes authored
The test was added in https://crrev.com/c/3372910, but needs to be skipped on non-SIMD hardware because it contains SIMD instructions. R=thibaudm@chromium.org Bug: v8:12330, chromium:1284980 Change-Id: Ifaede466b24aea4f9ef6b062414a31698bcca864 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3372917 Auto-Submit: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/main@{#78517}
-
Clemens Backes authored
The register state is accessed a lot in the mid-tier register allocator. Instead of going through an accessor with a DCHECK, just access directly. This makes stepping for debugging a lot easier, and will result in an easy-to-debug nullptr access if the register state is not initialized. R=thibaudm@chromium.org Bug: v8:12330 Change-Id: Icf4d1cc187a34f28ee44fc9b80ee5d765aa14b9a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3372911Reviewed-by:
-
Clemens Backes authored
The bailout is there explicitly in the code, so we should allow it in {CheckBailoutAllowed}. R=ahaas@chromium.org Bug: v8:12527 Change-Id: Ifd906afb5f034f05c2bf7d9a28e3ab458549e7ef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3372915Reviewed-by:Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#78515}
-
Clemens Backes authored
Spilling was already fixed if a fixed SIMD register overlaps with an allocated FP register, but the other way around was missing: If an odd FP register (in this case d1) is used as a fixed output register, but this register is in use as the upper half of a SIMD register (in this case q0), we did not detect this and would just use overwrite the SIMD half. This CL also fixes this case. R=thibaudm@chromium.org Bug: v8:12330, chromium:1284980 Change-Id: Id3f98b7accd77e38ab4cd5ff8910aaf5ad96a1ed Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3372910Reviewed-by:
-
Shu-yu Guo authored
This is a reland of c7c5b492 Changes since revert: - Save position instead of using PushBack - Allow private-name-surrogate-pair to fail on no_i18n builds Original change's description: > [scanner] Combine surrogate pairs at start when scanning private names > > Bug: v8:12523 > Change-Id: Ic3779fe6f20965d177d99d0a570a735df72e4fde > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3366994 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Shu-yu Guo <syg@chromium.org> > Cr-Commit-Position: refs/heads/main@{#78493} Bug: v8:12523 Change-Id: I8a92953549f5b38bfa004488db42bf9d835e1222 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3368361Reviewed-by:
-
Clemens Backes authored
This adds an output operator for {RegisterBitVector}, mostly for getting better DCHECK error messages. R=thibaudm@chromium.org Bug: v8:12330 Change-Id: I98f822f94a3b6a240c8ead7ea4de4049abe9998e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3372909Reviewed-by: -
Piotr Sikora authored
Missed in https://crrev.com/c/3333635. Signed-off-by:
-
Piotr Sikora authored
Missed in https://crrev.com/c/3337367. Signed-off-by:
-
Piotr Sikora authored
Signed-off-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/f29e3b6..3fd1fd5 Rolling v8/buildtools/linux64: git_revision:19bf826e6e5d05100cb3568e90e48bd3c97d4f22..git_revision:387b368dfe63fec317f8e609d90c634807f2764e Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/6a10e3e..4bf418e Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/e971498..9552069 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/24c1100..17ca796 Rolling v8/tools/luci-go: git_revision:89429843eb2dedb599a6c7c7754343b97d95943d..git_revision:d1e877e2b3e5a05a5cd34c4a340fedba14a16c2b Rolling v8/tools/luci-go: git_revision:89429843eb2dedb599a6c7c7754343b97d95943d..git_revision:d1e877e2b3e5a05a5cd34c4a340fedba14a16c2b R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I9b882395fb44b11308a3e55166bbf7f527c538d3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3371705 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78508}
-
Victor Costan authored
https://crrev.com/c/3297708 changed the serialization format for typed arrays without bumping the format version. As a consequence, builds that include that CL fail to deserialize typed arrays serialized by previous V8 versions. This CL reverts the serialization format change, and does minimal test changes to reflect the revert. https://crbug.com/v8/12532 tracks serializing typed array flags in a backwards-compatible manner. Bug: chromium:1284506 Change-Id: Ib32e88c6383e0ad4ad1a9ff63f413a1eb123b1ef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3370408Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
-
- 06 Jan, 2022 3 commits
-
-
Omer Katz authored
Bug: chromium:1283720 Cq-Include-Trybots: luci.v8.try:v8_linux_blink_rel Change-Id: Ifd9982a9315ebbed8765bc9f15ac3ffcbf04612f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3368269 Auto-Submit: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#78506}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ccc9811..f29e3b6 Rolling v8/buildtools/linux64: git_revision:281ba2c91861b10fec7407c4b6172ec3d4661243..git_revision:19bf826e6e5d05100cb3568e90e48bd3c97d4f22 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/ec88714..aa0e8d0 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/02d65ea..e971498 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/2d10229..24c1100 Rolling v8/tools/luci-go: git_revision:e897e118887a2e6c50a82212b660cb2a7c58d910..git_revision:89429843eb2dedb599a6c7c7754343b97d95943d Rolling v8/tools/luci-go: git_revision:e897e118887a2e6c50a82212b660cb2a7c58d910..git_revision:89429843eb2dedb599a6c7c7754343b97d95943d R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I9d02d870a7233878220336aaa985c9216f521c58 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3362608 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78505}
-
Aleksei Koziatinskii authored
In the C++20 a following paper was implemented [1]. This paper makes code below illformed. The high level idea is that as soon as class gets non default constructor - all default initializations are not added implicitly. class A { public: A(const A&) = delete; }; int main() { A a{}; return 0; } So if V8 embedder is building its code with C++20 it can not initialize v8::CppHeapCreateParams struct and as a result can not create a CppHeap. One of the possible mitigations (3.3) from the paper is to add non copyable field into class. Luckily there is std::vector<std::unique_ptr>> in this class already. [1] http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p1008r1.pdf Change-Id: I8a2dc35784d7646b5f73a5e178716e9bf2ffe601 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3348007Reviewed-by:
-
- 05 Jan, 2022 3 commits
-
-
Frank Tang authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/04cd6da0..6c9b4de Bug: v8:7834 Change-Id: I29159c3421ad81ec86544ac9682c76abc73c6703 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3367376Reviewed-by:
-
Shu-yu Guo authored
This reverts commit be6bd4f4. Reason for revert: Consistent timeouts on Linux and Mac, e.g. https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20debug/37973/overview https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Mac64%20-%20debug/37346/overview Original change's description: > [wasm] Fast paths in EvaluateInitExpression > > We add fast paths for the most common types of expressions in > {EvaluateInitExpression} to improve instantiation time. We fall back to > full expression decoding for less common operators, or for expressions > with operands. > > Bug: chromium:1284557 > Change-Id: I39a1816176974058b801cdad6eaaa6da156cea04 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3367627 > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> > Cr-Commit-Position: refs/heads/main@{#78497} Bug: chromium:1284557 Change-Id: If09468eb1e790d4359573ddff8b653fe84b0e11e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3368602 Auto-Submit: Shu-yu Guo <syg@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Shu-yu Guo <syg@chromium.org> Owners-Override: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#78502}
-
Piotr Sikora authored
Signed-off-by:
-
