- 14 Jun, 2016 24 commits
-
-
mlippautz authored
See bug description. BUG=chromium:619382 LOG=N R=ulan@chromium.org Review-Url: https://codereview.chromium.org/2065063002 Cr-Commit-Position: refs/heads/master@{#36968}
-
machenbach authored
Port https://codereview.chromium.org/2057053002/ for the v8-side configurations. BUG=chromium:616035 NOTRY=true TBR=vogelheim@chromium.org, jochen@chromium.org Review-Url: https://codereview.chromium.org/2066823002 Cr-Commit-Position: refs/heads/master@{#36967}
-
bmeurer authored
This is part of the fixes required to make type feedback viable for TurboFan on Octane. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2065953002 Cr-Commit-Position: refs/heads/master@{#36966}
-
ishell authored
The former will handle loads of predeclared global variables (vars and functions), lets, consts and undeclared variables. The latter will handle named loads from explicit receiver. In addition, named loads does not depend of the TypeofMode. TypeofMode related cleanup will be done in the follow-up CL. BUG=chromium:576312 LOG=Y TBR=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/1912633002 Cr-Commit-Position: refs/heads/master@{#36965}
-
yangguo authored
R=bmeurer@chromium.org, caitpotter88@gmail.com, neis@chromium.org BUG=v8:5099 Review-Url: https://codereview.chromium.org/2067503002 Cr-Commit-Position: refs/heads/master@{#36964}
-
bbudge authored
Moves between operands with different representations shouldn't happen, so don't test them. This makes it easier to modify canonicalization to differentiate between floating point types, which is needed to support floating point register aliasing for ARM and MIPS. This change also expands tests to include explicit FP moves (both register and stack slot). LOG=N BUG=v8:4124 Review-Url: https://codereview.chromium.org/2060273003 Cr-Commit-Position: refs/heads/master@{#36963}
-
mstarzinger authored
The pattern of how our source files are listed in GYP files changed, which in turn broke the parsing pattern that GCMole uses to gather a list of files to check. Only 'cctest' file were checked, 'src' files were being ignored. R=cbruni@chromium.org Review-Url: https://codereview.chromium.org/2065933002 Cr-Commit-Position: refs/heads/master@{#36962}
-
yangguo authored
R=mlippautz@chromium.org, yukishiino@chromium.org BUG=chromium:617649 Review-Url: https://codereview.chromium.org/2069563002 Cr-Commit-Position: refs/heads/master@{#36961}
-
yangguo authored
R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2068603002 Cr-Commit-Position: refs/heads/master@{#36960}
-
ishell authored
Zero value of ICStateField part made megamorphic stub cache unusable. We need to revisit hashing algorithm in order to remove the ICStateField. BUG=chromium:619016 LOG=N Review-Url: https://codereview.chromium.org/2064713002 Cr-Commit-Position: refs/heads/master@{#36959}
-
jkummerow authored
Review-Url: https://codereview.chromium.org/2064673002 Cr-Commit-Position: refs/heads/master@{#36958}
-
cbruni authored
Reland of place all remaining Oddball checks with new function (patchset #1 id:1 of https://codereview.chromium.org/2060213002/ ) Reason for revert: Cannot reproduce gc-stress failures locally. Original issue's description: > Revert of Replace all remaining Oddball checks with new function (patchset #10 id:180001 of https://codereview.chromium.org/2043183003/ ) > > Reason for revert: > failing tests > > Original issue's description: > > Replace all remaining Oddball checks with new function > > > > This CL removes the IsUndefined() and Co. methods from Object and HeapObject. > > The new method all take the isolate as parameter. > > > > BUG= > > > > Committed: https://crrev.com/ccefb3ae5fe967288d568013fb04e8761eafebc5 > > Cr-Commit-Position: refs/heads/master@{#36921} > > TBR=mstarzinger@chromium.org,verwaest@chromium.org,yangguo@chromium.org,ahaas@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= > > Committed: https://crrev.com/33b8bc24a12fb062100c0be84456faeb0b9fa5d1 > Cr-Commit-Position: refs/heads/master@{#36923} TBR=mstarzinger@chromium.org,verwaest@chromium.org,yangguo@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/2059173002 Cr-Commit-Position: refs/heads/master@{#36957}
-
machenbach authored
This moves common configs used by all v8 targets into common templates. This also fixes using v8_optimized_debug correctly in executables and components. BUG=chromium:474921 NOTRY=true Review-Url: https://codereview.chromium.org/2054803003 Cr-Commit-Position: refs/heads/master@{#36956}
-
adamk authored
R=cbruni@chromium.org BUG=chromium:618788 Review-Url: https://codereview.chromium.org/2058013002 Cr-Commit-Position: refs/heads/master@{#36955}
-
bmeurer authored
There's no need to have different versions of the fairly complex TransitionElementsKindStub just to avoid a single instance type check at execution time (which is used to figure out the effective length in case of JSArray objects). R=ishell@chromium.org Review-Url: https://codereview.chromium.org/2064993002 Cr-Commit-Position: refs/heads/master@{#36954}
-
ivica.bogosavljevic authored
Port: c8ac0d86 Fix compliation failure on MIPS64 big-endian caused by typo in implementation. BUG= Review-Url: https://codereview.chromium.org/2065903002 Cr-Commit-Position: refs/heads/master@{#36953}
-
clemensh authored
The function name table will now always be set; a CHECK will fail if the length would exceed the integer range. Also, the resolution of undefined function names to "<WASM UNNAMED>" is moved over to the wasm side. R=titzer@chromium.org Committed: https://crrev.com/3400ee9f4f21a455b7850ec42a4182a3c0eba310 Review-Url: https://codereview.chromium.org/2057523002 Cr-Original-Commit-Position: refs/heads/master@{#36918} Cr-Commit-Position: refs/heads/master@{#36952}
-
mstarzinger authored
The builtin function ID has been moved from the [function_data] field to the [function_location] field. This just updates existing verification functionality to be in sync. R=rmcilroy@chromium.org Review-Url: https://codereview.chromium.org/2064723002 Cr-Commit-Position: refs/heads/master@{#36951}
-
jarin authored
This introduces SilenceNaN operator, which makes sure that we only store quiet NaNs into holey arrays. We omit the NaN silencing code at instruction selection time if the input is an operation that cannot possibly produce signalling NaNs. BUG= Review-Url: https://codereview.chromium.org/2060233002 Cr-Commit-Position: refs/heads/master@{#36950}
-
mstarzinger authored
R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2067513002 Cr-Commit-Position: refs/heads/master@{#36949}
-
Ilija.Pavlovic authored
This patch enables V8 build with Clang without errors for MIPS64 release R6. TEST= BUG= Review-Url: https://codereview.chromium.org/2062713002 Cr-Commit-Position: refs/heads/master@{#36948}
-
bmeurer authored
This CheckBounds simplified operator is similar to the HBoundsCheck in Crankshaft, and is hooked up to the new type feedback support in the SimplifiedLowering. We use it to check the index bounds for keyed property accesses. Note to perf sheriffs: This will tank quite a few benchmarks, as the operator makes some redundant branch elimination ineffective for certain patterns of keyed accesses. This does require more serious redundancy elimination, which we will do in a separate CL. So ignore any regressions from this CL, we know there will be a few. R=jarin@chromium.org BUG=v8:4470,v8:5100 Review-Url: https://codereview.chromium.org/2035893004 Cr-Commit-Position: refs/heads/master@{#36947}
-
jyan authored
Port 7ceed92a Port 89d8c57b Original commit message: Import base::ieee754::atan() and base::ieee754::atan2() from fdlibm and introduce Float64Atan and Float64Atan2 TurboFan operators based on those, similar to what we already did for Float64Log and Float64Log1p. Rewrite Math.atan() and Math.atan2() as TurboFan builtin and use the operators to also inline Math.atan() and Math.atan2() into optimized TurboFan functions. Import base::ieee754::log1p() from fdlibm and introduce a Float64Log1p TurboFan operator based on that, similar to what we do for Float64Log. Rewrite Math.log1p() as TurboFan builtin and use that operator to also inline Math.log1p() into optimized TurboFan functions. Also unify the handling of the special IEEE 754 functions somewhat in the TurboFan backends. At some point we can hopefully express this completely in the InstructionSelector (once we have an idea what to do with the ST(0) return issue on IA-32/X87). Drive-by-fix: Add some more test coverage for the log function. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com, bjaideep@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/2064783002 Cr-Commit-Position: refs/heads/master@{#36946}
-
jyan authored
Port e95cfafb Original commit message: This fixes FastNewStrictArgumentsStub and FastNewRestParameterStub to no longer assume that the strict arguments object being allocated will fit into new-space. The case where said object needs to move to large object space is now handled in the runtime. R=mstarzinger@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com, bjaideep@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/2064023002 Cr-Commit-Position: refs/heads/master@{#36945}
-
- 13 Jun, 2016 16 commits
-
-
bbudge authored
LOG=N BUG=v8:4124 Review-Url: https://codereview.chromium.org/2067463003 Cr-Commit-Position: refs/heads/master@{#36944}
-
gdeepti authored
MemSize should use Relocatable constants, remove unconditional throw on no linear memory as this should be patched on GrowMemory. R=mtrofin@chromium.org, bradnelson@chromium.org Review-Url: https://codereview.chromium.org/2067433003 Cr-Commit-Position: refs/heads/master@{#36943}
-
jpp authored
This CL introduces the new type system for the ASM type-checker/validator. BUG= Review-Url: https://codereview.chromium.org/2045703007 Cr-Commit-Position: refs/heads/master@{#36942}
-
littledan authored
Revert of change most cases of variable redeclaration from TypeError to SyntaxError (patchset #8 id:140001 of https://codereview.chromium.org/2048703002/ ) Reason for revert: This is going to break the LayoutTest inspector-protocol/console/console-let-const-with-api.html as seen in https://build.chromium.org/p/tryserver.v8/builders/v8_linux_blink_rel/builds/2247 . Please run this test manually, using instructions at https://www.chromium.org/developers/testing/webkit-layout-tests , and fix on the Chrome side if needed before resubmitting this patch. Original issue's description: > change most cases of variable redeclaration from TypeError to SyntaxError. > > Code like `let a; eval("var a;");` should throw a SyntaxError, not a TypeError > (this caused a test262 failure.). However, the code `eval("function NaN() {}");` > should actually throw a TypeError. This patch changes most cases of > redeclaration errors from TypeError to SyntaxError. See the test > mjsunit/regress/redeclaration-error-types for a thorough analysis with spec > references. > > The relevant sections of the spec are ES#sec-globaldeclarationinstantiation and > ES#sec-evaldeclarationinstantiation > > BUG=v8:4955 > LOG=y > > Committed: https://crrev.com/2b787561763d0f7e8dab698652715a742cf78291 > Cr-Commit-Position: refs/heads/master@{#36940} TBR=adamk@chromium.org,jwolfe@igalia.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4955 Review-Url: https://codereview.chromium.org/2064793002 Cr-Commit-Position: refs/heads/master@{#36941}
-
jwolfe authored
Code like `let a; eval("var a;");` should throw a SyntaxError, not a TypeError (this caused a test262 failure.). However, the code `eval("function NaN() {}");` should actually throw a TypeError. This patch changes most cases of redeclaration errors from TypeError to SyntaxError. See the test mjsunit/regress/redeclaration-error-types for a thorough analysis with spec references. The relevant sections of the spec are ES#sec-globaldeclarationinstantiation and ES#sec-evaldeclarationinstantiation BUG=v8:4955 LOG=y Review-Url: https://codereview.chromium.org/2048703002 Cr-Commit-Position: refs/heads/master@{#36940}
-
gsathya authored
This patch declares a new rest parameter for the derived constructor, and passes it to base constructor after calling PrepareSpreadArguments. This patch also updates the test262.status to account for the now passing test. BUG=v8:4890 Review-Url: https://codereview.chromium.org/2056993004 Cr-Commit-Position: refs/heads/master@{#36939}
-
caitpotter88 authored
BUG=v8:4483, v8:4907, 618603 LOG=N R=neis@chromium.org, yangguo@chromium.org, littledan@chromium.org Review-Url: https://codereview.chromium.org/2051423003 Cr-Commit-Position: refs/heads/master@{#36938}
-
hlopko authored
With cl https://codereview.chromium.org/2043033002 blink will add new wrappers to its marking deque (and maintain this deque) so black allocated wrappers are not a problem anymore. To limit the scope of when blink has to detect wrappers, we need to tell blink when we start and when we end full gcs. For that we can nicely use TracePrologue and TraceEpilogue. LOG=no BUG=468240 Review-Url: https://codereview.chromium.org/2051103002 Cr-Commit-Position: refs/heads/master@{#36937}
-
danno authored
* The default text (placeholder) in the search box is now present. * All key events handled by turbolizer are not passed through to Chrome. Review-Url: https://codereview.chromium.org/2061713002 Cr-Commit-Position: refs/heads/master@{#36936}
-
bjaideep authored
Port 7ceed92a Port 89d8c57b Original commit message: Import base::ieee754::atan() and base::ieee754::atan2() from fdlibm and introduce Float64Atan and Float64Atan2 TurboFan operators based on those, similar to what we already did for Float64Log and Float64Log1p. Rewrite Math.atan() and Math.atan2() as TurboFan builtin and use the operators to also inline Math.atan() and Math.atan2() into optimized TurboFan functions. Import base::ieee754::log1p() from fdlibm and introduce a Float64Log1p TurboFan operator based on that, similar to what we do for Float64Log. Rewrite Math.log1p() as TurboFan builtin and use that operator to also inline Math.log1p() into optimized TurboFan functions. Also unify the handling of the special IEEE 754 functions somewhat in the TurboFan backends. At some point we can hopefully express this completely in the InstructionSelector (once we have an idea what to do with the ST(0) return issue on IA-32/X87). Drive-by-fix: Add some more test coverage for the log function. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:5086,v8:5092,v8:5095 LOG=N Review-Url: https://codereview.chromium.org/2061753002 Cr-Commit-Position: refs/heads/master@{#36935}
-
bjaideep authored
Port e95cfafb Original commit message: This fixes FastNewStrictArgumentsStub and FastNewRestParameterStub to no longer assume that the strict arguments object being allocated will fit into new-space. The case where said object needs to move to large object space is now handled in the runtime. R=mstarzinger@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=chromium:614727 LOG=N Review-Url: https://codereview.chromium.org/2060893002 Cr-Commit-Position: refs/heads/master@{#36934}
-
hlopko authored
In order to update v8 api and still be able to build chromium, we had to keep code in suboptimal state. Now when chromium caught up, we can perform cleanup :) LOG=no BUG=468240 Review-Url: https://codereview.chromium.org/2057613002 Cr-Commit-Position: refs/heads/master@{#36933}
-
danno authored
Fix bugs and add a few small useful features: * Fix Schedule view to properly parse schedule output and respond to switching back to graph views. * Add shorcuts for showing edges of selected nodes. - 'i' shows all inputs - 'o' shows all outputs - '1'-'9' shows all nodes nth input where 1 <= n <= 9 - 'c' shows all control inputs - 'e' shows all effect inputs * Holding the control key down when using a edge-showing shortcut toggles edge state rather the just showing. * 'a' selects all nodes in graph view. * Node selection is preserved between graph views and Schedule views. * Holding control key down when using regular expression search shows currently hidden nodes that match the regex search. * Pane expansion buttons now respond to clicks in entire button area. * Default text in regex search box makes searching more discoverable. Review-Url: https://codereview.chromium.org/2059193002 Cr-Commit-Position: refs/heads/master@{#36932}
-
ahaas authored
R=bmeurer@chromium.org, bradnelson@chromium.org BUG=v8:5086, v8:5095 Review-Url: https://codereview.chromium.org/2062773002 Cr-Commit-Position: refs/heads/master@{#36931}
-
neis authored
It's sufficient to bailout when seeing that the function literal is a generator or async function, as those are the only cases in which there can be yields. Also: add a comment on --turbo-from-bytecode and Ignition generators. R=mstarzinger@chromium.org BUG= Review-Url: https://codereview.chromium.org/2060843002 Cr-Commit-Position: refs/heads/master@{#36930}
-
nikolaos authored
It seems that I forgot to remove the DCHECK when refactoring this function, even though the comment had it right. It also seems that this is hard to trigger. The minimal example I found, after fuzzer's bug, was: eval, x[eval] R=adamk@chromium.org BUG=chromium:619476 LOG=N Review-Url: https://codereview.chromium.org/2058413002 Cr-Commit-Position: refs/heads/master@{#36929}
-