1. 18 Oct, 2013 1 commit
  2. 15 Oct, 2013 2 commits
  3. 04 Oct, 2013 1 commit
  4. 01 Oct, 2013 3 commits
  5. 20 Sep, 2013 1 commit
  6. 19 Sep, 2013 1 commit
  7. 17 Sep, 2013 3 commits
  8. 13 Sep, 2013 1 commit
  9. 12 Sep, 2013 1 commit
  10. 10 Sep, 2013 1 commit
  11. 04 Sep, 2013 1 commit
  12. 02 Sep, 2013 1 commit
  13. 27 Aug, 2013 1 commit
  14. 26 Aug, 2013 1 commit
  15. 19 Aug, 2013 1 commit
  16. 09 Aug, 2013 1 commit
  17. 02 Aug, 2013 1 commit
    • loislo@chromium.org's avatar
      Extract hardcoded error strings into a single place and replace them with enum. · d2c443b7
      loislo@chromium.org authored
      I'd like to propagate bailout reason to cpu profiler.
      So I need to save it into heap object SharedFunctionInfo.
      But:
      1) all bailout reason strings spread across all the sources.
      2) they are native strings and if I convert them into String then I may have a performance issue.
      3) one byte is enough for 184 bailout reasons. Otherwise we need 8 bytes for the pointer.
      
      Also I think it would be nice to have error strings collected in one place.
      In that case we will get additional benefits:
      
      It allows us to keep this set of messages under control.
      It gives us a chance to internationalize them.
      It slightly reduces the binary footprint.
      
      From the other hand the developers have to add new strings into that enum.
      
      BUG=
      R=jkummerow@chromium.org
      
      Review URL: https://codereview.chromium.org/20843012
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16024 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      d2c443b7
  18. 31 Jul, 2013 2 commits
  19. 30 Jul, 2013 1 commit
  20. 29 Jul, 2013 2 commits
  21. 23 Jul, 2013 1 commit
  22. 22 Jul, 2013 1 commit
  23. 19 Jul, 2013 2 commits
  24. 05 Jul, 2013 1 commit
  25. 03 Jul, 2013 1 commit
  26. 28 Jun, 2013 1 commit
  27. 27 Jun, 2013 1 commit
  28. 13 Jun, 2013 3 commits
    • yurys@chromium.org's avatar
      Notify CPU profiler when calling native getters · c4224f09
      yurys@chromium.org authored
      This change modifies code produced by BaseLoadStubCompiler::GenerateLoadCallback so that instead of calling AccessorGetter direcly it calls InvokeAccessorGetter which changes VM state and calls the actual callback. This way CPU profiler knows which external callback is being executed in this case. Indirect call happens only if CpuProfiler::is_profiling() is true.
      
      This is exactly same change as r15116 with a build fix for test-api.cc
      
      BUG=244580
      TBR=danno@chromium.org
      
      Review URL: https://codereview.chromium.org/16858013
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15135 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      c4224f09
    • yurys@chromium.org's avatar
      Revert "Notify CPU profiler when calling native getters" · 24ec0171
      yurys@chromium.org authored
      This reverts commit f323d984a73bab345c4eab5c1907552ccfa7ccaa.
      
      Broke compilation on the bots with an error that doesn't occur locally:
      
        CXX(target) /mnt/data/b/build/slave/v8-linux-debug/build/v8/out/Debug/obj.target/cctest/test/cctest/test-bignum-dtoa.o
      ../test/cctest/test-api.cc: In function ‘void FastReturnValueCallback(const v8::FunctionCallbackInfo<v8::Value>&) [with T = int]’:
      ../test/cctest/test-api.cc:1129: error: insufficient contextual information to determine type
      ../test/cctest/test-api.cc: In function ‘void FastReturnValueCallback(const v8::FunctionCallbackInfo<v8::Value>&) [with T = unsigned int]’:
      ../test/cctest/test-api.cc:1136: error: insufficient contextual information to determine type
      ../test/cctest/test-api.cc: In function ‘void FastReturnValueCallback(const v8::FunctionCallbackInfo<v8::Value>&) [with T = double]’:
      ../test/cctest/test-api.cc:1143: error: insufficient contextual information to determine type
      ../test/cctest/test-api.cc: In function ‘void FastReturnValueCallback(const v8::FunctionCallbackInfo<v8::Value>&) [with T = bool]’:
      ../test/cctest/test-api.cc:1150: error: insufficient contextual information to determine type
      ../test/cctest/test-api.cc: In function ‘void FastReturnValueCallback(const v8::FunctionCallbackInfo<v8::Value>&) [with T = void]’:
      ../test/cctest/test-api.cc:1157: error: insufficient contextual information to determine type
        CXX(target) /mnt/data/b/build/slave/v8-linux-debug/build/v8/out/Debug/obj.target/cctest/test/cctest/test-circular-queue.o
      
      BUG=None
      TBR=svenpanne@chromium.org
      
      Review URL: https://codereview.chromium.org/16838013
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15117 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      24ec0171
    • yurys@chromium.org's avatar
      Notify CPU profiler when calling native getters · 1a3c3cee
      yurys@chromium.org authored
      This change modifies code produced by BaseLoadStubCompiler::GenerateLoadCallback so that instead of calling AccessorGetter direcly it calls InvokeAccessorGetter which changes VM state and calls the actual callback. This way CPU profiler knows which external callback is being executed in this case.
      
      BUG=244580
      R=dcarney@chromium.org, loislo@chromium.org, svenpanne@chromium.org
      
      Review URL: https://codereview.chromium.org/16286016
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15116 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      1a3c3cee
  29. 12 Jun, 2013 2 commits