Commits · d4eaae37d13ca0c01400125f1a307a325aa83d8d · Linshizhi / V8

03 Dec, 2013 18 commits

Check whether the receiver to a keyed-call is actually a heapobject. · d4eaae37

verwaest@chromium.org authored Dec 03, 2013

BUG=325225
LOG=n
R=dslomov@chromium.org

Review URL: https://chromiumcodereview.appspot.com/101863004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18241 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d4eaae37

Fix condition in merge-to-branch.sh · 8058a7fd

dslomov@chromium.org authored Dec 03, 2013

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/101973002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18237 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8058a7fd

'make quickcheck': don't overwrite debug output. · 5e535ae6

jkummerow@chromium.org authored Dec 03, 2013

Achieved by turning optdebug into a first-class compilation mode.

R=bmeurer@chromium.org, machenbach@chromium.org

Review URL: https://codereview.chromium.org/98963002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18236 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5e535ae6

Disable escape analysis. · 9148975b

hpayer@chromium.org authored Dec 03, 2013

BUG=
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/101903002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18234 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9148975b

Tests that make a stack allocated persistent weak and rely on gc need to force gc · 9d2344d1

jochen@chromium.org authored Dec 03, 2013

Otherwise, if during a fuzzer test incremental marking is running, we'll
crash in the weak callback

BUG=none
TBR=verwaest@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/101843002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18233 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9d2344d1

Mock out date call in push-to-trunk script for testability. · 9087d5f8

machenbach@chromium.org authored Dec 03, 2013

TEST=python -m unittest test_scripts.ScriptTest.testPrepareChangeLog
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/98173003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18232 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9087d5f8

Make LCodeGen::RegisterDependentCodeForEmbeddedMaps platform independent. · a06c8435

ulan@chromium.org authored Dec 03, 2013

BUG=
R=hpayer@chromium.org

Review URL: https://chromiumcodereview.appspot.com/99053002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18231 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a06c8435

Revert "Use constant types to represent the fixed right arg of a MOD." · 7e540e6b

bmeurer@chromium.org authored Dec 03, 2013

This reverts commit r18228 for crashing on Windows.

TBR=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/101663002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18229 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7e540e6b

Use constant types to represent the fixed right arg of a MOD. · 5c6b9500

bmeurer@chromium.org authored Dec 03, 2013

R=mvstanton@chromium.org, svenpanne@chromium.org

Review URL: https://codereview.chromium.org/99173002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18228 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5c6b9500

Remove deprecated Persistent::MakeWeak usage from V8 · 8565d3e9

jochen@chromium.org authored Dec 03, 2013

BUG=none
LOG=n
R=dcarney@chromium.org, ulan@chromium.org

Review URL: https://codereview.chromium.org/101523002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18227 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8565d3e9

Change clang-format config to allow for two empty lines between functions · ee5726cd

jochen@chromium.org authored Dec 03, 2013

BUG=none
R=jkummerow@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/101543002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18226 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ee5726cd

Add dcarney to V8 OWNERS · b687004f

jochen@chromium.org authored Dec 03, 2013

R=danno@chromium.org
LOG=n
BUG=none

Review URL: https://codereview.chromium.org/101373003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18225 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b687004f

Enable new string add. · 15fdadfb

bmeurer@chromium.org authored Dec 03, 2013

BUG=v8:2990
LOG=n
R=hpayer@chromium.org

Review URL: https://codereview.chromium.org/100223003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18222 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15fdadfb

Remove HeapSnapshotsCollection class · 054bdf7f

yurys@chromium.org authored Dec 03, 2013

The class added unecessary level of indirection to the heap profiler implementation. I merged some of its implementation into HeapProfiler and deleted the rest. This refactoring is also a prerequisite for keeping HeapObjectsMap alive even when all snapshots are deleted.

BUG=None
LOG=N
R=alph@chromium.org, mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/101393002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18221 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

054bdf7f

Fix change log generation in push-to-trunk script. · 0fd81694

machenbach@chromium.org authored Dec 03, 2013

Fixed missing parenthesis in regular expression. The log checker matched on the word "true" and included a wrong change log entry.

TEST=python -m unittest test_scripts.ToplevelTest.testRegressWrongLogEntryOnTrue
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/99573003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18220 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0fd81694

Prepare push to trunk. Now working on version 3.23.18. · 738c15f6

machenbach@chromium.org authored Dec 03, 2013

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/101313002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18217 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

738c15f6

Refactor X64 movq assembler instruction · 52ff9897

haitao.feng@intel.com authored Dec 03, 2013

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/91333002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18216 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

52ff9897

Use ULL and LL suffix for uint64_t and int64_t constants on Mac · cb5ba0cf

haitao.feng@intel.com authored Dec 03, 2013

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/96623002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18215 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

cb5ba0cf

02 Dec, 2013 22 commits

MIPS: Tidy up Throw and Mod · 5691b8f9

palfia@homejinni.com authored Dec 02, 2013

Port r18200 (4110d9df)

Original commit message:
Small fixes to Throw and Mod Lithium instructions.

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/100003003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18214 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5691b8f9

MIPS: Refactor BinaryOpIC to be able to use different stubs. · 801b2b05

palfia@homejinni.com authored Dec 02, 2013

Port r18191 (c20c6dc1)

Original commit message:
Previously BinaryOpIC and BinaryOpStub were pretty much interdependent.
However, in order to use allocation sites for string adds on-demand,
we need to be able to use different stubs (with a different number of
register parameters, via trampolines) depending on the BinaryOpIC state.

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/100023002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18213 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

801b2b05

MIPS: Fix HInnerAllocatedObject to use an HValue for the offset. · 68e0ca2e

palfia@homejinni.com authored Dec 02, 2013

Port r18181 (2b41b833)

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/99763003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18212 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

68e0ca2e

MIPS: Optimize WrapReceiver · f8542470

palfia@homejinni.com authored Dec 02, 2013

Port r18180 (56666385)

Original commit message:
Optimize register constraints and code generated for WrapReceiver Lithium instruction.

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/100013002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18211 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f8542470

Check elimination: Learn from if(CompareMap(x)) on true branch. · 16c4c14f

titzer@chromium.org authored Dec 02, 2013

BUG=
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/99043002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18210 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

16c4c14f

Remove remaining HandleScope::Close usage · 5d4c7562

jochen@chromium.org authored Dec 02, 2013

For some reason, this is only caught when compiling with chromium on
Mac.

BUG=none
R=verwaest@chromium.org, dslomov@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/99263002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18209 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5d4c7562

MIPS: Remove the obsolete Code::IsPregenerated flag. · 83bd5a60

palfia@homejinni.com authored Dec 02, 2013

Port r18172 (cd823192)

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/99323003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18208 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

83bd5a60

Print exit code on crash in run-tests.py · 7f885c70

ulan@chromium.org authored Dec 02, 2013

R=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/99363002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18204 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7f885c70

Fix: test-debug.cc: don't misuse C++. · 54dfe365

marja@chromium.org authored Dec 02, 2013

The test in question (test-debug/LiveEditEnabled) is expected to fail, and it
failed, but because of the wrong reason (the test asserts that the default
isolate is not initialized, SetLiveEditEnabled initialized the default
isolate because it doesn't get one as param). Now it fails because of the right
reason.

R=ulan@chromium.org
BUG=

Review URL: https://codereview.chromium.org/99043004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18203 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

54dfe365

Bug in StoreIC::GenerateMegamorphic: strict_mode/extra_ic_state mismatch. · de96489d

mvstanton@chromium.org authored Dec 02, 2013

When computing the code flags for a megamorphic store IC, we mistakenly
passed a strict_mode variable when an ExtraICState was expected.

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/98633005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18202 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

de96489d

Support 'werror=no' on Mac/Xcode · 37e2c7e5

jkummerow@chromium.org authored Dec 02, 2013

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/98653003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18201 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

37e2c7e5

ARM: Tidy up Throw and Mod · 02bc466a

m.m.capewell@googlemail.com authored Dec 02, 2013

Small fixes to Throw and Mod Lithium instructions.

TEST=none
BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/98603005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18200 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

02bc466a

Enable global load elimination. · b5ee1e81

titzer@chromium.org authored Dec 02, 2013

BUG=
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/98943002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18198 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b5ee1e81

Simplify allocation tracker API · e87fe7b7

yurys@chromium.org authored Dec 02, 2013

Deprecated separate methods for starting/stopping allocation tracking in favor of a bool param to Start/StopTrackingHeapObjects.

BUG=None
LOG=N
R=loislo@chromium.org, mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/96933003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18197 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e87fe7b7

Move more logic from AST to oracle, pt 3 · bf3d84e3

rossberg@chromium.org authored Dec 02, 2013

Also eliminates remaining dependencies of type-info on AST.

R=jkummerow@chromium.org
BUG=

Review URL: https://codereview.chromium.org/95033003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18194 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

bf3d84e3

Fix NaCl build. · 620c985a

bmeurer@chromium.org authored Dec 02, 2013

TBR=dslomov@chromium.org

Review URL: https://codereview.chromium.org/99093003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18193 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

620c985a

Refactor BinaryOpIC to be able to use different stubs. · 9b892b86

bmeurer@chromium.org authored Dec 02, 2013

Previously BinaryOpIC and BinaryOpStub were pretty much interdependent.
However, in order to use allocation sites for string adds on-demand,
we need to be able to use different stubs (with a different number of
register parameters, via trampolines) depending on the BinaryOpIC state.

R=hpayer@chromium.org, mvstanton@chromium.org

Review URL: https://codereview.chromium.org/97543002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18191 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9b892b86

Fix invalid assertion with OSR in BuildBinaryOperation. · aa83f290

bmeurer@chromium.org authored Dec 02, 2013

BUG=v8:3032
LOG=n
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/98623004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18190 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

aa83f290

Make sin-cos test case compatible with --always-osr. · 3d062847

yangguo@chromium.org authored Dec 02, 2013

R=machenbach@chromium.org

Review URL: https://codereview.chromium.org/98893002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18188 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3d062847

Handle captured objects in OptimizedFrame::Summarize. · db915fe9

mstarzinger@chromium.org authored Dec 02, 2013

R=yangguo@chromium.org
BUG=v8:3029
TEST=mjsunit/regress/regress-3029
LOG=N

Review URL: https://codereview.chromium.org/96773002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18187 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

db915fe9

Removed pieces of extra_ic_state scattered around the stub compiler class... · 30c77be7

mvstanton@chromium.org authored Dec 02, 2013

Removed pieces of extra_ic_state scattered around the stub compiler class hierarchy, and pushed down to a extra_ic_state in the base class.

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/98853002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18185 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

30c77be7

Fix HInnerAllocatedObject to use an HValue for the offset. · a3d1df29

bmeurer@chromium.org authored Dec 02, 2013

R=hpayer@chromium.org, mvstanton@chromium.org

Review URL: https://codereview.chromium.org/98673003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18181 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a3d1df29