1. 18 Apr, 2018 1 commit
    • Simon Zünd's avatar
      Renamed builtins-typedarray* files. · 0ec7e505
      Simon Zünd authored
      This change is in preparation for implementing TypedArray builtins
      in torque. Torque makes assumptions about naming conventions regarding
      file and class names, which are currently inconsistent for TypedArrays.
      The class is called TypedArrayBuiltinsAssembler while the current file
      name suggests Typedarray... .
      
      R=jgruber@chromium.org
      
      Bug: v8:7382
      Change-Id: I3051dacb2bfbb7041482c8aa0a1104776ab4972c
      Reviewed-on: https://chromium-review.googlesource.com/1016300Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Commit-Queue: Simon Zünd <szuend@google.com>
      Cr-Commit-Position: refs/heads/master@{#52661}
      0ec7e505
  2. 19 Feb, 2018 1 commit
  3. 17 Feb, 2018 2 commits
  4. 30 Jan, 2018 1 commit
  5. 23 Nov, 2017 1 commit
  6. 23 Oct, 2017 1 commit
  7. 19 Oct, 2017 2 commits
  8. 16 Oct, 2017 1 commit
  9. 04 Sep, 2017 1 commit
  10. 01 Sep, 2017 1 commit
  11. 10 Jul, 2017 1 commit
  12. 17 May, 2017 1 commit
  13. 26 Apr, 2017 1 commit
  14. 04 Apr, 2017 3 commits
  15. 01 Apr, 2017 1 commit
  16. 25 Mar, 2017 1 commit
  17. 20 Mar, 2017 1 commit
  18. 16 Mar, 2017 2 commits
  19. 14 Mar, 2017 1 commit
  20. 13 Mar, 2017 2 commits
  21. 07 Mar, 2017 2 commits
  22. 02 Mar, 2017 1 commit
  23. 01 Mar, 2017 2 commits
    • Peter Marshall's avatar
      Revert "[builtins] Port TypedArrayInitialize to CodeStubAssembler." · a8e15e8f
      Peter Marshall authored
      This reverts commit b23b2c10.
      
      Reason for revert: Makes Linux debug bot sad
      
      Original change's description:
      > [builtins] Port TypedArrayInitialize to CodeStubAssembler.
      > 
      > Turbofan is a lot slower than Crankshaft at constructing TypedArrays,
      > because we always go to the C++ builtin. Port the builtin to CSA
      > to improve performance, and to clean up the implementation, which is
      > split across multiple files and pieces at the moment.
      > 
      > This CL increases the performance with --future to roughly the same
      > as with crankshaft.
      > 
      > BUG=v8:5977
      > 
      > Change-Id: I5a4c4b544a735a56290b85bf33c2f3718df7e2b8
      > Reviewed-on: https://chromium-review.googlesource.com/445717
      > Commit-Queue: Peter Marshall <petermarshall@chromium.org>
      > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
      > Reviewed-by: Camillo Bruni <cbruni@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#43518}
      
      TBR=cbruni@chromium.org,petermarshall@chromium.org,bmeurer@chromium.org,v8-reviews@googlegroups.com
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=v8:5977
      
      Change-Id: I5d5bc8b4677a405c716d78e688af80ae9c737b4a
      Reviewed-on: https://chromium-review.googlesource.com/448558Reviewed-by: 's avatarPeter Marshall <petermarshall@chromium.org>
      Commit-Queue: Peter Marshall <petermarshall@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#43520}
      a8e15e8f
    • Peter Marshall's avatar
      [builtins] Port TypedArrayInitialize to CodeStubAssembler. · b23b2c10
      Peter Marshall authored
      Turbofan is a lot slower than Crankshaft at constructing TypedArrays,
      because we always go to the C++ builtin. Port the builtin to CSA
      to improve performance, and to clean up the implementation, which is
      split across multiple files and pieces at the moment.
      
      This CL increases the performance with --future to roughly the same
      as with crankshaft.
      
      BUG=v8:5977
      
      Change-Id: I5a4c4b544a735a56290b85bf33c2f3718df7e2b8
      Reviewed-on: https://chromium-review.googlesource.com/445717
      Commit-Queue: Peter Marshall <petermarshall@chromium.org>
      Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
      Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#43518}
      b23b2c10
  24. 25 Feb, 2017 1 commit
  25. 23 Feb, 2017 1 commit
  26. 22 Feb, 2017 2 commits
  27. 17 Feb, 2017 1 commit
  28. 15 Feb, 2017 1 commit
    • caitp's avatar
      Reland [typedarrays] move %TypedArray%.prototype.copyWithin to C++ · dc302c74
      caitp authored
      - Removes shared InnerArrayCopyWithin JS builtin from src/js/array.js
      - Implements %TypedArray%.prototype.copyWithin as a C++ builtin, which
      relies on std::memmove rather than accessing individual eleements.
      - Fixes the case where copyWithin is invoked on a TypedArray with a
      detached buffer.
      - Add tests to ensure that +/-Infinity (for all 3 parameters) is handled
        correctly by the
      algorithm
      
      The C++ version gets through the benchmark more than 25000 times as
      quickly as the JS implementation.
      
      BUG=v8:5925, v8:5929, v8:4648
      R=cbruni@chromium.org, adamk@chromium.org, littledan@chromium.org
      
      Review-Url: https://codereview.chromium.org/2697593002
      Cr-Commit-Position: refs/heads/master@{#43213}
      dc302c74
  29. 12 Feb, 2017 1 commit
    • littledan's avatar
      Revert of [typedarrays] move %TypedArray%.prototype.copyWithin to C++... · 4530f0dc
      littledan authored
      Revert of [typedarrays] move %TypedArray%.prototype.copyWithin to C++ (patchset #6 id:100001 of https://codereview.chromium.org/2671233002/ )
      
      Reason for revert:
      Due to security issue described in review thread.
      
      Original issue's description:
      > [typedarrays] move %TypedArray%.prototype.copyWithin to C++
      >
      > - Removes shared InnerArrayCopyWithin JS builtin from src/js/array.js
      > - Implements %TypedArray%.prototype.copyWithin as a C++ builtin, which
      > relies on std::memmove rather than accessing individual eleements.
      > - Fixes the case where copyWithin is invoked on a TypedArray with a
      > detached buffer.
      > - Add tests to ensure that +/-Infinity (for all 3 parameters) is handled correctly by the
      > algorithm
      >
      > The C++ version gets through the benchmark more than 25000 times as
      > quickly as the JS implementation.
      >
      > BUG=v8:5925, v8:5929, v8:4648
      > R=cbruni@chromium.org, adamk@chromium.org, littledan@chromium.org
      >
      > Review-Url: https://codereview.chromium.org/2671233002
      > Cr-Commit-Position: refs/heads/master@{#42975}
      > Committed: https://chromium.googlesource.com/v8/v8/+/0f1c626d556cbf84b0e572635eb803729f88cbb3
      
      TBR=cbruni@chromium.org,adamk@chromium.org,bmeurer@chromium.org,cwhan.tunz@gmail.com,caitp@igalia.com
      # Not skipping CQ checks because original CL landed more than 1 days ago.
      BUG=v8:5925, v8:5929, v8:4648
      
      Review-Url: https://codereview.chromium.org/2693753002
      Cr-Commit-Position: refs/heads/master@{#43132}
      4530f0dc
  30. 06 Feb, 2017 2 commits
    • caitp's avatar
      [typedarrays] move %TypedArray%.prototype.copyWithin to C++ · 0f1c626d
      caitp authored
      - Removes shared InnerArrayCopyWithin JS builtin from src/js/array.js
      - Implements %TypedArray%.prototype.copyWithin as a C++ builtin, which
      relies on std::memmove rather than accessing individual eleements.
      - Fixes the case where copyWithin is invoked on a TypedArray with a
      detached buffer.
      - Add tests to ensure that +/-Infinity (for all 3 parameters) is handled correctly by the
      algorithm
      
      The C++ version gets through the benchmark more than 25000 times as
      quickly as the JS implementation.
      
      BUG=v8:5925, v8:5929, v8:4648
      R=cbruni@chromium.org, adamk@chromium.org, littledan@chromium.org
      
      Review-Url: https://codereview.chromium.org/2671233002
      Cr-Commit-Position: refs/heads/master@{#42975}
      0f1c626d
    • caitp's avatar
      [cleanup] fix comment in builtins-typedarray.cc · ec922ef6
      caitp authored
      It's supposed to be a JSTypedArray, not a JSGeneratorObject
      
      BUG=
      R=littledan@chromium.org, adamk@chromium.org, jgruber@chromium.org
      
      Review-Url: https://codereview.chromium.org/2674133002
      Cr-Commit-Position: refs/heads/master@{#42967}
      ec922ef6